Re: [edk2] [PATCH] OvmfPkg VirtioScsiDxe: Fix build with VS2010

2012-10-29 Thread Paolo Bonzini
Il 28/10/2012 16:30, Laszlo Ersek ha scritto: >> > Is there a UEFI macro for a compiler optimization barrier? If so, use >> > it and forget volatile altogether... > Wherever the virtio specification required a memory barrier, I used > MemoryFence(). I used volatile wherever I thought it was necess

Re: [edk2] SerialPortExtLib - Re: SF.net SVN: edk2:[13773] trunk/edk2

2012-10-29 Thread Olivier Martin
Jordan, you are right. I will have a look to fix the recent issues reported in SerialDxe and TemplateSerialPortLib. Thanks for the feedback, Olivier From: Jordan Justen [jljus...@gmail.com] Sent: 26 October 2012 20:20 To: Olivier Martin; Andrew J. Fish Cc:

Re: [edk2] Serial Protocol Implementation in BeagleBoardPkg

2012-10-29 Thread Olivier Martin
Hi Eugene, you are right. I will take your comments in account and fix TemplateSerialPortLib. Thanks, Olivier From: Eugene Khoruzhenko [eugene_khoruzhe...@phoenix.com] Sent: 26 October 2012 20:00 To: edk2-devel@lists.sourceforge.net Subject: Re: [edk2] Ser

Re: [edk2] [PATCH v3 2/4] OvmfPkg: Add LoadLinuxLib library interface

2012-10-29 Thread Laszlo Ersek
On 10/26/12 19:35, Jordan Justen wrote: > +/** > + Sets the kernel command line parameter within the setup image. > + > + @param[in,out] KernelSetup - The kernel setup image > + @param[in] CommandLine - The kernel command line > + > + @retvalEFI_SUCCESS - The Linux kernel setup is vali

Re: [edk2] [PATCH v3 1/4] OvmfPkg: Add Linux bzimage include file

2012-10-29 Thread Laszlo Ersek
On 10/26/12 19:35, Jordan Justen wrote: > This file is from the efilinux project where it resides > under the path loaders/bzimage/bzimage.h. > > Signed-off-by: Jordan Justen > Cc: Matt Fleming Won't try to split hairs in this one... :) Reviewed-by: Laszlo Ersek -

Re: [edk2] [PATCH v3 4/4] OvmfPkg: Add support for qemu's -kernel parameter

2012-10-29 Thread Laszlo Ersek
On 10/26/12 19:35, Jordan Justen wrote: > If QEMU's -kernel parameter was used, then download the > kernel from the FwCfg interface, and launch it. (See -kernel, > -initrd, -append) The application uses the LoadLinuxLib to boot > the kernel image. > > Signed-off-by: Jordan Justen Looks good. Th

Re: [edk2] [PATCH v3 3/4] OvmfPkg: Add LoadLinuxLib library implementation

2012-10-29 Thread Laszlo Ersek
On 10/26/12 19:35, Jordan Justen wrote: > This code is based on efilinux's bzimage support. > git://git.kernel.org/pub/scm/boot/efilinux/efilinux.git > > Signed-off-by: Jordan Justen > Cc: Matt Fleming At one point during the review I tried to apply the series on a temporary branch in my git cl

Re: [edk2] [PATCH v3 3/4] OvmfPkg: Add LoadLinuxLib library implementation

2012-10-29 Thread Jordan Justen
On Mon, Oct 29, 2012 at 11:51 AM, Laszlo Ersek wrote: > On 10/26/12 19:35, Jordan Justen wrote: >> +#define RETURN_X_ON_ERROR(Status, X) \ >> + do { if (RETURN_ERROR (Status)) { return (X); } } while(0) >> + >> +#define RETURN_STATUS_ON_ERROR(Status) \ >> + do { RETURN_STATUS __MacroStatus = (St

[edk2] Mapping of UEFI Spec enhancements to UDK Updates

2012-10-29 Thread Pranjal Goswami
Hello Edk2 developers, I have a query on how the UDK updates map to the changes in the UEFI spec. Now UEFI recently came up with some enhancements to the standard. http://www.businesswire.com/news/home/20120703005840/en/UEFI-Forum-Releases-UEFI-2.3.1-Specification-Update For example: UEFI 2.3.

Re: [edk2] EFI_FILE_PROTOCOL.Delete() failing with EFI_WARN_DELETE_FAILURE

2012-10-29 Thread Kashif Memon
Thanks for all the replies. Actually the problem was not the permissions, since I had tried the read+write combination already. The problem was the variable type of the "root" variable. Here is the original declaration that I was using that caused the problem: EFI_FILE_HANDLE