On 10/26/12 19:35, Jordan Justen wrote:
> If QEMU's -kernel parameter was used, then download the
> kernel from the FwCfg interface, and launch it.  (See -kernel,
> -initrd, -append) The application uses the LoadLinuxLib to boot
> the kernel image.
> 
> Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com>

Looks good. The series really has to be reviewed in reverse.

TryRunningQemuKernel
  LoadLinuxAllocateKernelSetupPages
  LoadLinuxCheckKernelSetup
  LoadLinuxGetKernelSize
  LoadLinuxAllocateKernelPages
  LoadLinuxAllocateCommandLinePages
  LoadLinuxSetCommandLine
  LoadLinuxAllocateInitrdPages
  LoadLinuxSetInitrd

  LoadLinux
    BasicKernelSetupCheck
      LoadLinuxCheckKernelSetup
    InitLinuxDescriptorTables
    SetupLinuxBootParams
      SetupGraphics
        SetupGraphicsFromGop
      SetupLinuxMemmap
    DisableInterrupts
    SetLinuxDescriptorTables
    JumpToKernel

I've finished staring at TryRunningQemuKernel() and the functions it
directly calls, except LoadLinux(). The sub-tree rooted in LoadLinux()
belongs to 3/4; I'm continuing there.

Reviewed-by: Laszlo Ersek <ler...@redhat.com>

------------------------------------------------------------------------------
The Windows 8 Center - In partnership with Sourceforge
Your idea - your app - 30 days.
Get started!
http://windows8center.sourceforge.net/
what-html-developers-need-to-know-about-coding-windows-8-metro-style-apps/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to