On 10/26/12 19:35, Jordan Justen wrote:
> This code is based on efilinux's bzimage support.
> git://git.kernel.org/pub/scm/boot/efilinux/efilinux.git
>
> Signed-off-by: Jordan Justen <[email protected]>
> Cc: Matt Fleming <[email protected]>
At one point during the review I tried to apply the series on a
temporary branch in my git clone, but "git am" refused the patches. So
did manual "patch", complaining about malformed diff headers. I don't
understand, but if it applies on your tree, all good.
> +
> +#define RETURN_X_ON_ERROR(Status, X) \
> + do { if (RETURN_ERROR (Status)) { return (X); } } while(0)
> +
> +#define RETURN_STATUS_ON_ERROR(Status) \
> + do { RETURN_STATUS __MacroStatus = (Status); \
> + if (RETURN_ERROR (__MacroStatus)) { return __MacroStatus; } \
> + } while(0)
I thought you objected to jump statements inside macros! ;)
... are the date ranges in the copyright messages precise? There are
some seemingly new files with copyrights dating back to 2008 or 2006.
... The LoadLinuxBzImage() function has no caller; I'd suggest dropping
it from here and its declaration from 2/4 (unless you have later plans
with it). Anyway dropping it can happen later. FWIW, I'm not reviewing
LoadLinuxBzImage() now.
TryRunningQemuKernel
LoadLinuxAllocateKernelSetupPages
LoadLinuxCheckKernelSetup
LoadLinuxGetKernelSize
LoadLinuxAllocateKernelPages
LoadLinuxAllocateCommandLinePages
LoadLinuxSetCommandLine
LoadLinuxAllocateInitrdPages
LoadLinuxSetInitrd
LoadLinux
BasicKernelSetupCheck
LoadLinuxCheckKernelSetup
InitLinuxDescriptorTables
SetupLinuxBootParams
SetupGraphics
SetupGraphicsFromGop
FindBits
SetupLinuxMemmap <---- I'm stuck here now, to be continued.
DisableInterrupts
SetLinuxDescriptorTables
JumpToKernel
Thanks,
Laszlo
------------------------------------------------------------------------------
The Windows 8 Center - In partnership with Sourceforge
Your idea - your app - 30 days.
Get started!
http://windows8center.sourceforge.net/
what-html-developers-need-to-know-about-coding-windows-8-metro-style-apps/
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel
