Re: [edk2] Patch for review: AppPkg/Applications/Python

Reviewed-by: Jaben Carsey From: Mcdaniel, Daryl Sent: Monday, August 18, 2014 2:30 PM To: edk2-devel@lists.sourceforge.net Subject: Patch for review: AppPkg/Applications/Python Please review the attached changes. GCC is the most affected compiler. Both patch files and the full file are included

Re: [edk2] Patch for review: AppPkg/Applications/Python

Reviewed-by: Erik Bjorge From: Mcdaniel, Daryl Sent: Monday, August 18, 2014 2:30 PM To: edk2-devel@lists.sourceforge.net Subject: Patch for review: AppPkg/Applications/Python Please review the attached changes. GCC is the most affected compiler. Both patch files and the full file are included.

[edk2] Patch for review: StdLibPrivateInternalFiles/Include/{Ia32, X64}/arith.h

Please review the attached changes. StdLibPrivateInternalFiles/Include/{Ia32,X64}/arith.h: Use programmatically generated arith.h files for greater compatibility with the gdtoa library in StdLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daryl McDaniel mailto:dar

Re: [edk2] Question for EDK II package owners - Re: [RFC 2/2] EDK II Contributions.txt: Note acceptable contribution licenses

No concern. > -Original Message- > From: Jordan Justen [mailto:jordan.l.jus...@intel.com] > Sent: Monday, August 18, 2014 2:04 PM > To: edk2-devel@lists.sourceforge.net > Subject: [edk2] Question for EDK II package owners - Re: [RFC 2/2] EDK II > Contributions.txt: Note acceptable contribu

[edk2] [RFC] EDK II UNI Unicode File Specification

Hi Folks, Here are the proposed changes to the EDK II UNI Unicode File Specification. Hopefully, HTML format for the chapters will be easier to review and respond with feedback. Please provide feedback by the end of this week (22 Aug. 2014). Updates: · Updated EBNF to follow syntax s

[edk2] Patch for review: StdLibPrivateInternalFiles/Include/{Ia32, X64}/arith.h

Please review the attached changes. StdLibPrivateInternalFiles/Include/{Ia32,X64}/arith.h: Use programmatically generated arith.h files for greater compatibility with the gdtoa library in StdLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daryl McDaniel mailto:dar

Re: [edk2] Patch for review: StdLibPrivateInternalFiles/Include/{Ia32, X64}/arith.h

Reviewed-by: Erik Bjorge From: Mcdaniel, Daryl Sent: Monday, August 18, 2014 3:57 PM To: edk2-devel@lists.sourceforge.net Subject: Patch for review: StdLibPrivateInternalFiles/Include/{Ia32,X64}/arith.h Please review the attached changes. StdLibPrivateInternalFiles/Include/{Ia32,X64}/arith.h: U

Re: [edk2] [RFC] EDK II UNI Unicode File Specification

Larry - The description of the extensions for modules/package abstracts/description are much better. Here are a few comments which are not specific to your update (although they are contained in the text below) 1. It is readable. I do think that adding <> terminals for single characters

Re: [edk2] Patch for review: StdLibPrivateInternalFiles/Include/{Ia32, X64}/arith.h

Reviewed-by: Jaben Carsey From: Mcdaniel, Daryl Sent: Monday, August 18, 2014 3:57 PM To: edk2-devel@lists.sourceforge.net Subject: Patch for review: StdLibPrivateInternalFiles/Include/{Ia32,X64}/arith.h Please review the attached changes. StdLibPriva

Re: [edk2] Missing Ping Reply

Hi, Chris DispatchDpc returns NOT_FOUND is correct. Ping command doesn't use DPC so the Rx event's callback function will be invoked immediately after SingalEvent(). Did you check the Token->Status and Token->Packet.RxData in Ip4InstanceDeliverPacket() before SingalEvent? Best Regards, Siyuan

[edk2] [PATCH] MdePkg: refine code for BaseOrderedCollectionRedBlackTreeLib

Hi Laszlo, I do some changes for this library to follow EDKII coding style, please help to review it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Thanks, Eric BaseOrderedCollectionRedBlackTreeLib.c.patch Description: BaseOrderedCollectionRedBlackTreeLib.c

Re: [edk2] Missing Ping Reply

Looks okay. Ip4InstanceDeliverPacket: Before SignalEvent Token->Status 0x0Ip4InstanceDeliverPacket: Before SignalEvent Token->Packet.RxData->HeaderLength 0x14Ip4InstanceDeliverPacket: Before SignalEvent Token->Packet.RxData->DataLength 0x10 From: siyuan...@intel.com To: nd6...@hotmail.com; edk2

[edk2] How to Parse DHCP Options

Hi guys, I'm writing a bootloader that is downloaded by the client over PXE and executed. In the bootloader I need to extract the value of some DHCP options from the last boot server ACK message. I understand that this message is available as EFI_PXE_BASE_CODE_PROTOCOL->Mode.ProxyOffer. My questio

Re: [edk2] [PATCH] MdePkg: refine code for BaseOrderedCollectionRedBlackTreeLib

Dong, Eric [mailto:eric.d...@intel.com] wrote: ]Hi Laszlo, ] ]I do some changes for this library to follow EDKII coding style, please help to ]review it. ] ]Contributed-under: TianoCore Contribution Agreement 1.0 ]Signed-off-by: Eric Dong ] ]Thanks, ]Eric Hello Eric, A couple of questions: 1)

[edk2] Redundant codes in MdeModulePkg PartitionDxe

Dear MdeModulePkg maintainers, I think this codes in MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c:168 — if (EFI_ERROR (Status)) { return Status; } return EFI_SUCCESS; } ——— may be safely reduced to - return Status; } Contributed-under: TianoCore Contribu

Re: [edk2] Missing Ping Reply

Hi, Chris I still can't reproduce this issue on my side, what's the EDKII and shell revision you are using? Can you reproduce it on other NIC, like NT32? Best Regards, Siyuan From: Chris Cuthbert [mailto:nd6...@hotmail.com] Sent: Tuesday, August 19, 2014 10:22 AM To: Fu, Siyuan; Edk2 Devel Subj

Re: [edk2] PXE Boot Error

Hi, Chris Just add "option vendor-class-identifier "PXEClient";" to your dhcpd.conf file, it will enable option 60. Best Regards, Siyuan From: Chris Cuthbert [mailto:nd6...@hotmail.com] Sent: Tuesday, August 19, 2014 4:20 AM To: Edk2 Devel Subject: [edk2] PXE Boot Error Hi All, I am trying t

Re: [edk2] [PATCH] UefiCpuPkg/ArchExceptionHandler.c: Fix comment typos

Hi, I also find the word “hanlde” in the edk2/IntelFrameworkModulePkg/Library/GenericBdsLib/ Please also fix On 08 июля 2014 г., at 13:17, chen.fan.f...@cn.fujitsu.com wrote: > On Tue, 2014-07-08 at 07:30 +, Fan, Jeff wrote: >> Hi, Chen >> >> Thanks your fix. >> >> I will help to check-in

Re: [edk2] [PATCH] MdePkg: refine code for BaseOrderedCollectionRedBlackTreeLib

Scott, We have seen issues with some source level debuggers when using static functions. I some cases, it will show the wrong function name when stepping through a static function. Unless there is a really good reason, we prefer to not use static to improve debugability. Public functions are

Re: [edk2] Patch for review: StdLibPrivateInternalFiles/Include/{Ia32, X64}/arith.h

Mcdaniel, Daryl [mailto:daryl.mcdan...@intel.com] wrote: ]Please review the attached changes. ] ]StdLibPrivateInternalFiles/Include/{Ia32,X64}/arith.h: Use programmatically ]generated arith.h files for greater compatibility with the gdtoa library in ]StdLib. ] ]Contributed-under: TianoCore Contri

Re: [edk2] Redundant codes in MdeModulePkg PartitionDxe

Agree. Reviewed-By: Feng Tian Thanks Feng From: Sergey Isakov [mailto:isakov...@bk.ru] Sent: Tuesday, August 19, 2014 11:46 To: edk2-devel@lists.sourceforge.net Subject: [edk2] Redundant codes in MdeModulePkg PartitionDxe Dear MdeModulePkg maintainers, I think this codes in MdeModulePkg/Unive

[edk2] [Patch][Basetools]Fix a build failure in Linux

Hello all, Could you help review this patch? This patch is going to fix a build failure in Linux system. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hess Chen mailto:hesheng.c...@intel.com>> Best Regards, Chen, Hess Intel China Software Center Tel: +86-21-6116-6740

Re: [edk2] TcpIoReceive question

Hi, Thanks for reporting this. We will check whether we can reproduce the issue. Best Regards, Ye Ting From: Thomas Rognon [mailto:tcrog...@gmail.com] Sent: Sunday, August 17, 2014 8:21 AM To: edk2-devel Subject: [edk2] TcpIoReceive question I'm receiving a packet of unknown length and it is le

Re: [edk2] [Patch 1/2] [MdePkg] INF/DEC file updates to EDK II packages

What is the commit message for this patch? It looks like this was missing the Contributed-under and Signed-off-by too. On Wed, Aug 13, 2014 at 7:13 PM, Gao, Liming wrote: > Hi, all > > Could you help review this patch? It includes the following changes 1-6 > for MdePkg. Why are you including

Re: [edk2] TcpIoReceive question

Hi, TcpIoReceive() library function is defined to receive required amount of data in a specified period, see the function description in TcpIoLib.h: @retval EFI_TIMEOUTFailed to receive the required amount of data in the specified time period. Whe

Re: [edk2] [Patch 1/2] [MdePkg] INF/DEC file updates to EDK II packages

Jordan: The commit message is just Mike description. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gao, Liming My change mainly are in INF and DEC (Item 1 and 4). Even if we separate them, the patch is still big. For Item 2&3, 5&6, new UNI files will be added. I have

[edk2] no longer able to build OVMF

Hi, I've been building OVMF successfully by running "build" in the edk2 top-level directory after having modified Conf/target.txt like so: ACTIVE_PLATFORM = OvmfPkg/OvmfPkgX64.dsc TOOL_CHAIN_TAG = GCC48 TARGET_ARCH = X64 As of this morning, that no longer works. Running "build" results in

[edk2] ShellPkg: Fix EFI_SHELL_PROTOCOL to contain new members from UEFI Shell 2.1 spec

Please review and provide any feedback. This code change removes EFI_SHELL_PROTOCOL21 and instead includes the new structure members from UEFI Shell 2.1 spec (RegisterGuidName, GetGuidName, GetGuidFromName, and GetEnvEx) into EFI_SHELL_PROTOCOL. A comment note was added to explain that Shel

[edk2] Wrong build.py rev 15816

Hi sirs, Commit 15816 contains broken build.py. I can compile after reverting the file to revision 15809. Please consider. Sergey -- ___ edk2-devel mailing list edk2-devel@list

Re: [edk2] Missing Ping Reply

Hi Siyuan, Here is the log again. Looks like NOT_FOUND is being returned by DispatchDpc. Thanx. Shell> ping -n 1 172.25.17.100 Ping StartsAPing 172.25.17.100 16 data bytes NicVfTransmit (ARP request) NicVfGetPacket

Re: [edk2] TcpIoReceive question

Thanks! I see now. I overlooked the outer while loop. Thomas Rognon On Mon, Aug 18, 2014 at 3:11 AM, Ye, Ting wrote: > Hi, > > > > TcpIoReceive() library function is defined to receive required amount of > data in a specified period, see the function description in TcpIoLib.h: > > > > @retv

[edk2] r15816 "retire the top level makefile" - Re: no longer able to build OVMF

I also see a build error with this change. Hess, Were you able to test Linux or OS X based builds with this patch? How long do you expect it will take to fix? Maybe we should revert the change for now to investigate further? -Jordan On Mon, Aug 18, 2014 at 6:25 AM, Gabriel L. Somlo wrote: > H

Re: [edk2] [Patch 1/2] [MdePkg] INF/DEC file updates to EDK II packages

On Mon, Aug 18, 2014 at 2:25 AM, Gao, Liming wrote: > Jordan: > > The commit message is just Mike description. Are you saying it will look like this? == Commit message start == [MdePkg] INF/DEC file updates to EDK II packages 1) Usage information in INF file comment blocks are either incomp

Re: [edk2] ShellPkg: Fix EFI_SHELL_PROTOCOL to contain new members from UEFI Shell 2.1 spec

Reviewed-by: Jaben Carsey From: Phillips, Chris J (Plano, TX) [mailto:chr...@hp.com] Sent: Monday, August 18, 2014 8:26 AM To: Carsey, Jaben; edk2-devel@lists.sourceforge.net Subject: ShellPkg: Fix EFI_SHELL_PROTOCOL to contain new members from UEFI Shell 2.1 spec Importance: High Please revie

[edk2] PXE Boot Error

Hi All, I am trying to boot an ARM core using PXE boot and I am following the steps mentioned in this Linaro wiki (https://wiki.linaro.org/LEG/Engineering/Kernel/UEFI/UEFI_Network_Booting). Most importantly, the DHCP server configuration part of it. It says: Add these lines to /etc/dhcp/dhcpd

Re: [edk2] [PATCH 0/4] OvmfPkg: complete client for QEMU's ACPI loader interface

On 08/09/14 04:08, Laszlo Ersek wrote: > This series strives to implement a client for QEMU's ACPI loader fw_cfg > interface as completely as I can imagine at this point. The only > shortcut it takes is that it equates the FSeg allocation hint with the > affected blob containing the RSD PTR table a

[edk2] Question for EDK II package owners - Re: [RFC 2/2] EDK II Contributions.txt: Note acceptable contribution licenses

This patch to Contributions.txt will update: AppPkg, ArmPkg, ArmPlatformPkg, BaseTools, BeagleBoardPkg, CryptoPkg, DuetPkg, EdkCompatibilityPkg, EdkShellBinPkg, EdkShellPkg, EmbeddedPkg, EmulatorPkg, FatBinPkg, IntelFrameworkModulePkg, IntelFrameworkPkg, MdeModulePkg, MdePkg, NetworkPkg,