Re: [edk2] NVMe question

2015-06-03 Thread Laszlo Ersek
Laszlo -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, June 02, 2015 15:46 To: edk2-devel@lists.sourceforge.net; Anbazhagan, Baraneedharan; Tian, Feng; Busch, Keith Cc: qemu devel list Subject: Re: [edk2] NVMe question On 06/02/15 09:19, Tian

Re: [edk2] NVMe question

2015-06-03 Thread Tian, Feng
Got your point. Ok, I will roll back the change Thanks Feng -Original Message- From: Busch, Keith Sent: Wednesday, June 03, 2015 22:47 To: Tian, Feng; Laszlo Ersek Cc: edk2-devel@lists.sourceforge.net; Anbazhagan, Baraneedharan; qemu devel list Subject: RE: [edk2] NVMe question

Re: [edk2] NVMe question

2015-06-02 Thread Laszlo Ersek
On 06/02/15 09:19, Tian, Feng wrote: Thanks for the info. I didn’t test it on NVMe-Qemu, I just run the change on a real production. I will do bigger scope test to see if it’s valuable to add it back. This email thread is a perfect example why top-posting is a horrible practice. The

Re: [edk2] NVMe question

2015-06-02 Thread Tian, Feng
Thanks for the info. I didn't test it on NVMe-Qemu, I just run the change on a real production. I will do bigger scope test to see if it's valuable to add it back. Thanks Feng From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Tuesday, June 02, 2015 06:22 To: Tian, Feng;

Re: [edk2] NVMe question

2015-06-02 Thread Tian, Feng
To: Laszlo Ersek Cc: edk2-devel@lists.sourceforge.net; Anbazhagan, Baraneedharan; Tian, Feng; Busch, Keith; qemu devel list Subject: Re: [edk2] NVMe question Hi, On Tue, 2 Jun 2015, Laszlo Ersek wrote: removed the nonzero initialization of Cc.Iosqes (submission queue size?) and Cc.Iocqes

Re: [edk2] NVMe question

2015-06-02 Thread Tian, Feng
-devel@lists.sourceforge.net; Anbazhagan, Baraneedharan; Tian, Feng; Busch, Keith Cc: qemu devel list Subject: Re: [edk2] NVMe question On 06/02/15 09:19, Tian, Feng wrote: Thanks for the info. I didn't test it on NVMe-Qemu, I just run the change on a real production. I will do bigger

Re: [edk2] NVMe question

2015-06-01 Thread Anbazhagan, Baraneedharan
Thanks for the update. NVMe used to work in QEMU and started failing now with this change. May be NVMe emulation issue in QEMU. -Baranee CONFIDENTIALITY NOTICE: The information contained in this e-mail and any accompanying documents may contain information which is HP confidential or

Re: [edk2] NVMe question

2015-05-31 Thread Tian, Feng
Hi, Baraneedharan Why I removed these two fields initialization is because NVMe spec 7.6.1 doesn't say it's mandatory. Do you see any real impact on this? Thanks Feng From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com] Sent: Saturday, May 30, 2015 06:21 To: Tian, Feng;

[edk2] NVMe question

2015-05-29 Thread Anbazhagan, Baraneedharan
With recent changes to NvmExpressDxe module, NvmeEnableController doesn't set I/O completion and submission queue size. Why default values are removed? CONFIDENTIALITY NOTICE: The information contained in this e-mail and any accompanying documents may contain information which is HP