[edk2] [PATCH] SecurityPkg/Tcg/MemoryOverwriteRequestControlLock: Add missing header file description in INF file

2015-08-03 Thread Qiu Shumin
Cc: Yao Jiewen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- SecurityPkg/Tcg/MemoryOverwriteRequestControlLock/TcgMorLockSmm.inf | 1 + 1 file changed, 1 insertion(+) diff --git a/SecurityPkg/Tcg/MemoryOverwriteRequestControlLock/TcgMorLockSmm.inf b/Sec

Re: [edk2] [PATCH] SecurityPkg/Tcg/MemoryOverwriteRequestControlLock: Add missing header file description in INF file

2015-08-03 Thread Yao, Jiewen
Reviewed by: Yao, Jiewen -Original Message- From: Qiu, Shumin Sent: Monday, August 03, 2015 3:05 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Yao, Jiewen Subject: [PATCH] SecurityPkg/Tcg/MemoryOverwriteRequestControlLock: Add missing header file description in INF file Cc: Yao Jiewe

Re: [edk2] [PATCH v4 00/13] BaseTools: unify all GCC linker scripts

2015-08-03 Thread Ard Biesheuvel
On 3 August 2015 at 03:39, Liu, Yingke D wrote: > Hi Ard, > > Sorry for delaying reply, please go ahead, If Liming agreed BaseTools' > patches, you could commit them without my feedback. > Thanks for clarifying. Committed as SVN r18130 ... r18142 Cheers, Ard. > -Original Message- > F

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Paolo Bonzini
On 03/08/2015 05:56, Gao, Liming wrote: > Hi, all > We will update BaseTools feature to allow more than one workspaces. The > detail design in the below. Please help review it. If you have any comments, > please let me know. > > 1. Keep $(WORKSPACE) environment as is > > a. $(WOR

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Gao, Liming
Paolo: I think that keep the exiting syntax for WORKSPACE to be a single path can minimize the impacts to exiting tools that assume a single workspace. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Paolo Bonzini Sent: Monday, A

[edk2] [PATCH v2 3/7] ArmPlatformPkg/ArmJunoPkg: use a rodata symbol for ReferenceAcpiTable

2015-08-03 Thread Ard Biesheuvel
The ACPI .aslc files contain a ReferenceAcpiTable() function whose sole purpose is to ensure that the table itself does not get optimized away. However, when using clang, these dummy functions result in a 4 KB section alignment requirement, which is silly since everything except the .data section i

[edk2] [PATCH v2 7/7] BaseTools: add support for CLANG compiler to GCC family

2015-08-03 Thread Ard Biesheuvel
This adds support for building the AARCH64 platforms using the Clang compiler and assembler combined with the GNU (cross-)linker. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- BaseTools/Conf/tools_def.template | 51 1 file changed,

[edk2] [PATCH v2 6/7] BaseTools/GenFw: allow AArch64 tiny and small code model relocations

2015-08-03 Thread Ard Biesheuvel
The AArch64 small C model makes extensive use of ADRP/ADD and ADRP/{LDR,STR} pairs to emit PC-relative symbol references with a +/- 4 GB range. Since the relocation pair splits the relative offset into a relative page offset and an absolute offset into a 4 KB page, we need to take extra care to ens

[edk2] [PATCH v2 0/7] small model and clang support for AARCH64

2015-08-03 Thread Ard Biesheuvel
This is another followup to the series 'small C model and LLVM/clang support for AARCH64' that I sent out on July 17th. Now that the FFS/FV optimization patches have been merged, this is what remains to allow the AARCH64 platforms to be built using clang, combined with the GNU binutils (cross-)tool

[edk2] [PATCH v2 5/7] ArmPlatformPkg/FVP: use 'auto' alignment and FIXED placement for XIP modules

2015-08-03 Thread Ard Biesheuvel
Now that GenFw correctly propagates the minimum alignment of the ELF input sections to the PE/COFF binary, we can simply select 'auto' alignment in the FDF Rule section instead of tweaking it by hand. Also add the FIXED FFS attribute to the module types that may execute in place. This enables a ne

[edk2] [PATCH v2 1/7] ArmPkg/GicV3: use GICv3 generic sysreg names only for GNU as

2015-08-03 Thread Ard Biesheuvel
The GNU assembler extends the generic notation for IMPLEMENTATION DEFINED system registers to support any system register, so that system registers defined by newer versions of the architecture can still be used by older versions of the toolchain. Clang before v3.6 supports the generic notation, b

[edk2] [PATCH v2 4/7] ArmPlatformPkg/ArmJunoPkg: use TE 'auto' alignment for SEC modules

2015-08-03 Thread Ard Biesheuvel
No need to hardcode the TE alignment anymore, now that GenFw sets the PE/COFF alignment according to the alignment requirements of the ELF input sections. Also enable FIXED FFS placement so that we can reclaim some of the space wasted to padding when using clang with 4 KB section alignment. Contr

[edk2] [PATCH v2 2/7] ArmPkg/GenericWatchdogDxe: add missing VOID* cast

2015-08-03 Thread Ard Biesheuvel
Use an explicit VOID* cast when passing a static char array into a function taking a void pointer. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [edk2] [Patch 0/3] Use new BDS and UiApp for OvmfPkg

2015-08-03 Thread David Woodhouse
On Mon, 2015-08-03 at 13:41 +0800, Ruiyu Ni wrote: > A new BDS and UiApp was created in MdeModulePkg and are already > used in Nt32Pkg. > The patch changes the OvmfPkg to use the new BDS and UiApp as well. Hi Ruiyu, were these changes tested with the SeaBIOS CSM? -- David Woodhouse

[edk2] MdePkg: Fix RAM Disk Device Path To Text Issue

2015-08-03 Thread Shah, Tapan
Feng / Star, Can you review this fix? Thanks, Tapan MdePkg: Perform Left Shift 32 bits of a 32-bit StartAddr[1] and EndingAddr[1] instead of Right Shift when displaying 64-bit Start and End Address Value StartAddr[1] and EndingAddr[1] are already a 32-bit val

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Jordan Justen
On 2015-08-03 02:08:14, Gao, Liming wrote: > Paolo: > I think that keep the exiting syntax for WORKSPACE to be a single > path can minimize the impacts to exiting tools that assume a > single workspace. I know you originally suggested to use WORKSPACE, but got some feedback that it might be

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Jordan Justen
Cc: edk2-devel On 2015-08-03 10:41:43, Tim Lewis wrote: > There are dozens of tools in commercial environments (including some > by Insyde) which will fail in this case. In addition, there are > codebases that I am aware of where $(WORKSPACE) is allowed directly > in other build files. Will all t

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Kinney, Michael D
Jordan, If we make a slight change to the requirements, we can provide clear priority rules. WORKSPACE is used to find Build and Conf. If WORKSPACE_MULTIPLE exists, then it is used as a prioritized list of paths to resolve all other workspace relative paths. This means WORKSPACE_MULTIPLE will

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Tim Lewis
Actually, I have less problem with the type of change being proposed, and more with the way in which it is accomplished. Today: set up the build environment requires: set up my tools, set up WORKSPACE, build. To build any project, that's it. But with the proposed solution, this is not enough, b

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Jordan Justen
On 2015-08-03 12:58:28, Kinney, Michael D wrote: > Jordan, > > If we make a slight change to the requirements, we can provide clear > priority rules. > > WORKSPACE is used to find Build and Conf. > > If WORKSPACE_MULTIPLE exists, then it is used as a prioritized list > of paths to resolve all ot

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Andrew Fish
> On Aug 3, 2015, at 12:58 PM, Kinney, Michael D > wrote: > > Jordan, > > If we make a slight change to the requirements, we can provide clear priority > rules. > > WORKSPACE is used to find Build and Conf. > > If WORKSPACE_MULTIPLE exists, then it is used as a prioritized list of paths >

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Andrew Fish
> On Aug 3, 2015, at 2:04 PM, Jordan Justen wrote: > > On 2015-08-03 12:58:28, Kinney, Michael D wrote: >> Jordan, >> >> If we make a slight change to the requirements, we can provide clear >> priority rules. >> >> WORKSPACE is used to find Build and Conf. >> >> If WORKSPACE_MULTIPLE exists,

Re: [edk2] [PATCH] Check arguments for PrintLib format format string

2015-08-03 Thread Andrew Fish
> On Aug 2, 2015, at 9:58 PM, Scott Duplichan wrote: > > Add support for checking the argument list of functions that use > a PrintLib style format string. This feature requires a patched > gcc tool chain that is identified by the presence of compiler > predefined macro __GCC_EDK2_FORMATS__. To

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Jordan Justen
On 2015-08-03 14:32:15, Andrew Fish wrote: > > > On Aug 3, 2015, at 2:04 PM, Jordan Justen wrote: > > > > On 2015-08-03 12:58:28, Kinney, Michael D wrote: > >> Jordan, > >> > >> If we make a slight change to the requirements, we can provide clear > >> priority rules. > >> > >> WORKSPACE is use

Re: [edk2] BaseTools features: multiple workspaces

2015-08-03 Thread Andrew Fish
> On Aug 3, 2015, at 3:05 PM, Jordan Justen wrote: > > On 2015-08-03 14:32:15, Andrew Fish wrote: >> >>> On Aug 3, 2015, at 2:04 PM, Jordan Justen wrote: >>> >>> On 2015-08-03 12:58:28, Kinney, Michael D wrote: Jordan, If we make a slight change to the requirements, we can pro

Re: [edk2] [PATCH 3/2] CryptoPkg: Remove OpenSSL hack and manually ignore validity time range

2015-08-03 Thread David Woodhouse
On Mon, 2015-07-27 at 17:25 +0100, David Woodhouse wrote: > Instead of hacking OpenSSL to remove the validity time checks, which met > with some resistance upstream (even when done in a cleaner fashion), just > ensure that we have a verify_cb registered and explicitly ignore the > X509_V_ERR_CERT_H

[edk2] [PATCH n/m] CryptoPkg/BaseCryptLib: Use X509_V_FLAG_PARTIAL_CHAIN

2015-08-03 Thread David Woodhouse
Since OpenSSL 1.0.2 we can set this flag on the X509_STORE to instruct OpenSSL to accept non-self-signed certificates as trusted. So we don't need two entirely identical copies of a verify_cb() function which makes it ignore the resulting errors. We also *didn't* use that verify_cb() function for

[edk2] [PATCH n+1/m] CryptoPkg/BaseCryptLib: Use X509_V_FLAG_NO_CHECK_TIME

2015-08-03 Thread David Woodhouse
OpenSSL HEAD is in the process of adding this flag to disable the validity time checking. Backport it to 1.0.2 and use it too, for consistency. https://rt.openssl.org/Ticket/Display.html?id=3951&user=guest&pass=guest Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Woo

Re: [edk2] MdePkg: Fix RAM Disk Device Path To Text Issue

2015-08-03 Thread Tian, Feng
Reviewed-by: Feng Tian I will help check this patch in. Thanks Feng From: Shah, Tapan [mailto:tapands...@hp.com] Sent: Monday, August 03, 2015 22:33 To: Tian, Feng; Zeng, Star; edk2-devel@lists.01.org Subject: MdePkg: Fix RAM Disk Device Path To Text Issue Feng / Star, Can you review this f

Re: [edk2] HID descriptor parsing

2015-08-03 Thread Tian, Feng
PS: please note edk2-de...@lists.sourceforge.net has been removed. Now we use edk2-devel@lists.01.org as edk2 discussion place. From: Tian, Feng Sent: Tuesday, August 04, 2015 09:05 To: Ulysses Mckibbens; edk2-de...@lists.sourceforge.net Cc: Tian, Feng

Re: [edk2] [PATCH] Check arguments for PrintLib format format string

2015-08-03 Thread Scott Duplichan
Andrew Fish [mailto:af...@apple.com] wrote: ]Sent: Monday, August 03, 2015 04:48 PM ]To: Scott Duplichan ]Cc: edk2-devel@lists.01.org ; Laszlo Ersek ]Subject: Re: [edk2] [PATCH] Check arguments for PrintLib format format string ] ] ]> On Aug 2, 2015, at 9:58 PM, Scott Duplichan wrote: ]> ]> A

Re: [edk2] [Patch 0/3] Use new BDS and UiApp for OvmfPkg

2015-08-03 Thread Ni, Ruiyu
No. I forgot to emphasize that I only tested the QEMU boot timeout feature after changing the QemuBootOrderLib. I don't know how to test the boot order feature. For the SeaBIOS CSM, can you tell me how to test or test it for me if it's very quick? Thanks, Ray -Original Message- From: e

[edk2] [patch 2/2] MdeModulePkg:Refine the code comments in UiApp

2015-08-03 Thread Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Application/UiApp/BootMaint/BootMaint.c| 1 - .../Application/UiApp/DeviceMngr/DeviceManager.h | 4 +- MdeModulePkg/Application/UiApp/FrontPage.c | 4 ++ MdeModulePkg/Application/UiApp/St

[edk2] [patch 1/2] IntelFrameworkModulePkg:Refine the code comments in LegacyBootMaintUiLib

2015-08-03 Thread Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 4 +--- .../Library/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf| 12 ++-- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git

Re: [edk2] [patch 1/2] IntelFrameworkModulePkg:Refine the code comments in LegacyBootMaintUiLib

2015-08-03 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Bi, Dandan Sent: Tuesday, August 04, 2015 12:51 PM To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org Subject: [patch 1/2] IntelFrameworkModulePkg:Refine the code comments in LegacyBootMaintUiLib Contributed-under: TianoCore Contributio

Re: [edk2] [patch 2/2] MdeModulePkg:Refine the code comments in UiApp

2015-08-03 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Bi, Dandan Sent: Tuesday, August 04, 2015 12:51 PM To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org Subject: [patch 2/2] MdeModulePkg:Refine the code comments in UiApp Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-

[edk2] [patch] MdeModulePkg:Fix the issue that refresh the question fail in DriverSample

2015-08-03 Thread Dandan Bi
Once the question is refreshed,the processing should happen in the callback function of EFI_BROWSER_ACTION_RETRIEVE case,rather than EFI_BROWSER_ACTION_CHANGING in DriverSample. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Universal/DriverSampleDxe/D

Re: [edk2] [patch] MdeModulePkg:Fix the issue that refresh the question fail in DriverSample

2015-08-03 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Tuesday, August 04, 2015 1:16 PM To: Dong, Eric; Gao, Liming; edk2-devel@lists.01.org Subject: [edk2] [patch] MdeModulePkg:Fix the issue that refresh the questi

[edk2] [Patch] UefiCpuPkg/CpuMpPei: Add meta data description

2015-08-03 Thread Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan CC: Qiu Shumin --- UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/UefiCpuPkg/CpuMpPei/CpuMpPei.inf b/UefiCpuPkg/CpuMpPei/CpuMpPei.inf index 92c64f9..64

Re: [edk2] [Patch] UefiCpuPkg/CpuMpPei: Add meta data description

2015-08-03 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin -Original Message- From: Fan, Jeff Sent: Tuesday, August 04, 2015 2:05 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin Subject: [Patch] UefiCpuPkg/CpuMpPei: Add meta data description Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan C

[edk2] error when build ovmf

2015-08-03 Thread ????
when build -a X64 -p OvmfPkg\OvmfPkgX64.dsc , build... : error C0DE: Unknown fatal error when processing [c:\edk2-master\OvmfPkg\Platf ormDxe\Platform.inf] (Please send email to edk2-de...@lists.sourceforge.net for help, attaching follo wing call stack trace!) (Python 2.7.3 on win32) Trace