Re: [edk2] [PATCH] MdeModulePkg: PciBusDxe: Properly exit PCI function loops early if the device is not a multifunction device.

Can I get help from someone to commit this change please? -Original Message- From: Ni, Ruiyu [mailto:ruiyu...@intel.com] Sent: Wednesday, September 30, 2015 12:35 AM To: Shifflett, Joseph ; El-Haj-Mahmoud, Samer ;

Re: [edk2] [PATCH v3 1/1] MdeModulePkg: exit pci function loops early if device is not multi-function

Sorry, this is the correct patch (v3) that needs to be committed. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ni, Ruiyu Sent: Wednesday, September 30, 2015 12:35 AM To: Shifflett, Joseph ; edk2-devel@lists.01.org Cc:

Re: [edk2] [PATCH] NetworkPkg: Remove unused local variables

Anyone for review please? -Original Message- From: El-Haj-Mahmoud, Samer Sent: Tuesday, September 29, 2015 6:02 PM To: edk2-devel@lists.01.org Cc: Siyuan Fu ; El-Haj-Mahmoud, Samer ; El-Haj-Mahmoud, Samer

[edk2] [PATCH v4 1/2] MdeModulePkg: exit pci function loops early if device is not multi-function

When looping through all PCI functions, code should not look for functions 1-7 if function 0 is not present or if function 0 indicates the device is not multifunction. Prior to this fix the code would use stale data in a buffer to determine if a device is multifunction even if function 0 is

Re: [edk2] [PATCH v3 1/1] MdeModulePkg: exit pci function loops early if device is not multi-function

On 10/06/15 17:37, El-Haj-Mahmoud, Samer wrote: > Sorry, this is the correct patch (v3) that needs to be committed. I could help you with committing this, but I see the following issues with the patch: - It modifies two top level packages in one patch, for no obvious reason. - If the original

[edk2] [PATCH v4 2/2] DuetPkg: exit pci function loops early if device is not multi-function

When looping through all PCI functions, code should not look for functions 1-7 if function 0 is not present or if function 0 indicates the device is not multifunction. Prior to this fix the code would use stale data in a buffer to determine if a device is multifunction even if function 0 is

Re: [edk2] [PATCH] Pkg-Module: Integrate new RngLib into RngDxe

Thomas, In other EDK II functions, we use the name "Uintn" instead of "Word" for a function that returns a value that is the natural size of the executing CPU. Also, I do not think you need the internal work function to generate a natural sized random number. Both IA32 and X64 versions the

Re: [edk2] [PATCH v4 1/2] MdeModulePkg: exit pci function loops early if device is not multi-function

Sigh. Here's what I did: On 10/06/15 21:19, Shifflett, Joseph wrote: > When looping through all PCI functions, code should not look for functions > 1-7 if function 0 is not present or if function 0 indicates the device is not > multifunction. Prior to this fix the code would use stale data in

Re: [edk2] [PATCH] NetworkPkg: Remove unused local variables

On 10/06/15 17:38, El-Haj-Mahmoud, Samer wrote: > Anyone for review please? I reproduced the build failure with Linaro's cross compiler (I added the HTTP stack to ArmVirtQemu.dsc and cross-built it). Reviewed-by: Laszlo Ersek Build-tested-by: Laszlo Ersek

[edk2] [PATCH] ArmPlatformPkg: Fixes for Juno ACPI

1. Change Interrupt for Juno PCI Routing table Interrupt Number Reference: http://www.arm.com/files/pdf/DDI0515D1a_juno_arm_development_platform_soc_trm.pdf table 3-3 page 3-7 2. Support for PCI IO range with ACPI on JUNO Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [PATCH] Pkg-Module: Integrate new RngLib into RngDxe v2

Use the new RngLib to provide the IA32/X64 random data for RngDxe. Remove x86 specific functions from RdRand files. Clean up files in RngDxe/IA32 and RngDxe/X64 that are subsumed by files in BaseRngLib. Simplify RngDxe by using GetRandomNumber64 for both IA32 and X64 platforms. Explicitly use

Re: [edk2] [PATCH] NetworkPkg: Remove unused local variables

Thank you! -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, October 06, 2015 2:53 PM To: El-Haj-Mahmoud, Samer ; edk2-devel@lists.01.org Cc: Siyuan Fu Subject: Re: [edk2] [PATCH]

Re: [edk2] [PATCH] Pkg-Module: Integrate new RngLib into RngDxe

Mike, Thanks for your response. I was trying to preserve the previous code as much as possible, so I did not rename the Word functions. Are you suggesting that I can remove the "Word" functions entirely and just use the 64 variants? If so, I'll refactor my patch accordingly.

Re: [edk2] [PATCH] Pkg-Module: Integrate new RngLib into RngDxe v2

Thomas, How about something like below to further simplify to one function and handle alignment issues. Also, do you know where the 10us delay comes from in RdRandGetSeed128()? Is there a pointer to a document? EFI_STATUS EFIAPI RdRandGetBytes ( IN UINTN Length, OUT UINT8

Re: [edk2] [PATCH v2 3/4] MdeModulePkg/DxeIplPeim: implement non-exec stack for ARM/AARCH64

On Mon, Sep 21, 2015 at 04:02:25PM -0700, Ard Biesheuvel wrote: > Mark the DXE stack region as non-executable right before handing > off to the DXE core, by invoking the appropriate ArmLib function. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH] ArmPlatformPkg/RTSM: remove obsolete Foundation model libraries

On 6 October 2015 at 13:18, Leif Lindholm wrote: > On Fri, Sep 04, 2015 at 12:01:24PM +0200, Ard Biesheuvel wrote: >> These are no longer used by any platform in the tree, nor are they >> of any significance to any out of tree platforms. > > Yep, drop 'em. > >

Re: [edk2] [PATCH 1/2] BaseTools/PeCoffLoader: fix handling of ARM MOVW/MOVT instruction relocs

On Tue, Sep 29, 2015 at 10:28:59AM +0200, Ard Biesheuvel wrote: > The handling of ARM MOVW/MOVT relocations sets the FixupData twice (once > incorrectly), but fails to advance the *FixupData pointer afterwards. > This is not actually a problem, since the fixup data is never used but > let's fix it

[edk2] [PATCH v3 0/5] non-exec DXE stack for AARCH64

This series enables the non-exec DXE stack feature for AARCH64. It involves some refactoring of ArmLib so we can reuse the bulk of the page table manipulation code (patch #1,#2). Then, it is simply a matter of calling the newly introduced ArmSetMemoryRegionNoExec () [patch #3] on the stack region

[edk2] [PATCH v3 4/5] MdeModulePkg/DxeIplPeim: implement non-exec stack for ARM/AARCH64

Mark the DXE stack region as non-executable right before handing off to the DXE core, by invoking the appropriate ArmLib function. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm

[edk2] [PATCH v3 2/5] ArmPkg/AArch64Mmu: move page table traversal code to separate function

Move the page table traversal and splitting logic to a separate function UpdateRegionMapping() and refactor it slightly so we can reuse it later to implement non-executable regions, for the stack. This primarly involves adding a value/mask pair to the function prototype that allows us to flip

[edk2] [PATCH] Pkg-Module: Integrate new RngLib into RngDxe

Use the new RngLib to provide the IA32/X64 random data for RngDxe. Remove x86 specific functions from RdRand files. Clean up files in RngDxe/IA32 and RngDxe/X64 that are subsumed by files in BaseRngLib. A key piece to this change was creating a RdRandWord and RdRandGetWords functions that could