Re: [edk2] SATA 3.0 AHCI host controller codebase

Hi Laszlo, Please find my replies and few more doubts in-lined. -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Monday, February 15, 2016 4:42 PM To: Shaveta Leekha ; Bhupesh Sharma ; Leif Lindholm

Re: [edk2] Memory sharing between PEI and DXE phases

On 02/16/16 07:26, Bhupesh Sharma wrote: > Hi Experts, > > I have a doubt regarding memory sharing between PEI and DXE phases. > > Let's say I have a PEI library 'NorLib.c' and a DXE driver 'NorDxeDriver.c', > where > the DXE driver uses some APIs of the PEI Library to obtain information and >

Re: [edk2] SATA 3.0 AHCI host controller codebase

On 02/16/16 09:06, Shaveta Leekha wrote: > Hi Laszlo, > > Please find my replies and few more doubts in-lined. I cannot visually distinguish your comments from mine. Can you please resend your email with a mailer that supports sane quoting, or else mark each one of the paragraphs you are adding

Re: [edk2] [PATCH] ArmPlatformPkg: delete Juno ACPI tables

On 15 February 2016 at 18:20, Leif Lindholm wrote: > Juno is now managed in OpenPlatformPkg, including the ACPI > tables - so delete this unmaintained copy. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leif Lindholm

Re: [edk2] [PATCH] ArmPlatformPkg: delete Juno ACPI tables

On 16 February 2016 at 08:52, Ard Biesheuvel wrote: > On 15 February 2016 at 18:20, Leif Lindholm wrote: >> Juno is now managed in OpenPlatformPkg, including the ACPI >> tables - so delete this unmaintained copy. >> >> Contributed-under:

Re: [edk2] SATA 3.0 AHCI host controller codebase

Resending it -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, February 16, 2016 2:02 PM To: Shaveta Leekha ; Bhupesh Sharma ; Leif Lindholm Cc: edk2-devel@lists.01.org

Re: [edk2] [patch 0/2] Refine function comments in Keyword Handler Protocol

Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Monday, February 15, 2016 2:56 PM To: edk2-devel@lists.01.org Cc: Dong, Eric; Gao, Liming Subject: [edk2] [patch 0/2] Refine function

[edk2] Why is the tools_def.txt file parsed 47 times on my fds build?

I turned on profiling in Python: BaseTools/BinWrappers/PosixLike/RunToolFromSource: #!/usr/bin/env bash #python `dirname $0`/RunToolFromSource.py `basename $0` $* PYTHONPATH="`dirname $0`/../../Source/Python" \ python -m cProfile -s time "`dirname $0`/../../Source/Python"/`basename

Re: [edk2] SATA 3.0 AHCI host controller codebase

On 02/16/16 10:01, Shaveta Leekha wrote: > Resending it > > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, February 16, 2016 2:02 PM > To: Shaveta Leekha ; Bhupesh Sharma > ; Leif Lindholm

[edk2] [patch 1/2] MdePkg: Add new HII action type EFI_BROWSER_ACTION_SUBMITTED

Base on the UEFI2.6, Add the new HII action type EFI_BROWSER_ACTION_SUBMITTED to notify HII driver when its question values are submitted. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi

[edk2] [patch 2/2] MdeModulePkg: Add new HII action type EFI_BROWSER_ACTION_SUBMITTED

Add new HII action type EFI_BROWSER_ACTION_SUBMITTED to notify HII driver when its question values are submitted. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi ---

[edk2] [patch 0/2] Add new HII action type EFI_BROWSER_ACTION_SUBMITTED

The following two patches mainly add the new HII action type EFI_BROWSER_ACTION_SUBMITTED to notify HII driver when its question values are submitted. Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

Re: [edk2] [PATCH v2 1/2] ShellPkg/UefiDpLib: Refine the code of locating all handles in DpTrace.c.

Series Reviewed -By: Samer El-Haj-Mahmoud -Original Message- From: Shia, Cinnamon Sent: Monday, February 15, 2016 3:07 AM To: edk2-devel@lists.01.org Cc: El-Haj-Mahmoud, Samer ; Shia, Cinnamon Subject: [PATCH v2

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

On 02/16/2016 12:58 AM, Dandan Bi wrote: This feature is aimed to allow OS make use of the HII database during runtime. In this case, the contents of the HII Database is exported to a buffer. The pointer to the buffer is placed in the EFI System Configuration Table, where it can be retrieved by

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

> On Feb 16, 2016, at 8:33 AM, Brian J. Johnson wrote: > > On 02/16/2016 12:58 AM, Dandan Bi wrote: >> This feature is aimed to allow OS make use of the HII database >> during runtime. In this case, the contents of the HII Database >> is exported to a buffer. The pointer to

Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned

(trimming) |Not wishing to influence the discussion, just out of curiosity: Jeremy |mentions "numerous other BlockIo protocol providers in edk2 bounce IO |operations rather than simply allowing them to fail" -- can we see some |examples? I wonder if, upon seeing that code, we could use "git

Re: [edk2] [PATCH] EmbeddedPkg: Add ACPI6.0 GIC Definitions

I will test it on Juno and update the patch. Thanks, Supreeth -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Monday, February 15, 2016 11:34 AM To: Supreeth Venkatesh Cc: edk2-devel@lists.01.org; ard.biesheu...@linaro.org; graeme.greg...@linaro.org

Re: [edk2] [PATCH] MdeModulePkg, AtaBusDxe: Bounce buffer IO operations if unaligned

On 02/16/16 17:36, Jeremy Linton wrote: > > (trimming) > > |Not wishing to influence the discussion, just out of curiosity: Jeremy > |mentions "numerous other BlockIo protocol providers in edk2 bounce IO > |operations rather than simply allowing them to fail" -- can we see some > |examples? I

Re: [edk2] [patch] MdeModulePkg: Make HII configuration settings available to OS runtime

+1 I also would add there may be some HII strings that are hidden from user interfaces, and reflect settings for field service or troubleshooting, and that a mass export to the OS may expose these settings to OS runtime code and possibly applications. -Original Message- From:

[edk2] [PATCH v1 1/1] StdLib/BsdSocketLib: Fix minor memory leak.

Fixes a minor memory leak in function res_mkupdrec() by freeing rrecp on error return. The error return is triggered by one of two conditions: 1. rrecp is NULL (calloc failed) 2. strdup(dname) returns NULL Previously, the function just returned NULL. This patch adds a call to free rrecp

Re: [edk2] [PATCH] BaseTools: LzmaCompress: eliminate _maxMode and bogus indentation

On 2016-02-15 10:47:28, Laszlo Ersek wrote: > The "_maxMode" variable doesn't exist in edk2's variant of LzmaCompress, > but the way one of the old uses of the variable is commented out (i.e., > together with the enclosing "if" statement) triggers the > "misleading-indentation" warning that is new

Re: [edk2] Using PCD to set default policy for IPv4/IPv6

Jiaxin, This proposal looks incomplete to me. If the configuration policy is set to Ip4Config2PolicyStatic or Ip6ConfigPolicyManual, then it seems like a lot more configuration information would be required for the static or manual policies. Can you also provide details on the complete

Re: [edk2] Using PCD to set default policy for IPv4/IPv6

Mike, Thanks your comments. First, I agree other platform modules can also change the police by using the set operation. Second for the complete design, the proposed for the new PCDs will only be consumed by Ip4Dxe/Ip6Dxe modules. The PCDs are used by these two modules to determine the default

Re: [edk2] [Patch 1/2] MdeModulePkg: Define one function to create DNS QName

Hi, Jiaxin Comments as below. 1. In the function description of NetLibCreateDnsQName(), whether below sentence The domain name terminates with the zero... Should be The QName terminates with the zero... The Caller should take responsibility to the buffer in QName. Should

Re: [edk2] [Patch 1/2] MdeModulePkg: Define one function to create DNS QName

BTW, the DNS_MAX_BLKSIZE better to be DNS_MAX_MESSAGE_SIZE, according to the words in RFC. > -Original Message- > From: Fu, Siyuan > Sent: Wednesday, February 17, 2016 11:20 AM > To: Wu, Jiaxin ; edk2-devel@lists.01.org > Cc: Hegde Nagaraj P

Re: [edk2] [Patch 2/2] NetworkPkg: Replace the internal function with exposed one

Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Friday, January 22, 2016 1:54 AM > To: edk2-devel@lists.01.org > Cc: Hegde Nagaraj P ; Ye, Ting > ; Fu, Siyuan > Subject: [Patch

Re: [edk2] [Patch 1/2] MdeModulePkg: Define one function to create DNS QName

Thanks Siyuan, I don't have strong opinion about the name DNS_MAX_BLKSIZE or DNS_MAX_MESSAGE_SIZE. For comments 1 and 2, I agree the changes. For comments 3 and 4, according RFC1035 descriptions as below: << Various objects and parameters in the DNS have size limits. They are listed below.

Re: [edk2] [Patch 1/2] MdeModulePkg: Define one function to create DNS QName

For public library interface, we should check the input parameters and return error code or NULL pointer if it's invalid, instead of use assert. > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, February 17, 2016 12:09 PM > To: Fu, Siyuan ;

Re: [edk2] [Patch 1/2] MdeModulePkg: Define one function to create DNS QName

That's fine, thanks Siyuan. -Original Message- From: Fu, Siyuan Sent: Wednesday, February 17, 2016 12:17 PM To: Wu, Jiaxin ; edk2-devel@lists.01.org Cc: Hegde Nagaraj P ; Ye, Ting Subject: RE: [Patch 1/2] MdeModulePkg:

[edk2] [PATCH v2 1/2] MdeModulePkg: Define a general function to create DNS QName

v2: * Correct function description. * Correct max QName size. * Add max domain name length check. This patch is used to define a general function to create DNS QName. QName is a domain name represented as a sequence of labels, where each label consists of a length octet followed by that number of

[edk2] [PATCH v2 0/2] Expose one function defined in DnsDxe to NetLib

v2: * Correct function description. * Correct max QName size. * Add max domain name length check. * Update to use DNS_MAX_MESSAGE_SIZE. The series of patches are used to expose one function defined in DnsDxe to NetLib. Cc: Hegde Nagaraj P Cc: Ye Ting

[edk2] [PATCH v2 2/2] NetworkPkg: Replace the internal function with exposed one

v2: * Update to use DNS_MAX_MESSAGE_SIZE. This patch is used to replace the internal function with the exposed one defined in NetLib.h. Cc: Hegde Nagaraj P Cc: El-Haj-Mahmoud Samer Cc: Ye Ting Cc: Fu Siyuan

Re: [edk2] [PATCH v3 1/2] MdeModulePkg: Define a general function to create DNS QName

Reviewed-by: Fu Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Wednesday, February 17, 2016 2:52 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan

[edk2] Allocating Aligned Pages

Hi Experts, We are using the 'AllocateAlignedPages' function (inside 'MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c') to allocate 512MB aligned memory chunk in a DXE driver. However the memory chunk which gets allocated by this API is around 1GB. I understand that this might be