[edk2] [PATCH] Maintainers.txt: Change maintainer of VLV2 packages.

2016-10-27 Thread david wei
Cc: Liming Gao Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: David Wei Acked-by: Jordan Justen --- Maintainers.txt | 4 ++-- 1 file changed, 2

Re: [edk2] [PATCH 00/47] edk2: centralize and adopt ARRAY_SIZE()

2016-10-27 Thread Laszlo Ersek
On 10/27/16 08:05, Jordan Justen wrote: > On 2016-10-26 12:04:17, Laszlo Ersek wrote: >> I'm sure most of us have wished at some point that ARRAY_SIZE() >> had existed in a central header file, like it does in many other >> open source projects. > > Indeed! > >> This series implements that. >>

Re: [edk2] [PATCH 11/47] DuetPkg/DuetBdsLib: rebase to ARRAY_SIZE()

2016-10-27 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Regards, Ray From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, October 27, 2016 4:17 PM To: edk2-devel-01 ; Ni, Ruiyu Subject: Re: [edk2] [PATCH 11/47]

Re: [edk2] [PATCH] Change maintainer of VLV2 packages

2016-10-27 Thread Jordan Justen
On 2016-10-26 23:45:48, Wei, David wrote: > From 5d74ba9b6be85a86cb470b302fe25349d05caa04 Mon Sep 17 00:00:00 2001 > From: david wei > Date: Thu, 27 Oct 2016 14:42:07 +0800 > Subject: [PATCH] Change maintainer of VLV2 packages. > Can you use git send-email to send patches?

Re: [edk2] [PATCH 45/47] Vlv2TbltDevicePkg/PlatformPei: rebase to ARRAY_SIZE()

2016-10-27 Thread Guo, Mang
Reviewed-by: Guo, Mang . -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, October 27, 2016 3:05 AM To: edk2-devel-01 Cc: Tim He; Wei, David Subject: [edk2] [PATCH 45/47]

[edk2] [patch] NetworkPkg: Add error handling logic when using AllocateZeorPool

2016-10-27 Thread Zhang Lubo
Add error handling logic if failed to apply new memory. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Cc: Fu Siyuan Cc: Wu Jiaxin --- NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c | 8 ++-- 1 file

Re: [edk2] [PATCH 11/47] DuetPkg/DuetBdsLib: rebase to ARRAY_SIZE()

2016-10-27 Thread Laszlo Ersek
Ray, On 10/26/16 21:04, Laszlo Ersek wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > --- > DuetPkg/Library/DuetBdsLib/BdsPlatform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[edk2] [PATCH] Change maintainer of VLV2 packages

2016-10-27 Thread Wei, David
>From 5d74ba9b6be85a86cb470b302fe25349d05caa04 Mon Sep 17 00:00:00 2001 From: david wei Date: Thu, 27 Oct 2016 14:42:07 +0800 Subject: [PATCH] Change maintainer of VLV2 packages. Contributed-under: TianoCore Contribution Agreement 1.0 Cc: Liming Gao

Re: [edk2] [PATCH 00/47] edk2: centralize and adopt ARRAY_SIZE()

2016-10-27 Thread Laszlo Ersek
On 10/27/16 06:43, Gary Lin wrote: > On Wed, Oct 26, 2016 at 09:04:17PM +0200, Laszlo Ersek wrote: >> I'm sure most of us have wished at some point that ARRAY_SIZE() >> had existed in a central header file, like it does in many other >> open source projects. This series implements that. >> >>

Re: [edk2] [PATCH 40/47] SecurityPkg/AuthVariableLib: rebase to ARRAY_SIZE()

2016-10-27 Thread Laszlo Ersek
Star, Chao, On 10/26/16 21:04, Laszlo Ersek wrote: > Cc: Chao Zhang > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek > --- >

Re: [edk2] [PATCH 43/47] Vlv2TbltDevicePkg/FirmwareUpdate: rebase to ARRAY_SIZE()

2016-10-27 Thread Guo, Mang
Reviewed-by: Guo, Mang . -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, October 27, 2016 3:05 AM To: edk2-devel-01 Cc: Tim He; Wei, David Subject: [edk2] [PATCH 43/47]

[edk2] [Patch 2/4] MdePkg DevicePathLib: Validate before touch input buffer.

2016-10-27 Thread Eric Dong
Current code not validate the input buffer before touch. it may touch the buffer outside the validate scope. This patch validate the input size big enough to touch the first node. Cc: Ruiyu NI Cc: Jiewen Yao Contributed-under: TianoCore Contribution

[edk2] [Patch 3/4] MdePkg UefiDevicePathLib: Rollback former change.

2016-10-27 Thread Eric Dong
Former patch still has some bugs, so rollback it and enhance the original code. Cc: Ruiyu NI Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong ---

[edk2] [Patch 4/4] MdePkg UefiDevicePathLib: Validate before touch input buffer.

2016-10-27 Thread Eric Dong
Current code not validate the input buffer before touch. it may touch the buffer outside the validate scope. This patch validate the input size big enough to touch the first node. Cc: Ruiyu NI Cc: Jiewen Yao Contributed-under: TianoCore Contribution

[edk2] [Patch 1/4] MdePkg DevicePathLib: Rollback former change.

2016-10-27 Thread Eric Dong
Former patch still has some bugs, so rollback it and enhance the original code. Cc: Ruiyu NI Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- .../UefiDevicePathLib.c

[edk2] [Patch 0/4] Enhance IsDevciePathValid API

2016-10-27 Thread Eric Dong
Current code may return error status and touch unsafe buffer, this patch series fix these issues. Eric Dong (4): MdePkg DevicePathLib: Rollback former change. MdePkg DevicePathLib: Validate before touch input buffer. MdePkg UefiDevicePathLib: Rollback former change. MdePkg

Re: [edk2] [PATCH 44/47] Vlv2TbltDevicePkg/PlatformInitPei: rebase to ARRAY_SIZE()

2016-10-27 Thread Guo, Mang
Reviewed-by: Guo, Mang . -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, October 27, 2016 3:05 AM To: edk2-devel-01 Subject: [edk2] [PATCH 44/47] Vlv2TbltDevicePkg/PlatformInitPei: rebase to

Re: [edk2] [PATCH 11/47] DuetPkg/DuetBdsLib: rebase to ARRAY_SIZE()

2016-10-27 Thread Laszlo Ersek
On 10/27/16 11:04, Ni, Ruiyu wrote: > Reviewed-by: Ruiyu Ni Thanks! Laszlo > Regards, > Ray > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, October 27, 2016 4:17 PM > To: edk2-devel-01 ;

Re: [edk2] [PATCH 40/47] SecurityPkg/AuthVariableLib: rebase to ARRAY_SIZE()

2016-10-27 Thread Laszlo Ersek
On 10/27/16 11:09, Zeng, Star wrote: > Oh, it is Reviewed-by: Star Zeng . :) Great, thanks! Laszlo > Thanks, > Star > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, October 27, 2016 5:08

Re: [edk2] [Patch 2/3] MdeModulePkg: Update IP4 stack drivers for classless address unicast check.

2016-10-27 Thread Ye, Ting
Hi Siyuan, When checking IPv4 address without subnet mask, do you think we need keep ALL-ZERO address check? I see the patch removes all checking, for example, when user input local IP/Gateway from UI in Ip4Config2Nv.c. Best Regards, Ye Ting -Original Message- From: edk2-devel

Re: [edk2] [PATCH 10/47] ArmVirtPkg/NorFlashQemuLib: rebase to ARRAY_SIZE()

2016-10-27 Thread Ard Biesheuvel
On 26 October 2016 at 20:04, Laszlo Ersek wrote: > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH 00/47] edk2: centralize and adopt ARRAY_SIZE()

2016-10-27 Thread Jordan Justen
On 2016-10-26 12:04:17, Laszlo Ersek wrote: > I'm sure most of us have wished at some point that ARRAY_SIZE() > had existed in a central header file, like it does in many other > open source projects. Indeed! > This series implements that. > > Patches 01-04 round up the modules that #define

Re: [edk2] [PATCH 47/47] Vlv2TbltDevicePkg/SmBiosMiscDxe: rebase to ARRAY_SIZE()

2016-10-27 Thread Guo, Mang
Reviewed-by: Guo, Mang . -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, October 27, 2016 3:05 AM To: edk2-devel-01 Cc: Tim He; Wei, David Subject: [edk2] [PATCH 47/47]

Re: [edk2] [PATCH 46/47] Vlv2TbltDevicePkg/PlatformSetupDxe: rebase to ARRAY_SIZE()

2016-10-27 Thread Guo, Mang
Reviewed-by: Guo, Mang . -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, October 27, 2016 3:05 AM To: edk2-devel-01 Cc: Tim He; Wei, David Subject: [edk2] [PATCH 46/47]

Re: [edk2] [PATCH 40/47] SecurityPkg/AuthVariableLib: rebase to ARRAY_SIZE()

2016-10-27 Thread Zeng, Star
Oh, it is Reviewed-by: Star Zeng . :) Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, October 27, 2016 5:08 PM To: Zeng, Star ; Zhang, Chao B

[edk2] [PATCH] OvmfPkg: Make use of ARRAY_SIZE()

2016-10-27 Thread Gary Lin
Convert the remaining pieces to make the code shorter and more readable. Cc: Justen Jordan Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin --- OvmfPkg/Csm/CsmSupportLib/LegacyRegion.c

[edk2] [PATCH v2 1/3] MdeModulePkg: Update NetLib interface to support classless addressing.

2016-10-27 Thread Fu Siyuan
V2: Add macro IP4_IS_UNSPECIFIED. The classful addressing (IP class A/B/C) has been deprecated according to RFC4632. This patch updates the NetLib NetGetIpClass() and NetIp4IsUnicast() accordingly. NetGetIpClass() The function is kept for compatibility, while the caller of this function could

[edk2] [PATCH v2 3/3] NetworkPkg: Update IP4 stack drivers for classless address unicast check.

2016-10-27 Thread Fu Siyuan
V2 update: Keep the zero address and broadcast check if network mask is not available. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan Cc: Ye Ting Cc: Zhang Lubo Cc: Wu Jiaxin

[edk2] [PATCH v2 2/3] MdeModulePkg: Update IP4 stack drivers for classless address unicast check.

2016-10-27 Thread Fu Siyuan
V2 update: Keep the zero address and broadcast check if network mask is not available. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan Cc: Ye Ting Cc: Zhang Lubo Cc: Wu Jiaxin

[edk2] [PATCH v2 0/3] classless address network unicast check

2016-10-27 Thread Fu Siyuan
V2 update: Keep the zero address and broadcast check if network mask is not available. The classful addressing (IP class A/B/C) has been deprecated according to RFC4632. This patch updates the NetLib and network drivers for the unicast check in classless network. Fu Siyuan (3): MdeModulePkg:

Re: [edk2] [PATCH 00/47] edk2: centralize and adopt ARRAY_SIZE()

2016-10-27 Thread Laszlo Ersek
On 10/26/16 21:04, Laszlo Ersek wrote: > I'm sure most of us have wished at some point that ARRAY_SIZE() > had existed in a central header file, like it does in many other > open source projects. This series implements that. > > Patches 01-04 round up the modules that #define ARRAY_SIZE() just >

Re: [edk2] [Patch 2/3] MdeModulePkg: Update IP4 stack drivers for classless address unicast check.

2016-10-27 Thread Fu, Siyuan
Hi, Ting Yes you are right, I have made the v2 patch to keep the zero address and broadcast address check, thanks. BestRegards Fu Siyuan > -Original Message- > From: Ye, Ting > Sent: Thursday, October 27, 2016 3:18 PM > To: Fu, Siyuan ; edk2-devel@lists.01.org >

Re: [edk2] [PATCH 2/3] MdeModulePkg/TerminalDxe: Optimize TtyTerm cursor motion

2016-10-27 Thread Kinney, Michael D
Committed at https://github.com/tianocore/edk2/commit/d1b757e2cd034e32676c5cc2d542f785e74f8c5d Mike > -Original Message- > From: Kinney, Michael D > Sent: Thursday, October 27, 2016 11:14 AM > To: Brian J. Johnson ; edk2-devel@lists.01.org; Kinney, > Michael D >

Re: [edk2] [PATCH 2/3] MdeModulePkg/TerminalDxe: Optimize TtyTerm cursor motion

2016-10-27 Thread Kinney, Michael D
Brian, Thanks. I will do the commit with your rb. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Brian > J. Johnson > Sent: Thursday, October 27, 2016 11:06 AM > To: Kinney, Michael D ;

Re: [edk2] [PATCH 2/3] MdeModulePkg/TerminalDxe: Optimize TtyTerm cursor motion

2016-10-27 Thread Brian J. Johnson
On 10/26/2016 10:09 PM, Kinney, Michael D wrote: Tian Feng, Unfortunately, this patch that was pushed to edk2/master today breaks on IA32 VS2015x86 builds with a signed/unsigned mismatch on 3 lines. I think the right fix might be: diff --git

Re: [edk2] [shell] AliasLower never used in InternalSetAlias

2016-10-27 Thread Tim Lewis
I would also note that GetAlias() has similar logic, but does, in fact use the AliasLower. As far as I can tell, the specification does not say anything about case-insensitive, so I believe this to be in error. Tim -Original Message- From: edk2-devel

[edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to SmmCpuFeaturesLib library.

2016-10-27 Thread Leo Duran
1) Remove SmmGetProcessorLocation() from PiSmmCpuDxeSmm driver 2) Add SmmCpuFeaturesGetProcessorLocation() to SmmCpuFeaturesLib library Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Leo Duran --- UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h |

[edk2] [PATCH] PiSmmCpuDxeSmm

2016-10-27 Thread Leo Duran
This patch moves code that uses Intel-specific CPUID to a library. Leo Duran (1): UefiCpuPkg: Move GetProcessorLocation() to SmmCpuFeaturesLib library. UefiCpuPkg/Include/Library/SmmCpuFeaturesLib.h | 17 +++ .../Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 118

[edk2] [shell] AliasLower never used in InternalSetAlias

2016-10-27 Thread Tim Lewis
In the function InternalSetAlias, it appears that AliasLower is duplicated (fromAlias), converted to lower case and freed ,but never actually used. Am I missing something? // Convert to lowercase to make aliases case-insensitive if (Alias != NULL) { AliasLower = AllocateCopyPool

[edk2] [shell]cd.. and cd\ are not valid alias

2016-10-27 Thread Tim Lewis
But the EDK2 registers them as a part of Level 2 supported command initialization. ShellCommandRegisterAlias(L"cd ..", L"cd.."); ShellCommandRegisterAlias(L"cd \\", L"cd\\"); According to the SetAlias() description: An alias is a C-style identifier The same language is repeated in 3.6.4.

[edk2] [RFC] [MdePkg] UefiLib: CreatePopUp

2016-10-27 Thread Felix Poludov
UefiLib library class (MdePkg ) includes CreatePopUp function. The function displays a message box. There is certainly more than one way to draw a message box. If homogenous user interface is a project requirement, CreatePopUp is likely to be overridden to align message box appearance with the

Re: [edk2] [PATCH] BaseTool/Pkcs7: Add TestRoot.cer.

2016-10-27 Thread Kinney, Michael D
Jiewen, Reviewed-by: Michael D Kinney Can you please add a Readme.MD to this directory that provides a brief description of each file in this directory and how each file was created/generated. TestCert.pem TestCert.pub.pem TestRoot.cer TestRoot.pem

Re: [edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to SmmCpuFeaturesLib library.

2016-10-27 Thread Fan, Jeff
Leo and Mike, GetProcessorLocation() are not only used by PiSmmCpuDxeSmm driver, it is also duplicated in UefiCpuPkg\Library\MpInitLib\MpLib.c. I suggest that we could add this API into UefiCpuPkg/Include/UefiCpuLib or UefiCpuPkg/Include/ LocalApicLib.h. Thus, it could be consumed by modules

Re: [edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to SmmCpuFeaturesLib library.

2016-10-27 Thread Kinney, Michael D
Leo, This looks like a good proposed change to the SmmFeaturesLib and PiSmmCpuDxeSmm module. Adding UefiCpuPkg maintainer Jeff Fan to the Cc list. There are 3 implementations of the SmmFeaturesLib in edk2/master. This patch needs to update all 3, or some of the platforms in edk2/master will no

Re: [edk2] [PATCH] BaseTool/Pkcs7: Add TestRoot.cer.

2016-10-27 Thread Yao, Jiewen
Yes, I am glad to. I have a step by step internally. Will write a MD in a new patch. From: Kinney, Michael D Sent: Friday, October 28, 2016 6:00 AM To: Yao, Jiewen ; edk2-devel@lists.01.org; Kinney, Michael D Cc: Gao, Liming

Re: [edk2] [PATCH] UefiCpuPkg: Move GetProcessorLocation() to SmmCpuFeaturesLib library.

2016-10-27 Thread Fan, Jeff
Because the CPU location information are gotten from Initial APIC ID, it makes more sense to be added into Local APIC Lib. The following is my proposal on its definition. /** Get CPU Package/Core/Thread location information. @param[in] InitialApicIdCPU APIC ID @param[out] Package

Re: [edk2] [patch] NetworkPkg: Add error handling logic when using AllocateZeorPool

2016-10-27 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan siyuan...@intel.com > -Original Message- > From: Zhang, Lubo > Sent: Thursday, October 27, 2016 3:41 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: [patch] NetworkPkg: Add error handling logic

Re: [edk2] [patch] NetworkPkg: Add error handling logic when using AllocateZeorPool

2016-10-27 Thread Wu, Jiaxin
Reviewed-By: Wu Jiaxin Best Regards! Jiaxin > -Original Message- > From: Zhang, Lubo > Sent: Thursday, October 27, 2016 3:41 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: [patch] NetworkPkg: Add

[edk2] [PATCH v2] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib

2016-10-27 Thread gdong1
CbPlatformSupportLib might use FindCbTag() API to parse platform specific information. So expose this API. And add EFIAPI to all functions in CbParseLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Dong ---

Re: [edk2] [PATCH] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib

2016-10-27 Thread Dong, Guo
Hi Maurice, Thank you for the comments. I have updated patch to add EFIAPI to all the APIs in CbParseLib. Thanks, Guo -Original Message- From: Ma, Maurice Sent: Wednesday, October 26, 2016 8:02 PM To: Dong, Guo Cc: Agyeman, Prince ;

[edk2] [PATCH V5 7/7] UefiCpuPkg/UefiCpuPkg.dsc: Add MicrocodeCapsule related component.

2016-10-27 Thread Jiewen Yao
Add Microcode capsule related component to check build. Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang

[edk2] [PATCH V5 6/7] UefiCpuPkg/MicrocodeCapsuleApp: Add MicrocodeCapsuleApp application.

2016-10-27 Thread Jiewen Yao
This MicrocodeCapsuleApp can help generate Microcode FMP capsule. It can also dump Microcode capsule information. Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao

[edk2] [PATCH V5 5/7] UefiCpuPkg/MicrocodeUpdate: Add MicrocodeUpdate component.

2016-10-27 Thread Jiewen Yao
MicrocodeUpdate supports update Microcode region via UEFI FMP capsule. MicrocodeUpdate SetImage() will perform the Microcode version, ProcessorSignature/ProcessorFlag, and try to load microcode. If and only if the Microcode is loaded successfully, and new Microcode will be updated to system flash

[edk2] [PATCH V5 4/7] UefiCpuPkg/MicrocodeFlashAccessLib: Add NULL MicrocodeFlashAccessLib.

2016-10-27 Thread Jiewen Yao
Add NULL instance to pass build. Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore

[edk2] [PATCH V5 1/7] UefiCpuPkg/Include: Add Microcode FMP definition.

2016-10-27 Thread Jiewen Yao
It defined ImageTypeId for Microcode. Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under:

[edk2] [PATCH 8/9] Vlv2TbltDevicePkg/bat: add capsule generation in bat.

2016-10-27 Thread Jiewen Yao
If OPENSSL_PATH is set, the build process generates capsule. Cc: David Wei Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang

Re: [edk2] [PATCH v2] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib

2016-10-27 Thread Dong, Guo
Hi Maurice, Thank you capture this typo. Updated patch has been sent. Thanks, Guo -Original Message- From: Ma, Maurice Sent: Thursday, October 27, 2016 9:38 AM To: Dong, Guo Cc: edk2-devel@lists.01.org; Agyeman, Prince Subject: RE:

Re: [edk2] [PATCH v3] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib

2016-10-27 Thread Ma, Maurice
Reviewed-by: Maurice Ma -Original Message- From: Dong, Guo Sent: Thursday, October 27, 2016 9:47 AM To: edk2-devel@lists.01.org Cc: Ma, Maurice; Agyeman, Prince; Dong, Guo Subject: [edk2] [PATCH v3] CorebootModulePkgPkg: Expose FindCbTag API from CbParseLib

[edk2] [Patch 2/3] MdeModulePkg LzmaDecompressLib: Update LZMA to new 16.04 version

2016-10-27 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- .../LzmaCustomDecompressLib/LZMA-SDK-README.txt| 6 +- .../LzmaArchCustomDecompressLib.inf| 10 +- .../LzmaCustomDecompressLib.inf| 10 +-

[edk2] [Patch 3/3] IntelFrameworkModulePkg LzmaDecompressLib: Update LZMA to new 16.04 version

2016-10-27 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- .../LzmaCustomDecompressLib/LZMA-SDK-README.txt| 6 +- .../LzmaArchCustomDecompressLib.inf| 10 +- .../LzmaCustomDecompressLib.inf| 10 +-

[edk2] [Patch 0/3] Update LZMA SDK to new 16.04 version

2016-10-27 Thread Liming Gao
New version LZMA improves the compression performance, and has no change on the compression algorithm. So, the decompression library can work with the old and new LZMA SDK. To be consistent, LZMA tool and library are both updated to new 16.04 version. Liming Gao (3): BaseTools LzmaCompress:

[edk2] [PATCH 4/9] Vlv2TbltDevicePkg/FlashDeviceLib: Add DXE flash device lib.

2016-10-27 Thread Jiewen Yao
Previous FlashDeviceLib only supports DxeRuntime and Smm. It cannot be linked with SystemBiosUpdateDxe driver. So we separate DxeRuntime related code into a standalone file, and create FlashDeviceLibDxe.inf. Cc: David Wei Cc: Feng Tian Cc: Star Zeng

[edk2] [PATCH 7/9] Vlv2TbltDevicePkg/dsc/fdf: add capsule generation DSC/FDF.

2016-10-27 Thread Jiewen Yao
Add DSC/FDF to generate capsule image. It is separated from normal DSC/FDF, because the FDF file need use the result of final build. Cc: David Wei Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc:

[edk2] [PATCH V5 13/15] SecurityPkg/FmpAuthenticationLibPkcs7: Add PKCS7 instance for FMP.

2016-10-27 Thread Jiewen Yao
It provides PKCS7 based FMP authentication. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH V5 12/15] SecurityPkg/SecurityPkg.dec: Add PcdPkcs7CertBuffer PCD.

2016-10-27 Thread Jiewen Yao
This PCD is similar to PcdRsa2048Sha256PublicKeyBuffer. It provides trusted cert for PKCS7 verification. It can be used for Recovery and Capsule Update images. We added warning message for both PcdPkcs7CertBuffer and PcdRsa2048Sha256PublicKeyBuffer. The default value is only for test purpose.

[edk2] [PATCH V5 10/15] MdeModulePkg/MdeModulePkg.dsc: Add FMP related component.

2016-10-27 Thread Jiewen Yao
Add FMP related component to check build. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH V5 08/15] MdeModulePkg/CapsuleApp: Add CapsuleApp application.

2016-10-27 Thread Jiewen Yao
This CapsuleApp can help perform capsule update in UEFI shell environment. It can also dump capsule information, capsule status variable, ESRT and FMP. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao

[edk2] [PATCH V5 07/15] MdeModulePkg/Esrt: Add ESRT_FW_TYPE_SYSTEMFIRMWARE check.

2016-10-27 Thread Jiewen Yao
The previous ESRT driver unconditionally treat FMP to be ESRT_FW_TYPE_DEVICEFIRMWARE. EDKII System Capsule reuses FMP, but it is ESRT_FW_TYPE_SYSTEMFIRMWARE. Add check to ImageTypeId check to see if it is ESRT_FW_TYPE_SYSTEMFIRMWARE. Cc: Feng Tian Cc: Star Zeng

[edk2] [PATCH V5 15/15] SecurityPkg/SecurityPkg.dsc: Add FmpAuthenticationLib*.

2016-10-27 Thread Jiewen Yao
Add FmpAuthenticationLib* to check build. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH V5 14/15] SecurityPkg/FmpAuthenticationLibRsa2048Sha256: Add RSA2048 instance.

2016-10-27 Thread Jiewen Yao
It provides Rsa2048Sha256 based FMP authentication. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution

[edk2] [PATCH V5 11/15] IntelFrameworkModulePkg/DxeCapsuleLib: Add ProcessCapsules() interface.

2016-10-27 Thread Jiewen Yao
Add NULL ProcessCapsules() interface for DxeCapsuleLib. IntelFrameworkModulePkg is under maintenance phase. We stop adding new feature there. Just add NULL function to make it pass build. Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc:

[edk2] [PATCH V5 10/12] SignedCapsulePkg/SystemFirmwareUpdate: Add SystemFirmwareUpdate.

2016-10-27 Thread Jiewen Yao
SystemFirmwareUpdate supports update system firmware via UEFI FMP capsule. SystemFirmwareReportDxe.inf can be included in system BIOS. It is a lightweight FMP protocol implementation and it only reports FMP information, so that ESRT table can report the system firmware information. SetImage()

[edk2] [PATCH V5 11/12] SignedCapsulePkg/RecoveryModuleLoadPei: Add RecoveryModuleLoadPei.

2016-10-27 Thread Jiewen Yao
RecoveryModuleLoadPei supports recovery system firmware via UEFI FMP capsule. RecoveryModuleLoadPei produces EFI_PEI_RECOVERY_MODULE_PPI. It is invoked by DxeIpl in recovery boot mode. LoadRecoveryCapsule() will scan all possible gEfiPeiDeviceRecoveryModulePpiGuid and get EDKII system FMP

[edk2] [PATCH V5 07/12] SignedCapsulePkg/IniParsingLib: Add InitParsingLib instance.

2016-10-27 Thread Jiewen Yao
This library is used to parse the INI configuration file. The INI configuration file is used in EDKII capsule image to describe the capsule information. Detail format is documented in header file. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney

[edk2] [PATCH V5 08/12] SignedCapsulePkg/EdkiiSystemCapsuleLib: Add EdkiiSystemCapsuleLib.

2016-10-27 Thread Jiewen Yao
This library is used to abstract the action for EDKII system FMP capsule, such as extracting a component from capsule, or authenticate the capsule. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao

[edk2] [PATCH V5 03/12] SignedCapsulePkg/Include: Add EdkiiSystemCapsuleLib definition.

2016-10-27 Thread Jiewen Yao
This library is used to abstract the action for EDKII system FMP capsule, such as extracting a component from capsule, or authenticate the capsule. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao

[edk2] [PATCH V5 06/12] SignedCapsulePkg/CapsulePkg.dec: Add capsule related definition.

2016-10-27 Thread Jiewen Yao
1) Add capsule related GUID. EdkiiSystemFmpCapsule 2) Add capsule related library. EdkiiSystemCapsuleLib IniParsingLib PlatformFlashAccessLib 3) Add EDKII system capsule related DynamicEx PCD PcdEdkiiSystemFirmwareImageDescriptor PcdEdkiiSystemFirmwareFileGuid NOTE: We use

[edk2] [PATCH V5 01/12] SignedCapsulePkg: Add license file.

2016-10-27 Thread Jiewen Yao
Add license file for SignedCapsulePkg. This package contains sample drivers to do system firmware update and recovery. It also includes a capsule library to support system FMP and device FMP. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney

[edk2] [PATCH V5 05/12] SignedCapsulePkg/Include: Add PlatformFlashAccessLib header.

2016-10-27 Thread Jiewen Yao
This library is used to abstract platform flash access. This library is consumed by a capsule update module. It may cover SystemFirmware region and/or non-SystemFirmware region. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney

[edk2] [PATCH V5 09/12] SignedCapsulePkg/PlatformFlashAccessLib: Add NULL instance.

2016-10-27 Thread Jiewen Yao
Add NULL instance to pass build. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH V5 04/12] SignedCapsulePkg/Include: Add IniParsingLib header.

2016-10-27 Thread Jiewen Yao
This library is used to parse the INI configuration file. The INI configuration file is used in EDKII capsule image to describe the capsule information. Detail format is documented in header file. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney

[edk2] [PATCH 3/9] Vlv2TbltDevicePkg/SystemFirmwareUpdateConfig: Add capsule config file.

2016-10-27 Thread Jiewen Yao
Add SystemFirmwareUpdateConfig as capsule configuration file. Cc: David Wei Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang

[edk2] [PATCH 2/9] Vlv2TbltDevicePkg/SystemFirmwareDescriptor: Add Descriptor for capsule update.

2016-10-27 Thread Jiewen Yao
Add SystemFirmwareDescriptor for capsule update. The PEIM extracts SystemFirmwareDescriptor info from FFS and reports it via PCD. Cc: David Wei Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc:

[edk2] [PATCH 6/9] Vlv2TbltDevicePkg/dsc/fdf: Add capsule/recovery support.

2016-10-27 Thread Jiewen Yao
Add capsule and recovery support module in platform dsc and fdf. Cc: David Wei Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang

[edk2] [PATCH 1/9] Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add instance for capsule update.

2016-10-27 Thread Jiewen Yao
Add PlatformFlashAccessLib for capsule update. Cc: David Wei Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang

[edk2] [PATCH 9/9] Vlv2TbltDevicePkg/Build: Add capsule/recovery in help info.

2016-10-27 Thread Jiewen Yao
Cc: David Wei Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH 5/9] Vlv2TbltDevicePkg/PlatformBootManager: Add capsule/recovery handling.

2016-10-27 Thread Jiewen Yao
1) Add capsule and recovery boot path handling in platform BDS. 2) Add check if the platform is using default test key for recovery or update. Produce PcdTestKeyUsed to indicate if there is any test key used in current BIOS, such as recovery key, or capsule update key. Then the generic UI may

[edk2] [PATCH V5 0/9] Add capsule support for Vlv2.

2016-10-27 Thread Jiewen Yao
This is series 5 of the whole capsule solution. Version 5. According to feedback, we split the big patch series to smaller one. Series 5: Vlv2 update The code is also in https://github.com/jyao1/edk2 V5 is at Capsule_V5 branch. V4, V3, V2, V1 are also pushed to coresponding branch. ==Below is

[edk2] [PATCH V5 06/15] MdeModulePkg/DxeCapsuleLibFmp: Add DxeCapsuleLibFmp instance.

2016-10-27 Thread Jiewen Yao
This instance handles Microsoft UX capsule, UEFI defined FMP capsule. This instance should not assume any capsule image format. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao

[edk2] [PATCH V5 00/15] Add capsule update and recovery sample.

2016-10-27 Thread Jiewen Yao
This is series 1 of the whole capsule solution. Version 5. According to feedback, we split the big patch series to smaller one. Series 1: Generic Update (MdeModulePkg/SecurityPkg) DxeCapsuleLib FmAuthenticationLib (*) CapsuleApp (*) The code is also in

[edk2] [PATCH V5 03/15] MdeModulePkg/MdeModulePkg.dec: Add capsule related definition.

2016-10-27 Thread Jiewen Yao
1) Add capsule related library. FmpAuthenticationLib 2) Add capsule related status code PCD. PcdStatusCodeSubClassCapsule PcdCapsuleStatusCodeProcessCapsulesBegin PcdCapsuleStatusCodeProcessCapsulesEnd PcdCapsuleStatusCodeUpdatingFirmware PcdCapsuleStatusCodeUpdateFirmwareSuccess

[edk2] [PATCH V5 05/15] MdeModulePkg/DxeCapsuleLibNull: Add ProcessCapsules() interface.

2016-10-27 Thread Jiewen Yao
Add ProcessCapsules() interface for DxeCapsuleLibNull. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution

[edk2] [PATCH V5 04/15] MdeModulePkg/FmpAuthenticationLibNull: Add NULL instance FMP.

2016-10-27 Thread Jiewen Yao
Add NULL instance to pass build. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH V5 00/12] Add EDKII signed capsule support.

2016-10-27 Thread Jiewen Yao
This is series 2 of the whole capsule solution. Version 5. According to feedback, we split the big patch series to smaller one. Series 2: EDKII Capsule (SignedCapsulePkg) IniParsingLib EdkiiSystemCapsuleLib PlatformFlashAccessLib SystemFirmwareUpdate driver

[edk2] [PATCH V5 02/12] SignedCapsulePkg/Include: Add EDKII system FMP capsule header.

2016-10-27 Thread Jiewen Yao
Add EDKII system FMP capsule header file. This describes the EDKII system FMP capsule format. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang

[edk2] [PATCH V5 1/7] QuarkPlatformPkg/PlatformFlashAccessLib: Add instance for capsule update.

2016-10-27 Thread Jiewen Yao
Add PlatformFlashAccessLib for capsule update. Cc: Michael D Kinney Cc: Kelly Steele Cc: Feng Tian Cc: Star Zeng Cc: Liming Gao Cc: Chao Zhang

[edk2] [PATCH V5 2/7] QuarkPlatformPkg/SystemFirmwareDescriptor: Add Descriptor for capsule update.

2016-10-27 Thread Jiewen Yao
Add SystemFirmwareDescriptor for capsule update. The PEIM extracts SystemFirmwareDescriptor info from FFS and reports it via PCD. Cc: Michael D Kinney Cc: Kelly Steele Cc: Feng Tian Cc: Star Zeng Cc:

[edk2] [PATCH V5 4/7] QuarkPlatformPkg/PlatformInit: Remove recovery PPI installation.

2016-10-27 Thread Jiewen Yao
The QuarkPlatform will use MdeModulePkg/RecoveryModuleLoadPei for recovery. There is no need to produce recovery PPI in platform module. Cc: Michael D Kinney Cc: Kelly Steele Cc: Feng Tian Cc: Star Zeng

[edk2] [PATCH V5 12/12] SignedCapsulePkg/CapsulePkg.dsc: Add capsule related component.

2016-10-27 Thread Jiewen Yao
Add capsule related component to check build. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement

[edk2] [PATCH V5 0/7] Add MicrocodeUpdate support.

2016-10-27 Thread Jiewen Yao
This is series 3 of the whole capsule solution. Version 5. According to feedback, we split the big patch series to smaller one. Series 3: Microcode Update (UefiCpuPkg) MicrocodeFlashAccessLib MicrocodeUpdate driver. The code is also in https://github.com/jyao1/edk2 V5 is at

  1   2   >