[edk2] [Patch] NetworkPkg/HttpDxe: Fix the incorrect SizeofHeaders in HttpTcpReceiveHeader().

Commit 19bd133562df951ae7ff7e1fff99b11a25b4cb6d is to fix the incorrect SizeofHeaders returned from HttpTcpReceiveHeader(). But it missed the "\r\n\r\n" calculation, which will cause the later HttpHeaders parsing failure. This patch is fix the above issue. Cc: Ye Ting Cc:

[edk2] [PATCH] Add NetworkPkg maintainer as MdeModulePkg/Universal/Network maintainer

Cc: Siyuan Fu Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Star Zeng --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index

Re: [edk2] [PATCH] Add NetworkPkg maintainer as MdeModulePkg/Universal/Network maintainer

Reviewed-by: Jiaxin Wu > -Original Message- > From: Zeng, Star > Sent: Wednesday, November 22, 2017 2:34 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Fu, Siyuan ; Wu, > Jiaxin > Subject: [PATCH]

Re: [edk2] [Patch] NetworkPkg/HttpDxe: Fix the incorrect SizeofHeaders in HttpTcpReceiveHeader().

Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Wednesday, November 22, 2017 2:36 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wu, > Jiaxin > Subject: [Patch]

Re: [edk2] [PATCH v6 1/2] MdeModulePkg/DxeCore: Filter out all paging capabilities

Reviewed-by: Star Zeng if the feedback from Jiewen (about comments) and Laszlo (about MemoryMapStart) has been addressed, and the merging will be done in a separated patch. Thanks, Star -Original Message- From: Wang, Jian J Sent: Friday, November 17, 2017 10:49

Re: [edk2] [Patch] MdeModulePkg: Free NET_BUF data after it is sent out to avoid memory leak

Reviewed-by: Fu Siyuan > -Original Message- > From: Wang, Fan > Sent: Wednesday, November 22, 2017 2:56 PM > To: edk2-devel@lists.01.org > Cc: Wu, Jiaxin ; Ye, Ting ; Fu, > Siyuan ; Wang, Fan

Re: [edk2] [PATCH] MdeModulePkg UhciPei: Support IoMmu

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, November 21, 2017 5:01 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen > Subject: [PATCH] MdeModulePkg UhciPei: Support IoMmu > > Update

[edk2] [Patch] MdeModulePkg: Free NET_BUF data after it is sent out to avoid memory leak

When build a DHCP message in function DhcpSendMessage() or DhcpRetransmit(), a new NET_BUF is created by the library of NetbufFromExt, but it's not freed after it is sent out. This patch is to fix this memory leak issue. Cc: Jiaxin Wu Cc: Ye Ting Cc: Fu

Re: [edk2] [PATCH] MdeModulePkg EhciPei: Minor refinement about IOMMU

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, November 21, 2017 5:04 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen > Subject: [PATCH] MdeModulePkg EhciPei: Minor refinement about

Re: [edk2] [PATCH] Add NetworkPkg maintainer as MdeModulePkg/Universal/Network maintainer

Reviewed-by: Fu Siyuan > -Original Message- > From: Zeng, Star > Sent: Wednesday, November 22, 2017 2:34 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Fu, Siyuan ; Wu, > Jiaxin > Subject:

Re: [edk2] [PATCH v7 0/2] Fix multiple entries of RT_CODE in memory map

I am OK on that. > -Original Message- > From: Zeng, Star > Sent: Wednesday, November 22, 2017 3:57 PM > To: Laszlo Ersek ; Wang, Jian J > Cc: edk2-devel@lists.01.org; Yao, Jiewen ; Zeng, Star > >

Re: [edk2] [PATCH v7 0/2] Fix multiple entries of RT_CODE in memory map

How about we have the v6 patch series in first with the feedback from Jiewen (about comments) and you (about MemoryMapStart) addressed? Then we can have a separated patch for the merging. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On

Re: [edk2] [PATCH 2/2] UefiCpuPkg/CpuDxe: Fix multiple entries of RT_CODE in memory map

Reviewed-by: Star Zeng -Original Message- From: Wang, Jian J Sent: Thursday, November 16, 2017 3:27 PM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Yao, Jiewen ; Zeng, Star ; Laszlo Ersek

[edk2] [PATCH] MdeModulePkg UhciPei: Support IoMmu

Update the UhciPei driver to consume IOMMU_PPI to allocate DMA buffer. If no IOMMU_PPI exists, this driver still calls PEI service to allocate DMA buffer, with assumption that DRAM==DMA. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2] [PATCH] MdeModulePkg EhciPei: Minor refinement about IOMMU

This patch is following 2c656af04d7f. 1. Fix typo "XHC" to "EHC". 2. Reinitialize Request(Phy/Map) and Data(Phy/Map) in Urb, otherwise the last time value of them may be used in error handling when error happens. Cc: Jiewen Yao Contributed-under: TianoCore Contribution

[edk2] [RFC] ACPI table HID/CID allocation

Hi, I am enabling ACPI on NXP platform , In order to do minimal changes in Linux driver for device-driver binding. I want to use PRP0001 device as CID and HID as actual (NXP allocated HID). So that Linux can bind with PRP0001 and compatible field, where as other OS (Window etc) can rely on

[edk2] [PATCH] [edk2-platforms]:Enabling Secure boot feature support on hikey platfrom

Added required library packages related to secure boot in hikey.dsc and Blockvariable driver[ from 96-board edk2 fork] to support the NV storage of the variables. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: kalyan-nagabhirava ---

Re: [edk2] [RFC] ACPI table HID/CID allocation

> On 21 November 2017 at 09:59, Udit Kumar wrote: > > Thanks Ard. > > Below table was for example. I am not converting whole DT to ACPI > > tables :) My idea is to reduce Linux patches for probing as possible. > > Also keeping firmware and OS separately then Let firmware

Re: [edk2] [RFC] ACPI table HID/CID allocation

On 21 November 2017 at 09:19, Udit Kumar wrote: > Hi, > > I am enabling ACPI on NXP platform , In order to do minimal changes in Linux > driver for device-driver binding. > > I want to use PRP0001 device as CID and HID as actual (NXP allocated HID). > > So that Linux can bind

Re: [edk2] [RFC] ACPI table HID/CID allocation

Thanks Ard. Below table was for example. I am not converting whole DT to ACPI tables :) My idea is to reduce Linux patches for probing as possible. Also keeping firmware and OS separately then Let firmware expose both way (HID and PRP1) and Linux to decide binding Please see inline as

Re: [edk2] [RFC] ACPI table HID/CID allocation

On 21 November 2017 at 09:59, Udit Kumar wrote: > Thanks Ard. > Below table was for example. I am not converting whole DT to ACPI tables :) > My idea is to reduce Linux patches for probing as possible. > Also keeping firmware and OS separately then > Let firmware expose both

Re: [edk2] [PATCH] BaseTools/tools_def AARCH64 ARM: disable PIE linking for .aslc sources

Hi Ard, 2017-11-16 16:45 GMT+01:00 Ard Biesheuvel : > On 16 November 2017 at 15:31, Gao, Liming wrote: >> Ard: >> Does this error only happen on ACPI table compiling? But, I see -no-pie is >> also in normal DLINK flag. Why is the driver not

Re: [edk2] [PATCH 05/15] ArmVirtPkg/PrePi: remove dependency on ArmPlatformLib

On 11/21/17 16:46, Laszlo Ersek wrote: > On 11/17/17 17:09, Ard Biesheuvel wrote: >> Remove the pointless dependency on ArmPlatformLib: none of the code we >> call from it actually does anything useful. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH 05/15] ArmVirtPkg/PrePi: remove dependency on ArmPlatformLib

On 11/17/17 17:09, Ard Biesheuvel wrote: > Remove the pointless dependency on ArmPlatformLib: none of the code we > call from it actually does anything useful. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH 09/15] ArmVirtPkg/ArmVirtPlatformLib: remove support for uncached mappings

On 11/17/17 17:09, Ard Biesheuvel wrote: > QEMU/KVM has very little tolerance for using anything except writeback > cacheable mappings of DRAM, so let's remove the 'feature' that allows > us to select uncached mappings at build time. > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [PATCH 07/15] ArmVirtPkg/PrePi: remove ArmPlatformStackLib dependency

On 11/17/17 17:09, Ard Biesheuvel wrote: > ArmPlatformStackLib has hooks into primary/secondary core PCDs and > other ArmPlatformLib related junk, so let's simply set the stack > pointer directly. This is trivial given that our PrePi is unicore > only. > > Contributed-under: TianoCore

Re: [edk2] [PATCH 08/15] ArmVirtPkg/PrePi: remove bogus IntelFrameworkModulePkg.dec dependency

On 11/17/17 17:09, Ard Biesheuvel wrote: > PrePi doesn't use anything defined by this package so drop the bogus > dependency. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2] [PATCH 11/15] ArmVirtPkg/ArmVirtXen: add ArmVirtMemInfoLib implementation

On 11/17/17 17:09, Ard Biesheuvel wrote: > Clone the existing ArmPlatformGetVirtualMemoryMap () for this platform, > clean it up slightly (by using a static buffer rather than a heap > allocation, and removing the support for uncached DRAM mappings), and > turn it into a new ArmVirtMemInfoLib

Re: [edk2] [PATCH] BaseTools/tools_def AARCH64 ARM: suppres PIE sections via linker script

Hi Ard, 2017-11-21 17:10 GMT+01:00 Ard Biesheuvel : > Recent distro builds of GCC 6 enable PIE linking by default, and allow > the previous behavior to be restored by passing the -no-pie command line > argument. This was implemented by commits 1894a7c64c0a and

Re: [edk2] [PATCH 12/15] ArmVirtPkg/ArmVirtQemu: add ArmVirtMemInfoLib implementation

On 17 November 2017 at 16:09, Ard Biesheuvel wrote: > Clone the existing ArmPlatformGetVirtualMemoryMap () for this platform, > clean it up slightly (by removing the support for uncached DRAM mappings), > and turn it into a new ArmVirtMemInfoLib implementation. > > In a

Re: [edk2] [PATCH 12/15] ArmVirtPkg/ArmVirtQemu: add ArmVirtMemInfoLib implementation

On 21 November 2017 at 16:56, Laszlo Ersek wrote: > On 11/17/17 17:09, Ard Biesheuvel wrote: >> Clone the existing ArmPlatformGetVirtualMemoryMap () for this platform, >> clean it up slightly (by removing the support for uncached DRAM mappings), >> and turn it into a new

Re: [edk2] [PATCH 06/15] ArmVirtPkg/PrePi: move DRAM discovery code into PrePi

On 11/17/17 17:09, Ard Biesheuvel wrote: > ArmVirtQemuKernel and ArmVirtXen use essentially the same code to > retrieve DRAM information from the DT /memory node at early boot, > and invoke it via the ArmPlatformPeiBootAction () hook exposed by > ArmPlatformLib. Let's move this code into the PrePi

Re: [edk2] [PATCH 10/15] ArmVirtPkg: introduce ArmVirtMemInfoLib library class

On 11/21/17 17:23, Laszlo Ersek wrote: > On 11/17/17 17:09, Ard Biesheuvel wrote: >> As part of the effort to get rid of ArmPlatformLib (which incorporates >> far too many duties in a single library), introduce ArmVirtMemInfoLib >> which will be invoked by our ArmVirtMemoryInitPeiLib

[edk2] [PATCH] BaseTools/tools_def AARCH64 ARM: suppres PIE sections via linker script

Recent distro builds of GCC 6 enable PIE linking by default, and allow the previous behavior to be restored by passing the -no-pie command line argument. This was implemented by commits 1894a7c64c0a and 3380a591232d but unfortunately, it turns out that GCC 5 does not support this command line

Re: [edk2] [PATCH 10/15] ArmVirtPkg: introduce ArmVirtMemInfoLib library class

On 11/17/17 17:09, Ard Biesheuvel wrote: > As part of the effort to get rid of ArmPlatformLib (which incorporates > far too many duties in a single library), introduce ArmVirtMemInfoLib > which will be invoked by our ArmVirtMemoryInitPeiLib implementation to > get a description of the virtual

Re: [edk2] [PATCH 10/15] ArmVirtPkg: introduce ArmVirtMemInfoLib library class

On 21 November 2017 at 16:27, Laszlo Ersek wrote: > On 11/21/17 17:23, Laszlo Ersek wrote: >> On 11/17/17 17:09, Ard Biesheuvel wrote: >>> As part of the effort to get rid of ArmPlatformLib (which incorporates >>> far too many duties in a single library), introduce

Re: [edk2] [PATCH 12/15] ArmVirtPkg/ArmVirtQemu: add ArmVirtMemInfoLib implementation

On 11/17/17 17:09, Ard Biesheuvel wrote: > Clone the existing ArmPlatformGetVirtualMemoryMap () for this platform, > clean it up slightly (by removing the support for uncached DRAM mappings), > and turn it into a new ArmVirtMemInfoLib implementation. I've looked at this patch with "git show

Re: [edk2] [PATCH 03/15] ArmVirtPkg/PrePi: remove unused GetPlatformPpi() function

On 11/17/17 17:09, Ard Biesheuvel wrote: > Remove GetPlatformPpi() from PrePi: it is not used anywhere. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/PrePi/PrePi.c | 24 > 1 file

Re: [edk2] [PATCH 02/15] ArmVirtPkg/PrePi: run all library constructors by hand

On 11/17/17 17:09, Ard Biesheuvel wrote: > Instead of invoking the library constructors of some libraries by > hand, invoke the generated function ProcessLibraryConstructorList > in AutoGen.c so all constructors are executed. > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2] [PATCH 04/15] ArmVirtPkg/PrePi: remove bogus primary core check

On 11/17/17 17:09, Ard Biesheuvel wrote: > QEMU and KVM based ARM/AARCH64 virtual machines only enter UEFI on > a single core, so ArmPlatformIsPrimaryCore() always returns true. > And even if it didn't, our code does absolutely nothing meaningful > based on its return value, so don't bother

Re: [edk2] [RFC] ACPI table HID/CID allocation

Thanks Ard, My intend of this email to know, what is right way to define HID and CID in ACPI firmware i.e Device(XYZ) { Name(_HID, "NXP0001") Name(_CID, "PRP0001") Device(Slave1) { Name(_CID, "PRP0001")

Re: [edk2] [RFC] ACPI table HID/CID allocation

On 21 November 2017 at 13:24, Udit Kumar wrote: > Thanks Ard, > > My intend of this email to know, what is right way to define HID and CID in > ACPI firmware i.e > > Device(XYZ) { > Name(_HID, "NXP0001") > Name(_CID, "PRP0001") >

Re: [edk2] [PATCH v7 0/2] Fix multiple entries of RT_CODE in memory map

Jian, On 11/21/17 07:17, Jian J Wang wrote: >> v7: >> Merge memory map after filtering paging attributes > > More than one entry of RT_CODE memory might cause boot problem for some > old OSs. This patch will fix this issue to keep OS compatibility as much > as possible. > > Jian J Wang (2): >

Re: [edk2] [RFC] ACPI table HID/CID allocation

On 21 November 2017 at 11:32, Udit Kumar wrote: > >> On 21 November 2017 at 09:59, Udit Kumar wrote: >> > Thanks Ard. >> > Below table was for example. I am not converting whole DT to ACPI >> > tables :) My idea is to reduce Linux patches for probing as

Re: [edk2] [PATCH 14/15] ArmVirtPkg/ArmVirtMemoryInitPeiLib: move to ArmVirtMemInfoLib

On 11/17/17 17:09, Ard Biesheuvel wrote: > Move to the new ArmVirtMemInfoLib library to retrieve DRAM information > from the platform, so that we can phase out ArmPlatformLib going forward. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel

Re: [edk2] [PATCH 15/15] ArmVirtPkg: remove ArmPlatformLib implementations

On 11/17/17 17:09, Ard Biesheuvel wrote: > These libraries are no longer used, so remove them from the tree. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/ArmVirtQemuKernel.dsc

Re: [edk2] [PATCH 13/15] ArmVirtPkg: implement ArmVirtMemInfo PPI, PEIM and library

> On 21 Nov 2017, at 17:49, Laszlo Ersek wrote: > >> On 11/17/17 17:09, Ard Biesheuvel wrote: >> Equivalent to the PrePi based platforms, this patch implements the >> newly introduced ArmVirtMemInfo library class via a separate PEIM >> and PPI. >> >> The reason is that

Re: [edk2] [RFC] ACPI table HID/CID allocation

Thanks Ard, For internal SOC devices, this is perfectly ok to drop PRP0001 from CID. > This could be a valid reason to use PRP0001 + compatible, for things like I2C > slaves that are external to the SoC For external devices (for which HID is not available), you suggest to go with PRP0001 +

Re: [edk2] [PATCH 13/15] ArmVirtPkg: implement ArmVirtMemInfo PPI, PEIM and library

On 11/17/17 17:09, Ard Biesheuvel wrote: > Equivalent to the PrePi based platforms, this patch implements the > newly introduced ArmVirtMemInfo library class via a separate PEIM > and PPI. > > The reason is that ArmVirtPlatformLib has populated the ArmPlatformLib > API function

Re: [edk2] [PATCH 13/15] ArmVirtPkg: implement ArmVirtMemInfo PPI, PEIM and library

On 21 November 2017 at 20:17, Laszlo Ersek wrote: > On 11/21/17 18:57, Ard Biesheuvel wrote: >> >> >>> On 21 Nov 2017, at 17:49, Laszlo Ersek wrote: >>> On 11/17/17 17:09, Ard Biesheuvel wrote: Equivalent to the PrePi based platforms, this patch

Re: [edk2] [PATCH 13/15] ArmVirtPkg: implement ArmVirtMemInfo PPI, PEIM and library

On 11/21/17 18:57, Ard Biesheuvel wrote: > > >> On 21 Nov 2017, at 17:49, Laszlo Ersek wrote: >> >>> On 11/17/17 17:09, Ard Biesheuvel wrote: >>> Equivalent to the PrePi based platforms, this patch implements the >>> newly introduced ArmVirtMemInfo library class via a

Re: [edk2] [patch] PcAtChipsetPkg/IsaAcpiDxe: Fix VS2012 build failure

Reviewed-by: Ruiyu Ni > -Original Message- > From: Bi, Dandan > Sent: Wednesday, November 22, 2017 10:02 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [patch] PcAtChipsetPkg/IsaAcpiDxe: Fix VS2012 build failure > > Done: > if

[edk2] [PATCH] SecurityPkg/SecureBootConfigDxe: Fix deleting signature data issue.

Replace "(UINT8 *)NewVariableData" with (UINT8 *)NewVariableData + Offset" to avoid the header of EFI_SIGNATURE_LIST being copied to the front of NewVariableData every time and update ListWalker when handling the current EFI_SIGNATURE_LIST finishes. Cc: Zhang Chao

[edk2] [patch] PcAtChipsetPkg/IsaAcpiDxe: Fix VS2012 build failure

Done: if (EFI_ERROR (Status)) { if (PciIo != NULL && Enabled) { PciIo->Attributes ( PciIo, EfiPciIoAttributeOperationSet, OriginalAttributes, NULL ); } } In above codes, VS2012/VS2010 will report that "OriginalAttributes"

[edk2] [PATCH] CryptoPkg/IntrinsicLib: Fix the warning on memset

Gcc issued the warning when compiling CryptoPkg: CryptoPkg/Library/Include/CrtLibSupport.h:135:17: warning: type of 'memset' does not match original declaration [-Wlto-type-mismatch] void *memset (void *, int, size_t); ^