Re: [edk2] How to using PcdGetEx to change a PCD.

Hi,Liming and Andrew Fish, I modified as your description,and move the pcd to [PcdEx] in inf file,but compile fail,the error is type-Mismatched,I understand now,so this pcd is not Ex-Pcd. As Andrew Fish said:"If different binaries that got compiled in different places need to work together

[edk2] [PATCH edk2-platforms] Platform/Socionext/SynQuacerEvalBoard: add ACPI support

Enable ACPI support for the SynQuacerEvalBoard platform: add descriptions of the CPUs, the GIC, the serial port, the timers and the second PCIe RC, including the MSI routing via the GICv3 ITS. Also add descriptions of the ethernet and MMC platform devices. Note that PCIe support is limited to the

Re: [edk2] [PATCH] BaseTools/tools_def XCODE5: Add -Wno-varargs

Disregard this patch if Zenith432's patch to fix this bug is accepted. On Thu, Dec 28, 2017 at 12:04 PM Alex James wrote: > Commit 47bfbd7f8069e523798ef973c8eb0abd5c6b0746 ("BaseTools/Conf: > Support LLVM39 and LLVM40 in CLANG38 toolchain") added -Wno-varargs to >

[edk2] [PATCH] BaseTools/PcdValueCommon: Fix PcdDataTypeUint64 format string

Always specify unsigned long long for PcdDataTypeUint64. This is needed to fix building with XCODE5. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Alex James --- BaseTools/Source/C/Common/PcdValueCommon.c | 4 1 file changed, 4

[edk2] [PATCH] BaseTools/tools_def XCODE5: Add -Wno-varargs

Commit 47bfbd7f8069e523798ef973c8eb0abd5c6b0746 ("BaseTools/Conf: Support LLVM39 and LLVM40 in CLANG38 toolchain") added -Wno-varargs to suppress va_start errors when building MdePkg/UefiLib. Do the same for the XCODE5 toolchain to fix building with Xcode 9 as per

[edk2] [Patch] BaseTools: Fix the bug for QuarkPlatformPkg build failure

The issue is that the string 'LPC' starts with the 'L' character and this is being confused with L" or L' for a Unicode string or Unicode character. Fixes:https://bugzilla.tianocore.org/show_bug.cgi?id=831 Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement

[edk2] [Patch] MdeModulePkg DxePrintLibPrint2Protocol: Fix GCC5 build failure

Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Eric Dong --- MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [edk2] [PATCH] MdeModulePkg/DxePrintLibPrint2Protocol: fix GCC5 build break

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian >J Wang >Sent: Friday, December 29, 2017 9:40 AM >To: edk2-devel@lists.01.org >Cc: Kinney, Michael D ; Dong, Eric

Re: [edk2] [PATCH v2 0/2] Fix error in PrintLib

Mike, Thanks for catching it. The patch has sent out. Regards, Jian > -Original Message- > From: Kinney, Michael D > Sent: Friday, December 29, 2017 9:08 AM > To: Wang, Jian J ; edk2-devel@lists.01.org; Kinney, > Michael D > Subject:

Re: [edk2] [PATCH] MdeModulePkg/DxePrintLibPrint2Protocol: fix GCC5 build break

Reviewed-by: Eric Dong -Original Message- From: Wang, Jian J Sent: Friday, December 29, 2017 9:40 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Dong, Eric ; Kinney, Michael D Subject: [PATCH]

Re: [edk2] [Patch] BaseTools: Fix a bug for different FV use same FILE statement Guid

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Yonghong Zhu >Sent: Friday, December 29, 2017 1:41 AM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] BaseTools: Fix a bug for different FV use

Re: [edk2] [PATCH] BaseTools/PcdValueCommon: Fix PcdDataTypeUint64 format string

Hi Liming, I was able to reproduce this, will send out the v2 patch shortly. Thanks, Alex On Thu, Dec 28, 2017 at 7:46 PM Gao, Liming wrote: > This fix will trig GCC build warning. > > PcdValueCommon.c: In function '__PcdSet': > PcdValueCommon.c:269:35: error: format

[edk2] [PATCH v2] BaseTools/PcdValueCommon: Fix build with XCODE5

Use the correct UINT64 format specifier when building on macOS. This is needed to fix building with XCODE5. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Alex James --- Notes: v2: - Change ifdef to fix GCC build failure [Liming]

[edk2] [PATCH] MdeModulePkg/DxePrintLibPrint2Protocol: fix GCC5 build break

Cc: Star Zeng Cc: Eric Dong Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jian J Wang --- MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c | 2 +-

Re: [edk2] [Patch] BaseTools: Fix the bug for QuarkPlatformPkg build failure

Reviewed-by: Liming Gao >-Original Message- >From: Zhu, Yonghong >Sent: Friday, December 29, 2017 8:28 AM >To: edk2-devel@lists.01.org >Cc: Gao, Liming >Subject: [Patch] BaseTools: Fix the bug for QuarkPlatformPkg build failure > >The issue is

[edk2] [RFC v4 0/6] Stack trace support in X64 exception handling

Hi, This series adds stack trace support during IA32 and X64 CPU exceptions. Informations like back trace, stack contents and image module names (that were part of the call stack) will be dumped out. The current limitation is that it relies on available frame pointers (GCC only) in order to

Re: [edk2] [PATCH] BaseTools/PcdValueCommon: Fix PcdDataTypeUint64 format string

This fix will trig GCC build warning. PcdValueCommon.c: In function '__PcdSet': PcdValueCommon.c:269:35: error: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'UINT64 {aka long unsigned int}' [-Werror=format=] sprintf(PcdList[Index].Value,

Re: [edk2] [PATCH v2 0/2] Fix error in PrintLib

Jian, This change breaks GCC5 builds. /home/mdkinney/tianocore/edk2/MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c: In function 'InternalPrintLibSPrintMarker': /home/mdkinney/tianocore/edk2/MdeModulePkg/Library/DxePrintLibPrint2Protocol/PrintLib.c:2054:71: error: suggest parentheses

[edk2] [RFC v4 5/6] UefiCpuPkg/CpuExceptionHandlerLib: Ensure valid frame/stack pointers

Validate all possible memory dereferences during stack traces in IA32 and X64 CPU exceptions. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Eric Dong Cc: Laszlo Ersek Requested-by: Brian Johnson Requested-by: Jiewen

[edk2] [RFC v4 2/6] UefiCpuPkg/CpuExceptionHandlerLib: Export GetPdbFileName()

This function will be used by both IA32 and X64 exception handling in order to print out image module names during stack unwinding. Cc: Eric Dong Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Paulo Alcantara

[edk2] [RFC v4 4/6] UefiCpuPkg/CpuExceptionHandlerLib: Add helper to valid memory addresses

Introduce IsLinearAddressValid() function that will be used for validating memory addresses that would get dereferenced during stack traces in IA32 and X64 CPU exceptions. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Eric Dong Cc: Laszlo Ersek

[edk2] [RFC v4 6/6] UefiCpuPkg/CpuExceptionHandlerLib: Correctly print IP addresses

Remove the supurious '- 1' when calculating the IP addresses during the stack traces. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Eric Dong Cc: Laszlo Ersek Requested-by: Jeff Fan Signed-off-by: Paulo Alcantara

[edk2] [RFC v4 1/6] UefiCpuPkg/CpuExceptionHandlerLib/X64: Add stack trace support

This patch adds stack trace support during a X64 CPU exception. It will dump out back trace, stack contents as well as image module names that were part of the call stack. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Eric Dong Cc: Laszlo Ersek

[edk2] [RFC v4 3/6] UefiCpuPkg/CpuExceptionHandlerLib/Ia32: Add stack trace support

This patch adds stack trace support during a IA32 CPU exception. It will dump out back trace, stack contents as well as image module names that were part of the call stack. Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Eric Dong Cc: Laszlo Ersek