Re: [edk2] [Patch 5/5] UefiCpuPkg: Remove X86 ASM and S files

2018-05-15 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, Liming Sent: Monday, May 14, 2018 9:03 PM To: Laszlo Ersek Cc: edk2-devel@lists.01.org Subject: Re: [edk2] [Patch 5/5]

Re: [edk2] [Patch 0/2] Add referenced spec information.

2018-05-15 Thread Wu, Hao A
The series seems good to me. Reviewed-by: Hao Wu Best Regards, Hao Wu > -Original Message- > From: Dong, Eric > Sent: Tuesday, May 08, 2018 10:33 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Yao, Jiewen > Subject: [Patch 0/2] Add referenced spec information. >

Re: [edk2] Proposition of a BmEnumerateBootOptions() hook.

2018-05-15 Thread Laszlo Ersek
On 05/15/18 15:02, Marvin Häuser wrote: >> -Original Message- >> From: Laszlo Ersek >> Sent: Tuesday, May 15, 2018 10:22 AM >> To: Marvin Häuser ; edk2- >> de...@lists.01.org >> Cc: eric.d...@intel.com; star.z...@intel.com >> Subject: Re:

Re: [edk2] [PATCH] Enable using device address when programming BARs

2018-05-15 Thread Roman Bacik
Hi Laszlo, Ard, After seeing the commits you have pointed out your comments are starting to be more clear. We will try to follow your suggestions and will let you know if it works for us. Thank you very much for your explanation, Roman > -Original Message- > From: Laszlo Ersek

[edk2] [PATCH 3/4] ovmf: replace SecurityPkg with OvfmPkg Tcg2PhysicalPresenceLibQemu

2018-05-15 Thread marcandre . lureau
From: Marc-André Lureau Cloned "SecurityPkg/Library/DxeTcg2PhysicalPresenceLib" and: - removed all the functions that are unreachable from Tcg2PhysicalPresenceLibProcessRequest() - replaced everything that's related to the TCG2_PHYSICAL_PRESENCE*_VARIABLE

[edk2] [PATCH 2/4] ovmf: add QemuTpm.h header

2018-05-15 Thread marcandre . lureau
From: Marc-André Lureau Add some common macros and type definitions corresponding to the QEMU TPM interface. Signed-off-by: Marc-André Lureau --- OvmfPkg/Include/IndustryStandard/QemuTpm.h | 67 ++ 1 file changed,

[edk2] [PATCH 1/4] ovmf: add and link with Tcg2PhysicalPresenceLibNull when !TPM2_ENABLE

2018-05-15 Thread marcandre . lureau
From: Marc-André Lureau This NULL library will let us call Tcg2PhysicalPresenceLibProcessRequest() unconditionally from BdsPlatform when building without TPM2_ENABLE. Signed-off-by: Marc-André Lureau ---

[edk2] [PATCH 0/4] RFC: ovmf: Add support for TPM Physical Presence interface

2018-05-15 Thread marcandre . lureau
From: Marc-André Lureau Hi, The following series adds basic TPM PPI 1.3 support for OVMF-on-QEMU with TPM2 (I haven't tested TPM1, for lack of interest). PPI test runs successfully with Windows 10 WHLK, despite the limited number of supported funcions

[edk2] [PATCH 4/4] ovmf: process TPM PPI request in AfterConsole()

2018-05-15 Thread marcandre . lureau
From: Marc-André Lureau Call Tcg2PhysicalPresenceLibProcessRequest() to process pending PPI requests from PlatformBootManagerAfterConsole(). Laszlo understanding of edk2 is that the PPI operation processing was meant to occur *entirely* before End-Of-Dxe, so that

Re: [edk2] Proposition of a BmEnumerateBootOptions() hook.

2018-05-15 Thread Marvin Häuser
Hi Laszlo, thanks for your feedback! Comments are inline. I also CC'd Jordan and Ard because of OVMF references in the third comment. Thanks in advance for your time! I have rewritten a few parts multiple times, so, if something doesn't make sense (because I forgot to rework it in the context),

Re: [edk2] Proposition of a BmEnumerateBootOptions() hook.

2018-05-15 Thread Laszlo Ersek
On 05/15/18 17:38, Marvin Häuser wrote: >> -Original Message- >> From: Laszlo Ersek >> Sent: Tuesday, May 15, 2018 3:53 PM >> To: Marvin Häuser ; edk2- >> de...@lists.01.org >> Cc: eric.d...@intel.com; star.z...@intel.com;

[edk2] [PATCH edk2-platforms 2/5] Silicon/AMD/Styx: remove MpBootDxe driver

2018-05-15 Thread Ard Biesheuvel
MpBootDxe implements support for the ACPI Parking Protocol and the DT based spintable protocol to bring up secondaries, neither of which are recommended on systems implementing EL3, are not enabled in the default build configuration of the platforms that include it and is therefore essentially

[edk2] [PATCH edk2-platforms 4/5] Silicon/AMD/Styx: make ISCP dependency unconditional

2018-05-15 Thread Ard Biesheuvel
The Styx code can be built without relying on the ISCP, but doing so is rather pointless, and is essentially dead code because nobody ever does that. Let's just remove this feature. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel

[edk2] [PATCH edk2-platforms 3/5] Silicon/AMD/Styx: remove support for the ACPI parking protocol

2018-05-15 Thread Ard Biesheuvel
The ACPI parking protocol is a kludge to allow SOC implementations that lack EL3 support to bring up secondaries in a standardized manner. Since our UEFI implementation unconditionally relies on ARM Trusted Firmware and PSCI now, there is no point in supporting the parking protocol any longer so

[edk2] [PATCH edk2-platforms 5/5] Platform/AMD/Overdrive: enable support for NVME PCIe devices

2018-05-15 Thread Ard Biesheuvel
Upon request, add the generic NvmExpress driver to the Overdrive build so plugin NVME SSDs can be supported at boot. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 +

[edk2] [PATCH edk2-platforms 0/5] Seattle spring cleaning

2018-05-15 Thread Ard Biesheuvel
Some cleanup patches for Seattle, removing the unused code that deals with configurations where the SCP, ARM-TF or PSCI support are absent, which is rather pointless for a platform that is no longer under development. Ard Biesheuvel (5): Silicon/AMD/Styx: make ARM-TF and PSCI dependencies

Re: [edk2] Proposition of a BmEnumerateBootOptions() hook.

2018-05-15 Thread Marvin Häuser
Thanks for your feedback! Comments inline Regards, Marvin. > -Original Message- > From: Laszlo Ersek > Sent: Tuesday, May 15, 2018 6:12 PM > To: Marvin Häuser ; edk2- > de...@lists.01.org > Cc: gso...@gmail.com; ard.biesheu...@linaro.org;

[edk2] [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition.

2018-05-15 Thread Marvin Häuser
This patch adds the HPET Event Timer Block ID definition that can be found in the IA-PC HPET Specification, section 3.2.4. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marvin Haeuser ---

Re: [edk2] Proposition of a BmEnumerateBootOptions() hook.

2018-05-15 Thread Laszlo Ersek
On 05/15/18 19:14, Marvin Häuser wrote: >> -Original Message- >> From: Laszlo Ersek >> Sent: Tuesday, May 15, 2018 6:12 PM >> To: Marvin Häuser ; edk2- >> de...@lists.01.org >> Cc: gso...@gmail.com; ard.biesheu...@linaro.org;

Re: [edk2] Proposition of a BmEnumerateBootOptions() hook.

2018-05-15 Thread Marvin Häuser
> -Original Message- > From: Laszlo Ersek > Sent: Tuesday, May 15, 2018 3:53 PM > To: Marvin Häuser ; edk2- > de...@lists.01.org > Cc: eric.d...@intel.com; star.z...@intel.com; jordan.l.jus...@intel.com; > ard.biesheu...@linaro.org;

[edk2] [PATCH edk2-platforms 1/5] Silicon/AMD/Styx: make ARM-TF and PSCI dependencies unconditional

2018-05-15 Thread Ard Biesheuvel
The Styx platform theoretically supports running in an environment where no ARM Trusted Firmware is running in EL3 and PSCI is not implemented. This is not a configuration that we aim to support, and so let's remove the code that implements this, especially because it is essentially dead code and

[edk2] Extracting vendor blobs from edk2-coreboot payload

2018-05-15 Thread Anatol Pomozov
Hello I am trying to modify/rebuild a Coreboot+EDK2 rom for my hardware. To do that I need Intel vendor blobs that I cannot find in web unfortunately. Intel seems does not share the blobs publicly. Here is the build script used to build my UEFI payload

Re: [edk2] Proposition of a BmEnumerateBootOptions() hook.

2018-05-15 Thread Laszlo Ersek
On 05/14/18 21:00, Marvin H?user wrote: > Hey Star, Eric and everyone else, > > I have seen that some platforms add a Boot Option for the UEFI Shell > in "PlatformBootManagerBeforeConsole()", which is called as part of > the regular boot flow. This is surely beneficial for development > platforms

[edk2] [Patch] MdeModulePkg PeiCore: FvCount to be checked for the registered for shadow PEIM

2018-05-15 Thread Liming Gao
The PEIM in all cached FV image may be in registered for shadow status. Current logic CurrentPeimFvCount is not enough. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Liming Gao Cc: Star Zeng ---

Re: [edk2] [Patch] MdeModulePkg PeiCore: FvCount to be checked for the registered for shadow PEIM

2018-05-15 Thread Zeng, Star
Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Gao, Liming Sent: Wednesday, May 16, 2018 9:35 AM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [Patch] MdeModulePkg PeiCore: FvCount to be checked for the registered for

Re: [edk2] [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition.

2018-05-15 Thread Carsey, Jaben
I have no clue on OSS laws/rules, I was just confused. I think that you do no need to update any copyright (except your own). The code change looks good and that is about all I can really say. :) -Jaben > -Original Message- > From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] >