> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Tuesday, April 17, 2018 6:27 AM
> To: Kinney, Michael D ;
> Gao, Liming ; Laszlo Ersek
>
> Cc: edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] MdePkg: add big-endian MMIO
> BaseBeIoLib
&
On Mon, Apr 16, 2018 at 10:42:26PM +0200, Laszlo Ersek wrote:
> On 04/16/18 16:34, Michael Brown wrote:
> > On 16/04/18 15:10, Kinney, Michael D wrote:
> >> I agree that the opposite use case is a BE CPU
> >> needing a LE operation.
> >>
> >> I think we only need a single lib class and lib
> >> Ins
Hi Laszlo
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, April 17, 2018 3:12 PM
> To: Udit Kumar ; Leif Lindholm
>
> Cc: Kinney, Michael D ; edk2-devel@lists.01.org;
> Gao, Liming
> Subject: Re: [edk2] [PATCH] Mde
On 04/17/18 10:24, Michael Brown wrote:
> On 17/04/18 09:01, Laszlo Ersek wrote:
>> The thing is, the BeIoLib and LeIoLib classes are already good for this
>> -- they can be implemented as you suggest. So no need to call the
>> function SwapIfNeededForBigEndianDeviceMmioRead16(), just call it
>> Be
On 04/17/18 10:15, Udit Kumar wrote:
> Hi Laszlo,
>
> Considering all possible option is best to have in code 😊
> But IMO, We are running UEFI on LE CPU only, Not sure someone is running on
> BE. AFAIK even specs says LE.
>
>> (c) assuming we introduce a CPU with BE byte order, the same drive
On 17/04/18 09:01, Laszlo Ersek wrote:
The thing is, the BeIoLib and LeIoLib classes are already good for this
-- they can be implemented as you suggest. So no need to call the
function SwapIfNeededForBigEndianDeviceMmioRead16(), just call it
BeMmioRead16().
I know. I thought that suggesting a
y, April 17, 2018 1:03 AM
> To: Leif Lindholm
> Cc: Kinney, Michael D ; edk2-devel@lists.01.org;
> Gao, Liming
> Subject: Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib
>
> On 04/16/18 12:07, Leif Lindholm wrote:
> > On Fri, Apr 13, 2018 at 11:32:35PM +, Kinn
On 04/17/18 00:14, Michael Brown wrote:
> On 16/04/18 21:42, Laszlo Ersek wrote:
>> On 04/16/18 16:34, Michael Brown wrote:
>>> On 16/04/18 15:10, Kinney, Michael D wrote:
I think we only need a single lib class and lib
Instance that does the byte swap and we should
not use Le or Be
chael D
> Sent: Monday, April 16, 2018 7:41 PM
> To: Leif Lindholm ; Kinney, Michael D
>
> Cc: edk2-devel@lists.01.org; Laszlo Ersek ; Gao, Liming
>
> Subject: Re: [edk2] [PATCH] MdePkg: add big-endian MMIO BaseBeIoLib
>
> Leif,
>
> I agree that the opposite use case
On 16/04/18 21:42, Laszlo Ersek wrote:
On 04/16/18 16:34, Michael Brown wrote:
On 16/04/18 15:10, Kinney, Michael D wrote:
I think we only need a single lib class and lib
Instance that does the byte swap and we should
not use Le or Be in any of the names of the class,
instance, or APIs. Just "
On 04/16/18 16:34, Michael Brown wrote:
> On 16/04/18 15:10, Kinney, Michael D wrote:
>> I agree that the opposite use case is a BE CPU
>> needing a LE operation.
>>
>> I think we only need a single lib class and lib
>> Instance that does the byte swap and we should
>> not use Le or Be in any of th
On 04/16/18 12:07, Leif Lindholm wrote:
> On Fri, Apr 13, 2018 at 11:32:35PM +, Kinney, Michael D wrote:
>> Leif,
>>
>> I am curious why a Swap class/instances is not sufficient.
>>
>> Currently EDK II follows the UEFI/PI specs, which for all supported
>> CPU architectures use little endian ABI
On 16/04/18 15:10, Kinney, Michael D wrote:
I agree that the opposite use case is a BE CPU
needing a LE operation.
I think we only need a single lib class and lib
Instance that does the byte swap and we should
not use Le or Be in any of the names of the class,
instance, or APIs. Just "Swap".
; Cc: edk2-devel@lists.01.org; Laszlo Ersek
> ; Gao, Liming
> Subject: Re: [edk2] [PATCH] MdePkg: add big-endian MMIO
> BaseBeIoLib
>
> On Fri, Apr 13, 2018 at 11:32:35PM +, Kinney,
> Michael D wrote:
> > Leif,
> >
> > I am curious why a Swap class/instances i
; > To: Kinney, Michael D
> > Cc: edk2-devel@lists.01.org; Laszlo Ersek
> > ; Gao, Liming
> > Subject: Re: [edk2] [PATCH] MdePkg: add big-endian MMIO
> > BaseBeIoLib
> >
> > On Fri, Apr 13, 2018 at 07:24:06PM +, Kinney,
> > Michael D wrote:
> &
Thanks Leif
This is really useful, We will re-spin our patches based on this
Regards
Udit
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Friday, April 13, 2018 11:12 PM
> To: edk2-devel@lists.01.org
> Cc: Michael D Kinney ; Liming Gao
> ; Laszlo Erse
dk2-devel@lists.01.org; Laszlo Ersek
> ; Gao, Liming
> Subject: Re: [edk2] [PATCH] MdePkg: add big-endian MMIO
> BaseBeIoLib
>
> On Fri, Apr 13, 2018 at 07:24:06PM +, Kinney,
> Michael D wrote:
> > Hi Leif,
> >
> > I think we need to look at the names. I
On Fri, Apr 13, 2018 at 07:24:06PM +, Kinney, Michael D wrote:
> Hi Leif,
>
> I think we need to look at the names. I see a mix of
> "Be" and "Swap". We should pick one and use it
> consistently.
This was what I meant by the comments:
---
This modified version introduces a single BeIoLib i
Hi Leif,
I think we need to look at the names. I see a mix of
"Be" and "Swap". We should pick one and use it
consistently.
Mike
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Friday, April 13, 2018 10:42 AM
> To: edk2-devel@lists.01.org
> Cc: Kinn
When performing MMIO to a destination of the opposite endianness to the
executing processor, this library provides automatic byte order reversal
on inputs and outputs.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm
---
Udit, many apologies for this dragging
20 matches
Mail list logo