; Cc: Kinney, Michael D ; Laszlo Ersek
>
> Subject: Re: [edk2] [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if
> reloc info is invalid
>
> Reviewed-by: Liming Gao
>
> > -Original Message-
> > From: Bi, Dandan
> > Sent: Thursday, January 31,
Reviewed-by: Liming Gao
> -Original Message-
> From: Bi, Dandan
> Sent: Thursday, January 31, 2019 8:27 AM
> To: Hsueh, Hong-chihX ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
> ; Laszlo Ersek
> Subject: RE: [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if
Reviewed-by: Bi Dandan
Thanks,
Dandan
> -Original Message-
> From: Hsueh, Hong-chihX
> Sent: Wednesday, January 30, 2019 9:20 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
> ; Bi, Dandan ; Laszlo Ersek
>
> Subject: [PATCH] MdePkg/BasePeCoffLib: skip runtime
Hi,
I think this is maybe the 3rd or 4th iteration of the patch. That's OK,
but if you don't add v2, v3, v4 identifies to the subject prefix, such
as [PATCH v2], [PATCH v3] etc, then it's too difficult to follow what
one should review vs. what is obsolete.
Anyway, I think this version is good:
On 01/29/19 19:50, Neo Hsueh wrote:
> Skip runtime relocation for PE images that provide invalid relocation
> infomation (ex: RelocDir->Size = 0) to fix a hang observed while booting
> Windows.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Neo Hsueh
> Cc: Michael D
5 matches
Mail list logo
