Re: [edk2] [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.

2019-01-21 Thread Philippe Mathieu-Daudé
On 1/21/19 10:21 PM, Laszlo Ersek wrote: > Hi Phil, > > On 01/21/19 14:26, Philippe Mathieu-Daudé wrote: >> Hi, >> >> On 1/21/19 1:53 PM, Gao, Liming wrote: >>> Thanks Ard and Laszlo. For the minor change in single patch, the patch may >>> be sent separately with the clear subject. Or, the patch

Re: [edk2] [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.

2019-01-21 Thread Laszlo Ersek
Hi Phil, On 01/21/19 14:26, Philippe Mathieu-Daudé wrote: > Hi, > > On 1/21/19 1:53 PM, Gao, Liming wrote: >> Thanks Ard and Laszlo. For the minor change in single patch, the patch may >> be sent separately with the clear subject. Or, the patch set can be sent >> again. > > Since it is hard

Re: [edk2] [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.

2019-01-21 Thread Philippe Mathieu-Daudé
Hi, On 1/21/19 1:53 PM, Gao, Liming wrote: > Thanks Ard and Laszlo. For the minor change in single patch, the patch may be > sent separately with the clear subject. Or, the patch set can be sent again. Since it is hard to follow technical discussion when top-posted (see

Re: [edk2] [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.

2019-01-21 Thread Gao, Liming
Thanks Ard and Laszlo. For the minor change in single patch, the patch may be sent separately with the clear subject. Or, the patch set can be sent again. Thanks Liming > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Saturday, January 19, 2019 9:17 AM > To:

Re: [edk2] [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.

2019-01-20 Thread Wu, Jiaxin
> >> This is my idea to avoid the duplicated mail. I also include Ard and > >> Laszlo to > collect the feedback on how to handle the partial update in the patchset. > >> > > > > Laszlo may disagree with me, but I think that it is not always > > necessary to resend the entire series when only a

Re: [edk2] [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.

2019-01-18 Thread Laszlo Ersek
On 01/18/19 12:09, Ard Biesheuvel wrote: > On Fri, 18 Jan 2019 at 06:38, Gao, Liming wrote: >> >> This is my idea to avoid the duplicated mail. I also include Ard and Laszlo >> to collect the feedback on how to handle the partial update in the patchset. >> > > Laszlo may disagree with me, but I

Re: [edk2] [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.

2019-01-18 Thread Ard Biesheuvel
On Fri, 18 Jan 2019 at 06:38, Gao, Liming wrote: > > This is my idea to avoid the duplicated mail. I also include Ard and Laszlo > to collect the feedback on how to handle the partial update in the patchset. > Laszlo may disagree with me, but I think that it is not always necessary to resend

Re: [edk2] [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.

2019-01-17 Thread Gao, Liming
This is my idea to avoid the duplicated mail. I also include Ard and Laszlo to collect the feedback on how to handle the partial update in the patchset. Thanks Liming > -Original Message- > From: Wu, Jiaxin > Sent: Friday, January 18, 2019 1:32 PM > To: Fu, Siyuan ; Wu, Hao A ; >

Re: [edk2] [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.

2019-01-17 Thread Wu, Jiaxin
Just confirmed with Liming, we don't need to seed the full series patches if only one is updated. Thanks, jiaxin > -Original Message- > From: Fu, Siyuan > Sent: Friday, January 18, 2019 1:29 PM > To: Wu, Hao A ; Wu, Jiaxin ; > edk2-devel@lists.01.org > Cc: Ye, Ting ; Gao, Liming >

Re: [edk2] [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.

2019-01-17 Thread Fu, Siyuan
Hi, Jiaxin Yes the full patch series is needed for a v2 version. And also, why you removed the "(Instance->Token != NULL)" check in the if condition? BestRegards Fu Siyuan > -Original Message- > From: Wu, Hao A > Sent: Friday, January 18, 2019 1:22 PM > To: Wu, Jiaxin ;

Re: [edk2] [PATCH v2 1/3] MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.

2019-01-17 Thread Wu, Hao A
Hi Jiaxin, A comment that is not related with the content of the patch itself: Please help to send the full patch series when a new version is needed. Best Regards, Hao Wu > -Original Message- > From: Wu, Jiaxin > Sent: Friday, January 18, 2019 1:16 PM > To: edk2-devel@lists.01.org >