Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-26 Thread Laszlo Ersek
On 08/24/15 08:15, Ni, Ruiyu wrote: Jordan, The mail is too long so let me summarize in below: (I changed all API name to remove Lib) 1. Have four or six BLT APIs? four: BltVideoFill BltVideoToVideo BltVideoToBuffer BltBufferToVideo six: BltVideoFill BltVideoToVideo BltVideoToBuffer

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-23 Thread Jordan Justen
On 2015-08-23 20:09:23, Ni, Ruiyu wrote: Jordan, reply embedded in the mail. Mike, Jordan proposed to add a new parameter Configuration in BltConfigure, instead of removing this API, to eliminate the global variables in library implementation. I think it's also a good solution and can

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-17 Thread Ni, Ruiyu
Jordan, Sorry I missed your previous questions. Let me try to answer all your questions in this email. Q1: Why merging Ex and non-Ex APIs? Providing Non-Ex APIs was to make simpler functions available for blt operations. Merging the Ex and non-EX APIs is to avoid the library APIs provide

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-17 Thread Jordan Justen
On 2015-08-17 06:45:27, Ruiyu Ni wrote: The BltConfigure() API caches the video frame buffer meta data which forbids the library to be implemented to support re-entry. How does this help? GraphicsOutputDxe will set a mode, and then use BltLib with that mode. I already asked this, and I had