Re: [edk2] [RFC] MdePkg/BaseLib: Change BitField functions.

2018-02-25 Thread Pankaj Bansal
-devel@lists.01.org > Cc: Kinney, Michael D > Subject: Re: [edk2] [RFC] MdePkg/BaseLib: Change BitField functions. > > On 02/23/18 12:16, Pankaj Bansal wrote: > > Hi Liming Gao, > > > > Thanks for your comments. > > I am not able to understand the full purpose of

Re: [edk2] [RFC] MdePkg/BaseLib: Change BitField functions.

2018-02-23 Thread Laszlo Ersek
On 02/23/18 12:16, Pankaj Bansal wrote: > Hi Liming Gao, > > Thanks for your comments. > I am not able to understand the full purpose of the BitField functions. > Can you please help me to understand. > > As per my understanding : > BitFieldAnd32 (Operand, StartBit, EndBit, AndData) : > > We wan

Re: [edk2] [RFC] MdePkg/BaseLib: Change BitField functions.

2018-02-23 Thread Pankaj Bansal
Hi Liming Gao, Thanks for your comments. I am not able to understand the full purpose of the BitField functions. Can you please help me to understand. As per my understanding : BitFieldAnd32 (Operand, StartBit, EndBit, AndData) : We want to calculate the bitwise and (&) between Operand's bits (S

Re: [edk2] [RFC] MdePkg/BaseLib: Change BitField functions.

2018-02-23 Thread Gao, Liming
Pankaj: OrData, AndData and Value are the bit field value specified by StartBit and EndBit. They are not the full value. They must be adjusted to the full value, then calculated with Operand. And, we use LShit() or RShit() function for 64bit operand, because we find VS compiler may generate

Re: [edk2] [RFC] MdePkg/BaseLib: Change BitField functions.

2018-02-19 Thread Pankaj Bansal
Hi everybody, Any comments on this change ? > -Original Message- > From: Pankaj Bansal > Sent: Friday, February 09, 2018 4:30 PM > To: edk2-devel@lists.01.org > Cc: Pankaj Bansal ; Michael D Kinney > ; Liming Gao > Subject: [RFC] MdePkg/BaseLib: Change BitField functions. > > The bit fi