Re: [PATCH] Add version hint to gnu-efi dependency

2019-04-02 Thread Andreas Reichel
On Tue, Apr 02, 2019 at 02:45:01PM +0200, Jan Kiszka wrote: > On 02.04.19 14:30, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel > > > > Definition of EFI_SIMPLE_TEXT_OUT_PROTOCOL is not before > > version 3.0.5. > > > > Signed-off-by: Andreas

Re: Building Error on efibootguard

2019-04-01 Thread Andreas Reichel
gt; To view this discussion on the web visit > https://groups.google.com/d/msgid/efibootguard-dev/20190401115214.rbz537w4ahdfskkm%40MD1ZFJVC.ad001.siemens.net. > For more options, visit https://groups.google.com/d/optout. -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant andreas.reic...@tngt

Re: [PATCH] fix: do not leak file descriptor while reading /proc/mounts

2019-03-25 Thread Andreas Reichel
39,6 +39,7 @@ char *get_mountpoint(char *devpath) > if (!mntpoint) { > break; > } > + endmntent(mtab); > return mntpoint; > } > } Ow.. thanks. Acked-by:

Re: Detecting corrupted-failed update

2018-11-21 Thread Andreas Reichel
to the root of problems. A machine either works or it does not. If it is in between, something is wrong. And there are indeed a lot of machines/systems around, that are in between and software is hacked around to cope with this :) Well - as you wish of course, but I had to point that out first. Andreas >

Re: Detecting corrupted-failed update

2018-11-20 Thread Andreas Reichel
email > to efibootguard-dev+unsubscr...@googlegroups.com. > To post to this group, send email to efibootguard-dev@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/ > efibootguard-dev/ > BN6PR1101MB23565CA2C4F289FC0778D387B2D80%40BN6PR1101MB2356.na

Re: [meta-efibootguard][PATCH] Declare compatibility with thud

2018-10-31 Thread Andreas Reichel
ribe from this group and stop receiving emails from it, send an > email to efibootguard-dev+unsubscr...@googlegroups.com. > To post to this group, send email to efibootguard-dev@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/efibootguard-dev

Re: [PATCH v3 2/5] Add function to get boot device and compare it to others

2018-09-05 Thread Andreas Reichel
On Wed, Sep 05, 2018 at 02:18:34PM +0200, Jan Kiszka wrote: > On 2018-09-05 13:12, Andreas Reichel wrote: > > On Tue, Sep 04, 2018 at 05:44:07PM +0200, Jan Kiszka wrote: > > > On 2018-09-03 16:09, [ext] Andreas J. Reichel wrote: > > > > From: Andreas Reichel > &

Re: [PATCH v3 1/5] Add function to remove last node from device path

2018-09-05 Thread Andreas Reichel
On Wed, Sep 05, 2018 at 01:15:50PM +0200, Jan Kiszka wrote: > On 2018-09-05 13:04, Andreas Reichel wrote: > > On Tue, Sep 04, 2018 at 05:44:01PM +0200, Jan Kiszka wrote: > > > On 2018-09-03 16:09, [ext] Andreas J. Reichel wrote: > > > > From: Andreas Reichel >

Re: [PATCH v3 3/5] Print information if environment is on boot dev

2018-09-05 Thread Andreas Reichel
On Tue, Sep 04, 2018 at 05:49:22PM +0200, Jan Kiszka wrote: > On 2018-09-03 16:09, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel > > > > During environment enumeration, notify if it is on the boot device > > > > Signed-off-by: Andreas Reichel >

Re: [PATCH v3 4/5] Implement recovery mode as config filter

2018-09-05 Thread Andreas Reichel
On Tue, Sep 04, 2018 at 06:06:44PM +0200, Jan Kiszka wrote: > On 2018-09-03 16:09, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel > > > > + > > + filtered_volumes = mmalloc(sizeof(UINTN) * *numHandles); > > Missing NULL check. That will actuall

Re: [PATCH v3 2/5] Add function to get boot device and compare it to others

2018-09-05 Thread Andreas Reichel
On Tue, Sep 04, 2018 at 05:44:07PM +0200, Jan Kiszka wrote: > On 2018-09-03 16:09, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel > > > > Get the boot device out of the loaded image's handle and add a > > function to compare a device path

Re: [PATCH v3 1/5] Add function to remove last node from device path

2018-09-05 Thread Andreas Reichel
On Tue, Sep 04, 2018 at 05:44:01PM +0200, Jan Kiszka wrote: > On 2018-09-03 16:09, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel > > > > To compare device paths it is necessary to be able to split off > > sub-paths from the right hand side.

Re: [meta-efibootguard][PATCH] Rename base package to efibootguard

2018-08-30 Thread Andreas Reichel
ed to the Google Groups > "EFI Boot Guard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to efibootguard-dev+unsubscr...@googlegroups.com. > To post to this group, send email to efibootguard-dev@googlegroups.com. >

Re: [PATCH 02/16] Add StrRStrip function for device path manipulation

2018-05-28 Thread Andreas Reichel
On Mon, May 28, 2018 at 01:21:15PM +0200, Claudius Heine wrote: > Hi, > > On 2018-05-25 14:00, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > To compare device paths it is necessary to be able to split of >

Re: [PATCH 10/16] Simplify config partition management

2018-05-28 Thread Andreas Reichel
On Mon, May 28, 2018 at 03:46:03PM +0200, Claudius Heine wrote: > > > On 2018-05-25 14:01, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > * volumes[] already contains all needed data, so instead of > &

Re: [RFC] efibootguard faile-safe mode

2018-05-23 Thread Andreas Reichel
Just as info - working on it. -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant andreas.reic...@tngtech.com, +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller Sitz: Unterfoehring

Re: [meta-efibootguard][PATCH] package all debug symbol files in tools-dbg

2018-05-07 Thread Andreas Reichel
Thanks! > Jan > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux > > -- > You received this message because you are subscribed to the Google Groups > "EFI Boot Guard" group. > To unsubscribe from th

Re: [PATCH v2] Make efibootguard compatible to gcc 8.1

2018-05-07 Thread Andreas Reichel
On Mon, May 07, 2018 at 02:01:55PM +0200, Andreas J. Reichel wrote: Sorry, copied wrong message-id to git send-email. > From: Andreas Reichel <andreas.reichel@siemens.com> > > GCC 8.1 has some additional `intelligent` tests, that do not allow the > length parameter in `st

Re: [PATCH v3 0/3] Bugfix and garbage collector add-on

2018-05-02 Thread Andreas Reichel
On Wed, May 02, 2018 at 01:40:08PM +0200, Andreas J. Reichel wrote: > From: Andreas Reichel <andreas.reichel@siemens.com> > > This patch series fixes a bug regarding user variables. > > Furthermore it introduces a garbage collector to > ebg_env_finalize_update, so th

Re: [PATCH v2 2/3] Add registry for garbage collection on update finalization

2018-05-02 Thread Andreas Reichel
On Wed, May 02, 2018 at 01:27:27PM +0200, Jan Kiszka wrote: > On 2018-04-27 14:44, Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > Provide possibility to register user variables that are deleted > > on finalization

[RFC] efibootguard faile-safe mode

2018-03-22 Thread Andreas Reichel
be sought on the efibootguard partition. Opinions? Cheers, Andreas -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant andreas.reic...@tngtech.com, +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard

Re: [PATCH 2/3] Add registry for garbage collection on update finalization

2018-03-19 Thread Andreas Reichel
har *buffer, wchar_t *src); > > > > Jan -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant andreas.reic...@tngtech.com, +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller Sitz: Unter

Re: [PATCH 1/3] Bugfix: Don't map non-existing user variables

2018-03-19 Thread Andreas Reichel
On Mon, Mar 19, 2018 at 06:38:43PM +0800, Jan Kiszka wrote: > On 2018-03-13 01:10, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > If a non-existing user variable is requested and a NULL-buffer is > > provided,

Re: [PATCH 2/3] Add registry for garbage collection on update finalization

2018-03-19 Thread Andreas Reichel
On Mon, Mar 19, 2018 at 06:44:29PM +0800, Jan Kiszka wrote: > On 2018-03-13 01:10, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > Provide possibility to register user variables that are deleted > > on finalizat

Re: [PATCH] env_api: Delete recovery_status user variable for SWUpdate

2018-03-05 Thread Andreas Reichel
On Mon, Mar 05, 2018 at 06:19:22PM +0100, Jan Kiszka wrote: > On 2018-03-05 17:24, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > If 'recovery_status' is set to 'in_progress' by the bootloader interface > &g

Re: bg_setenv without parameters

2018-03-05 Thread Andreas Reichel
On Mon, Mar 05, 2018 at 01:43:01PM +0100, [ext] Jan Kiszka wrote: > On 2018-03-05 13:24, Andreas Reichel wrote: > > On Mon, Mar 05, 2018 at 01:01:14PM +0100, Jan Kiszka wrote: > >> Hi Andreas, > >> > >> what is bg_setenv without any parameters supposed t

Re: bg_setenv without parameters

2018-03-05 Thread Andreas Reichel
fore it would be strange if the help page was printed as if the user missed something, since optional arguments are not required per definition. Andreas > Jan > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux -- Andreas

Re: [PATCH 0/6] Update the meta-efibootguard layer for latest Yocto layers

2018-02-26 Thread Andreas Reichel
Jan Kiszka [mailto:jan.kis...@siemens.com] > Sent: Wednesday, February 21, 2018 10:43 PM > To: Abbas, Farhat <farhat_ab...@mentor.com>; > efibootguard-dev@googlegroups.com; Andreas Reichel > <andreas.reic...@tngtech.com> > Subject: Re: [PATCH 0/6] Update the meta-efibootgua

Re: Boot path querying

2018-02-26 Thread Andreas Reichel
ail to efibootguard-dev@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/efibootguard-dev/17592bad-af66-b7c7-062b-f64723457010%40siemens.com. > For more options, visit https://groups.google.com/d/optout. -- Andreas Reichel Dipl.-Phys. (Univ.) S

Re: [PATCH 0/6] *** SUBJECT HERE ***

2018-02-21 Thread Andreas Reichel
, send an > email to efibootguard-dev+unsubscr...@googlegroups.com. > To post to this group, send email to efibootguard-dev@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/efibootguard-dev/1519211476-6350-1-git-send-email-Farhat_Abbas%40ment

Re: [PATCH] Updated README file, tested with updated OE layers

2018-02-21 Thread Andreas Reichel
> email to efibootguard-dev+unsubscr...@googlegroups.com. > To post to this group, send email to efibootguard-dev@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/efibootguard-dev/1519181625-7422-1-git-send-email-Farhat_Abbas%40mentor

Re: [feature request] Add "quiet" option

2018-02-05 Thread Andreas Reichel
ooglegroups.com. > To post to this group, send email to efibootguard-dev@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/efibootguard-dev/46ceee1a-b54b-4eee-93fe-2d5b4bc610ef%40googlegroups.com. > For more options, visit https://groups.go

Re: [PATCH 8/8] Adapt README.md for rocko branch

2018-01-29 Thread Andreas Reichel
On Mon, Jan 29, 2018 at 02:54:31PM +0100, Jan Kiszka wrote: > On 2018-01-29 14:48, Andreas Reichel wrote: > > On Mon, Jan 29, 2018 at 02:39:52PM +0100, Jan Kiszka wrote: > >> On 2018-01-24 11:23, [ext] Andreas J. Reichel wrote: > >>> From: Andreas Reichel &l

Re: [PATCH 8/8] Adapt README.md for rocko branch

2018-01-29 Thread Andreas Reichel
On Mon, Jan 29, 2018 at 02:39:52PM +0100, Jan Kiszka wrote: > On 2018-01-24 11:23, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > Add information that are Poky Rocko specific. > > > > Signed-o

Re: [PATCH 6/8] When creating a dir, wait till finished

2018-01-29 Thread Andreas Reichel
On Mon, Jan 29, 2018 at 02:36:24PM +0100, Jan Kiszka wrote: > On 2018-01-24 11:23, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > efibootguard.bbclass creates an iso directory, > > which sometimes

Re: [PATCH 5/7] Adapt README.md for rocko branch

2018-01-10 Thread Andreas Reichel
On Wed, Jan 10, 2018 at 04:40:41PM +0100, Jan Kiszka wrote: > On 2018-01-10 13:09, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > Add information that are Poky Rocko specific. > > > > Signed-o

Re: [PATCH 1/9] env: Include update process indicator

2017-11-27 Thread Andreas Reichel
On Thu, Nov 23, 2017 at 09:40:53PM +0100, Jan Kiszka wrote: > On 2017-11-22 12:59, Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > For SWupdate, not only the update state, but also the currently > > performed acti

Re: meta-efibootguard with rocko

2017-11-22 Thread Andreas Reichel
oup and stop receiving emails from it, send an > email to efibootguard-dev+unsubscr...@googlegroups.com. > To post to this group, send email to efibootguard-dev@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/efibootguard-dev/ce039965-7d1d-413a

Re: Release planning

2017-11-15 Thread Andreas Reichel
7-3821-9378-acb5-5d3b0559c354%40siemens.com. > For more options, visit https://groups.google.com/d/optout. -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant andreas.reic...@tngtech.com, +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges

Re: [PATCH v4 0/6] Add USERVAR_TYPE_GLOBAL, bugfixes and tests

2017-11-13 Thread Andreas Reichel
On Tue, Nov 07, 2017 at 03:12:24PM +0100, Andreas J. Reichel wrote: > From: Andreas Reichel <andreas.reichel@siemens.com> > Hi Jan, can we merge this? Claudius and I agreed. Kind regards -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant andreas.reic...@tngtech.com, +49

Re: [PATCH 5/6] Make code more modular

2017-10-25 Thread Andreas Reichel
On Tue, Oct 24, 2017 at 06:27:48PM +0200, Claudius Heine wrote: > Hi, > > On Tue, 2017-10-24 at 17:42 +0200, Andreas Reichel wrote: > > On Tue, Oct 24, 2017 at 04:27:55PM +0200, Claudius Heine wrote: > > > Hi, > > > > > > On Tue, 2017-10-24 at 14:26 +02

Re: [PATCH 4/6] Update travis build script

2017-10-25 Thread Andreas Reichel
On Tue, Oct 24, 2017 at 06:20:49PM +0200, Claudius Heine wrote: > Hi Andreas, > > On Tue, 2017-10-24 at 17:50 +0200, Andreas Reichel wrote: > > On Tue, Oct 24, 2017 at 04:20:07PM +0200, Claudius Heine wrote: > > > Hi, > > > > > > since we seems to like c

Re: [PATCH 4/6] Update travis build script

2017-10-24 Thread Andreas Reichel
t is unclean. It just means, that I have collected all changes that touch the travis script here and you would like to make travis work with every single commit. > > On Tue, 2017-10-24 at 14:26 +0200, Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.c

Re: [PATCH 6/6] Add new tests based on check, fff and linker wrapping

2017-10-24 Thread Andreas Reichel
On Tue, Oct 24, 2017 at 05:23:07PM +0200, Claudius Heine wrote: > On Tue, 2017-10-24 at 14:26 +0200, Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > The new testcode initially provides tests for > > * inte

Re: [PATCH 5/6] Make code more modular

2017-10-24 Thread Andreas Reichel
On Tue, Oct 24, 2017 at 04:27:55PM +0200, Claudius Heine wrote: > Hi, > > On Tue, 2017-10-24 at 14:26 +0200, Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > For unit test support, code must be more modular. >

Re: [PATCH 3/6] Add function faking framework as submodule

2017-10-24 Thread Andreas Reichel
On Tue, Oct 24, 2017 at 04:08:42PM +0200, Claudius Heine wrote: > Hi, > > On Tue, 2017-10-24 at 14:26 +0200, Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > Use function faking framework for mocking in unit tests.

Re: [PATCH 1/6] Remove cmocka test suite

2017-10-24 Thread Andreas Reichel
On Tue, Oct 24, 2017 at 04:04:42PM +0200, Claudius Heine wrote: > Hi Andreas, > > On Tue, 2017-10-24 at 14:26 +0200, Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > Due to license incompatbility, remove cmocka

Re: [PATCH 2/6] Add libcheck unit testing framework

2017-10-24 Thread Andreas Reichel
On Tue, Oct 24, 2017 at 04:07:29PM +0200, Claudius Heine wrote: > On Tue, 2017-10-24 at 14:26 +0200, Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > Use libcheck as new unit testing framework. > > > > Signed-o

Re: [PATCH v2] Bugfix: bgenv_get: Error codes overlap return values

2017-10-20 Thread Andreas Reichel
On Thu, Oct 19, 2017 at 06:20:17PM +0200, Jan Kiszka wrote: > On 2017-10-19 16:49, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > If bgenv_get is called with a NULL pointer as data destination, it > > returns

Re: [PATCH bugfix] tests: test_partitions: Fix function overloading

2017-09-26 Thread Andreas Reichel
On Tue, Sep 26, 2017 at 12:55:59PM +0200, Jan Kiszka wrote: > On 2017-09-26 11:19, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > * Use --weaken to generally weaken library functions for tests, > >

Re: [PATCH v4 11/13] env: Add user variables

2017-09-12 Thread Andreas Reichel
ntX_t. Uff, that would indeed cause trouble if cross-compiling and pre-filling a target's environment with a different, natively built tool and later reading it with the cross-compiled tool with both tools having a different size_t size. Big thanks for seeing this! -- Andreas Reichel Dipl.-Phys. (U

Re: [PATCH v4 12/13] bg_setenv: Use task list, refactor code

2017-09-12 Thread Andreas Reichel
l environment. By using a list as journal for outstanding > > tasks, tasks can be accumulated while parsing the arguments and > > applied in the end. > > > > * Furthermore, the structure of the main function is simplified. > > > > Signed-off-by: Andreas Reichel <

Re: [PATCH v4 07/13] ustate: Refactor state variable

2017-09-12 Thread Andreas Reichel
ity. Also, an enum is added for > > the API code. > > > > Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> > > --- > > docs/TODO.md | 9 -- > > docs/TOOLS.md| 9 +- > > docs/UPDATE.md |

Re: [PATCH v4 05/13] env: Make backend for environment storage configurable

2017-09-12 Thread Andreas Reichel
with-env-backend configure option to specify the c-file > > with the backend implementation. > > > > Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> > > --- > > Makefile.am | 4 ++-- > > configure.ac | 11 +

Re: [PATCH v4 03/13] bg_setenv: Specify output path with --filepath

2017-09-11 Thread Andreas Reichel
` to `--filepath` and now accepts a path, where `BGENV.DAT` > > is created so that it can directly be applied to the real environ- > > ment location. > > > > Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> > > --- > > docs/TODO.md

Re: [PATCH v4 07/13] ustate: Refactor state variable

2017-09-11 Thread Andreas Reichel
ity. Also, an enum is added for > > the API code. > > > > Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> > > --- > > docs/TODO.md | 9 -- > > docs/TOOLS.md| 9 +- > > docs/UPDATE.md |

Re: [PATCH v4 08/13] swupdate-adapter: Refactor API

2017-09-11 Thread Andreas Reichel
eeds an implementation for access scheduling for > > multiple environment accesses at the same time, however, the > > introduction of a better coding style per se is independent of this > > idea and all functions remain unsafe regarding threads. > &

Re: [PATCH v2 3/6] wic: Add wic plugins for efibootguard

2017-09-07 Thread Andreas Reichel
On Thu, Sep 07, 2017 at 10:34:32AM +0200, Jan Kiszka wrote: > On 2017-09-07 10:30, Andreas Reichel wrote: > > On Wed, Sep 06, 2017 at 08:17:34PM +0200, Jan Kiszka wrote: > >> On 2017-09-06 13:34, [ext] Andreas J. Reichel wrote: > >>> From: Andreas Reichel &l

Re: [PATCH v2 3/6] wic: Add wic plugins for efibootguard

2017-09-07 Thread Andreas Reichel
On Wed, Sep 06, 2017 at 08:17:34PM +0200, Jan Kiszka wrote: > On 2017-09-06 13:34, [ext] Andreas J. Reichel wrote: > > From: Andreas Reichel <andreas.reichel@siemens.com> > > > > Add wic plugins for > > * efibootguard EFI partition > > * efibootguard

Re: [PATCH v3 02/12] tests: Build tests always, run tests on 'make check'

2017-09-06 Thread Andreas Reichel
On Tue, Sep 05, 2017 at 02:27:40PM +0200, Claudius Heine wrote: > Hi, > > On 09/05/2017 10:27 AM, [ext] Andreas Reichel wrote: > > From: Reichel Andreas <andreas.reichel@siemens.com> > > > > Per default, tests are now always compiled. > > > >

Re: [PATCH v3 07/12] ustate: Refactor state variable

2017-09-06 Thread Andreas Reichel
On Tue, Sep 05, 2017 at 03:08:25PM +0200, Claudius Heine wrote: > > > On 09/05/2017 10:27 AM, [ext] Andreas Reichel wrote: > > From: Reichel Andreas <andreas.reichel@siemens.com> > > > > diff --git a/docs/UPDATE.md b/docs/UPDATE.md > > index 169fb9d..

Re: [PATCH v3 12/12] bg_setenv: Use task list, refactor code

2017-09-06 Thread Andreas Reichel
On Wed, Sep 06, 2017 at 12:31:38PM +0200, Claudius Heine wrote: > > > On 09/05/2017 10:27 AM, [ext] Andreas Reichel wrote: > > From: Reichel Andreas <andreas.reichel@siemens.com> > > > > - the introduction of a special marker byte which tells the

[PATCH 6/6] README.md: Add instructions

2017-09-05 Thread Andreas Reichel
From: Reichel Andreas <andreas.reichel@siemens.com> Add ToDo list for integration into yocto projects Add an example for a .wks file to use efibootguard as boot loader. Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> --- RE

[PATCH 4/6] efibootguard: Add bitbake recipe

2017-09-05 Thread Andreas Reichel
From: Reichel Andreas <andreas.reichel@siemens.com> Add bitbake recipe for compilation of * efibootguard * efibootguard native environment utilities Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> --- .../recipes-bsp/efibootguard/efibootguard.b

[PATCH 3/6] wic: Add wic plugins for efibootguard

2017-09-05 Thread Andreas Reichel
From: Reichel Andreas <andreas.reichel@siemens.com> Add wic plugins for * efibootguard EFI partition * efibootguard config partition(s) Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> --- .../lib/wic/plugins/source/efibootguard-boot

[PATCH 0/6] Provide meta-efibootguard layer

2017-09-05 Thread Andreas Reichel
From: Reichel Andreas <andreas.reichel@siemens.com> This series creates a new meta-efibootguard layer that provides integration of efibootguard into existing yocto projects. Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> Reichel Andreas (6): meta-efibootg

[PATCH v3 10/12] env_api_fat: Fix problem with crc32 testing

2017-09-05 Thread Andreas Reichel
ritten by updates. Also, the variable name 'oldenvs' is misleading, as it is an array containing all current environments. Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> --- env/env_api_fat.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-)

[PATCH v3 06/12] env: Make number of config partitions configurable

2017-09-05 Thread Andreas Reichel
From: Reichel Andreas <andreas.reichel@siemens.com> Add --with-num-config-parts=XX to define number of config partitions at configuration. Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> --- configure.ac | 15 +++

[PATCH v3 05/12] env: Make backend for environment storage configurable

2017-09-05 Thread Andreas Reichel
From: Reichel Andreas <andreas.reichel@siemens.com> For API refactoring, storage backend should be configurable. Add --with-env-backend configure option to specify the c-file with the backend implementation. Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> ---

[PATCH v3 09/12] Combine libraries to one API

2017-09-05 Thread Andreas Reichel
From: Reichel Andreas <andreas.reichel@siemens.com> There is no need for two different static libraries, hence these two are combined to one `libebgenv.a`. Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> --- Makefile.am

[RFC v2 00/12] Major change in API and functionality

2017-09-01 Thread Andreas Reichel
sition of the crc32 value changes. If it is not read correctly, tools must reinitialize the working copy of the environment to remain usable. * Documentation is updated. * Tests are updated. * docs/TODO.md is updated. Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> Reichel

[RFC v2 06/12] env: Make number of config partitions configurable

2017-09-01 Thread Andreas Reichel
From: Reichel Andreas <andreas.reichel@siemens.com> Add --with-num-config-parts=XX to define number of config partitions at configuration. Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> --- configure.ac | 17 +

[RFC v2 08/12] swupdate-adapter: Simplify API

2017-09-01 Thread Andreas Reichel
files, there is no need for switch cases. * move some functions to simplify API dependencies * remove ebgdefs.h, since it only included one define, which better fits into the envdata.h Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> --- env/env_api_fat.c

[RFC v2 05/12] env: Make backend for environment storage configurable

2017-09-01 Thread Andreas Reichel
From: Reichel Andreas <andreas.reichel@siemens.com> For API refactoring, storage backend should be configurable Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> --- Makefile.am | 4 ++-- configure.ac | 25 ++

[RFC v2 09/12] Combine libraries to one API

2017-09-01 Thread Andreas Reichel
From: Reichel Andreas <andreas.reichel@siemens.com> There is no need for two different static libraries, hence these two are combined to one `libebgenv.a`. Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> --- Makefile.am

Re: [PATCH v3 4/4] docs: Update documentation.

2017-07-21 Thread Andreas Reichel
On Fri, Jul 21, 2017 at 02:23:13PM +0200, Jan Kiszka wrote: > On 2017-07-21 14:00, Andreas Reichel wrote: > > On Thu, Jul 20, 2017 at 08:05:31PM +0200, Jan Kiszka wrote: > >> On 2017-07-12 14:38, [ext] Reichel Andreas wrote: > > OK, I see. > > That makes me wo

Re: [PATCH v3 4/4] docs: Update documentation.

2017-07-21 Thread Andreas Reichel
needed for any non-broken BIOS. At most, > you would have to remove any existing settings and let the BIOS fall > back to that. I would not highlight the exceptional case here. > Not true. Maybe you have two harddisks and want to boot from fs0 instead from fs1. Or you want to boot fs0: before networ

Re: [PATCH 3/4] bg_utils: Remove FAT16 restriction for environment

2017-07-12 Thread Andreas Reichel
On 07/11/2017 08:44 PM, Claudius Heine wrote: On Tue, 2017-07-11 at 15:37 +0200, Reichel Andreas wrote: * Allow FAT12, FAT16 and FAT32 for environment data. * Minor code style fixes Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> --- tools/bg_utils.c | 13 +--

Re: [PATCH v3 1/1] bg_utils: Use own code of used parted functions

2017-07-04 Thread Andreas Reichel
. Signed-off-by: Andreas Reichel <andreas.reichel@siemens.com> --- Makefile.am | 4 +- swupdate-adapter/Makefile | 54 - tools/bg_utils.c | 1 + tools/bg_utils.h | 2 +- tools/ebgpart.c