Re: [PATCH] Accept more :tangle-mode specification forms

2021-11-18 Thread Tom Gillespie
Hi Timothy, The confusion with 755 and "755" could lead to security issues in cases like 600 vs "600" vs #o600. The need to protect against the 600 case is fairly important, however I don't think there is anything we can do about it, because someone might want to enter their modes as base 10

[BUG] Bug: Footnotes break iCalendar export [9.4.6 (9.4.6-g069bcb @ /home/msi/.emacs.d/straight/build/org/)]

2021-11-18 Thread msi
Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See https://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org mailing list.

Bug: org-fill-paragraph [9.3 (release_9.3 @ /usr/share/emacs/27.1/lisp/org/)]

2021-11-18 Thread Edrie Ddrie
When using `org-fill-paragraph' on a part of a paragraph, e.g. with halve the lines as active region, it still uses the unselected text around when filling. This works different than `fill-paragraph', `fill-region' and `fill-region-as-paragraph' that fill only the selected part of a paragraph

[BUG] Footnotes break iCalendar export [9.4.6 (9.4.6-g069bcb @ /home/msi/.emacs.d/straight/build/org/)]

2021-11-18 Thread msi
Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See https://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org mailing list.

Re: [PATCH] Accept more :tangle-mode specification forms

2021-11-18 Thread Timothy
Hi All, I thought I’d checked for this, but I’ve just noticed that :tangle-mode 755 doesn’t actually work as expected. I assumed 755 would be passed as a string but org-babel-parse-header-arguments actually turns it into an integer, just like (identity #o755). Obviously 755 != #o755 and so this

Re: [BUG] org-mode binds C-c C-TAB, which seems illegal [9.5 (9.5-g0a86ad @ /home/il/.config/emacs/elpa/org-9.5/)]

2021-11-18 Thread Max Nikulin
On 18/11/2021 04:19, Ingo Lohmar wrote: On Fri, Oct 01 2021 23:16 (+0200), Ingo Lohmar wrote: In 9.5, org-key-map binds org-force-cycle-archived to (kbd "C-c C-TAB"). At least on my machine, this specification is illegal: it generates an entry in org-key-map, but the key presses yield an

LinkRemark Firefox extension approved for addons.mozilla.org

2021-11-18 Thread Max Nikulin
A year ago I announced LinkRemark browser extension to save metadata of web pages as notes in Org Mode. New version is available in Firefox catalog (It is not published to Chrome store, the only option is still to load unpacked extension.): https://addons.mozilla.org/firefox/addon/linkremark/

Re: table and Cyrillic characters: org-element--cache: Unregistered buffer modifications detected. Resetting

2021-11-18 Thread Max Nikulin
On 17/11/2021 19:15, Ihor Radchenko wrote: Max Nikulin writes: Unintentionally I pressed some keys and it appeared again ... C-\ russian-computer RET || By "|" I mean Shift+\ that inserts "/" with russian-computer input method. I pushed yet another workaround. That part of code is turning

[BUG] C-c C-* causes "org-element--cache: Unregistered buffer modifications detected."

2021-11-18 Thread Max Nikulin
On 14/11/2021 14:59, Ihor Radchenko wrote: Ihor Radchenko writes: Confirmed However, I can only trigger the warning up to Emacs 27. Emacs 28 and later has no issue. Need to investigate further. Fixed via c3f457375. This is another case when Emacs internals (replace-match) increase

Re: [BUG] Unregistered buffer modifications detected [9.5 (9.5-g49e2f6 @ /Users/myuser/.emacs.d/straight/29/straight/build/org/)]

2021-11-18 Thread Ihor Radchenko
Aaron Jensen writes: > I'm seeing another issue and I don't know if it is related. When I > save an org-capture my emacs spins for a long time. I C-g w/ > toggle-debug-on-quit and got this: > > > Debugger entered--Lisp error: (quit) > org-element--parse-generic-emphasis("/" italic) >

Re: [BUG] Unregistered buffer modifications detected [9.5 (9.5-g49e2f6 @ /Users/myuser/.emacs.d/straight/29/straight/build/org/)]

2021-11-18 Thread Aaron Jensen
On Wed, Nov 17, 2021 at 7:03 AM Ihor Radchenko wrote: > > Aaron Jensen writes: > > > Here's another on c47b535bb: > > > > https://gist.github.com/aaronjensen/348d879f79099c0d9b660bad199f25af > > > > I don't recall what I was doing at the time, it was during a meeting. > > I do not see anything

Re: c47b535bb origin/main org-element: Remove dependency on ‘org-emphasis-regexp-components’

2021-11-18 Thread Ihor Radchenko
Nicolas Goaziou writes: >> My intuition says that the current parser behaviour is not correct. It >> would make more sense to prioritise link over italics. However, it would >> require a major change in the parser - instead of a single pass, the >> parser may parse different types of objects

Re: [Problems with org-ref-helm-insert-ref-link and org-id-get-create]

2021-11-18 Thread John Kitchin
if you don't get a helm buffer popping up, it could mean you have not turned helm-mode on (e.g. M-x helm-mode). That redefines completing-read in a helm style, and should act and feel like helm when you insert a ref link. If you don't have that on, then you will see the older completing read

Re: c47b535bb origin/main org-element: Remove dependency on ‘org-emphasis-regexp-components’

2021-11-18 Thread Nicolas Goaziou
Hello, Ihor Radchenko writes: > My intuition says that the current parser behaviour is not correct. It > would make more sense to prioritise link over italics. However, it would > require a major change in the parser - instead of a single pass, the > parser may parse different types of objects

Re: c47b535bb origin/main org-element: Remove dependency on ‘org-emphasis-regexp-components’

2021-11-18 Thread Ihor Radchenko
Max Nikulin writes: > These regexps will always fail under some conditions, since it is not > strict markup. An example is emphasis terminated inside link target > > /A link [[https://orgmode.org/?oops=true][Org Mode]] Your example actually reveals a much bigger issue with current element

Re: [PATCH] org.el (org-display-inline-image--width): Small fix

2021-11-18 Thread Timothy
Just marking this patch as applied for updates.orgmode.org. Nicolas Goaziou writes: > Hello, > > Sébastien Miquel writes: > >> Subject: [PATCH] org.el (org-display-inline-image--width): Small fix > > I expounded the commit message and applied your patch. Thank you. > > Regards,

Re: [PATCH] Treat :tangle-mode as an octal value not integer

2021-11-18 Thread Timothy
Just removing this from updates.orgmode.org.

Re: [BUG] org-occur doesn't hide unmatching top-levels [9.5 (release_9.5-225-g494c20.dirty @ /Users/carlos/Install/Source/org-mode/lisp/)]

2021-11-18 Thread Ihor Radchenko
Carlos Pita writes: >> I think you misread the docstring for org-show-context-detail: > > Sorry, I don't concur here. > > This is in the docstring I'm interested in (org-occur): I agree that org-occur could have a better docstring. > It's not very relevant to my concern if things are first

Re: [BUG] org-occur doesn't hide unmatching top-levels [9.5 (release_9.5-225-g494c20.dirty @ /Users/carlos/Install/Source/org-mode/lisp/)]

2021-11-18 Thread Carlos Pita
Hi Ihor, On Thu, Nov 18, 2021 at 7:28 AM Ihor Radchenko wrote: > > Carlos Pita writes: > > > I see no reason why a match inside b2 will hide b1 and b3 but not a > > and c (I'm referring to the headings, not the contents). > > I think you misread the docstring for org-show-context-detail:

Re: [PATCH] ob-R async evaluation

2021-11-18 Thread Timothy
Hi Jeremie, Sorry it's taken a while to get to this. I've just gone through your patch and it looks quite reasonable. I also took the liberty of fixing the indentation in a few spots and tweaking your commit message. This has just been pushed as 58db28d. > I'm attaching a patch that clean up

Re: [BUG] org-occur doesn't hide unmatching top-levels [9.5 (release_9.5-225-g494c20.dirty @ /Users/carlos/Install/Source/org-mode/lisp/)]

2021-11-18 Thread Ihor Radchenko
Carlos Pita writes: > I see no reason why a match inside b2 will hide b1 and b3 but not a > and c (I'm referring to the headings, not the contents). I think you misread the docstring for org-show-context-detail: >> Alist between context and visibility span when **revealing** a ;; <-- >>

Re: [PATCH] Accept more :tangle-mode specification forms

2021-11-18 Thread Timothy
Hi All, This has just been pushed as described in fa97f9a39. See some tests I performed before pushing below. #+begin_src text :tangle-mode (identity #o345) :tangle t1.txt this works #+end_src #+begin_src text :tangle-mode 433 :tangle t2.txt this works #+end_src #+begin_src text :tangle-mode

Re: [BUG] org-mode binds C-c C-TAB, which seems illegal [9.5 (9.5-g0a86ad @ /home/il/.config/emacs/elpa/org-9.5/)]

2021-11-18 Thread Ihor Radchenko
Timothy writes: > I think that the two actions we may want to take here are: > 1. Replace "C-TAB" with "C-" in the keybinding > 2. Change the keybinding to something else that doesn't use control+tab >for instance, "C-c M-TAB" seems to be available. > > Which option seems preferable? Note

Re: [BUG] require org-macs at compile time [9.5 (9.5-g0a86ad @ /home/phil/.emacs.d/elpa/org-9.5/)]

2021-11-18 Thread Timothy
Hi Phil, > The macro `org-dlet' is not expanded in file org-agenda.el at compile > time when installing Org 9.5 from ELPA. How does this issue manifest? I tried byte-compiling org-agenda.el and didn't see any errors/warnings. -- Timothy

Re: [BUG] Weird sparse tree folding [9.5 (release_9.5-225-g494c20.dirty @ /Users/carlos/Install/Source/org-mode/lisp/)]

2021-11-18 Thread Ihor Radchenko
Carlos Pita writes: > That said, my report was about the expansion of: > ... > c3 > ... > to: > * a... > ** b3 > c3 > ... > c4 > ... > > when pressing TAB at the beginning of the first ... Confirmed on current main. Though I plan a bunch of commits that will

Re: [PATCH] org-manual.org: org-cite additions

2021-11-18 Thread Timothy
Hi Bruce, Thanks for this patch. I've had a read through and it all looks good to me. I've just applied this with minor tweaks as 30dbfc6. > This is a minor patch to address the most obvious missing pieces that > have confused people. -- Timothy

Re: [Problems with org-ref-helm-insert-ref-link and org-id-get-create]

2021-11-18 Thread Uwe Brauer
>>> "UB" == Uwe Brauer writes: > So I checked out the org-ref-2 branch from the github repository. > But still there the function org-ref-helm-insert-cite-link is gone and > other related org-ref-helm functions. Is this correct? I got the behaviour back by loading (require 'org-ref-helm)