Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Stefan Monnier writes: >> (setq-local kill-line-query-function #'org-kill-line-query) > > Please use `add-function` for such things. > That's its raison d'être. When comparing imaginary kill-line-query-functions (abnormal hook) + add-hook vs. kill-line-query-function + add-function, which one

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> (setq-local kill-line-query-function #'org-kill-line-query) Please use `add-function` for such things. That's its raison d'être. Stefan

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Eli Zaretskii writes: >> May you please elaborate what you mean by "old one"? > > kill-line-query-function There is no such variable in Emacs. I proposed to introduce a new variable `kill-line-query-function' earlier in this thread. There is no backwards-compatibility problem we need to solve

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Ihor Radchenko > Cc: monn...@iro.umontreal.ca, emacs-orgmode@gnu.org, 65...@debbugs.gnu.org, > maniku...@gmail.com, i...@whxvd.name > Date: Fri, 12 Jan 2024 12:39:18 + > > Eli Zaretskii writes: > > >> I think that I see what you mean. What we can do to achieve this is > >>

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Eli Zaretskii writes: >> I think that I see what you mean. What we can do to achieve this is >> changing `kill-line-query-function' into abnormal hook >> `kill-line-query-functions'. Then, `kill-line'/`kill-whole-line' will >> use (run-hook-with-args-until-success 'kill-line-query-functions) to

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Ihor Radchenko > Cc: monn...@iro.umontreal.ca, emacs-orgmode@gnu.org, 65...@debbugs.gnu.org, > maniku...@gmail.com, i...@whxvd.name > Date: Fri, 12 Jan 2024 12:24:01 + > > Eli Zaretskii writes: > > >> Then, Org mode can instead have > >> > >> (setq-local kill-line-query-function

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Eli Zaretskii writes: >> Then, Org mode can instead have >> >> (setq-local kill-line-query-function #'org-kill-line-query) >> (defun org-kill-line-query (beg end) >> (org-with-point-at beg >> (when (and (org-at-heading-p) >>(progn >> (end-of-line) >>

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Ihor Radchenko > Cc: monn...@iro.umontreal.ca, emacs-orgmode@gnu.org, 65...@debbugs.gnu.org, > maniku...@gmail.com, i...@whxvd.name > Date: Thu, 11 Jan 2024 18:08:11 + > > Then, Org mode can instead have > > (setq-local kill-line-query-function #'org-kill-line-query) > (defun

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Eli Zaretskii writes: >> > How would kill-line know that it's about to kill a subtree? All it >> > knows is that it is killing some invisible text. >> >> I imagine the following: >> >> 1. `kill-*-line' function will, by default, test if invisible text of >>length size is killed and query

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Ihor Radchenko > Cc: monn...@iro.umontreal.ca, emacs-orgmode@gnu.org, 65...@debbugs.gnu.org, > maniku...@gmail.com, i...@whxvd.name > Date: Thu, 11 Jan 2024 16:15:13 + > > Eli Zaretskii writes: > > >> So, I'd like some way to configure `kill-whole-line'/`kill-line' to warn > >>

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Eli Zaretskii writes: >> So, I'd like some way to configure `kill-whole-line'/`kill-line' to warn >> user about killing hidden text when we detect that we are deleting a >> folded heading. Something like: >> >>(y-or-n-p "Kill hidden subtree along with headline? ") >> >> I believe that it

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Ihor Radchenko > Cc: monn...@iro.umontreal.ca, emacs-orgmode@gnu.org, 65...@debbugs.gnu.org, > maniku...@gmail.com, i...@whxvd.name > Date: Thu, 11 Jan 2024 15:50:10 + > > Eli Zaretskii writes: > > >> Then, we discussed that Emacs commands to not always provide enough > >>

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Eli Zaretskii writes: >> Then, we discussed that Emacs commands to not always provide enough >> toggles. So, I am asking to add one in this thread. > > I don't think I understand what kind of toggle are we talking about. What I would like to request is a way to handle the following situation:

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Stefan Monnier writes: >>> I said that remapping widely-used keys to commands that behave >>> significantly differently places a non-trivial burden on users, >>> especially on those who use the remapping mode relatively rarely. >> >> Sure. From which I concluded that Org mode should avoid

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Stefan Monnier > Cc: Eli Zaretskii , emacs-orgmode@gnu.org, > 65...@debbugs.gnu.org, maniku...@gmail.com, i...@whxvd.name > Date: Wed, 10 Jan 2024 11:26:08 -0500 > > >> I said that remapping widely-used keys to commands that behave > >> significantly differently places a non-trivial

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

>> I said that remapping widely-used keys to commands that behave >> significantly differently places a non-trivial burden on users, >> especially on those who use the remapping mode relatively rarely. > > Sure. From which I concluded that Org mode should avoid remapping I don't think that's what

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Ihor Radchenko > Cc: monn...@iro.umontreal.ca, emacs-orgmode@gnu.org, 65...@debbugs.gnu.org, > maniku...@gmail.com, i...@whxvd.name > Date: Wed, 10 Jan 2024 13:05:19 + > > Eli Zaretskii writes: > > > I said that remapping widely-used keys to commands that behave > > significantly

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Eli Zaretskii writes: >> Eli told me in the past that Org mode should not remap keys. >> See the discussion branch starting at >> https://yhetil.org/emacs-devel/8735gfs3is.fsf@localhost/ > > I said that remapping widely-used keys to commands that behave > significantly differently places a

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Ihor Radchenko > Cc: emacs-orgmode@gnu.org, Eli Zaretskii , > 65...@debbugs.gnu.org, Max Nikulin , i...@whxvd.name > Date: Tue, 09 Jan 2024 22:33:58 + > > Stefan Monnier writes: > > >> Although, I am still interested to pursue feature request to allow > >> customizing

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> Eli told me in the past that Org mode should not remap keys. > See the discussion branch starting at > https://yhetil.org/emacs-devel/8735gfs3is.fsf@localhost/ Then I'll let Eli take care of this :-) Stefan

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Stefan Monnier writes: >> Although, I am still interested to pursue feature request to allow >> customizing `kill-whole-line' and `kill-line' by major modes. > > [ I'm sorry I didn't pay very much attention to this part. > Naively, I'd suggest you use `remap` bindings for that, but I'm sure >

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Stefan Monnier writes: >> It would be nice if this advice were added to the relevant docstrings. > > Not sure exactly which advice you're referring to (the text you quoted > above is misleading: it would encourage the naive reader to just do the > work in `after-change-functions` since it's

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

>> That's why I said "rule of thumb": there can be tradeoffs. >> In practice 99% of Emacs commands modify only a single contiguous chunk >> of text, so the tradeoff comes into play fairly rarely. > It would be nice if this advice were added to the relevant docstrings. Not sure exactly which

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

>>> But in addition to that, I suspect that Org should probably not modify >>> visibility directly from the modification hooks. Instead, its >>> modification hook function should just stash the info somewhere and then >>> update the visibility later on, such as in a `post-command-hook`, timer,

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Ihor Radchenko writes: > Stefan Monnier writes: > >> But in addition to that, I suspect that Org should probably not modify >> visibility directly from the modification hooks. Instead, its >> modification hook function should just stash the info somewhere and then >> update the visibility

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Stefan Monnier writes: > That's why I said "rule of thumb": there can be tradeoffs. > In practice 99% of Emacs commands modify only a single contiguous chunk > of text, so the tradeoff comes into play fairly rarely. It would be nice if this advice were added to the relevant docstrings. --

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

>> As a rule of thumb, I think modification hooks should be treated a bit >> like POSIX signal handlers: just record the event somewhere but don't do >> any substantial work in there. > Yet, it is sometimes necessary to modify text right inside the > modification hooks. Otherwise, it is very hard

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Stefan Monnier writes: > But in addition to that, I suspect that Org should probably not modify > visibility directly from the modification hooks. Instead, its > modification hook function should just stash the info somewhere and then > update the visibility later on, such as in a

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> The reported bug is a side effect of a feature when Org automatically > reveals hidden outlines that are "broken" due to edits and thus could > not be unfolded easily. For example, when destroying parent heading in a > folding subtree: I'd be in favor of changing `kill-whole-line` to do the

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Sebastian Miele writes: >>> Then, what should we do to move things forward? I guess the first step >>> will be writing these missing tests. >> >> Yes, that'd be most welcome. > > I will write the tests. And I will probably come up with an updated > version of the original patch. There is at

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Eli Zaretskii writes: >> We may have a misunderstanding here. >> In "* Heading text :tag1:tag2:", everything is visible yet Org needs to >> protect ":tag1:tag2: from being killed by `kill-line', but not from >> `kill-whole-line'. Moreover, the behaviour also depends on the point >> position - if

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Eli Zaretskii > Date: Thu, 2023-09-07 13:19 +0300 > >> From: Ihor Radchenko >> Cc: i...@whxvd.name, 65...@debbugs.gnu.org, emacs-orgmode@gnu.org >> Date: Thu, 07 Sep 2023 10:00:49 + >> >> Eli Zaretskii writes: >> >> > Then perhaps just a special value for buffer-invisibility-spec,

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Ihor Radchenko > Cc: i...@whxvd.name, 65...@debbugs.gnu.org, emacs-orgmode@gnu.org > Date: Thu, 07 Sep 2023 10:00:49 + > > Eli Zaretskii writes: > > > Then perhaps just a special value for buffer-invisibility-spec, or > > some other simple variation of a property Org already uses?

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Sebastian Miele writes: >> I think there is misunderstanding. `combine-after-change-calls' will not >> affect the two-step modification of the kill ring, if we put it around >> `kill-whole-line'. Or do I miss something? > > I tried to wrap the problematic portion of `kill-whole-line' into >

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Eli Zaretskii writes: >> >> In addition, `org-kill-line' acts specially in certain scenarios: >> >> >> >> For >> >> * Heading text :tag1:tag2: >> >> >> >> `org-kill-line' will keep and re-align ":tag1:tag2:": >> >> >> >> * Heading :tag1:tag2: >> >> >> >> It would be nice if we could

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Ihor Radchenko > Date: Wed, 2023-09-06 08:30 + > > Eli Zaretskii writes: > >>> It would also make sense to group the two edits together via >>> `combine-after-change-calls', although a more universal way to know that >>> certain edits are a part of the same known command (even when

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Eli Zaretskii > Date: Wed, 2023-09-06 15:16 +0300 > >> From: Ihor Radchenko >> Date: Wed, 06 Sep 2023 08:23:23 + >> >> Eli Zaretskii writes: >> >> >> The following would do it. I think I tested it rather thoroughly. >> >> During testing I found another bug that is addressed by

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Ihor Radchenko > Cc: i...@whxvd.name, 65...@debbugs.gnu.org, emacs-orgmode@gnu.org > Date: Wed, 06 Sep 2023 08:30:36 + > > Eli Zaretskii writes: > > >> In addition, `org-kill-line' acts specially in certain scenarios: > >> > >> For > >> * Heading text :tag1:tag2: > >> > >>

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Ihor Radchenko > Cc: Sebastian Miele , 65...@debbugs.gnu.org, > emacs-orgmode@gnu.org > Date: Wed, 06 Sep 2023 08:23:23 + > > Eli Zaretskii writes: > > >> The following would do it. I think I tested it rather thoroughly. > >> During testing I found another bug that is addressed

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Eli Zaretskii writes: >> It would also make sense to group the two edits together via >> `combine-after-change-calls', although a more universal way to know that >> certain edits are a part of the same known command (even when called >> non-interactively) would be useful. > > The command kills

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Eli Zaretskii writes: >> The following would do it. I think I tested it rather thoroughly. >> During testing I found another bug that is addressed by the let-binding >> of kill-read-only-ok during the first kill-region below. > > Thanks. Sadly, we don't have any tests for this function in our

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Ihor Radchenko > Cc: Max Nikulin , i...@whxvd.name, > 65...@debbugs.gnu.org, emacs-orgmode@gnu.org > Date: Tue, 05 Sep 2023 15:50:58 + > > Eli Zaretskii writes: > > >> On 05/09/2023 17:29, Ihor Radchenko wrote: > >> > Confirmed. > >> > >> It is a regression in comparison to e.g.

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Max Nikulin writes: >> The feature was introduced in Or 9.5. > > Or in 9.6? Oops. Yup. Org 9.6 - the latest release. Together with org-fold library. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

On 05/09/2023 22:50, Ihor Radchenko wrote: Eli Zaretskii writes: On 05/09/2023 17:29, Ihor Radchenko wrote: Confirmed. It is a regression in comparison to e.g. org-mode-9.3.1. What changed since org-mode-9.3.1? Was it some change in Emacs, and if so, which one? That was a comparison on

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Sebastian Miele > Cc: Ihor Radchenko , 65...@debbugs.gnu.org, > emacs-orgmode@gnu.org > Date: Tue, 05 Sep 2023 17:25:38 +0200 > > > From: Eli Zaretskii > > Date: Tue, 2023-09-05 14:54 +0300 > > > > […] > > > > So we could decide that this command needs to become smarter when the > >

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

Eli Zaretskii writes: >> On 05/09/2023 17:29, Ihor Radchenko wrote: >> > Confirmed. >> >> It is a regression in comparison to e.g. org-mode-9.3.1. > > What changed since org-mode-9.3.1? Was it some change in Emacs, and > if so, which one? The reported bug is a side effect of a feature when

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> Cc: emacs-orgmode@gnu.org, 65...@debbugs.gnu.org > Date: Tue, 5 Sep 2023 21:30:58 +0700 > From: Max Nikulin > > On 05/09/2023 17:29, Ihor Radchenko wrote: > > Confirmed. > > It is a regression in comparison to e.g. org-mode-9.3.1. What changed since org-mode-9.3.1? Was it some change in

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> From: Eli Zaretskii > Date: Tue, 2023-09-05 14:54 +0300 > > […] > > So we could decide that this command needs to become smarter when the > visual line includes invisible text. That is, improve the command > without making any Org-specific changes anywhere. Patches to that > effect are

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

On 05/09/2023 17:29, Ihor Radchenko wrote: Confirmed. It is a regression in comparison to e.g. org-mode-9.3.1. I noticed it for multiline plain list items - ab cd Only first line is removed by C-S- when the item is folded by TAB. For headings I usually use C-c C-x C-w, so I had less

Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]

> Cc: 65...@debbugs.gnu.org, emacs-orgmode@gnu.org > From: Ihor Radchenko > Date: Tue, 05 Sep 2023 10:29:20 + > > As I described in the above, Org needs more control over the behaviour of > `kill-line'/`kill-whole-line' when the visible line contains multiple > lines of hidden text - to