Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface

2020-02-19 Thread stardiviner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Bastien writes: > Hi stardiviner, > > stardiviner writes: > >> I tested your method, true. And I also pulled that latest ob-clojure.el >> changes. >> Works great, I like this new method more. Thanks for your >> improvement. > > Thanks for your

Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface

2020-02-18 Thread Bastien
Hi stardiviner, stardiviner writes: > I tested your method, true. And I also pulled that latest ob-clojure.el > changes. > Works great, I like this new method more. Thanks for your > improvement. Thanks for your feedback. Also, you may have noted that the code for Clojure sessions has been

Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface

2020-02-18 Thread stardiviner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Bastien writes: > stardiviner writes: > >> I use CIDER (sesman) keybinding =[C-c C-s d]= on ob-clojure src >> block to link current buffer directory to CIDER REPL session. > > I simply start Cider with C-c M-j and then execute the Clojure source

Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface

2020-02-16 Thread Bastien
Tim Cross writes: > Thanks for the response and work Bastien. I will check out the updated > version when I get a chance. Thanks. > One point possibly relevant with regards to Clojurescript. I suspect > there could be a reasonable use case when you consider clojurescipt in > the context of

Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface

2020-02-16 Thread Tim Cross
Thanks for the response and work Bastien. I will check out the updated version when I get a chance. One point possibly relevant with regards to Clojurescript. I suspect there could be a reasonable use case when you consider clojurescipt in the context of node rather than just as a browser

Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface

2020-02-16 Thread Bastien
Hi Tim, thanks for your email. Tim Cross writes: > I wonder if it would make sense to use shadow-cljs rather than cider as > a back end for evaluating clojurescript? I am inclined to question the usefulness of evaluating ClojureScript code *at all*. > More generally, I wonder if there would

Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface

2020-02-14 Thread Tim Cross
I wonder if it would make sense to use shadow-cljs rather than cider as a back end for evaluating clojurescript? More generally, I wonder if there would be any benefit in considering a Clojure CLI Tools back end integration and bypassing CIDER altogether? While I love CIDER, I'm not sure it is

Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface

2020-02-14 Thread Bastien
stardiviner writes: > I use CIDER (sesman) keybinding =[C-c C-s d]= on ob-clojure src > block to link current buffer directory to CIDER REPL session. I simply start Cider with C-c M-j and then execute the Clojure source block with C-c C-c, it works fine. > I guess this should work for

Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface

2020-02-14 Thread stardiviner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Bastien writes: > Hi Stardiviner, > > stardiviner writes: > >> About this patch, last night, I try to test ob-clojurescript eval with CIDER >> connection. But no luck, the ClojureScript REPL connection always failed to >> start. I have problem

Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface

2020-02-14 Thread stardiviner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Bastien writes: > stardiviner writes: > >> I've already signed FSF papers before. Actually I contributed some >> patches already. :) > > Argh, yes, sorry, my bad! I was confused because I saw TINYCHANGE in > previous commit messages. It's

Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface

2020-02-14 Thread Bastien
Hi Stardiviner, stardiviner writes: > About this patch, last night, I try to test ob-clojurescript eval with CIDER > connection. But no luck, the ClojureScript REPL connection always failed to > start. I have problem on CIDER. So I have a request that can you take a test. > Because on my side,

Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface

2020-02-14 Thread Bastien
stardiviner writes: > I've already signed FSF papers before. Actually I contributed some > patches already. :) Argh, yes, sorry, my bad! I was confused because I saw TINYCHANGE in previous commit messages. -- Bastien

Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface

2020-02-13 Thread stardiviner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 About this patch, last night, I try to test ob-clojurescript eval with CIDER connection. But no luck, the ClojureScript REPL connection always failed to start. I have problem on CIDER. So I have a request that can you take a test. Because on my

Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface

2020-02-13 Thread stardiviner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Bastien writes: > Hi, > > stardiviner writes: > >> And patches in attachments. > > Applied, thanks. Great! > > I made some minor modifications: > > - I added the TINYCHANGE cookie in both messages > - I replaced "ob-clojure.el: (...)" by

Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface

2020-02-13 Thread Bastien
Hi, stardiviner writes: > And patches in attachments. Applied, thanks. I made some minor modifications: - I added the TINYCHANGE cookie in both messages - I replaced "ob-clojure.el: (...)" by "ob-clojure.el (...):" In general, try `C-x 4 a' on a change, either from magit or from the