Re: [O] "git describe" in version of info file with "make info_git_describe"

2011-10-30 Thread Michael Brand
Hi Achim On Sun, Oct 30, 2011 at 08:01, Achim Gratz wrote: > Why should the git-describe info not be part of the ELPA tarball?  If > there is a good reason not to include it (I think it is useful > to know which commit the ELPA archive was built on) one could alter the > include file before rolli

Re: [O] "git describe" in version of info file with "make info_git_describe"

2011-10-30 Thread Achim Gratz
Michael Brand writes: > Is it possible with your current "make info" to get an info file > without git describe for a release like ELPA when made from within a > git repo Why should the git-describe info not be part of the ELPA tarball? If there is a good reason not to include it (I think it is

Re: [O] "git describe" in version of info file with "make info_git_describe"

2011-10-29 Thread Michael Brand
Hi Achim On Fri, Oct 28, 2011 at 11:26, Achim Gratz wrote: > Again I don't know if or when this gets merged. I've already used up my > TINYCHANGEs and hit an impasse with the FSF papers that I don't know how > to resolve... :-( Then again, the build system doesn't really become > part of Emacs,

Re: [O] "git describe" in version of info file with "make info_git_describe"

2011-10-28 Thread Achim Gratz
Michael Brand writes: > If set-version.pl would be obsolete my patch would be much shorter and > I would use something even more portable than perl to change the > version in /tmp/org.texi like the POSIX/SUS ed command, used inline in > the Makefile. Would you agree? I don't know if it is still u

Re: [O] "git describe" in version of info file with "make info_git_describe"

2011-10-27 Thread Michael Brand
Hi Achim Thank you for your review. On Wed, Oct 26, 2011 at 18:56, Achim Gratz wrote: > The set-version.pl file may be obsolete (perl is still required), If set-version.pl would be obsolete my patch would be much shorter and I would use something even more portable than perl to change the versi

Re: [O] "git describe" in version of info file with "make info_git_describe"

2011-10-26 Thread Achim Gratz
Michael Brand writes: > There has not yet been any review or comment on the changes in the > Makefile and in UTILITIES/set-version.pl. I would be happy if these > parts could be reviewed too. The set-version.pl file may be obsolete (perl is still required), there is no version number in the indiv

Re: [O] "git describe" in version of info file with "make info_git_describe"

2011-10-26 Thread Michael Brand
Hi Carsten and Bastien On Fri, Oct 21, 2011 at 16:44, Carsten Dominik wrote: > is there an agreement that this is a good patch?  I have not followed the > discussion. Let me summarize: > On Oct 16, 2011, at 9:12 PM, Michael Brand wrote: >> The previous patch attachment had a wrong mime typ

Re: [O] "git describe" in version of info file with "make info_git_describe"

2011-10-23 Thread Bernt Hansen
>> On Oct 16, 2011, at 9:12 PM, Michael Brand wrote: >> >>> I made a new patch replacing the previous, now considering the >>> Makefile targets "target" and "help" introduced meanwhile by Achim >>> Gratz and with a shorter name "info-vg" for the new target for easier >>> typing of the make command.

Re: [O] "git describe" in version of info file with "make info_git_describe"

2011-10-21 Thread Bernt Hansen
I still have this as a TODO item for review. I'll take a look at it this weekend. -Bernt Carsten Dominik writes: > Hi, > > is there an agreement that this is a good patch? I have not followed the > discussion. > > - Carsten > > On Oct 16, 2011, at 9:12 PM, Michael Brand wrote: > >> Hi al

Re: [O] "git describe" in version of info file with "make info_git_describe"

2011-10-21 Thread Carsten Dominik
Hi, is there an agreement that this is a good patch? I have not followed the discussion. - Carsten On Oct 16, 2011, at 9:12 PM, Michael Brand wrote: > Hi all > > I made a new patch replacing the previous, now considering the > Makefile targets "target" and "help" introduced meanwhile by

Re: [O] "git describe" in version of info file with "make info_git_describe"

2011-10-16 Thread Michael Brand
Hi all I made a new patch replacing the previous, now considering the Makefile targets "target" and "help" introduced meanwhile by Achim Gratz and with a shorter name "info-vg" for the new target for easier typing of the make command. The previous patch attachment had a wrong mime type, could the

Re: [O] "git describe" in version of info file with "make info_git_describe"

2011-06-02 Thread Michael Brand
The patch is ready and attached. Michael On Thu, Jun 2, 2011 at 17:05, Michael Brand wrote: [...] > Since I would like to give the more often used "git describe" > precedence I will make org-version and "make info_git_describe" > consistent with git. The ".dirty" postfix of org-version I will le

Re: [O] "git describe" in version of info file with "make info_git_describe"

2011-06-02 Thread Michael Brand
On Thu, Jun 2, 2011 at 16:47, Bernt Hansen wrote: > Michael Brand writes: >> Can I remove this substitution of "release_7.5-350-g3433" -> >> "release_7.5.350.g3433" from org-version in my patch or should "make >> info_git_describe" do the same and why? > > Hi Michael, > > This was purely cosmetic

Re: [O] "git describe" in version of info file with "make info_git_describe"

2011-06-02 Thread Bernt Hansen
Michael Brand writes: > Hi Bernt, hi all > > I appreciate that org-version adds the output of "git describe" to the > org-version string if we are running > from a git repository. Thanks to Bernt et al: > http://thread.gmane.org/gmane.emacs.orgmode/16620 > > Now I suggest the same for the info fi

[O] "git describe" in version of info file with "make info_git_describe"

2011-06-02 Thread Michael Brand
Hi Bernt, hi all I appreciate that org-version adds the output of "git describe" to the org-version string if we are running from a git repository. Thanks to Bernt et al: http://thread.gmane.org/gmane.emacs.orgmode/16620 Now I suggest the same for the info file by using the new target "make info_