Re: [O] Can't remove deadline or schedule in bulk mode
Kyle Meyer writes: > Julien Cubizolles writes: > >> Julien Cubizolles writes: >> >>> Kyle Meyer writes: >>> >>> Since you have the git repo set up and have a good/bad range, you can use git bisect to find the offending commit. >> >> I finally found the offending commit, >> >> it's commit 4f578a3f7fe193229adc239c93d6983bcc030d41 org-agenda: Small >> refactoring by N. Goaziou. > > Yep, that's the same commit that I pointed to in the later part of the > message you quote, but my guess about what the problematic bits were was > wrong. Anyway, should be fixed with b900a85fe. It is, thanks.
Re: [O] Can't remove deadline or schedule in bulk mode
Julien Cubizolles writes: > Julien Cubizolles writes: > >> Kyle Meyer writes: >> >> >>> Since you have the git repo set up and have a good/bad range, you can use >>> git bisect to find the offending commit. > > I finally found the offending commit, > > it's commit 4f578a3f7fe193229adc239c93d6983bcc030d41 org-agenda: Small > refactoring by N. Goaziou. Yep, that's the same commit that I pointed to in the later part of the message you quote, but my guess about what the problematic bits were was wrong. Anyway, should be fixed with b900a85fe. -- Kyle
Re: [O] Can't remove deadline or schedule in bulk mode
Julien Cubizolles writes: > Kyle Meyer writes: > > >> Since you have the git repo set up and have a good/bad range, you can use >> git bisect to find the offending commit. I finally found the offending commit, it's commit 4f578a3f7fe193229adc239c93d6983bcc030d41 org-agenda: Small refactoring by N. Goaziou. Julien.
Re: [O] Can't remove deadline or schedule in bulk mode
Kyle Meyer writes: > Since you have the git repo set up and have a good/bad range, you can use > git bisect to find the offending commit. I'm having trouble using setting it up. To go back to a previous state using magit, I'm * choosing a commit in the log view of magit-status * magit-checkout or magit-reset --soft to this commit * rebuild org-mode with make clean && make update --8<---cut here---start->8--- (add-to-list 'load-path "~/git-repositories/org-mode/lisp") (add-to-list 'load-path "~/git-repositories/org-mode/contrib/lisp") (org-reload) --8<---cut here---end--->8--- Somehow I'm missing something since even when going back to 8.xx versions of org-mode, the problem remains although the stock version (Org mode version 9.0.9 (release_9.0.9 @ /usr/share/emacs/26.0.50/lisp/org/)) doesn't exhibit it. What is the right way to load the org-mode from the git repo instead of the one already installed on the system ? Julien.
Re: [O] Can't remove deadline or schedule in bulk mode
Kyle Meyer writes: > Since you have the git repo set up and have a good/bad range, you can use > git bisect to find the offending commit. > > Based on changes that touched org-agenda-bulk-action recently, my guess > is 4f578a3f7 (org-agenda: Small refactoring, 2017-05-12). Quickly > looking at that patch (and not testing), I think ?d's > > `(lambda () >(let ((org-log-redeadline (and org-log-redeadline 'time))) > (org-agenda-deadline arg ,time))) > > should s/arg/',arg/. > > The code for ?s is similar, so I'd guess you'd hit the same error when > running C-u B s. I'm not sure. I thought so too, at first, but here's the working code from 9.0.5: #+BEGIN_SRC elisp (setq cmd `(eval '(let ((org-log-reschedule (and org-log-reschedule 'time))) (,c1 arg ,time +#END_SRC "arg" is not unquoted there. Also, a very silly test, but in my current Org 9.0.5 configuration, I evaled the org-agenda-bulk-action function from master, with the code you quoted, and it works.
Re: [O] Can't remove deadline or schedule in bulk mode
Julien Cubizolles writes: > Adam Porter writes: > >> Julien Cubizolles writes: >> >>> In an agenda buffer, C-u B d should clear the deadline of the entries >>> marked the way C-u does on a single entry. I think it's what it used to >>> do some time ago. Instead, I get: >>> >>> org-agenda-deadline: Invalid function: 4 >> >> FWIW, works for me on Org 9.0.5. > > Indeed, works for me on Org mode version 9.0.9 (release_9.0.9 @ > /usr/share/emacs/26.0.50/lisp/org/) > > but not on Org mode version 9.0.9 (release_9.0.9-738-g8ab9a8 @ > /home/wilk/git-repositories/org-mode/lisp/) Since you have the git repo set up and have a good/bad range, you can use git bisect to find the offending commit. Based on changes that touched org-agenda-bulk-action recently, my guess is 4f578a3f7 (org-agenda: Small refactoring, 2017-05-12). Quickly looking at that patch (and not testing), I think ?d's `(lambda () (let ((org-log-redeadline (and org-log-redeadline 'time))) (org-agenda-deadline arg ,time))) should s/arg/',arg/. The code for ?s is similar, so I'd guess you'd hit the same error when running C-u B s. -- Kyle
Re: [O] Can't remove deadline or schedule in bulk mode
Adam Porter writes: > Julien Cubizolles writes: > >> In an agenda buffer, C-u B d should clear the deadline of the entries >> marked the way C-u does on a single entry. I think it's what it used to >> do some time ago. Instead, I get: >> >> org-agenda-deadline: Invalid function: 4 > > FWIW, works for me on Org 9.0.5. Indeed, works for me on Org mode version 9.0.9 (release_9.0.9 @ /usr/share/emacs/26.0.50/lisp/org/) but not on Org mode version 9.0.9 (release_9.0.9-738-g8ab9a8 @ /home/wilk/git-repositories/org-mode/lisp/) Julien.
Re: [O] Can't remove deadline or schedule in bulk mode
Julien Cubizolles writes: > In an agenda buffer, C-u B d should clear the deadline of the entries > marked the way C-u does on a single entry. I think it's what it used to > do some time ago. Instead, I get: > > org-agenda-deadline: Invalid function: 4 FWIW, works for me on Org 9.0.5.
