Re: [Emc-developers] G74 and G84 docs and L-

2021-10-20 Thread Greg C
Thank you Andy for committing the docs changes. Rainer - Perhaps one rainy cold Fall day I will start combing through them to see if there is anything I can do to make it more clear. If nothing else, I personally think it would be good to explicitly define the letters for each G-Code.

Re: [Emc-developers] G74 and G84 docs and L- => forked topic: dedicated command for a canned rigid tapping cycle

2021-10-20 Thread Feral Engineer
Yeah but even on a siemens, it's simply referred to as cycle84 and inside the cycle gui, you have options of floating and rigid tapping. I think the rigid part should just be an m function and the tapping function should just reside inside of the same g84. Just my $0.02  Phil T. The Feral

Re: [Emc-developers] G74 and G84 docs and L- => forked topic: dedicated command for a canned rigid tapping cycle

2021-10-20 Thread andy pugh
On Tue, 19 Oct 2021 at 17:45, Rainer Stelzer wrote: > So I totally agree, rigid tapping should work the way G84 does. > > Regarding the syntax, I don't know the policy behind the development. > If it is to stay as close as possible to one big brand I think that we stick to NIST RS274NGC, and

Re: [Emc-developers] G74 and G84 docs and L- => forked topic: dedicated command for a canned rigid tapping cycle

2021-10-19 Thread Rainer Stelzer
Hi Phil, I'd like to see rigid tapping being able to be toggled with an m code or a parameter I'm the cycle instead of calling g33.1. fanuc mills use m29 primarily, siemens just has a cycle option for floating holder or synchronous tapping Today I changed a postprocessor to  generate rigid

Re: [Emc-developers] G74 and G84 docs and L-

2021-10-19 Thread Rainer Stelzer
Hi Greg, Please let me know if you think anything about it should be changed. perfectly fine. I did think of adding the R- and L- explanations to G81 too. But I am trying to refrain from going too far down the docs editing rabbit hole. IMHO it should be done. LinuxCNC is a great piece of

Re: [Emc-developers] G74 and G84 docs and L-

2021-10-18 Thread Greg C
Done. https://github.com/LinuxCNC/linuxcnc/pull/1319 -Greg On Mon, Oct 18, 2021 at 8:14 PM andy pugh wrote: > On Mon, 18 Oct 2021 at 23:50, Greg C wrote: > > > Attached is my proposed changes to G74 and G84 in the docs. > > Is it possible to submit it as a pull request at: >

Re: [Emc-developers] G74 and G84 docs and L-

2021-10-18 Thread Greg C
Ok no worries, I will submit the pull request. I wasn’t sure which was easier so I erred on this side. Thanks Andy! On Mon, Oct 18, 2021 at 8:14 PM andy pugh wrote: > On Mon, 18 Oct 2021 at 23:50, Greg C wrote: > > > Attached is my proposed changes to G74 and G84 in the docs. > > Is it

Re: [Emc-developers] G74 and G84 docs and L-

2021-10-18 Thread andy pugh
On Mon, 18 Oct 2021 at 23:50, Greg C wrote: > Attached is my proposed changes to G74 and G84 in the docs. Is it possible to submit it as a pull request at: https://github.com/LinuxCNC/linuxcnc/pulls (If not, we can still look at it, but it's harder) -- atp "A motorcycle is a bicycle with a

Re: [Emc-developers] G74 and G84 docs and L-

2021-10-18 Thread Feral Engineer
I'd like to see rigid tapping being able to be toggled with an m code or a parameter I'm the cycle instead of calling g33.1. fanuc mills use m29 primarily, siemens just has a cycle option for floating holder or synchronous tapping Phil T. The Feral Engineer Check out my LinuxCNC tutorials,

Re: [Emc-developers] G74 and G84 docs and L-

2021-10-18 Thread Greg C
Rainer, Attached is my proposed changes to G74 and G84 in the docs. Please let me know if you think anything about it should be changed. I did think of adding the R- and L- explanations to G81 too. But I am trying to refrain from going too far down the docs editing rabbit hole. Let me know if

Re: [Emc-developers] G74 and G84 docs and L-

2021-10-18 Thread Greg C
Rainer, Thank you for looking into it, very much appreciated! Thanks, Greg On Mon, Oct 18, 2021 at 7:00 AM Rainer Stelzer wrote: > Hi Greg, > > > Although, I do wonder if no X or Y are given, should L still be valid? > > totally agree. > > I retrofitted some machines with Sinumerik 810

Re: [Emc-developers] G74 and G84 docs and L-

2021-10-18 Thread Rainer Stelzer
Hi Greg, Although, I do wonder if no X or Y are given, should L still be valid? totally agree. I retrofitted some machines with Sinumerik 810 controls. Tapping and rigid tapping are done with the same G code on this controls but ask for different  parameters. In combination with a very

Re: [Emc-developers] G74 and G84 docs and L-

2021-10-18 Thread Greg C
Good morning Rainer, Thanks for the explanation, that makes sense. Although, I do wonder if no X or Y are given, should L still be valid? I will take a look at the docs later and see what I can do and submit a PR to make it a bit more clear (at least for G74 and G84) for future “me’s” :)

Re: [Emc-developers] G74 and G84 docs and L-

2021-10-18 Thread Gene Heskett
On Monday 18 October 2021 04:23:25 Rainer Stelzer wrote: > Hi Greg, > > the L in a tapping cycle is not intended to tap the same location. > > In incremental mode and with a X or Y axis given, it taps at different > locations. > Handy when you do manual programming, confusing when you are used to

Re: [Emc-developers] G74 and G84 docs and L-

2021-10-18 Thread Rainer Stelzer
Hi Greg, the L in a tapping cycle is not intended to tap the same location. In incremental mode and with a X or Y axis given, it taps at different locations. Handy when you do manual programming, confusing when you are used to use CAM tools. It is explained in the G81 cycle. The

[Emc-developers] G74 and G84 docs and L-

2021-10-17 Thread Greg C
Good evening, I spent some time today in the G-Code docs looking at G74 and G84 (left and right hand tapping with a tension-compression head in mind) in an attempt to fully understand the options. I found the docs for these G-Codes to be a bit vague, and confusing. Especially given that R- and