Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: made DynamicMessages accessible in
uicommonweb
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41947
To
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: made DynamicMessages accessible in
uicommonweb
..
Patch Set 4: Code-Review+1
(1 comment)
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: clicking system tree doesn't update main tab
..
Patch Set 1:
(1 comment)
Vojtech Szocs has submitted this change and it was merged.
Change subject: core: Stop overriding id of new permission in backend
..
core: Stop overriding id of new permission in backend
Remove overriding of id of new
Vojtech Szocs has submitted this change and it was merged.
Change subject: gwt: Emulate random UUID generation in GWT
..
gwt: Emulate random UUID generation in GWT
Adds emulation of random UUID generation in GWT code that is
Vojtech Szocs has posted comments on this change.
Change subject: core: Stop overriding id of new permission in backend
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41984
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: core: Stop overriding id of new permission in backend
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41984
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: gwt: Emulate random UUID generation in GWT
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41983
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: storage main tab 500
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42095
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: VM general refresh
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41986
To unsubscribe, visit
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Persistent client-side logging infra
..
webadmin,userportal: Persistent client-side logging infra
This patch adds following
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: ClientStorage improvements
..
Patch Set 3:
Rebased, no changes since last patchset.
--
To view, visit https://gerrit.ovirt.org/41404
To
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: ClientStorage improvements
..
webadmin,userportal: ClientStorage improvements
1. All key/value pairs persisted through
Vojtech Szocs has posted comments on this change.
Change subject: frontend: fixed NPEs in debug mode
..
Patch Set 1:
I think it's worth to spend time and investigate why are we sending
PersistentBag instances to frontend in
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Null pointer dereferences in model classes
..
webadmin: Null pointer dereferences in model classes
Added null check when calling
Vojtech Szocs has posted comments on this change.
Change subject: core, webadmin: Dismissible events
..
Patch Set 5: Code-Review+1
Frontend part looks good.
--
To view, visit https://gerrit.ovirt.org/41382
To unsubscribe,
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: ClientStorage improvements
..
Patch Set 2:
Tested instance creator role in UserPortal with Tomas, all seems to work well.
--
To view,
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: cluster guide me datacenter
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41486
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: cluster guide me datacenter
..
Patch Set 1:
Sorry, I missed your conversation with Alex at
https://gerrit.ovirt.org/#/c/40782/ - please discard my
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: cluster guide me datacenter
..
Patch Set 1:
Shmuel, with this patch applied, is your patch
https://gerrit.ovirt.org/#/c/40782/ still needed? (AFAIK,
Vojtech Szocs has posted comments on this change.
Change subject: core, webadmin: Dismissible events
..
Patch Set 3: Code-Review+1
(4 comments)
Nice patch overall, some inline comments for your consideration.
Vojtech Szocs has posted comments on this change.
Change subject: core, webadmin: Dismissible events
..
Patch Set 3:
(1 comment)
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Persistent client-side logging infra
..
Patch Set 14:
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/35832/ :
The
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Persistent client-side logging infra
..
Patch Set 14:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/25444
To unsubscribe,
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: ClientStorage improvements
..
Patch Set 1:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/41404
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: ClientStorage improvements
..
Patch Set 1:
http://jenkins.ovirt.org/job/ovirt-engine_master_find-bugs_gerrit/35833/ :
The patch does not
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Persistent client-side logging infra
..
Patch Set 14:
I'll write a patch to modify key format used to persist data in browser's
local
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Null pointer dereferences in model classes
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/41405
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: ClientStorage improvements
..
Patch Set 1:
(2 comments)
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Persistent client-side logging infra
..
Patch Set 14:
Rebase, no changes since last patchset.
--
To view, visit
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin,userportal: ClientStorage improvements
..
webadmin,userportal: ClientStorage improvements
1. All key/value pairs persisted through ClientStorage
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: Null pointer dereferences in model classes
..
webadmin: Null pointer dereferences in model classes
Added null check when calling
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: ClientStorage improvements
..
Patch Set 1: Verified+1
Screenshot of Firefox / Dev Tools / local storage inspection:
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: ClientStorage improvements
..
Patch Set 1:
@Tomas, please review my comments in UserPortal SystemModule.java - thanks!
--
To view, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Null pointer dereferences in model classes
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/41405
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: added visual indicator for tooltips
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41296
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: added visual indicator for tooltips
..
Patch Set 1:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/41296
To unsubscribe,
Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: automatically show header tooltip
underline
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41298
To
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Optimize syntax checker handling
..
Patch Set 1: Verified+1
Did some additional sanity tests for both WebAdmin UserPortal in Firefox,
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin,userportal: Optimize syntax checker handling
..
webadmin,userportal: Optimize syntax checker handling
1. access to (search) syntax checker instance is
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Optimize syntax checker handling
..
Patch Set 2:
Greg, thanks for your review!
--
To view, visit https://gerrit.ovirt.org/41284
To
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Optimize syntax checker handling
..
Patch Set 1:
Thanks Tomas for review!
--
To view, visit https://gerrit.ovirt.org/41237
To
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Optimize syntax checker handling
..
webadmin,userportal: Optimize syntax checker handling
1. access to (search) syntax checker
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Optimize syntax checker handling
..
Patch Set 2: Verified+1
Verified on IE8 (Win2008R2 Win7) - this patch reduces the delay between
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Optimize syntax checker handling
..
Patch Set 1:
Thanks Greg for your review.
Adding some more UI maintainers, I'd like to have at least
Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: removed unused images and css
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40106
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: fix broken helptag implementation
..
Patch Set 2: Code-Review+1
Looks good, it's basically +2 from me.
--
To view, visit
Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: fix IE8 rendering / jquery failure
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41228
To unsubscribe, visit
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin,userportal: Optimize syntax checker handling
..
webadmin,userportal: Optimize syntax checker handling
1. access to (search) syntax checker instance is
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Optimize syntax checker handling
..
Patch Set 1:
Verified on IE8 together with https://gerrit.ovirt.org/#/c/41228/
This patch reduces the
Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: fix IE8 rendering / jquery failure
..
Patch Set 1: Verified+1
Verified as part of verifying master patch
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Persistent client-side logging infra
..
Patch Set 11:
Tomas, thanks for your review!
I'll submit a final version of the patchset soon,
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Persistent client-side logging infra
..
Patch Set 12: Verified+1
All changes done and tested, patchset 12 is the one to review.
Verified
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugin revealPlace API - rename parameter
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41031
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugin API - setSearchString
..
Patch Set 4: Code-Review+1
All looks good, I'd like Alex to review this too, just in case.
--
To view, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugins - control tab priority
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41032
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Persistent client-side logging infra
..
Patch Set 12:
To avoid clashes between WebAdmin vs. UserPortal instances running on the same
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugin API - revealPlace
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41029
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Update host general layout.
..
Patch Set 2: Code-Review+1
All looks good!
--
To view, visit https://gerrit.ovirt.org/40886
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugins - control tab priority
..
Patch Set 4: Verified+1
Last patchset with some small tweaks.
--
To view, visit https://gerrit.ovirt.org/40510
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: UI plugins - control tab priority
..
webadmin: UI plugins - control tab priority
When adding custom main or sub tab, UI plugins can now
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugins - control tab priority
..
Patch Set 4:
Verified using test UI plugin attached to BZ https://bugzilla.redhat.com/1214624
--
To view, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugins - control tab priority
..
Patch Set 1:
tested and it is working great.
Thanks, Karnan. Let me quickly rebase and re-check before we can
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugins - control tab priority
..
Patch Set 1:
@Alex, can you please review this one?
--
To view, visit https://gerrit.ovirt.org/40510
To
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugins - control tab priority
..
Patch Set 1:
One more patchset coming up soon to improve the logic for comparing tab
priorities (represented as
Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: Number field reporting wrong error
..
Patch Set 8:
(2 comments)
Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: Number field reporting wrong error
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/37244
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: fluent UiAction
..
Patch Set 25:
(1 comment)
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: fluent UiAction
..
Patch Set 45:
Wow that's a lot of patchsets, going to look at the most recent one.
--
To view, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: fluent UiAction
..
Patch Set 45:
(10 comments)
https://gerrit.ovirt.org/#/c/36848/45//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2015-05-05
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: fluent UiAction
..
Patch Set 45: Code-Review+1
Giving +1 (see my inline comments for your consideration), Alex should take a
look as well.
--
To
Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: show tooltips on cropped input boxes
..
Patch Set 3:
(2 comments)
In general looks OK, posted some comments, but I see that you will
Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: Number field reporting wrong error
..
Patch Set 8:
(3 comments)
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugins - control tab priority
..
Patch Set 1:
Great, so this means it works? :-)
Have you tried different priority values for a custom main/sub
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: fluent UiAction
..
Patch Set 47: Code-Review+2
Looks good, thanks for addressing all review comments.
--
To view, visit
Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: show tooltips on cropped input boxes
..
Patch Set 3:
(1 comment)
Vojtech Szocs has posted comments on this change.
Change subject: userportal, webadmin: Number field reporting wrong error
..
Patch Set 7:
(1 comment)
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: cluster guide me datacenter
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/37763
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: cluster guide me datacenter
..
Patch Set 2:
(1 comment)
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: UI plugin API - revealPlace
..
webadmin: UI plugin API - revealPlace
This patch adds new UI plugin API function ('revealPlace')
that can be
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: UI plugin API - setSearchString
..
webadmin: UI plugin API - setSearchString
This patch adds new UI plugin API function ('setSearchString')
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: UI plugin revealPlace API - rename parameter
..
webadmin: UI plugin revealPlace API - rename parameter
Renamed placeToken to historyToken for
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugin revealPlace API - rename parameter
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40494
To unsubscribe, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Disable GWTP version checking
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/40502
To unsubscribe, visit
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin,userportal: Disable GWTP version checking
..
webadmin,userportal: Disable GWTP version checking
Disabled GWTP VersionInspectorLinker functionality in
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugin revealPlace API - rename parameter
..
Patch Set 1:
Thanks Alex for quick review.
--
To view, visit https://gerrit.ovirt.org/40494
To
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: UI plugin revealPlace API - rename parameter
..
webadmin: UI plugin revealPlace API - rename parameter
Renamed placeToken to historyToken for
Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Disable GWTP version checking
..
Patch Set 1:
Yeah, it is sad that we won't be able to upgrade to newer GWT/GWT-P due to
the de-RPC
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Disable GWTP version checking
..
webadmin,userportal: Disable GWTP version checking
Disabled GWTP VersionInspectorLinker
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: UI plugins - control tab priority
..
webadmin: UI plugins - control tab priority
When adding custom main or sub tab, UI plugins can now specify
the
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugin API - setSearchString
..
Patch Set 2: Verified+1
Verified using test UI plugin attached to BZ https://bugzilla.redhat.com/1081028
No impact
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugin API - setSearchString
..
Patch Set 1:
Testing reveals that current implementation is quirky, need to update this
patch.
--
To view, visit
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugin API - setSearchString
..
Patch Set 2:
(1 comment)
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugin API - revealPlace
..
Patch Set 1: Verified+1
Verified using test UI plugin attached to BZ https://bugzilla.redhat.com/1168334
--
To view,
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: UI plugin API - revealPlace
..
Patch Set 1:
Would it make sense to add another function to list the available places for
the plugin. To allow for
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: UI plugin API - setSearchString
..
webadmin: UI plugin API - setSearchString
This patch adds new UI plugin API function ('setSearchString')
that can
Vojtech Szocs has uploaded a new change for review.
Change subject: webadmin: UI plugin API - revealPlace
..
webadmin: UI plugin API - revealPlace
This patch adds new UI plugin API function ('revealPlace')
that can be used to
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Replace usage of *PmProxyPreferences() with
*FenceProxySources()
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39761
To
Vojtech Szocs has posted comments on this change.
Change subject: build: pack gwt-symbols within jar
..
Patch Set 2:
Please ignore my above comment, dependency has impact on build order as Maven
sorts all modules before doing
Vojtech Szocs has posted comments on this change.
Change subject: build: pack gwt-symbols within jar
..
Patch Set 2:
Not sure if dependencies in frontend-symbols/pom.xml is needed at all (due
to using resource copying) but
1 - 100 of 2752 matches
Mail list logo
