Re: [E-devel] [PATCH 2/2] Zero is a valid fd value

2011-01-24 Thread Tom Hacohen
On Mon, 2011-01-24 at 08:49 +0100, Vincent Torri wrote: imho, B) with a file in it saying at which revision it has been deleted Or better yet, start writing sane *descriptive* and *searchable* log messages in svn and maybe even use tags like [REMOVED-DEPRECATED] or stuff like that and then it

Re: [E-devel] [PATCH 2/2] Zero is a valid fd value

2011-01-24 Thread Mike Blumenkrantz
On Mon, 24 Jan 2011 10:16:37 + Tom Hacohen tom.haco...@partner.samsung.com wrote: On Mon, 2011-01-24 at 08:49 +0100, Vincent Torri wrote: imho, B) with a file in it saying at which revision it has been deleted Or better yet, start writing sane *descriptive* and *searchable* log

[E-devel] [PATCH] Handle ecore signals with a pipe

2011-01-24 Thread Mike McCormack
The way ecore handles signals is racy. The attached patch uses a pipe to avoid races between signals and select/poll(). A fix for before or after 1.0...? thanks, Mike btw. the SIGRTMIN is totally borken and probably should be deleted From 1a21c643e08e325b2773e53ecde27bcf46ca5148 Mon Sep 17

Re: [E-devel] [PATCH] Handle ecore signals with a pipe

2011-01-24 Thread Mike Blumenkrantz
On Mon, 24 Jan 2011 20:56:25 +0900 Mike McCormack mj.mccorm...@samsung.com wrote: The way ecore handles signals is racy. The attached patch uses a pipe to avoid races between signals and select/poll(). A fix for before or after 1.0...? thanks, Mike btw. the SIGRTMIN is totally

Re: [E-devel] [PATCH] Handle ecore signals with a pipe

2011-01-24 Thread Tom Hacohen
On Mon, 2011-01-24 at 06:58 -0500, Mike Blumenkrantz wrote: I'll look a bit more carefully later, but it looks like some great cleanup work that would be nice to see in 1.0 since the current code is a total mess. We were supposed to release yesterday, I don't think it's a good time for

Re: [E-devel] Startup applications issues

2011-01-24 Thread Sebastian Dransfeld
On 01/23/2011 07:36 PM, Jeff Hoogland wrote: So after talks about my issues with start up applications with a fresh user creation in IRC last night, I am certain it is an efreet cache issue. I removed LXDM and used GDM as the login manager and the startup applications still fail to load

Re: [E-devel] Failed to add poll on fd 18 (errno = 17)!

2011-01-24 Thread Andreas Volz
Am Sun, 19 Dec 2010 10:07:52 +0100 schrieb Andreas Volz: so the question is... is it really adding the same fd twice - and if so.. why was it doing that? that userspace code needs fixing if it did. May be an hint. I also noticed that the function was called twice while stepping through.

Re: [E-devel] e_dbus and places module patches

2011-01-24 Thread Dave Andreoli
2011/1/19 Mike Blumenkrantz m...@zentific.com: On Wed, 19 Jan 2011 11:57:21 -0500 Nikolas Arend nikolas.ar...@gmx.net wrote: Hello, Attached please find two small patches for e_dbus and the places module. They fix segfaults for me (triggered in e_hal_property_bool_get()) that I was

Re: [E-devel] [PATCH] Handle ecore signals with a pipe

2011-01-24 Thread Mike Blumenkrantz
On Mon, 24 Jan 2011 21:10:30 +0900 Tom Hacohen tom.haco...@partner.samsung.com wrote: On Mon, 2011-01-24 at 06:58 -0500, Mike Blumenkrantz wrote: I'll look a bit more carefully later, but it looks like some great cleanup work that would be nice to see in 1.0 since the current code is a total

Re: [E-devel] [PATCH] Handle ecore signals with a pipe

2011-01-24 Thread Michael Jennings
On Monday, 24 January 2011, at 14:56:52 (-0500), Mike Blumenkrantz wrote: Isn't just before release the best time to be fixing stuff that is messy? No. Just before release isn't the best time to fix anything. It's an appropriate time to fix critical bugs, but it's not even an appropriate time

Re: [E-devel] Startup applications issues

2011-01-24 Thread Sebastian Dransfeld
On 01/24/2011 04:57 PM, Sebastian Dransfeld wrote: On 01/23/2011 07:36 PM, Jeff Hoogland wrote: So after talks about my issues with start up applications with a fresh user creation in IRC last night, I am certain it is an efreet cache issue. I removed LXDM and used GDM as the login manager and

Re: [E-devel] Startup applications issues

2011-01-24 Thread Christopher Michael
On 01/24/2011 05:46 PM, Sebastian Dransfeld wrote: On 01/24/2011 04:57 PM, Sebastian Dransfeld wrote: On 01/23/2011 07:36 PM, Jeff Hoogland wrote: So after talks about my issues with start up applications with a fresh user creation in IRC last night, I am certain it is an efreet cache issue. I

Re: [E-devel] Startup applications issues

2011-01-24 Thread Sebastian Dransfeld
On 01/24/2011 11:53 PM, Christopher Michael wrote: On 01/24/2011 05:46 PM, Sebastian Dransfeld wrote: On 01/24/2011 04:57 PM, Sebastian Dransfeld wrote: On 01/23/2011 07:36 PM, Jeff Hoogland wrote: So after talks about my issues with start up applications with a fresh user creation in IRC

Re: [E-devel] [Patch] patch for elm_main.c (about elm_all_flush func)

2011-01-24 Thread Daniel Juyung Seo
Hello, Anybody can review this patch? It looks like Woohyun is right. Below 3 APIs has nothing to do with _elm_win_list. And at least if _elm_win_list is NULL, below 3 APIs are not called. ejde_file_cache_flush(); edje_collection_cache_flush(); eet_clearcache(); Thank you. Daniel Juyung Seo

Re: [E-devel] [PATCH] Handle ecore signals with a pipe

2011-01-24 Thread Tom Hacohen
On Mon, 2011-01-24 at 14:56 -0500, Mike Blumenkrantz wrote: Isn't just before release the best time to be fixing stuff that is messy? Not in my pov, so close to release we should try to avoid doing big changes because big changes sometimes (usually) bring bugs in. But what a big change is, is

Re: [E-devel] [PATCH] Handle ecore signals with a pipe

2011-01-24 Thread Lucas De Marchi
On Mon, Jan 24, 2011 at 9:56 AM, Mike McCormack mj.mccorm...@samsung.com wrote: The way ecore handles signals is racy. The attached patch uses a pipe to avoid races between signals and select/poll(). Couldn't we use signalfd instead? It's the most clean way I know. A fix for before or

[E-devel] [Patch] genlist item cache exception handling patch

2011-01-24 Thread Daniel Juyung Seo
Hello, I added no cached item handling. In some case, items should not be cached and should not use caches. For example, if there was a state change in item style, it should not be cached because it remembers the state changes. And if we use elm_genlist_item_item_class_update() API, item should

Re: [E-devel] E SVN: jeffdameth trunk/E-MODULES-EXTRA/everything-websearch/src

2011-01-24 Thread David Seikel
On Mon, 24 Jan 2011 08:57:41 -0800 Enlightenment SVN no-re...@enlightenment.org wrote: Log: disable youtube download actions, dont work anymore Author: jeffdameth Date: 2011-01-24 08:57:41 -0800 (Mon, 24 Jan 2011) New Revision: 56288 Trac:

[E-devel] Clicked signal in elm_entry

2011-01-24 Thread Tom Hacohen
Hey all, MJ (in cc) has brought to my attention that the elm_entry clicked signal (and actually all of the rest as well) is connected to the text part of the edje object entry, which is not always the same size as the entry's evas_object. For example, if an entry is of size 200x200 and it's text

Re: [E-devel] [PATCH] Handle ecore signals with a pipe

2011-01-24 Thread Mike McCormack
On 01/25/2011 12:10 PM, Lucas De Marchi wrote: On Mon, Jan 24, 2011 at 9:56 AM, Mike McCormack mj.mccorm...@samsung.com wrote: The way ecore handles signals is racy. The attached patch uses a pipe to avoid races between signals and select/poll(). Couldn't we use signalfd instead? It's the

[E-devel] GSOC 2011

2011-01-24 Thread Ian Caldwell
it's that time of year again. Google has just announced their Summer of code for 2011... We should really try to participate this year! the announcement is herel Google has just announced GSoC2011. http://google-opensource.blogspot.com/2011/01/google-summer-of-code-announced-at-lca.html The

[E-devel] [Patch] patch for elm_module

2011-01-24 Thread WooHyun Jung
Hello. Mr. Wonguk Jeong made a patch for elm_module. This patch is for changing the timing of module loading. For now, module loading is done in elm_init Thus, modules are always loaded, even if the application does not use them. So this patch deferred the timing of module loading to

Re: [E-devel] [Patch] patch for elm_module

2011-01-24 Thread Tom Hacohen
Dear WooHyun, I haven't really reviewed the patch because I really don't know enough about elementary's modules. But I did manage to spot a couple of issues that mean that the patch can't be accepted: 1. line 15 of the patch: if (_elm_module_load(m) == EINA_FALSE) should be if