Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check.

2013-10-07 Thread ChunEon Park
) -Regards, Hermet- -Original Message- From: Tom Hacohentom.hacohen@samsung.com To: enlightenment-devel@lists.sourceforge.net; Cc: Sent: 2013-10-04 (금) 21:59:15 Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check. On 04/10

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check.

2013-10-07 Thread Tom Hacohen
On 07/10/13 09:14, ChunEon Park wrote: Yes there was a misunderstanding. I agree. But I didn't disagree on Tom's request and revert. I agree on him(lack of commit message) and you. I'm glad you agree with that, as that was the only thing I was arguing about. I just wondered one of the

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check.

2013-10-07 Thread ChunEon Park
- From: Tom Hacohentom.haco...@samsung.com To: enlightenment-devel@lists.sourceforge.net; Cc: Sent: 2013-10-07 (월) 18:43:24 Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check. On 07/10/13 09:14, ChunEon Park wrote: Yes there was a misunderstanding. I

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check.

2013-10-07 Thread Tom Hacohen
On 07/10/13 11:48, ChunEon Park wrote: OK, again to clarify this, I don't wanna arguing about commit message. Even I didn't oppose and mentioned about it in the replies. I agree on the more descrive commit msg also. My first asking was this, is this right the

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check.

2013-10-06 Thread ChunEon Park
@lists.sourceforge.net; Cc: Sent: 2013-10-04 (금) 21:52:28 Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check. On Fri, Oct 4, 2013 at 9:09 AM, ChunEon Park hermet@naver.com wrote: it shouldn't be in. maybe. but you made the function to return NULL. and then you want

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check.

2013-10-06 Thread ChunEon Park
- From: Tom Hacohentom.haco...@samsung.com To: enlightenment-devel@lists.sourceforge.net; Cc: Sent: 2013-10-04 (금) 21:59:15 Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check. On 04/10/13 13:09, ChunEon Park wrote: it shouldn't be in. maybe. but you made

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check.

2013-10-06 Thread Cedric BAIL
) -Regards, Hermet- -Original Message- From: Tom Hacohentom.haco...@samsung.com To: enlightenment-devel@lists.sourceforge.net; Cc: Sent: 2013-10-04 (금) 21:59:15 Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check. On 04/10/13 13

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check.

2013-10-05 Thread ChunEon Park
- -Original Message- From: Tom Hacohentom.haco...@samsung.com To: enlightenment-devel@lists.sourceforge.net; Cc: Sent: 2013-10-04 (금) 22:54:39 Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check. On 04/10/13 14:47, Carsten Haitzler (The Rasterman) wrote

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check.

2013-10-04 Thread Tom Hacohen
On 03/10/13 19:02, ChunEon Park wrote: If so, why dot you leave the evas_textblock_cursor_format_is_visible_get() to return NULL if you think it must verify the fnode? You missed the whole point of the revert. The point of the revert was my inability to review your patch, and thus I

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check.

2013-10-04 Thread ChunEon Park
: Sent: 2013-10-04 (금) 19:59:02 Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check. On 03/10/13 19:02, ChunEon Park wrote: If so, why dot you leave the evas_textblock_cursor_format_is_visible_get() to return NULL if you think it must verify the fnode

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check.

2013-10-04 Thread Iván Briano
. -Regards, Hermet- -Original Message- From: Tom Hacohentom.haco...@samsung.com To: enlightenment-devel@lists.sourceforge.net; Cc: Sent: 2013-10-04 (금) 19:59:02 Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check. On 03/10/13

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check.

2013-10-04 Thread Tom Hacohen
On 04/10/13 13:09, ChunEon Park wrote: it shouldn't be in. maybe. but you made the function to return NULL. and then you want to know reason by other people? Maybe it should, maybe it shouldn't the point is, I don't know. You are now trying to explain yourself in the ML, why not explain

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check.

2013-10-04 Thread The Rasterman
say it. :) -Regards, Hermet- -Original Message- From: Tom Hacohentom.haco...@samsung.com To: enlightenment-devel@lists.sourceforge.net; Cc: Sent: 2013-10-04 (금) 19:59:02 Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check.

2013-10-04 Thread Tom Hacohen
On 04/10/13 14:47, Carsten Haitzler (The Rasterman) wrote: On Fri, 4 Oct 2013 21:09:29 +0900 (KST) ChunEon Park her...@naver.com said: it shouldn't be in. maybe. but you made the function to return NULL. and then you want to know reason by other people? what tom is fishing for is.. you

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert evas/textblock - null check.

2013-10-03 Thread ChunEon Park
If so, why dot you leave the evas_textblock_cursor_format_is_visible_get() to return NULL if you think it must verify the fnode? -Regards, Hermet- -Original Message- From: Tom Hacohent...@stosb.com To: g...@lists.enlightenment.org; Cc: Sent: