Re: [E-devel] [patch] elm_genlist - add merging edc strings list

2012-03-25 Thread Daniel Juyung Seo
Question in _item_content_realize(). I don't see a point to merge the list here. +*source = eina_list_merge(*source, cons); *source must be NULL when you run _item_content_realize(). If it's not NULL, that's a huge problem. Creating another list pointer(cons) and merging it with NULL

Re: [E-devel] [patch] elm_genlist - add merging edc strings list

2012-03-25 Thread The Rasterman
On Sun, 25 Mar 2012 15:45:21 +0900 Daniel Juyung Seo seojuyu...@gmail.com said: Question in _item_content_realize(). I don't see a point to merge the list here. +*source = eina_list_merge(*source, cons); *source must be NULL when you run _item_content_realize(). If it's not

Re: [E-devel] [patch] elm_genlist - add merging edc strings list

2012-03-25 Thread Hyoyoung Chang
in most of cases, Daniel is right. But i added this for item_fields_update if ((!itf) || (itf ELM_GENLIST_ITEM_FIELD_CONTENT)) { _it-content_objs = _item_content_unrealize(_it, VIEW(_it), _it-contents, parts);

Re: [E-devel] [patch] elm_genlist - add merging edc strings list

2012-03-25 Thread Daniel Juyung Seo
Hello, On Sun, Mar 25, 2012 at 4:42 PM, Hyoyoung Chang hyoyo...@gmail.com wrote: in most of cases, Daniel is right. But i added this for item_fields_update   if ((!itf) || (itf ELM_GENLIST_ITEM_FIELD_CONTENT))     {        _it-content_objs = _item_content_unrealize(_it, VIEW(_it),        

Re: [E-devel] [patch] elm_genlist - add merging edc strings list

2012-03-25 Thread Hyoyoung Chang
On Sun, Mar 25, 2012 at 5:19 PM, Daniel Juyung Seo seojuyu...@gmail.com wrote: Hello, On Sun, Mar 25, 2012 at 4:42 PM, Hyoyoung Chang hyoyo...@gmail.com wrote: in most of cases, Daniel is right. But i added this for item_fields_update   if ((!itf) || (itf ELM_GENLIST_ITEM_FIELD_CONTENT))  

Re: [E-devel] [patch] elm_genlist - add merging edc strings list

2012-03-24 Thread The Rasterman
On Fri, 23 Mar 2012 19:19:55 +0900 Hyoyoung Chang hyoyo...@gmail.com said: tnx! looked at it - in svn! :) Dear all I add like a routine in previous patch. It add merging routines to realize functions. also i removed elm_widget_stringlist_free(cons) because all of it is freed at

[E-devel] [patch] elm_genlist - add merging edc strings list

2012-03-23 Thread Hyoyoung Chang
Dear all I add like a routine in previous patch. It add merging routines to realize functions. also i removed elm_widget_stringlist_free(cons) because all of it is freed at item_unrealize. Thanks Index: elementary/src/lib/elm_genlist.c