Re: [E-devel] need advice for refactorying elc_multibuttonentry

2013-01-17 Thread Daniel Juyung Seo
+1 here :) Multimuttonentry should have been reviewed correctly since the beginning. Thanks for the refactoring but you should NOT: 1) break C API. (you confirmed) 2) break signals. (you confirmed) 3) break theme API. Existing theme should work. 4) break any apps which were using multibuttonentry

Re: [E-devel] need advice for refactorying elc_multibuttonentry

2013-01-17 Thread Gustavo Lima Chaves
* Sohyun Kim [2013-01-17 14:48:08 +0900]: Hi, Sohyun. I think you might have broken theme API. If you kept the C API, though, I happy to ignore the other borkage, because this widget's code really sucks big time, as of now. You have my blessing to replace it. > Hello, this is Sohyun Kim. > I ne

[E-devel] need advice for refactorying elc_multibuttonentry

2013-01-16 Thread Sohyun Kim
Hello, this is Sohyun Kim. I need your advice for refactorying the elc_multibuttonentry widget. When we used it in the tizen project, we found several fatal problems, and they were very complex to fix. Because multibuttonentry had structural weakness, as I fixed bugs, it increased the complexity.