Re: [E-devel] New patch for entranced and entrance

2006-08-30 Thread Eugen Minciu
Hi, here's another patch for entrance.OK, I've done this acccording to what raster told me, I hope I understood these things properly.1) A shell should be run, so the users's profile is loaded. After thinking about it, this is a great idea indeed, this way if I have a ~/bin in my PATH my wm can

Re: [E-devel] New patch for entranced and entrance

2006-08-28 Thread Eugen Minciu
On Mon, 28 Aug 2006 08:01:54 +0300 Eugen Minciu [EMAIL PROTECTED] wrote: And here is another version that frees the memory it allocates in the correct place. Sorry about so many posts on what should have been a simple thingie. It's the first patch I'm sending you guys, I promise I'll try to

Re: [E-devel] New patch for entranced and entrance

2006-08-28 Thread Eugen Minciu
On Mon, 28 Aug 2006 14:29:08 +0100 Essien Ita Essien [EMAIL PROTECTED] wrote: Well .. then maybe we shouldn't clearenv() in the first place? We may not need to, since setenv(x,y,1) is called, which overwrites the var's contents anyway. I didn't want to try it before because I suspected

Re: [E-devel] New patch for entranced and entrance

2006-08-28 Thread Essien Ita Essien
Eugen Minciu wrote: On Mon, 28 Aug 2006 08:01:54 +0300 Eugen Minciu [EMAIL PROTECTED] wrote: And here is another version that frees the memory it allocates in the correct place. Sorry about so many posts on what should have been a simple thingie. It's the first patch I'm sending you

Re: [E-devel] New patch for entranced and entrance

2006-08-28 Thread The Rasterman
On Mon, 28 Aug 2006 16:57:13 +0300 Eugen Minciu [EMAIL PROTECTED] babbled: On Mon, 28 Aug 2006 14:29:08 +0100 Essien Ita Essien [EMAIL PROTECTED] wrote: Well .. then maybe we shouldn't clearenv() in the first place? We may not need to, since setenv(x,y,1) is called, which overwrites the

Re: [E-devel] New patch for entranced and entrance

2006-08-28 Thread The Rasterman
On Mon, 28 Aug 2006 16:55:19 +0200 Sebastian Dransfeld [EMAIL PROTECTED] babbled: Eugen Minciu wrote: On Mon, 28 Aug 2006 14:29:08 +0100 Essien Ita Essien [EMAIL PROTECTED] wrote: Well .. then maybe we shouldn't clearenv() in the first place? We may not need to, since setenv(x,y,1) is

Re: [E-devel] New patch for entranced and entrance

2006-08-28 Thread Justin Patrin
On 8/28/06, The Rasterman Carsten Haitzler [EMAIL PROTECTED] wrote: On Mon, 28 Aug 2006 16:55:19 +0200 Sebastian Dransfeld [EMAIL PROTECTED] babbled: Eugen Minciu wrote: On Mon, 28 Aug 2006 14:29:08 +0100 Essien Ita Essien [EMAIL PROTECTED] wrote: Well .. then maybe we shouldn't

Re: [E-devel] New patch for entranced and entrance

2006-08-28 Thread Essien Ita Essien
Justin Patrin wrote: On 8/28/06, The Rasterman Carsten Haitzler [EMAIL PROTECTED] wrote: On Mon, 28 Aug 2006 16:55:19 +0200 Sebastian Dransfeld [EMAIL PROTECTED] babbled: Eugen Minciu wrote: On Mon, 28 Aug 2006 14:29:08 +0100 Essien Ita Essien [EMAIL PROTECTED] wrote:

Re: [E-devel] New patch for entranced and entrance

2006-08-28 Thread Eugen Minciu
It _should_ inherit DISPLAY (as it's passed through a parameter to the function. This thing does work on my machine, remember?Also Essien told me he is currently working on fixing up session detection through ecore_desktop, so this may just be a case of our code not playing nice together ;) Could

Re: [E-devel] New patch for entranced and entrance

2006-08-28 Thread The Rasterman
On Tue, 29 Aug 2006 00:50:31 +0100 Essien Ita Essien [EMAIL PROTECTED] babbled: Justin Patrin wrote: On 8/28/06, The Rasterman Carsten Haitzler [EMAIL PROTECTED] wrote: On Mon, 28 Aug 2006 16:55:19 +0200 Sebastian Dransfeld [EMAIL PROTECTED] babbled: Eugen Minciu wrote:

Re: [E-devel] New patch for entranced and entrance

2006-08-28 Thread Sebastian Dransfeld
Carsten Haitzler (The Rasterman) wrote: On Mon, 28 Aug 2006 16:55:19 +0200 Sebastian Dransfeld [EMAIL PROTECTED] babbled: Eugen Minciu wrote: On Mon, 28 Aug 2006 14:29:08 +0100 Essien Ita Essien [EMAIL PROTECTED] wrote: Well .. then maybe we shouldn't clearenv() in the first place? We may

Re: [E-devel] New patch for entranced and entrance

2006-08-28 Thread The Rasterman
On Tue, 29 Aug 2006 06:12:47 +0200 Sebastian Dransfeld [EMAIL PROTECTED] babbled: Carsten Haitzler (The Rasterman) wrote: On Mon, 28 Aug 2006 16:55:19 +0200 Sebastian Dransfeld [EMAIL PROTECTED] babbled: Eugen Minciu wrote: On Mon, 28 Aug 2006 14:29:08 +0100 Essien Ita Essien [EMAIL

[E-devel] New patch for entranced and entrance

2006-08-27 Thread Eugen Minciu
Here's a new patch for entranced and entrance. This time I did what the comment suggested in both places. I used strtok and parsed directly into a char ** which then gets run by execv/execvp. If my code strikes you as ugly (I'm not sure if it should) be sure to tell me what I did wrong and

Re: [E-devel] New patch for entranced and entrance

2006-08-27 Thread Essien Ita Essien
Eugen Minciu wrote: On Sun, 27 Aug 2006 22:30:58 +0300 Eugen Minciu [EMAIL PROTECTED] wrote: Sorry, it seems that if I use this I get some issues within e. If I try to start an application from the run command thingie, it will tell me that the application failed to start. I'll try to see

Re: [E-devel] New patch for entranced and entrance

2006-08-27 Thread Eugen Minciu
On Sun, 27 Aug 2006 22:36:31 +0300 Eugen Minciu [EMAIL PROTECTED] wrote: I've figured out what causes the problem, but I don't know how to fix it this time. This happens because once I replace the execl() call in entrance_session_start_user_session, the environment variables for the user are

Re: [E-devel] New patch for entranced and entrance

2006-08-27 Thread Eugen Minciu
On Sun, 27 Aug 2006 23:49:40 +0100 Essien Ita Essien [EMAIL PROTECTED] wrote: Indeed. But it seems that just passing the environ pointer to an execve() call is not sufficient. What bash -l does is invoke /etc/profile ~/.bash_profile etc. So I need a way to parse those files (at least from a

Re: [E-devel] New patch for entranced and entrance

2006-08-27 Thread Eugen Minciu
On Sun, 27 Aug 2006 23:22:38 +0300 Eugen Minciu [EMAIL PROTECTED] wrote: And finally, I've got it. The problem was in entrance_auth_setup_environment() which called clearenv(). For some reasong calling getenv() there did not return the path either. So I added an extra parameter, const char