Re: [E-devel] PATCH: duplicated XDG_DATA_DIRS fix

2015-01-05 Thread Thanatermesis
As: http://www.enlightenment.org/ss/e-54aa94e4da9742.14698270.jpg Where the real bug happens is where my patch is, but after that there's hardcoded /usr/share and /usr/local/share in the case that we dont have XDG_DATA_DIRS set (which the default dirs are these ones, so having them hardcoded

Re: [E-devel] PATCH: duplicated XDG_DATA_DIRS fix

2015-01-03 Thread Sebastian Dransfeld
Den Jan 2, 2015 kl. 22:18 skrev Davide Andreoli d...@gurumeditation.it: 2014-12-31 19:31 GMT+01:00 Thanatermesis thanatermesis.e...@gmail.com: Right, there's also the case of /usr/local which i have not considered (only /usr and /usr/local), so this updated patch fixes it:

Re: [E-devel] PATCH: duplicated XDG_DATA_DIRS fix

2015-01-02 Thread Davide Andreoli
2014-12-31 19:31 GMT+01:00 Thanatermesis thanatermesis.e...@gmail.com: Right, there's also the case of /usr/local which i have not considered (only /usr and /usr/local), so this updated patch fixes it: http://pastebin.com/1Nn4rETD by other side these trailing slashes seems like to be made

Re: [E-devel] PATCH: duplicated XDG_DATA_DIRS fix

2014-12-31 Thread Thanatermesis
Right, there's also the case of /usr/local which i have not considered (only /usr and /usr/local), so this updated patch fixes it: http://pastebin.com/1Nn4rETD by other side these trailing slashes seems like to be made wrongly by your OS creating the XDG_DATA_DIRS variable, they should not

Re: [E-devel] PATCH: duplicated XDG_DATA_DIRS fix

2014-12-30 Thread Thanatermesis
Back from some holidays (more or less) My previous patch was wrong, since strcmp returns the inverse of what I expected (zero if success), so this is the correct one: http://pastebin.com/xDj755cL Should I push it to master? 2014-12-24 13:34 GMT+01:00 Thanatermesis

Re: [E-devel] PATCH: duplicated XDG_DATA_DIRS fix

2014-12-30 Thread Davide Andreoli
2014-12-30 16:57 GMT+01:00 Thanatermesis thanatermesis.e...@gmail.com: Back from some holidays (more or less) My previous patch was wrong, since strcmp returns the inverse of what I expected (zero if success), so this is the correct one: http://pastebin.com/xDj755cL Should I push it to

Re: [E-devel] PATCH: duplicated XDG_DATA_DIRS fix

2014-12-30 Thread Jean-Philippe André
Hi, On Wed, Dec 31, 2014 at 3:04 AM, Davide Andreoli d...@gurumeditation.it wrote: 2014-12-30 16:57 GMT+01:00 Thanatermesis thanatermesis.e...@gmail.com: Back from some holidays (more or less) My previous patch was wrong, since strcmp returns the inverse of what I expected (zero if

Re: [E-devel] PATCH: duplicated XDG_DATA_DIRS fix

2014-12-24 Thread Thanatermesis
Not sure how you got /usr/share to be duplicated, it is not the case here... That's exactly what my patch does :), as: % echo $XDG_DATA_DIRS | tr ':' '\n' | sort /opt/e/share /opt/e/share/enlightenment /usr/local/share /usr/share for your case, since you don't have /usr as default prefix

Re: [E-devel] PATCH: duplicated XDG_DATA_DIRS fix

2014-12-23 Thread Jean-Philippe André
Hi, Not sure how you got /usr/share to be duplicated, it is not the case here... On Wed, Dec 24, 2014 at 1:13 AM, Thanatermesis thanatermesis.e...@gmail.com wrote: If you run: echo $XDG_DATA_DIRS | tr ':' '\n' | sort you will see that you have a duplicated one % echo $XDG_DATA_DIRS