Re: [E-devel] PATCH: eina_stringshare in epsilon

2008-12-18 Thread The Rasterman
On Thu, 18 Dec 2008 15:55:44 +0100 Viktor Kojouharov babbled: looks ok to me. as i said - stringshare is good - use it for string tokens that MAY be used elsewhere or multiple times - if you absolutely know they wont be, then no point. > I've attached an updated patch that removed the redundant

Re: [E-devel] PATCH: eina_stringshare in epsilon

2008-12-18 Thread Viktor Kojouharov
I've attached an updated patch that removed the redundant if's. Everything else is pretty much the same. So if no one has any objections in the near future, I'd like to commit it. On Mon, 2008-12-15 at 10:00 +1100, Carsten Haitzler wrote: > On Sun, 14 Dec 2008 15:24:06 +0100 Sebastian Dransfeld >

Re: [E-devel] PATCH: eina_stringshare in epsilon

2008-12-14 Thread The Rasterman
On Sun, 14 Dec 2008 15:24:06 +0100 Sebastian Dransfeld babbled: > Viktor Kojouharov wrote: > > Hi, > > > > I'm trying to bring epsilon into the 21st century with some > > eina_stringshare love. The attached patch should convert all epsilon > > strings to consts that use eina_stringshare_*. Pleas

Re: [E-devel] PATCH: eina_stringshare in epsilon

2008-12-14 Thread Gustavo Sverzut Barbieri
On Sun, Dec 14, 2008 at 1:16 PM, Viktor Kojouharov wrote: > On Sun, 2008-12-14 at 12:56 -0200, Gustavo Sverzut Barbieri wrote: >> On Sun, Dec 14, 2008 at 12:24 PM, Sebastian Dransfeld >> wrote: >> > Viktor Kojouharov wrote: >> >> Hi, >> >> >> >> I'm trying to bring epsilon into the 21st century w

Re: [E-devel] PATCH: eina_stringshare in epsilon

2008-12-14 Thread Sebastian Dransfeld
Viktor Kojouharov wrote: > On Sun, 2008-12-14 at 12:56 -0200, Gustavo Sverzut Barbieri wrote: >> On Sun, Dec 14, 2008 at 12:24 PM, Sebastian Dransfeld >> wrote: >>> Viktor Kojouharov wrote: Hi, I'm trying to bring epsilon into the 21st century with some eina_stringshare love. T

Re: [E-devel] PATCH: eina_stringshare in epsilon

2008-12-14 Thread Viktor Kojouharov
On Sun, 2008-12-14 at 12:56 -0200, Gustavo Sverzut Barbieri wrote: > On Sun, Dec 14, 2008 at 12:24 PM, Sebastian Dransfeld > wrote: > > Viktor Kojouharov wrote: > >> Hi, > >> > >> I'm trying to bring epsilon into the 21st century with some > >> eina_stringshare love. The attached patch should conv

Re: [E-devel] PATCH: eina_stringshare in epsilon

2008-12-14 Thread Gustavo Sverzut Barbieri
On Sun, Dec 14, 2008 at 12:24 PM, Sebastian Dransfeld wrote: > Viktor Kojouharov wrote: >> Hi, >> >> I'm trying to bring epsilon into the 21st century with some >> eina_stringshare love. The attached patch should convert all epsilon >> strings to consts that use eina_stringshare_*. Please review i

Re: [E-devel] PATCH: eina_stringshare in epsilon

2008-12-14 Thread Sebastian Dransfeld
Viktor Kojouharov wrote: > Hi, > > I'm trying to bring epsilon into the 21st century with some > eina_stringshare love. The attached patch should convert all epsilon > strings to consts that use eina_stringshare_*. Please review it. Strings which are probably unique (like paths) should not be st

Re: [E-devel] PATCH: eina_stringshare in epsilon

2008-12-14 Thread Gustavo Sverzut Barbieri
On Sun, Dec 14, 2008 at 10:59 AM, Viktor Kojouharov wrote: > Hi, > > I'm trying to bring epsilon into the 21st century with some > eina_stringshare love. The attached patch should convert all epsilon > strings to consts that use eina_stringshare_*. Please review it. looks good, but you can just r