Re: [E-devel] [Patch] Entry - Password show last input patch

2011-04-28 Thread Tom Hacohen
Dear Daniel, Thanks for forwarding this patch, I will review it soon. -- Tom. On Thu, 2011-04-28 at 14:38 +0900, Daniel Juyung Seo wrote: > Dear all, I forward Shilpaonkar Singh's entry patch to mailing list. > Please find the attached mail and patch files. > > > --- Original Message -

Re: [E-devel] [Patch] Entry - Password show last input patch

2011-04-28 Thread Tom Hacohen
Dear Shilpa, Here are my comments: 1. Looking at the changes you did for elementary: I don't see why you even need them. Just change the env var to EDJE_ENTRY_PASSWORD_SHOW_LAST and skip all the things you had to do in elm... Makes no sense to have those in ELM. By doing that you get the added val

Re: [E-devel] E SVN: cedric trunk/elementary/src/lib

2011-04-28 Thread Cedric BAIL
On Thu, Apr 28, 2011 at 4:03 AM, Daniel Juyung Seo wrote: > Hi Cedric, > I think ethumb check routine had to be added as well. > It had build break without ethumb installation. > I fixed it. Can you check it? > http://trac.enlightenment.org/e/changeset/58982 Thanks, I forgot about that configure

Re: [E-devel] [Patch] Entry - Password show last input patch

2011-04-28 Thread Tom Hacohen
Regarding bullet 4: done, in svn, 58991. I tested it with your patches and it seems to work, please also update and make sure. Thanks, Tom. On Thu, 2011-04-28 at 10:58 +0300, Tom Hacohen wrote: > Dear Shilpa, > > Here are my comments: > 1. Looking at the changes you did for elementary: I don't

Re: [E-devel] [Patch] Entry - Password show last input patch

2011-04-28 Thread SHILPAONKAR SINGH
Dear Tom, Please find my reply inline. 1. Looking at the changes you did for elementary: I don't see why you even need them. Just change the env var to EDJE_ENTRY_PASSWORD_SHOW_LAST and skip all the things you had to do in elm... Makes no sense to have those in ELM. By doing that you get the added

Re: [E-devel] E SVN: cedric trunk/enki/src/bin

2011-04-28 Thread Atton Jonathan
hum 2011/4/28 Enlightenment SVN > Log: > enki: always delete child before deleting parent. > > > Author: cedric > Date: 2011-04-28 02:04:02 -0700 (Thu, 28 Apr 2011) > New Revision: 58993 > Trac: http://trac.enlightenment.org/e/changeset/58993 > > Modified: > trunk/enki/src

Re: [E-devel] E SVN: cedric trunk/enlil/src/enlil

2011-04-28 Thread Vincent Torri
On Thu, 28 Apr 2011, Enlightenment SVN wrote: > Log: > enlil: azy don't like beeing called with NULL client. shouldn't this be fixed in azy instead ? Vincent > > > Author: cedric > Date: 2011-04-28 02:03:03 -0700 (Thu, 28 Apr 2011) > New Revision: 58992 > Trac: http://tr

Re: [E-devel] [Patch] Entry - Password show last input patch

2011-04-28 Thread Tom Hacohen
Dear Shilpa, Please mark your changes in a more visible way next time. :P I can't understand who's who. My comments are also inlined. On Thu, 2011-04-28 at 09:21 +, SHILPAONKAR SINGH wrote: > Dear Tom, > > Please find my reply inline. > 1. Looking at the changes you did for elementary: I don

Re: [E-devel] [Patch] Entry - Password show last input patch

2011-04-28 Thread Tom Hacohen
P.S: I committed the textblock part of the patch, that one was good, and I have no comments about that one. -- Tom. On Thu, 2011-04-28 at 12:42 +0300, Tom Hacohen wrote: > Dear Shilpa, > > Please mark your changes in a more visible way next time. :P I can't > understand who's who. > > My commen

Re: [E-devel] [Patch] Entry - Password show last input patch

2011-04-28 Thread SHILPAONKAR SINGH
Dear Tom and Raster, Please find my reply inline in a more visible manner :). > Please find my reply inline. > 1. Looking at the changes you did for elementary: I don't see why you > even need them. Just change the env var to EDJE_ENTRY_PASSWORD_SHOW_LAST > and skip all the thin

[E-devel] Changing elm_entry/label API - wrapping

2011-04-28 Thread Tom Hacohen
Dear All, How are you? Currently elm_entry and elm_label have: elm_entry_line_wrap_set elm_entry_line_char_wrap_set Which is bad, I want to have elm_entry_line_wrap_set(obj, WRAP_TYPE) WRAP_TYPE can be either WRAP_NONE, WRAP_CHAR, WRAP_WORD or WRAP_MIXED (which is not even supported in elm at t

Re: [E-devel] Changing elm_entry/label API - wrapping

2011-04-28 Thread Atton Jonathan
ok 2011/4/28 Tom Hacohen > Dear All, > > How are you? > > Currently elm_entry and elm_label have: > elm_entry_line_wrap_set > elm_entry_line_char_wrap_set > > Which is bad, I want to have > elm_entry_line_wrap_set(obj, WRAP_TYPE) > > WRAP_TYPE can be either WRAP_NONE, WRAP_CHAR, WRAP_WORD or WRA

Re: [E-devel] Changing elm_entry/label API - wrapping

2011-04-28 Thread Daniel Juyung Seo
Right. This is good. +1 Daniel Juyung Seo (SeoZ) On Thu, Apr 28, 2011 at 11:15 PM, Atton Jonathan wrote: > ok > > 2011/4/28 Tom Hacohen > > > Dear All, > > > > How are you? > > > > Currently elm_entry and elm_label have: > > elm_entry_line_wrap_set > > elm_entry_line_char_wrap_set > > > > Whic

Re: [E-devel] [Patch] Entry - Password show last input patch

2011-04-28 Thread Tom Hacohen
Dear Shilpa, Please start by splitting the patches and sending two different patches. It's really hard for me to further review the patches like this (that I don't know what I need to review and what not). Regarding what we discussed. Lets wait for others to reply, though honestly, I like setting

Re: [E-devel] E SVN: cedric IN trunk/eio: . src/lib

2011-04-28 Thread Vincent Torri
On Thu, 28 Apr 2011, Enlightenment SVN wrote: > Log: > eio: also copy xattr when available. > > > Author: cedric > Date: 2011-04-28 09:45:45 -0700 (Thu, 28 Apr 2011) > New Revision: 59015 > Trac: http://trac.enlightenment.org/e/changeset/59015 > > Modified: > trunk/eio/con

[E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Eduardo Felipe
Folks, Mac OS X does not provide an implementation of clock_gettime() even though it's POSIX, but it does provide a fast high-resolution monotonic clock through mach specific APIs that are perfectly suited for usage in ecore_timer. Without this patch ecore_timer throws a critical warning on Mac O

Re: [E-devel] ecore: request to drop printf warning

2011-04-28 Thread Eduardo Felipe
Folks, Sorry to bring the thread back from the ashes but this warning did annoy me to such a great extent that I just submitted a patch to implement a monotonic clock using Mac OS X's API. Now we can get rid of this warning. Cheers, Eduardo Felipe. On Sat, Apr 9, 2011 at 6:28 AM, Carsten Haitzl

Re: [E-devel] ecore: request to drop printf warning

2011-04-28 Thread Eduardo Felipe
I submitted a patch to the mailing list, since I don't have commit access to SVN. Was my mail lost on the tubes? Cheers, Eduardo Felipe. On Thu, Apr 28, 2011 at 3:08 PM, Lucas De Marchi wrote: > On Thu, Apr 28, 2011 at 11:58 AM, Eduardo Felipe > wrote: >> Folks, >> >> Sorry to bring the threa

Re: [E-devel] ecore: request to drop printf warning

2011-04-28 Thread Lucas De Marchi
On Thu, Apr 28, 2011 at 11:58 AM, Eduardo Felipe wrote: > Folks, > > Sorry to bring the thread back from the ashes but this warning did > annoy me to such a great extent that I just submitted a patch to > implement a monotonic clock using Mac OS X's API. Now we can get rid > of this warning. I've

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Vincent Torri
On Thu, 28 Apr 2011, Eduardo Felipe wrote: > Folks, > > Mac OS X does not provide an implementation of clock_gettime() even > though it's POSIX, but it does provide a fast high-resolution > monotonic clock through mach specific APIs that are perfectly suited > for usage in ecore_timer. > > Witho

[E-devel] Default widget/dialog/module "heading" text color

2011-04-28 Thread Don Harden
Hello E17 Developers, First off I would like to say many thanks and kudos for Enlightenment. It's a fabulous window manager being feature-rich, highly customizable, and easy to use. Every time I have to jump on a box that has only KDE, or even worse Gnome, I am thankful yet again for E17.

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Eduardo Felipe
I would appreciate if I'm mentioned as the author of the patch and the commit message is preserved. This is the third time a patch of mine is accepted without attribution, and I think it shows a lack of care for input from users. Eduardo. On Thu, Apr 28, 2011 at 3:43 PM, Vincent Torri wrote: > >

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Vincent Torri
On Thu, 28 Apr 2011, Eduardo Felipe wrote: > I would appreciate if I'm mentioned as the author of the patch and the > commit message is preserved. > This is the third time a patch of mine is accepted without > attribution, and I think it shows a lack of care for input from users. what I can do

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Vincent Torri
On Thu, 28 Apr 2011, Vincent Torri wrote: > > > On Thu, 28 Apr 2011, Eduardo Felipe wrote: > >> I would appreciate if I'm mentioned as the author of the patch and the >> commit message is preserved. >> This is the third time a patch of mine is accepted without >> attribution, and I think it show

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Eduardo Felipe
Reverting is dangerous. I guess should have written the changes to the Changelog myself. Should I write it now or would you do it for me? On Thu, Apr 28, 2011 at 4:21 PM, Vincent Torri wrote: > > > On Thu, 28 Apr 2011, Vincent Torri wrote: > >> >> >> On Thu, 28 Apr 2011, Eduardo Felipe wrote: >>

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Vincent Torri
On Thu, 28 Apr 2011, Eduardo Felipe wrote: > Reverting is dangerous. I guess should have written the changes to the > Changelog myself. Should I write it now or would you do it for me? do it, so that you'll put exactly what you want. Vincent > > On Thu, Apr 28, 2011 at 4:21 PM, Vincent Torri

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Eduardo Felipe
So here is the patch for the ChangeLog. Thanks, Eduardo Felipe. On Thu, Apr 28, 2011 at 4:25 PM, Vincent Torri wrote: > > > On Thu, 28 Apr 2011, Eduardo Felipe wrote: > >> Reverting is dangerous. I guess should have written the changes to the >> Changelog myself. Should I write it now or would

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Vincent Torri
On Thu, 28 Apr 2011, Eduardo Felipe wrote: > So here is the patch for the ChangeLog. > > Thanks, done, sorry for not mentioning you Vincent > > Eduardo Felipe. > > On Thu, Apr 28, 2011 at 4:25 PM, Vincent Torri wrote: >> >> >> On Thu, 28 Apr 2011, Eduardo Felipe wrote: >> >>> Reverting is da

Re: [E-devel] [PATCH] Add monotonic clock implementation for Mac OS X

2011-04-28 Thread Lucas De Marchi
On Thu, Apr 28, 2011 at 1:18 PM, Eduardo Felipe wrote: > I would appreciate if I'm mentioned as the author of the patch and the > commit message is preserved. > This is the third time a patch of mine is accepted without > attribution, and I think it shows a lack of care for input from users. Anot

[E-devel] [Patch] elm_conform patch from Prince

2011-04-28 Thread Daniel Juyung Seo
Dear all, this is an email from Prince. Please find his email and attachment. Thanks. Daniel Juyung Seo (SeoZ) --- Original Message --- Sender : PRINCE KUMAR DUBEY Date : 2011-04-28 17:38 (GMT+09:00) Title : elm_conformant SVN Patch. Dear Mr Seo, Can you please post the attached elm_con

Re: [E-devel] composite problem

2011-04-28 Thread The Rasterman
On Tue, 26 Apr 2011 12:00:09 +0200 Mathieu Taillefumier said: next time you get it... go to a text console - get a backtrace. send it here. :) > Hello, > > > > have u tried gdb attaching to e - did it segv? > > http://trac.enlightenment.org/e/wiki/Debugging > > I might be able to help on this

Re: [E-devel] E SVN: raster trunk/evas_generic_loaders

2011-04-28 Thread The Rasterman
On Wed, 27 Apr 2011 14:06:59 +0200 (CEST) Vincent Torri said: > > can do - that.. once it becomes useful to do it. ie.. when there is > 1 > > binary :) > > pdf, dvi, ps djvu. once someone starts another blob of src for another binary loader.. it can be put into common shared code. it doesn't ac

Re: [E-devel] another feezing problem

2011-04-28 Thread The Rasterman
On Thu, 28 Apr 2011 03:51:35 +0300 المسالم المسالمة said: works for me... :) > hello all > > = > > i discovered this week another freezing problem > > but i forget to report about it > > so > > you see > > when you try to shutdown your computer > > you will get five choices wh

Re: [E-devel] Patch to the engage module

2011-04-28 Thread The Rasterman
On Thu, 28 Apr 2011 06:29:16 +0200 Alek Mosingiewicz said: i hate to discourage people actively scratching their itches... but it'd be oh so much nicer to provide a patch :) > Hi, > >Previously the Engage panel failed to show up after minimizing a > previously maximized window if the autoh

Re: [E-devel] Default widget/dialog/module "heading" text color

2011-04-28 Thread The Rasterman
On Thu, 28 Apr 2011 16:15:02 -0400 Don Harden said: > Hello E17 Developers, > > First off I would like to say many thanks and kudos for Enlightenment. > It's a fabulous window manager being feature-rich, highly customizable, > and easy to use. Every time I have to jump on a box that has on

Re: [E-devel] [Patch] elm_conform patch from Prince

2011-04-28 Thread sangho park
if use --disable-ecore-x, build break.. pls check this. elm_conform.c: In function ‘_conformant_part_sizing_eval’: elm_conform.c:134:43: warning: unused parameter ‘obj’ elm_conform.c:134:69: warning: unused parameter ‘part_type’ elm_conform.c: In function ‘_content_resize_event_cb’: elm_conform.c:

Re: [E-devel] ELM_LIST PROBLEM.

2011-04-28 Thread The Rasterman
On Thu, 28 Apr 2011 15:18:48 +0900 ChunEon Park said: evas_object_ref() evas_object_unref() :) can always use these to make sure the obj isnt deleted while its in use (things being walked etc.) :) > Hi, This is Hermet. > > I have a problem at elm_list. > > When user delete the list in the

Re: [E-devel] splitting elm_map into a new library

2011-04-28 Thread The Rasterman
On Wed, 27 Apr 2011 22:05:57 +0200 Atton Jonathan said: sangho was talking of doing this too. sangho? > hello great people of big E, > > We had a discussion about splitting elm_map into a new library which will > manage all coordinates methods (route, download tiles ...). This way elm_map > wil

Re: [E-devel] [PATCH] Add ecore_imf_context_autocapital_type_{set, get}, ecore_imf_context_prediction_allow_{set, get}

2011-04-28 Thread The Rasterman
On Mon, 25 Apr 2011 19:01:09 +0900 Jihoon Kim said: thanks! very muchly. :) in svn it is! (added changelog too for you) > Thank you for your valuable comment. > > I fixed the patch file and send again according to your advice. > > Would you please review it again? :) > > -Original Messag

Re: [E-devel] Proposal on extending elm_notify functionalities for having title support

2011-04-28 Thread The Rasterman
On Tue, 26 Apr 2011 15:10:58 +0200 Atton Jonathan said: agreed. elm_notify is popping up SOME generic object thing in the window (at some location) maybe having it animate on show and hide, and contain some content. what rajeev is suggesting is some pre-defined standard content COMBINEd with elm_

Re: [E-devel] discussion of elementary header separation.

2011-04-28 Thread The Rasterman
On Wed, 27 Apr 2011 22:24:48 +0900 Daniel Juyung Seo said: i'm in the "1 header to rule them all and in the darkness bind them" camp... but also in the "throw those docs in the header" camp and frankly.. we already have some there due to structs and enums being documented. :) > Any further discu

Re: [E-devel] [Patch] els_scroller default wheel control

2011-04-28 Thread The Rasterman
On Wed, 27 Apr 2011 09:51:05 +0900 sangho park said: approved. commit it to svn :) (you have access) :) > Dear all, > > this patch is for enable / disable the default els_scroller's wheel control. > > when I use elm_map, map's default wheel control means zoom in / out. > so enable / disable el

Re: [E-devel] E SVN: raster trunk/evas_generic_loaders

2011-04-28 Thread Vincent Torri
On Fri, 29 Apr 2011, Carsten Haitzler (The Rasterman) wrote: > On Wed, 27 Apr 2011 14:06:59 +0200 (CEST) Vincent Torri > said: > >>> can do - that.. once it becomes useful to do it. ie.. when there is > 1 >>> binary :) >> >> pdf, dvi, ps djvu. > > once someone starts another blob of src for ano

Re: [E-devel] E SVN: raster IN trunk/ecore: . src/lib/ecore_imf

2011-04-28 Thread Vincent Torri
On Thu, 28 Apr 2011, Enlightenment SVN wrote: > Log: > From: Jihoon Kim > Subject: [E-devel] [PATCH] Add ecore_imf_context_autocapital_type_{set, get}, > > To support the autocapitalization feature, I'd like to add > ecore_imf_context_autocapital_type_{set,get} API. > I will implement the a

Re: [E-devel] E SVN: raster trunk/evas_generic_loaders

2011-04-28 Thread The Rasterman
On Fri, 29 Apr 2011 08:02:12 +0200 (CEST) Vincent Torri said: > > > On Fri, 29 Apr 2011, Carsten Haitzler (The Rasterman) wrote: > > > On Wed, 27 Apr 2011 14:06:59 +0200 (CEST) Vincent Torri > > said: > > > >>> can do - that.. once it becomes useful to do it. ie.. when there is > 1 > >>> bina

Re: [E-devel] Patch to the engage module

2011-04-28 Thread hannes.janet...@gmail.com
On Thu, Apr 28, 2011 at 6:29 AM, Alek Mosingiewicz wrote: > Hi, > >  Previously the Engage panel failed to show up after minimizing a previously > maximized window if the autohide was set to Overlap. It irked me, so I went > through the code and patched it. The new version of the e_mod_main.c is >

Re: [E-devel] Proposal on extending elm_notify functionalities for having title support

2011-04-28 Thread Daniel Juyung Seo
1. Add this feature to notify. 2. Make a new widget 3. Use elm_layout 1 doesn't look so promising. I prefer 2. Those kind of combination(title, content, action area) is common I think. We can do this by 3 even now :) But still 2 is useful :) Thanks. Daniel Juyung Seo (SeoZ) On Fri, Apr 29, 2011

Re: [E-devel] discussion of elementary header separation.

2011-04-28 Thread Daniel Juyung Seo
Ok, I'm going to make a proposal with one widget which is very easy. Put documents to 1 header. (Elementary.h) Thanks. Daniel Juyung Seo (SeoZ) On Fri, Apr 29, 2011 at 2:51 PM, Carsten Haitzler wrote: > On Wed, 27 Apr 2011 22:24:48 +0900 Daniel Juyung Seo > > said: > > i'm in the "1 header to r

Re: [E-devel] [Patch] els_scroller default wheel control

2011-04-28 Thread Daniel Juyung Seo
It's already in SVN :) Thanks. Daniel Juyung Seo (SeoZ) On Fri, Apr 29, 2011 at 3:03 PM, Carsten Haitzler wrote: > On Wed, 27 Apr 2011 09:51:05 +0900 sangho park said: > > approved. commit it to svn :) (you have access) :) > > > Dear all, > > > > this patch is for enable / disable the default e

Re: [E-devel] [Patch] els_scroller default wheel control

2011-04-28 Thread The Rasterman
On Fri, 29 Apr 2011 15:35:26 +0900 Daniel Juyung Seo said: pfpft! :-P :) > It's already in SVN :) > > Thanks. > Daniel Juyung Seo (SeoZ) > > On Fri, Apr 29, 2011 at 3:03 PM, Carsten Haitzler wrote: > > > On Wed, 27 Apr 2011 09:51:05 +0900 sangho park said: > > > > approved. commit it to

[E-devel] [Review] [Patch] Evas - evas_object_map_ y-invert case for Native Surface

2011-04-28 Thread Sung W. Park
Hi all, As I was testing evas_gl, I've ran into a bug when I'm using the evas_object_map_* functions. I don't necessarily want to say it's a bug because it did say // FIXME: handle yinvert ERR("not handling inverted y case for map"); So i'm submitting a patch that handles the yinvert case. Inde