[E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread SHILPA ONKAR SINGH
Hi All, Please find attached patch for new elementary widget elm_colorpalette.c. Change description: New widget colorpalette added. elm_colorpalette is a color selection widget. It provides by default, theme specific set of Predefined colors and also allows to set a series of colors. The colors

Re: [E-devel] E SVN: tasn IN trunk/elementary/src: bin lib

2012-02-16 Thread Michael Blumenkrantz
On Thu, 16 Feb 2012 01:26:30 -0800 "Enlightenment SVN" wrote: > Log: > Elm pager: die pager, die! Use naviframe instead. > > Author: tasn > Date: 2012-02-16 01:26:30 -0800 (Thu, 16 Feb 2012) > New Revision: 68015 > Trac: http://trac.enlightenment.org/e/changeset/68015 > >

Re: [E-devel] E SVN: tasn IN trunk/elementary/src: bin lib

2012-02-16 Thread Tom Hacohen
See the docs, all clearly say "Use naviframe." I guess people are smart enough to use the same functions. Will update the wiki in a sec. -- Tom. On 16/02/12 11:29, Michael Blumenkrantz wrote: > On Thu, 16 Feb 2012 01:26:30 -0800 > "Enlightenment SVN" wrote: > >> Log: >> Elm pager: die pager, d

Re: [E-devel] E SVN: tasn IN trunk/elementary/src: bin lib

2012-02-16 Thread Tom Hacohen
Btw, thanks for the gracious 2-3 minutes to get around to changing the wiki page before posting this annoying email... -- Tom. On 16/02/12 11:29, Michael Blumenkrantz wrote: > On Thu, 16 Feb 2012 01:26:30 -0800 > "Enlightenment SVN" wrote: > >> Log: >> Elm pager: die pager, die! Use naviframe i

Re: [E-devel] E SVN: tasn IN trunk/elementary/src: bin lib

2012-02-16 Thread Michael Blumenkrantz
On Thu, 16 Feb 2012 11:34:09 +0200 Tom Hacohen wrote: > Btw, thanks for the gracious 2-3 minutes to get around to changing the > wiki page before posting this annoying email... > > -- > Tom. > > On 16/02/12 11:29, Michael Blumenkrantz wrote: > > On Thu, 16 Feb 2012 01:26:30 -0800 > > "Enlighte

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread Tom Hacohen
Will take a look soon, but please, next time you submit patches make sure to base yourself on current svn version... :| -- Tom. On 16/02/12 11:24, SHILPA ONKAR SINGH wrote: > > Hi All, > > Please find attached patch for new elementary widget elm_colorpalette.c. > > Change description: > New widg

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread Tom Hacohen
Widget looks nice. A bit plain maybe, but I guess it's somehow needed. Can't review API/code atm, sorry. -- Tom. On 16/02/12 11:44, Tom Hacohen wrote: > Will take a look soon, but please, next time you submit patches make > sure to base yourself on current svn version... :| > > -- > Tom. > > On

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread Michael Blumenkrantz
On Thu, 16 Feb 2012 11:48:25 +0200 Tom Hacohen wrote: > Widget looks nice. A bit plain maybe, but I guess it's somehow needed. > > Can't review API/code atm, sorry. > > -- > Tom. > > On 16/02/12 11:44, Tom Hacohen wrote: > > Will take a look soon, but please, next time you submit patches make

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread Tom Hacohen
Dunno, arleady deleted it. But yeah, being able to longpress/right click on a colour to edit the palette manually is possibly important -- Tom. On 16/02/12 11:55, Michael Blumenkrantz wrote: > On Thu, 16 Feb 2012 11:48:25 +0200 > Tom Hacohen wrote: > >> Widget looks nice. A bit plain maybe,

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread SHILPA ONKAR SINGH
Hi, This widget is a color palette, it takes the initial set of colors from theme and provides option to application to provide its own list of colors. Application can provide a option to pick a color from external source and then add the new set of colors to color palette widget. Thanks & Reg

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread Tom Hacohen
I understand that. With that being said, please consider doing what Mike and I suggested and make right click/longpress open color_selector to change that specific colour. -- Tom. On 16/02/12 13:07, SHILPA ONKAR SINGH wrote: > Hi, > > This widget is a color palette, it takes the initial set of

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread SHILPA ONKAR SINGH
Hi, We understand the below requirement, on right click/long press we should be able to open color selector and change the palette's specific color. we will work on this requirement and send it as an enhancement patch. hence please consider this patch as base version, review it and if ok please

Re: [E-devel] [Patch] Elementary: New custom widget Popup

2012-02-16 Thread Tom Hacohen
Your patch doesn't apply. Won't review. -- Tom. On 16/02/12 12:05, Rajeev Ranjan wrote: > Hi All, > Attached to the mail is the patch for a new custom elementary widget > elm_popup for your review. > > Change description: > New custom widget Popup added. > > elm_popup is an enhancement over

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread Tom Hacohen
On 16/02/12 13:26, SHILPA ONKAR SINGH wrote: > We understand the below requirement, on right click/long press we should > be able to open > > color selector and change the palette's specific color. > > we will work on this requirement and send it as an enhancement patch. > > hence please consider t

Re: [E-devel] [Patch][elm_map] Refactoring Elementary Map

2012-02-16 Thread Daniel Juyung Seo
I know you did a good job but this smells like a big blob of patch. (I didn't even read the code yet.) But we can't review this big patch at a time. Please split this patch as small as possible. Thanks. Daniel Juyung Seo (SeoZ) On Thu, Feb 16, 2012 at 8:14 PM, Bluezery wrote: > Hello, > > I hav

Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib

2012-02-16 Thread Daniel Juyung Seo
On Thu, Feb 16, 2012 at 8:39 PM, Enlightenment SVN < no-re...@enlightenment.org> wrote: > Log: > Reviewed elm_label's API and documentation > > > Author: woohyun > Date: 2012-02-16 03:39:07 -0800 (Thu, 16 Feb 2012) > New Revision: 68024 > Trac: http://trac.enlightenment.org/e

Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib

2012-02-16 Thread Gustavo Sverzut Barbieri
On Thu, Feb 16, 2012 at 4:38 AM, Enlightenment SVN wrote: > Log: > Reviewed elm_index's APIs and documentations. So many things to be >  modified :( I never see the point in having index as an independent widget as opposed to a decoration of indexed elements. Could anyone explain? I can explain

Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib

2012-02-16 Thread Gustavo Sverzut Barbieri
On Thu, Feb 16, 2012 at 10:20 AM, Enlightenment SVN wrote: > Log: > Add EINA_DEPRECATED ~ thx to Seoz > -EAPI void                        elm_label_fontsize_set(Evas_Object *obj, > int fontsize); > +EINA_DEPRECATED EAPI void                         > elm_label_fontsize_set(Evas_Object *obj, int

Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib

2012-02-16 Thread Tom Hacohen
On 16/02/12 15:09, Gustavo Sverzut Barbieri wrote: > Note: for next-elementary (post release) ProFUSION is working with > Samsung to fix the class hierarchy and add interfaces, the index could > be an interface own its own, or at least part of scrollable interface. > Yeah, that's the idea. So many

Re: [E-devel] E SVN: tasn trunk/eina/src/examples

2012-02-16 Thread Gustavo Sverzut Barbieri
On Thu, Feb 16, 2012 at 10:37 AM, Enlightenment SVN wrote: > @@ -47,8 +47,8 @@ >    /* define extra methods */ > >    type->type_size = sizeof(Animal_Type); > -   _ANIMAL_TYPE.breathe = _animal_breathe; > -   _ANIMAL_TYPE.eat = _animal_eat; > +   ANIMAL_TYPE(type)->breathe = _animal_breathe; > +

Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib

2012-02-16 Thread Tom Hacohen
On 16/02/12 15:11, Gustavo Sverzut Barbieri wrote: > On Thu, Feb 16, 2012 at 10:20 AM, Enlightenment SVN > wrote: >> Log: >> Add EINA_DEPRECATED ~ thx to Seoz > > >> -EAPI voidelm_label_fontsize_set(Evas_Object *obj, >> int fontsize); >> +EINA_DEPRECATED EAPI void

Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib

2012-02-16 Thread David Seikel
On Thu, 16 Feb 2012 15:10:44 +0200 Tom Hacohen wrote: > On 16/02/12 15:09, Gustavo Sverzut Barbieri wrote: > > Note: for next-elementary (post release) ProFUSION is working with > > Samsung to fix the class hierarchy and add interfaces, the index > > could be an interface own its own, or at least

[E-devel] Elementary improvements/review

2012-02-16 Thread Gustavo Sverzut Barbieri
Since people are patching elementary like crazy, goes an idea: Some time ago we've introduced couple of elm_layout styles to help applications writers. Could you replace manual assignment of box/table with them, making everyone's lives easier, particularly to the newcomers that may try to use test

Re: [E-devel] E SVN: tasn trunk/eina/src/examples

2012-02-16 Thread Tom Hacohen
On 16/02/12 15:14, Gustavo Sverzut Barbieri wrote: > no ugly, needless! :-( > > Consistency In the case of multi-level inheritance, having: type->version = bla; ANIMAL(type)->eat = _eat; HUMAN(type)->poop = _poop; is better than _HUMAN_TYPE.parent_class.parent_class.version =

Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib

2012-02-16 Thread Tom Hacohen
On 16/02/12 15:18, David Seikel wrote: > On Thu, 16 Feb 2012 15:10:44 +0200 Tom Hacohen > wrote: > >> On 16/02/12 15:09, Gustavo Sverzut Barbieri wrote: >>> Note: for next-elementary (post release) ProFUSION is working with >>> Samsung to fix the class hierarchy and add interfaces, the index >>>

Re: [E-devel] E SVN: tasn trunk/eina/src/examples

2012-02-16 Thread Gustavo Sverzut Barbieri
On Thu, Feb 16, 2012 at 11:30 AM, Tom Hacohen wrote: > On 16/02/12 15:14, Gustavo Sverzut Barbieri wrote: >> >> no ugly, needless! :-( >> >> > > Consistency In the case of multi-level inheritance, having: > > type->version = bla; > ANIMAL(type)->eat = _eat; > HUMAN(type)->poop

Re: [E-devel] E SVN: tasn trunk/eina/src/examples

2012-02-16 Thread David Seikel
On Thu, 16 Feb 2012 11:36:26 -0200 Gustavo Sverzut Barbieri wrote: > On Thu, Feb 16, 2012 at 11:30 AM, Tom Hacohen > wrote: > > On 16/02/12 15:14, Gustavo Sverzut Barbieri wrote: > >> > >> no ugly, needless! :-( > >> > >> > > > > Consistency In the case of multi-level inherit

Re: [E-devel] E SVN: woohyun trunk/elementary/src/lib

2012-02-16 Thread Gustavo Sverzut Barbieri
On Thu, Feb 16, 2012 at 11:18 AM, David Seikel wrote: > On Thu, 16 Feb 2012 15:10:44 +0200 Tom Hacohen > wrote: > >> On 16/02/12 15:09, Gustavo Sverzut Barbieri wrote: >> > Note: for next-elementary (post release) ProFUSION is working with >> > Samsung to fix the class hierarchy and add interface

Re: [E-devel] [Patch] Elementary: New custom widget Popup

2012-02-16 Thread Gustavo Sverzut Barbieri
On Thu, Feb 16, 2012 at 9:30 AM, Tom Hacohen wrote: > Your patch doesn't apply. Won't review. aside from that I wonder what it offers on top of elm_layout. Maybe just add a canned layout as we do with others? how does it compare with inwin? Isn't it better to provide styles for notify and inwin

Re: [E-devel] [Patch] Elementary: New custom widget Popup

2012-02-16 Thread Tom Hacohen
On 16/02/12 16:38, Gustavo Sverzut Barbieri wrote: > On Thu, Feb 16, 2012 at 9:30 AM, Tom Hacohen wrote: >> Your patch doesn't apply. Won't review. > > aside from that I wonder what it offers on top of elm_layout. Maybe > just add a canned layout as we do with others? > > how does it compare with

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread Gustavo Sverzut Barbieri
On Thu, Feb 16, 2012 at 7:24 AM, SHILPA ONKAR SINGH wrote: > > Hi All, > > Please find attached patch for new elementary widget elm_colorpalette.c. > > Change description: > New widget colorpalette added. > elm_colorpalette is a color selection widget. > It provides by default, theme specific set

Re: [E-devel] E SVN: sanjeev IN trunk/PROTO/elev8: . src src/bin src/include src/modules

2012-02-16 Thread Leandro Pereira
On 02/16/2012 04:02 AM, Enlightenment SVN wrote: > Log: > Modularize elev8. Cleanup required, but this is a working version. > It would be nice if, instead of loading everything automatically, we had a global "modules" object, where we could do things like: elm = modules.elm; dbus

Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib

2012-02-16 Thread Davide Andreoli
2012/2/16 ChunEon Park > I think theme should not broken the compatibility neither. > It means we don't need to check the versions in minor changes. > but when major version of elm is updated, > then it allows the breaking of the theme compatibility. > So I though just collection need to check th

Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib

2012-02-16 Thread Gustavo Sverzut Barbieri
On Thu, Feb 16, 2012 at 6:20 PM, Davide Andreoli wrote: > 2012/2/16 ChunEon Park > >> I think theme should not broken the compatibility neither. >> It means we don't need to check the versions in minor changes. >> but when major version of elm is updated, >> then it allows the breaking of the the

Re: [E-devel] E SVN: barbieri trunk/eina/src/tests

2012-02-16 Thread Michael Blumenkrantz
On Thu, 16 Feb 2012 11:33:50 -0800 "Enlightenment SVN" wrote: > Log: > 3/3 eina_model: fix inheritance test. > > HUMAN_POOPER_IFACE must have ANIMAL_POOPER_IFACE as parent interface, > otherwise the order will be incorrect. best commit message. > > The test were also improved in other

Re: [E-devel] E SVN: barbieri trunk/eina/src/tests

2012-02-16 Thread Gustavo Sverzut Barbieri
On Thu, Feb 16, 2012 at 6:48 PM, Michael Blumenkrantz wrote: > On Thu, 16 Feb 2012 11:33:50 -0800 > "Enlightenment SVN" wrote: > >> Log: >> 3/3 eina_model: fix inheritance test. >> >>   HUMAN_POOPER_IFACE must have ANIMAL_POOPER_IFACE as parent interface, >>   otherwise the order will be incorrec

Re: [E-devel] E SVN: barbieri trunk/eina/src/tests

2012-02-16 Thread Leandro Pereira
On 02/16/2012 06:48 PM, Michael Blumenkrantz wrote: > On Thu, 16 Feb 2012 11:33:50 -0800 > "Enlightenment SVN" wrote: > >> Log: >> 3/3 eina_model: fix inheritance test. >> >>HUMAN_POOPER_IFACE must have ANIMAL_POOPER_IFACE as parent interface, >>otherwise the order will be incorrect. > bes

Re: [E-devel] E SVN: barbieri trunk/eina/src/tests

2012-02-16 Thread Tom Hacohen
On 16/02/12 22:53, Gustavo Sverzut Barbieri wrote: > On Thu, Feb 16, 2012 at 6:48 PM, Michael Blumenkrantz > wrote: >> On Thu, 16 Feb 2012 11:33:50 -0800 >> "Enlightenment SVN" wrote: >> >>> Log: >>> 3/3 eina_model: fix inheritance test. >>> >>> HUMAN_POOPER_IFACE must have ANIMAL_POOPER_IFACE

Re: [E-devel] E SVN: sanjeev IN trunk/PROTO/elev8: . src src/bin src/include src/modules

2012-02-16 Thread Sanjeev
Leonardo, Thanks for your review. On 02/17/2012 12:46 AM, Leandro Pereira wrote: > On 02/16/2012 04:02 AM, Enlightenment SVN wrote: >> Log: >> Modularize elev8. Cleanup required, but this is a working version. >> > It would be nice if, instead of loading everything automatically, we had > a globa

Re: [E-devel] [Patch] Elementary: New custom widget Popup

2012-02-16 Thread Daniel Juyung Seo
I think Rajeev needs to have a solid explanation why popup is needed even though we already have notify widget. Rajeev, can you describe that? Thanks in advance. Daniel Juyung Seo (SeoZ) On Thu, Feb 16, 2012 at 11:43 PM, Tom Hacohen wrote: > On 16/02/12 16:38, Gustavo Sverzut Barbieri wrote: >

Re: [E-devel] E SVN: sanjeev IN trunk/PROTO/elev8: . src src/bin src/include src/modules

2012-02-16 Thread Leandro Pereira
On Thu, Feb 16, 2012 at 11:04 PM, Sanjeev wrote: > Are you suggesting that we load the modules when the JS parser sees the > module name in the JS file? Imagine you expose an object called "modules" to JavaScript. This object is implemented in C++ using the V8 API: modules = {}; This object

Re: [E-devel] E SVN: sanjeev IN trunk/PROTO/elev8: . src src/bin src/include src/modules

2012-02-16 Thread Sanjeev
*Leandro -Original Message- From: Sanjeev [mailto:as290...@samsung.com] Sent: Friday, February 17, 2012 10:04 AM To: Enlightenment developer list Subject: RE: [E-devel] E SVN: sanjeev IN trunk/PROTO/elev8: . src src/bin src/include src/modules Leonardo, Thanks for your review. On 02/17/

Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib

2012-02-16 Thread ChunEon Park
Anycase, that will be no problem. Actually, if each group have their own versions, it could check any breakings elaborately. But still I think we don't need to have a version for each groups. Reasons. 1. elm would not break abi or functional operations in minor changes. also I think elm should

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2012-02-16 Thread ChunEon Park
Why does elm_naviframe_item_style_default_set API required? This API says that elm_object_style_default_set is also needed. -Regards, Hermet- -Original Message- From: "Enlightenment SVN" To: enlightenment-...@lists.sourcefo

Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib

2012-02-16 Thread Gustavo Sverzut Barbieri
You are missing our point. Think outside of the box, elementary is not the sole user of Edje. Imagine the user is using elementary at theme version 1 and libXYZ at theme version 2. If they are the same file, as it is common, then in your proposal it fails. A concrete case for that is app-specific

Re: [E-devel] E SVN: hermet IN trunk/elementary: data/themes/widgets src/lib

2012-02-16 Thread ChunEon Park
it sounds like dependency of packages are broken already. -Regards, Hermet- -Original Message- From: "Gustavo Sverzut Barbieri" To: "Enlightenment developer list" Cc: "enlightenment

Re: [E-devel] E SVN: sanjeev IN trunk/PROTO/elev8: . src src/bin src/include src/modules

2012-02-16 Thread David Seikel
On Thu, 16 Feb 2012 13:46:57 -0200 Leandro Pereira wrote: > On 02/16/2012 04:02 AM, Enlightenment SVN wrote: > > Log: > > Modularize elev8. Cleanup required, but this is a working version. > > > > It would be nice if, instead of loading everything automatically, we > had a global "modules" objec

Re: [E-devel] [e-users] Exquisite bootsplash release

2012-02-16 Thread Youness Alaoui
(FYI: for those who didn't read from IRC, when Carsten realized I meant to transform exquisite into a library+tools, and not add a new library to the set, he agreed to it). So I've done it, just finished, but I have a couple of questions : - what should I use for creating an object? exquisite_obje