Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-03-07 Thread The Rasterman
On Tue, 06 Mar 2012 22:06:18 +0900 ChunEon Parkher...@naver.com said: no no no! a color palette is a SEt of colors, 1, 2, 5, 20, 100 - look at gimp or photoshop - look t the palettes list. these have names. THATS what i am referring to. so you have a palette default it has: #ff #00

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-03-07 Thread SHILPA ONKAR SINGH
Haitzlerras...@rasterman.com Date : Mar 07, 2012 19:29 (GMT+09:00) Title : Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch On Tue, 06 Mar 2012 22:06:18 +0900 ChunEon Park said: no no no! a color palette is a SEt of colors, 1, 2, 5, 20, 100 - look at gimp or photoshop - look t

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-03-07 Thread The Rasterman
On Tue, 06 Mar 2012 22:06:18 +0900 ChunEon Parkher...@naver.com said: wait - i sent my mail after a short read ans seeing _elm_config_color_set()... but now i read some more.. that doesnt set a color.. that APPENDS a color to the named palette. ok ok - this was right. ignore my previous mail.

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-03-07 Thread The Rasterman
On Tue, 06 Mar 2012 22:06:18 +0900 ChunEon Parkher...@naver.com said: ok. looking at the overall api its good except use int not unisnged int for g, b, and a - just convention thats done in evas too. no - there is no sense in color values 0 or 255, but hey - its extra headroom to do funky

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-03-05 Thread The Rasterman
On Sat, 3 Mar 2012 06:26:20 -0300 Gustavo Sverzut Barbieri barbi...@profusion.mobi said: i'd say this may be a better ultimate solution, where the colorpalette is merged in as part OF the color selector and it just has different view modes (selector only, palette only and auto switch between them

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-03-03 Thread Gustavo Sverzut Barbieri
What is your take on my initial review? Merging this with color selector and automatically change between modes, with an option to fix a mode. This would provide us with more flexibility. For instance most of palette users (apps) will need to handle color selection. Then there is code to write to

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-03-02 Thread The Rasterman
On Tue, 28 Feb 2012 13:05:33 +0900 ChunEon Parkher...@naver.com said: well my comment still stands - without being able to load a named palettes, save it. you didnt address # 6 - where u get an object item returned then u use color number (index) to address it. thats a bit inconsistent. Here

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-27 Thread ChunEon Park
Here is a Shilpa’s mail forwarded(shilpa.si...@samsung.com) Hi, Please find attached updated patch of new widget colorpalette with review comment fixes. Change Description: New widget elm_colorpalette is added. ColorPalette is a color selection widget. It allows the user to set a series of

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-24 Thread The Rasterman
: Feb 18, 2012 01:15 (GMT+09:00) Title : Re: Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch On Fri, Feb 17, 2012 at 10:56 AM, SHILPA ONKAR SINGH wrote: Hi Gustavo/Tom, how does it compare with existing Colorselector (http://docs.enlightenment.org/auto/elementary

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-17 Thread Gustavo Sverzut Barbieri
On Fri, Feb 17, 2012 at 10:56 AM, SHILPA ONKAR SINGH shilpa.si...@samsung.com wrote: Hi Gustavo/Tom, how does it compare with existing Colorselector (http://docs.enlightenment.org/auto/elementary/group__Colorselector.html) ColorPalette supports  two major features.  1. Has theme based

[E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread SHILPA ONKAR SINGH
Hi All, Please find attached patch for new elementary widget elm_colorpalette.c. Change description: New widget colorpalette added. elm_colorpalette is a color selection widget. It provides by default, theme specific set of Predefined colors and also allows to set a series of colors. The

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread Tom Hacohen
Will take a look soon, but please, next time you submit patches make sure to base yourself on current svn version... :| -- Tom. On 16/02/12 11:24, SHILPA ONKAR SINGH wrote: Hi All, Please find attached patch for new elementary widget elm_colorpalette.c. Change description: New widget

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread Tom Hacohen
Widget looks nice. A bit plain maybe, but I guess it's somehow needed. Can't review API/code atm, sorry. -- Tom. On 16/02/12 11:44, Tom Hacohen wrote: Will take a look soon, but please, next time you submit patches make sure to base yourself on current svn version... :| -- Tom. On

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread Michael Blumenkrantz
On Thu, 16 Feb 2012 11:48:25 +0200 Tom Hacohen tom.haco...@samsung.com wrote: Widget looks nice. A bit plain maybe, but I guess it's somehow needed. Can't review API/code atm, sorry. -- Tom. On 16/02/12 11:44, Tom Hacohen wrote: Will take a look soon, but please, next time you submit

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread Tom Hacohen
Dunno, arleady deleted it. But yeah, being able to longpress/right click on a colour to edit the palette manually is possibly important -- Tom. On 16/02/12 11:55, Michael Blumenkrantz wrote: On Thu, 16 Feb 2012 11:48:25 +0200 Tom Hacohentom.haco...@samsung.com wrote: Widget looks nice.

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread SHILPA ONKAR SINGH
Regards Shilpa Singh --- Original Message --- Sender : Tom Hacohentom.haco...@samsung.com Engineer/STRI-EFL Enhancement/Samsung Electronics Date : Feb 16, 2012 18:57 (GMT+09:00) Title : Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch Dunno, arleady deleted it. But yeah

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread Tom Hacohen
: Tom Hacohentom.haco...@samsung.com Engineer/STRI-EFL Enhancement/Samsung Electronics Date : Feb 16, 2012 18:57 (GMT+09:00) Title : Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch Dunno, arleady deleted it. But yeah, being able to longpress/right click on a colour to edit

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread SHILPA ONKAR SINGH
--- Original Message --- Sender : Tom Hacohen Engineer/STRI-EFL Enhancement/Samsung Electronics Date : Feb 16, 2012 18:57 (GMT+09:00) Title : Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch Dunno, arleady deleted it. But yeah, being able to longpress/right click on a colour

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread Tom Hacohen
On 16/02/12 13:26, SHILPA ONKAR SINGH wrote: We understand the below requirement, on right click/long press we should be able to open color selector and change the palette's specific color. we will work on this requirement and send it as an enhancement patch. hence please consider this

Re: [E-devel] : Elementary: Elm_colorpalette - New widget patch

2012-02-16 Thread Gustavo Sverzut Barbieri
On Thu, Feb 16, 2012 at 7:24 AM, SHILPA ONKAR SINGH shilpa.si...@samsung.com wrote: Hi All, Please find attached patch for new elementary widget elm_colorpalette.c. Change description: New widget colorpalette added. elm_colorpalette is a color selection widget. It provides by default,