Raster and I completely agree here, so you can see most of my response
in his email in his words. :)
But there's one more thing I wanted to add: I love error-free and
defensive coding, I think it's good and needed. I'm not arguing here
whether we should write safe code or not, I'm arguing
2012/9/6 Tom Hacohen tom.haco...@samsung.com:
Raster and I completely agree here, so you can see most of my response
in his email in his words. :)
But there's one more thing I wanted to add: I love error-free and
defensive coding, I think it's good and needed. I'm not arguing here
whether we
On Thu, 6 Sep 2012 13:18:15 +0900 Daniel Juyung Seo seojuyu...@gmail.com said:
On Thu, Sep 6, 2012 at 8:54 AM, Carsten Haitzler ras...@rasterman.com wrote:
On Thu, 6 Sep 2012 01:14:34 +0900 Daniel Juyung Seo seojuyu...@gmail.com
said:
I am sick and tired of hearing that EFL code sucks
On Thu, Sep 6, 2012 at 7:00 PM, Carsten Haitzler ras...@rasterman.com wrote:
On Thu, 6 Sep 2012 13:18:15 +0900 Daniel Juyung Seo seojuyu...@gmail.com
said:
On Thu, Sep 6, 2012 at 8:54 AM, Carsten Haitzler ras...@rasterman.com
wrote:
On Thu, 6 Sep 2012 01:14:34 +0900 Daniel Juyung Seo
On Thu, 6 Sep 2012 19:23:41 +0900 Daniel Juyung Seo seojuyu...@gmail.com said:
On Thu, Sep 6, 2012 at 7:00 PM, Carsten Haitzler ras...@rasterman.com wrote:
On Thu, 6 Sep 2012 13:18:15 +0900 Daniel Juyung Seo seojuyu...@gmail.com
said:
On Thu, Sep 6, 2012 at 8:54 AM, Carsten Haitzler
On 06/09/12 14:53, Carsten Haitzler (The Rasterman) wrote:
they are still separate libs though. treat them as such until such a day as we
have a single namespace. :)
And even then, they'll be different components...
--
Tom.
On Wed, Sep 05, 2012 at 04:39:23PM +0300, Tom Hacohen wrote:
On 05/09/12 16:26, Daniel Willmann wrote:
Hi,
On 09/05/2012 02:12 PM, Tom Hacohen wrote:
free, strlen and strcpy are just a few of the many examples that don't
accept NULL. Having sanity checks everywhere is not safer, it just
On 06/09/12 16:44, Joerg Sonnenberger wrote:
free(NULL) has been well defined since ANSI C89 at least.
Just checked, and you are right, thanks. I said I wasn't 100% sure about
this one.
--
Tom.
--
Live Security
Hi,
I still have 10 more null chekcing patches :(
This patch is for eet_lib.c. eet_identity_x509, eet_identity_signature,
eet_identity_sha1 can be crushed
when fucntion tries to if(!ef-sugnature) when ef is null.
Thanks.
Sincerely,
Sungho Kwak.
eet_lib.diff
Description: Binary data
I'm not sure we really want to add NULL checks everywhere. If the docs
say (or should say) passing NULL is not supported, we just shouldn't
pass NULL. We can't possibly do such sanity cases everywhere, as they'd
just slow us and the apps down, and bloat the code.
--
Tom.
On 05/09/12 11:19,
On Wed, Sep 5, 2012 at 10:21 AM, Tom Hacohen tom.haco...@samsung.com wrote:
I'm not sure we really want to add NULL checks everywhere. If the docs
say (or should say) passing NULL is not supported, we just shouldn't
pass NULL. We can't possibly do such sanity cases everywhere, as they'd
just
On Wed, 5 Sep 2012 17:19:38 +0900 Sungho Kwak sungho@gmail.com said:
Hi,
I still have 10 more null chekcing patches :(
This patch is for eet_lib.c. eet_identity_x509, eet_identity_signature,
eet_identity_sha1 can be crushed
when fucntion tries to if(!ef-sugnature) when ef is null.
we should check null at least for public apis.
Daniel Juyung Seo (SeoZ)
On Sep 5, 2012 5:23 PM, Tom Hacohen tom.haco...@samsung.com wrote:
I'm not sure we really want to add NULL checks everywhere. If the docs
say (or should say) passing NULL is not supported, we just shouldn't
pass NULL. We
Why should we? It makes really no sense. And if you want to rely on
past experience i.e what people do, instead of sense, take a look at libc:
free, strlen and strcpy are just a few of the many examples that don't
accept NULL. Having sanity checks everywhere is not safer, it just
hides bugs at
Hi,
On 09/05/2012 02:12 PM, Tom Hacohen wrote:
free, strlen and strcpy are just a few of the many examples that don't
accept NULL. Having sanity checks everywhere is not safer, it just
I agree with most things you said, just one note from the free() man
page: Otherwise, or if free(ptr) has
On 05/09/12 16:26, Daniel Willmann wrote:
Hi,
On 09/05/2012 02:12 PM, Tom Hacohen wrote:
free, strlen and strcpy are just a few of the many examples that don't
accept NULL. Having sanity checks everywhere is not safer, it just
I agree with most things you said, just one note from the free()
: 2012-09-05 (수) 22:12:42
Subject: Re: [E-devel] Add Null Chekcing Routine in eet_lib
Why should we? It makes really no sense. And if you want to rely on
past experience i.e what people do, instead of sense, take a look at libc:
free, strlen and strcpy are just a few of the many examples
On Wed, Sep 5, 2012 at 10:12 PM, Tom Hacohen tom.haco...@samsung.com wrote:
Why should we? It makes really no sense. And if you want to rely on past
experience i.e what people do, instead of sense, take a look at libc:
free, strlen and strcpy are just a few of the many examples that don't
I think EFL is younger than them and we still have a chance to avoid crashing.
Daniel Juyung Seo (SeoZ)
On Wed, Sep 5, 2012 at 10:39 PM, Tom Hacohen tom.haco...@samsung.com wrote:
On 05/09/12 16:26, Daniel Willmann wrote:
Hi,
On 09/05/2012 02:12 PM, Tom Hacohen wrote:
free, strlen and
Do you mean EINA_ARG_NONNULL?
As far as I know, they don't do anything.
They are just warning from header documentation.
That's why they are not used that much and removed from some EFL libs
several months ago.
Daniel Juyung Seo (SeoZ)
On Wed, Sep 5, 2012 at 5:29 PM, Cedric BAIL
On 05/09/12 17:18, Daniel Juyung Seo wrote:
On Wed, Sep 5, 2012 at 10:12 PM, Tom Hacohen tom.haco...@samsung.com wrote:
Why should we? It makes really no sense. And if you want to rely on past
experience i.e what people do, instead of sense, take a look at libc:
free, strlen and strcpy are
On 05/09/12 17:22, Daniel Juyung Seo wrote:
Do you mean EINA_ARG_NONNULL?
As far as I know, they don't do anything.
They are just warning from header documentation.
That's why they are not used that much and removed from some EFL libs
several months ago.
They were removed because raster was
They can change it whenever they want, they can change strlen not to
crash now if they want to, but they don't, and there's a good reason for
that.
--
Tom.
On 05/09/12 17:20, Daniel Juyung Seo wrote:
I think EFL is younger than them and we still have a chance to avoid crashing.
Daniel
On Wed, Sep 5, 2012 at 4:31 PM, Tom Hacohen tom.haco...@samsung.com wrote:
On 05/09/12 17:18, Daniel Juyung Seo wrote:
On Wed, Sep 5, 2012 at 10:12 PM, Tom Hacohen tom.haco...@samsung.com wrote:
Why should we? It makes really no sense. And if you want to rely on past
experience i.e what people
On Wed, Sep 5, 2012 at 11:31 PM, Tom Hacohen tom.haco...@samsung.com wrote:
On 05/09/12 17:18, Daniel Juyung Seo wrote:
On Wed, Sep 5, 2012 at 10:12 PM, Tom Hacohen tom.haco...@samsung.com
wrote:
Why should we? It makes really no sense. And if you want to rely on past
experience i.e what
I think that maintain issue is more important than performance.
(except kernel or etc..) and there are so many dumb developers like
me :)
2012. 9. 6. 오전 1:15 Daniel Juyung Seo seojuyu...@gmail.com 작성:
On Wed, Sep 5, 2012 at 11:31 PM, Tom Hacohen tom.haco...@samsung.com wrote:
On 05/09/12
On 05/09/12 19:14, Daniel Juyung Seo wrote:
I am sick and tired of hearing that EFL code sucks because of those
missing exception handlings.
I'm out, so I'll give you a full reply tomorrow, but just regarding this
sentence: maybe you need to start talking to other people, i.e not the
people
On Thu, 6 Sep 2012 01:14:34 +0900 Daniel Juyung Seo seojuyu...@gmail.com said:
I am sick and tired of hearing that EFL code sucks because of those
missing exception handlings.
and do these people bitch about libc too? checking the programmers bad and
non-sensical input is a nicety we do in
On Thu, Sep 6, 2012 at 8:54 AM, Carsten Haitzler ras...@rasterman.com wrote:
On Thu, 6 Sep 2012 01:14:34 +0900 Daniel Juyung Seo seojuyu...@gmail.com
said:
I am sick and tired of hearing that EFL code sucks because of those
missing exception handlings.
and do these people bitch about libc
.
-Regards, Hermet-
-Original Message-
From: Daniel Juyung Seoseojuyu...@gmail.com
To: Carsten Haitzlerras...@rasterman.com;
Cc: Enlightenment developer listenlightenment-devel@lists.sourceforge.net;
Sent: 2012-09-06 (목) 13:18:15
Subject: Re: [E-devel] Add Null Chekcing Routine in eet_lib
On Thu, Sep 6, 2012 at 1:39 AM, Tom Hacohen t...@stosb.com wrote:
On 05/09/12 19:14, Daniel Juyung Seo wrote:
I am sick and tired of hearing that EFL code sucks because of those
missing exception handlings.
I'm out, so I'll give you a full reply tomorrow, but just regarding this
sentence:
(목) 13:27:29
Subject: Re: [E-devel] Add Null Chekcing Routine in eet_lib
On Thu, Sep 6, 2012 at 1:39 AM, Tom Hacohen tom@stosb.com wrote:
On 05/09/12 19:14, Daniel Juyung Seo wrote:
I am sick and tired of hearing that EFL code sucks because of those
missing exception handlings.
I'm out, so
32 matches
Mail list logo
