Re: [Ethereal-dev] Redesign of the WHOLE Ethereal main menu structure

2003-12-08 Thread Ulf Lamping
Guy Harris wrote: On Dec 8, 2003, at 11:00 AM, Ulf Lamping wrote: which should be converted automatically to the output formats: - manpage(s) (unix platforms) - online help in html format for www.ethereal.com - manpages in html format for win32 platforms (installed by NSIS) - GTK built in help

Re: [Ethereal-dev] What is "File->Save Highlighted" menu item for?

2003-12-08 Thread Ulf Lamping
Richard Sharpe wrote: On Mon, 8 Dec 2003, Guy Harris wrote: On Dec 8, 2003, at 11:57 AM, Richard Sharpe wrote: See how Ulf did it in his recent checkin to move that too "File->Export->Raw Packet data". OK, the current label does not indicate that only the highlighted packet data is

Re: [Ethereal-dev] Quick question

2003-12-08 Thread Tomas Kukosa
There is not RFB dissector in the Ethereal now but Brad Hards seems working on it. See: http://www.ethereal.com/lists/ethereal-dev/200309/msg00673.html http://www.ethereal.com/lists/ethereal-dev/200310/msg00076.html David Stuart wrote: Hi All, Is there a publicly available RFB dissector for ethere

Re: [Ethereal-dev] small bug in packet-tcp.c

2003-12-08 Thread didier
Guy Harris wrote: On Dec 6, 2003, at 7:15 PM, didier wrote: If there's no filter, aka if tree is null, dissect_ip_tcp_options is not called and you don't get the same column info. I've checked in a fix. Unrelated question: Is it safe to use a tvbuff after subdissectors have been called? "Sa

Re: [Ethereal-dev] 3GPP RADIUS VSAs (according to TS 29.061 V4.8.0)

2003-12-08 Thread Guy Harris
On Fri, Dec 05, 2003 at 12:50:28AM +, Rui Carmo wrote: > Not really, no. But the enum code block wasn't really commented (so I > couldn't know what it was supposed to be or the semantics of its use), I've added a comment. > and after dealing with 3GPP specs for a few years, believe me when I

[Ethereal-dev] Quick question

2003-12-08 Thread David Stuart
Hi All, Is there a publicly available RFB dissector for ethereal? I would like to do some VNC trouble-shootings and am having trouble finding a tool that will help me diagnose it. Please keep in mind I'm not subscribed to the list, so CC me directly in any reply.. thanks.. -- David Stuart, SI

Re: [Ethereal-dev] Patch for SEGV in ANSI-637

2003-12-08 Thread Guy Harris
On Dec 8, 2003, at 4:40 PM, Michael Lum wrote: packet-ansi_637.c.diff Fixed incorrect switch values which resulted in NULL strings being passed to ..._add_text(). Checked in. ___ Ethereal-dev mailing list [EMAIL PROTECTED] http://www.eth

[Ethereal-dev] Patch for SEGV in ANSI-637

2003-12-08 Thread Michael Lum
cvs diff -u from latest source: packet-ansi_637.c.diff Fixed incorrect switch values which resulted in NULL strings being passed to ..._add_text(). -- Michael Lum Architect 4600 Jacombs Road (604) 276-0055 Richmond, B.C. Canada V6V 3B1 Tel

Re: [Ethereal-dev] small bug in packet-tcp.c

2003-12-08 Thread Guy Harris
On Dec 6, 2003, at 7:15 PM, didier wrote: If there's no filter, aka if tree is null, dissect_ip_tcp_options is not called and you don't get the same column info. I've checked in a fix. Unrelated question: Is it safe to use a tvbuff after subdissectors have been called? "Safe" in what sense? __

Re: [Ethereal-dev] What is a simple example of using conversations in Ethereal ?

2003-12-08 Thread Guy Harris
On Dec 6, 2003, at 7:53 PM, Michael Lum wrote: I would like to investigate what it will take to add conversations for connection oriented SCCP. An example that's probably somewhat close to what you're trying to do would be packet-tds.c. "dissect_tds_tcp_heur()" does heuristic checks to see if t

Re: [Ethereal-dev] help dir needs a Makefile.am

2003-12-08 Thread Guy Harris
On Dec 2, 2003, at 12:18 AM, Biot Olivier wrote: Shouldn't we write a perl or python script to generate them? They both have the transliteration operation onboard. Why do that rather than just reading them from text files when the help window is popped up? __

Re: [Ethereal-dev] GSM MAP dissector

2003-12-08 Thread Guy Harris
On Dec 4, 2003, at 8:40 AM, Michael Lum wrote: Also, should "my_decode_bitfield_value()" (which appears to be in a number of dissectors) be put into "epan/to_str.c" with a different name, "decode_bitfield_value()" changed to call it (the only difference appears to be the " = " that "decode_bitfiel

[Ethereal-dev] Creating a new decode

2003-12-08 Thread Craig Bumpstead
Hi, I would like to create a decode for a protocol that is not currently supported. Does anyone have any tips or advice on where to start. Thanks in advance, Craig ___ Ethereal-dev mailing list [EMAIL PROTECTED] http://www.ethereal.com/mailman/listin

Re: PDML from tethereal, was Re: [Ethereal-dev] New "matches" (PCRE support) patch

2003-12-08 Thread Gilbert Ramirez
On Mon, 2003-12-08 at 15:41, Guy Harris wrote: > > On Dec 8, 2003, at 1:14 PM, Gilbert Ramirez wrote: > > > On Sat, 2003-12-06 at 20:24, Guy Harris wrote: > >> Should we force the verbose flag on when "-T ps" or "-T pdml" is > >> specified? (Actually, does "-T ps" require "-V"? I think we can

Re: [Ethereal-dev] Print as XML - Status of work?

2003-12-08 Thread Gilbert Ramirez
On Mon, 2003-12-08 at 16:42, Guy Harris wrote: > > On Dec 5, 2003, at 10:12 PM, Gilbert Ramirez wrote: > > > I've committed the change to CVS. Update and read the > > doc/README.xml-output file for more information. > > Should the mapping from Ethereal-specific names to generic PDML names > (e.

Re: [Ethereal-dev] Print as XML - Status of work?

2003-12-08 Thread Guy Harris
On Dec 5, 2003, at 10:12 PM, Gilbert Ramirez wrote: I've committed the change to CVS. Update and read the doc/README.xml-output file for more information. Should the mapping from Ethereal-specific names to generic PDML names (e.g. "frame.number" -> "geninfo.num") be done by adding an additional

Re: [Ethereal-dev] incomplete performance patch giving ~7% for tethereal testcase

2003-12-08 Thread Guy Harris
On Dec 6, 2003, at 8:40 PM, Pia Sahlberg wrote: Does any code really rely on the curernt behvoious of the parent pointer There is code that uses the parent pointer - see "packet-dcerpc-{epm,epm4,nt,spoolss}.c", for example. It probably requires that the parent pointer really point to the paren

Re: [Ethereal-dev] What is "File->Save Highlighted" menu item for?

2003-12-08 Thread Richard Sharpe
On Mon, 8 Dec 2003, Guy Harris wrote: > > On Dec 8, 2003, at 3:28 PM, Richard Sharpe wrote: > > > OK, the current label does not indicate that only the highlighted > > packet > > data is saved ... Perhaps we want Highlighted Packet Data or something > > like that. > > That sounds reasonable. >

Re: [Ethereal-dev] Makefile.nmake missing target: doc?

2003-12-08 Thread Guy Harris
On Dec 8, 2003, at 7:14 AM, Ulf Lamping wrote: Is there a reason, that the Makefile.nmake doesn't have a doc target? I don't know of a reason, so I added a "doc" target. ___ Ethereal-dev mailing list [EMAIL PROTECTED] http://www.ethereal.com/mailman/lis

Re: [Ethereal-dev] What is "File->Save Highlighted" menu item for?

2003-12-08 Thread Guy Harris
On Dec 8, 2003, at 3:28 PM, Richard Sharpe wrote: OK, the current label does not indicate that only the highlighted packet data is saved ... Perhaps we want Highlighted Packet Data or something like that. That sounds reasonable. BTW, it might be nice if that menu item were active only if there *

Re: [Ethereal-dev] What is "File->Save Highlighted" menu item for?

2003-12-08 Thread Richard Sharpe
On Mon, 8 Dec 2003, Guy Harris wrote: > > On Dec 8, 2003, at 11:57 AM, Richard Sharpe wrote: > > > Seems like a good idea to me ... now, how do you construct sub-menus > > again? > > See how Ulf did it in his recent checkin to move that too > "File->Export->Raw Packet data". OK, the current l

Re: [Ethereal-dev] What is "File->Save Highlighted" menu item for?

2003-12-08 Thread Guy Harris
On Dec 8, 2003, at 11:57 AM, Richard Sharpe wrote: Seems like a good idea to me ... now, how do you construct sub-menus again? See how Ulf did it in his recent checkin to move that too "File->Export->Raw Packet data". ___ Ethereal-dev mailing list [EMA

Re: [Ethereal-dev] Redesign of the WHOLE Ethereal main menu structure

2003-12-08 Thread Guy Harris
On Dec 8, 2003, at 11:00 AM, Ulf Lamping wrote: We should have: One basis of help content (in whatever format, maybe .pod?), Perhaps. which should be converted automatically to the output formats: - manpage(s) (unix platforms) - online help in html format for www.ethereal.com - manpages in html

Re: PDML from tethereal, was Re: [Ethereal-dev] New "matches" (PC RE support) patch

2003-12-08 Thread Guy Harris
On Dec 8, 2003, at 1:17 PM, Biot Olivier wrote: I got some brilliant (heh heh) idea: why can't we write PDF instead of or in addition to PS? It's basically extremely similar to PS... and it's available to everybody. That sounds reasonable. ___ Etherea

Re: PDML from tethereal, was Re: [Ethereal-dev] New "matches" (PCRE support) patch

2003-12-08 Thread Guy Harris
On Dec 8, 2003, at 1:14 PM, Gilbert Ramirez wrote: On Sat, 2003-12-06 at 20:24, Guy Harris wrote: Should we force the verbose flag on when "-T ps" or "-T pdml" is specified? (Actually, does "-T ps" require "-V"? I think we can print summaries in PostScript from Ethereal - if not, that's arguabl

Re: [Ethereal-dev] MTP3/SCCP patch for OPC/DPC, and epan changes for AT_SS7PC

2003-12-08 Thread Guy Harris
On Dec 5, 2003, at 5:07 PM, Michael Lum wrote: packet_info.h.diff New AT_SS7PC to_str.c.diff Call to address format routine for AT_SS7PC packet-mtp3.h.diff packet-mtp3.c.diff Code for setting net_dst, net_src with AT_SS7PC packet-sccp.c.diff Code for setting direction in p

RE: PDML from tethereal, was Re: [Ethereal-dev] New "matches" (PC RE support) patch

2003-12-08 Thread Biot Olivier
I got some brilliant (heh heh) idea: why can't we write PDF instead of or in addition to PS? It's basically extremely similar to PS... and it's available to everybody. | -Original Message- | From: Gilbert Ramirez | | On Sat, 2003-12-06 at 20:24, Guy Harris wrote: | > Should we force the v

[Ethereal-dev] Questions on dfilter processing

2003-12-08 Thread Biot Olivier
Hi List, I have some doubts/questions on how the dfilter processing works (maybe I don't get all the items right). I added debug logging in epan/dfilter/semcheck.c and I realized that dfw_semcheck() is called for every header field when a dfilter is evaluated. Now, I intend to compile and analyze

PDML from tethereal, was Re: [Ethereal-dev] New "matches" (PCRE support) patch

2003-12-08 Thread Gilbert Ramirez
On Sat, 2003-12-06 at 20:24, Guy Harris wrote: > Should we force the verbose flag on when "-T ps" or "-T pdml" is > specified? (Actually, does "-T ps" require "-V"? I think we can print > summaries in PostScript from Ethereal - if not, that's arguably a bug.) > Verbose flag: I don't know. I cho

RE: [Ethereal-dev] Are WSP content types the same as HTTP content types?

2003-12-08 Thread Biot Olivier
I checked in a fix some minutes ago. I also got rid of the unused wbxml_handle in packet-wsp.c. Compiled and executed with a 9 MB historical collection of snoops :) Regards, Olivier | -Original Message- | From: Biot Olivier | | | From: Guy Harris | | | | On Sun, Dec 07, 2003 at 01:22:0

Re: [Ethereal-dev] patch for packet-dcerpc.c

2003-12-08 Thread Guy Harris
On Dec 7, 2003, at 10:32 AM, Jaime Fournier wrote: I have fixed it so the UNKUUID's dont print out on fragments for known dissectors. Checked in. ___ Ethereal-dev mailing list [EMAIL PROTECTED] http://www.ethereal.com/mailman/listinfo/ethereal-dev

Re: [Ethereal-dev] Update to packet-srvloc

2003-12-08 Thread Guy Harris
On Dec 8, 2003, at 7:51 AM, Greg Morris wrote: This patch updates the attribute reply to decode the attribute structure instead of reporting a really long undecoded string. :@( Checked in. ___ Ethereal-dev mailing list [EMAIL PROTECTED] http://www.ethe

Re: [Ethereal-dev] nsis script fix

2003-12-08 Thread Guy Harris
On Dec 8, 2003, at 4:04 AM, Lars Roland wrote: attached is patch fixes a typo and the makefile for nsis. Checked in. ___ Ethereal-dev mailing list [EMAIL PROTECTED] http://www.ethereal.com/mailman/listinfo/ethereal-dev

Re: [Ethereal-dev] IS-IS cleanup, new Checksum CLV dissector

2003-12-08 Thread Guy Harris
On Dec 8, 2003, at 2:40 AM, Hannes Gredler wrote: pls find attached a patch that cleans up the IS-IS dissector and adds a new CLV dissector; (i have added also a few packet captures that contains examples for the Checksum CLV) Checked in. ___ Ethereal-d

Re: [Ethereal-dev] [patch] small improvements for afp and dsi dissectors

2003-12-08 Thread Guy Harris
On Dec 7, 2003, at 11:31 PM, didier wrote: AFP dissector: add offset and size parameters in info colum for read and write commands. DSI dissector: check packet format in get_dsi_pdu_len. Checked in. ___ Ethereal-dev mailing list [EMAIL PROTECTED] http

Re: [Ethereal-dev] Check content type before calling SDP dissecto r, packet-sip(Patch)

2003-12-08 Thread Guy Harris
On Dec 8, 2003, at 6:51 AM, Anders Broman (TN/EAB) wrote: Included updated patch to call dissector dependent on Media-type. ...and to put the message body into a subtree of the SIP tree rather than as a top-level item. Checked in. What would be the best way to call a dissector for media-type m

Re: [Ethereal-dev] What is "File->Save Highlighted" menu item for ?

2003-12-08 Thread Guy Harris
On Dec 8, 2003, at 7:01 AM, Biot Olivier wrote: I'd propose to use "File -> Export" as menu item, and then let the user pick an option from a list (radio button): selected frames, selected frame, selected data in frame (or something like that). You could even add an option having either the valu

Re: [Ethereal-dev] What is "File->Save Highlighted" menu item for?

2003-12-08 Thread Ulf Lamping
Richard Sharpe wrote: On Mon, 8 Dec 2003, Guy Harris wrote: On Mon, Dec 08, 2003 at 10:31:38AM +0100, Ulf Lamping wrote: Could someone explain to me, what the "File->Save Highlighted" menu item is useful for? Please keep in mind, that this menu item is somewhat very uncommon, and even wor

Re: [Ethereal-dev] Redesign of the WHOLE Ethereal main menu structure

2003-12-08 Thread Ulf Lamping
Ronnie Sahlberg wrote: - Original Message - From: "Ulf Lamping" Sent: Saturday, November 29, 2003 5:54 AM Subject: Re: [Ethereal-dev] Redesign of the WHOLE Ethereal main menu structure b. Win32 users usually cannot access the man page :-(, so no help about the menu is available! I'm u

Re: [Ethereal-dev] What is "File->Save Highlighted" menu item for?

2003-12-08 Thread Richard Sharpe
On Mon, 8 Dec 2003, Ulf Lamping wrote: > Guy Harris schrieb am 08.12.03 10:36:53: > > > > On Mon, Dec 08, 2003 at 10:31:38AM +0100, Ulf Lamping wrote: > > > Could someone explain to me, what the "File->Save Highlighted" menu > > > item is useful for? Please keep in mind, that this menu item is so

Re: [Ethereal-dev] What is "File->Save Highlighted" menu item for?

2003-12-08 Thread Richard Sharpe
On Mon, 8 Dec 2003, Guy Harris wrote: > On Mon, Dec 08, 2003 at 10:31:38AM +0100, Ulf Lamping wrote: > > Could someone explain to me, what the "File->Save Highlighted" menu > > item is useful for? Please keep in mind, that this menu item is somewhat > > very uncommon, and even worse, I don't have

Re: [Ethereal-dev] Redesign of the WHOLE Ethereal main menu structure

2003-12-08 Thread Ulf Lamping
Guy Harris wrote: On Nov 27, 2003, at 3:15 PM, Ulf Lamping wrote: Guy Harris wrote: Don't forget to update the man page You are talking about the doc/ethereal.pod file I think. Yes. As I'm not familiar with this file type, I must edit this file with a simple text editor by hand. It's

RE: [Ethereal-dev] What is "File->Save Highlighted" menu item for ?

2003-12-08 Thread Ulf Lamping
Biot Olivier <[EMAIL PROTECTED]> schrieb am 08.12.03 16:01:59: > > | From: Ulf Lamping > | > | Hmm, that sounds to me like the first export function, so we > | should put this into a new submenu item? What about putting this into: > | > | File->Export->Raw Packet Data (Of Selected Area) > > I'

[Ethereal-dev] Update to packet-srvloc

2003-12-08 Thread Greg Morris
This patch updates the attribute reply to decode the attribute structure instead of reporting a really long undecoded string. :@(   Greg packet-srvloc.c.diff Description: Binary data ___ Ethereal-dev mailing list [EMAIL PROTECTED] http://www.ethereal.c

[Ethereal-dev] Private DLT_s and WTAP_ENCAP_s

2003-12-08 Thread Tomas Kukosa
Hi, would not it be usefull to make some reserved DLT_s and WTAP_ENCAP_s? It would be intended only for private usage when the global new values are not really necessary. I think the DLT_USER0-DLT_USER15 and WTAP_ENCAP_USER0-WTAP_ENCAP_USER15 should be enough. Why I ask? I would like to try som

[Ethereal-dev] Makefile.nmake missing target: doc?

2003-12-08 Thread Ulf Lamping
Hi List! Is there a reason, that the Makefile.nmake doesn't have a doc target? The doc/Makefile.nmake is called with the clean and distclean targets, but never with the doc target. Or do I miss something out? Regards, ULFL ___

RE: [Ethereal-dev] What is "File->Save Highlighted" menu item for ?

2003-12-08 Thread Biot Olivier
| From: Ulf Lamping | | Hmm, that sounds to me like the first export function, so we | should put this into a new submenu item? What about putting this into: | | File->Export->Raw Packet Data (Of Selected Area) I'd propose to use "File -> Export" as menu item, and then let the user pick an opti

Re: [Ethereal-dev] What is "File->Save Highlighted" menu item for?

2003-12-08 Thread Ulf Lamping
Guy Harris schrieb am 08.12.03 10:36:53: > > On Mon, Dec 08, 2003 at 10:31:38AM +0100, Ulf Lamping wrote: > > Could someone explain to me, what the "File->Save Highlighted" menu > > item is useful for? Please keep in mind, that this menu item is somewhat > > very uncommon, and even worse, I don't

[Ethereal-dev] nsis script fix

2003-12-08 Thread Lars Roland
Hello, attached is patch fixes a typo and the makefile for nsis. please check in. regards, Lars Index: ethereal/packaging/nsis/Makefile.nmake === RCS file: /cvsroot/ethereal/packaging/nsis/Makefile.nmake,v retrieving revision 1.26 di

RE: [Ethereal-dev] Are WSP content types the same as HTTP content types?

2003-12-08 Thread Biot Olivier
| From: Guy Harris | | On Sun, Dec 07, 2003 at 01:22:01PM +0100, Biot Olivier wrote: | > Agreed. However, there are TWO media dissector tables in WSP: | > - the literally represented media type table (e.g., "text/html") | > - the numerically represented media type table (e.g., 0x01) | > | > We ca

Re: [Ethereal-dev] What is "File->Save Highlighted" menu item for?

2003-12-08 Thread Guy Harris
On Mon, Dec 08, 2003 at 10:31:38AM +0100, Ulf Lamping wrote: > Could someone explain to me, what the "File->Save Highlighted" menu > item is useful for? Please keep in mind, that this menu item is somewhat > very uncommon, and even worse, I don't have a clue, what it will really > do! I'll let Ric

[Ethereal-dev] What is "File->Save Highlighted" menu item for?

2003-12-08 Thread Ulf Lamping
Hi List! Could someone explain to me, what the "File->Save Highlighted" menu item is useful for? Please keep in mind, that this menu item is somewhat very uncommon, and even worse, I don't have a clue, what it will really do! I can't see, why this shouldn't be included in the "File->Save As"/"F

Re: [Ethereal-dev] Are WSP content types the same as HTTP content types?

2003-12-08 Thread Guy Harris
On Sun, Dec 07, 2003 at 01:22:01PM +0100, Biot Olivier wrote: > Agreed. However, there are TWO media dissector tables in WSP: > - the literally represented media type table (e.g., "text/html") > - the numerically represented media type table (e.g., 0x01) > > We cannot get rid of the "numerical tab

[Ethereal-dev] [patch] small improvements for afp and dsi dissectors

2003-12-08 Thread didier
Hi, AFP dissector: add offset and size parameters in info colum for read and write commands. DSI dissector: check packet format in get_dsi_pdu_len. didier ethereal_afp.patch.gz Description: Unix tar archive ___ Ethereal-dev mailing list [EMAIL PROTEC