[Evolution-hackers] [CamelStore] clarifying of documentation becomes a minor change of code

2008-09-01 Thread Paul Bolle
I wanted to clarify the documentation for camel_store_free_folder_info() a bit. In found myself altering its implementation. Rationale is (obviously) to simply make sure that camel_store_free_folder_info() handles a NULL return of camel_store_get_folder_info() gracefully so my documentation change

Re: [Evolution-hackers] bug fixing in stable 2.22.x branch

2008-09-01 Thread Patrick Ohly
On Thu, 2008-08-21 at 12:37 +0530, Chenthill wrote: > Thanks, I will send out a mail to the list mentioning the critical > fixes which have gone in recently in the stable branch which needs to be > taken into the distro's. Bug #548268 is in trunk (thanks Chenthill!) and tested automatically

Re: [Evolution-hackers] [CamelStore] clarifying of documentation becomes a minor change of code

2008-09-01 Thread Jeffrey Stedfast
On Mon, 2008-09-01 at 18:19 +0200, Paul Bolle wrote: [snip] > void > camel_store_free_folder_info (CamelStore *store, CamelFolderInfo *fi) > { > + if (!fi) > + return; > + that null-check should probably go after the g_return below: > g_return_if_fail (CAMEL_IS_STORE (sto

Re: [Evolution-hackers] [CamelStore] clarifying of documentation becomes a minor change of code

2008-09-01 Thread Paul Bolle
On Mon, 2008-09-01 at 16:46 -0400, Jeffrey Stedfast wrote: > On Mon, 2008-09-01 at 18:19 +0200, Paul Bolle wrote: Viewing this message's subject actually renders a tab between "[...] of" and "code." This tab was inserted (I suppose by evolution) because the Subject header wrapped some magic line l

Re: [Evolution-hackers] [CamelStore] clarifying of documentation becomes a minor change of code

2008-09-01 Thread Paul Bolle
On Mon, 2008-09-01 at 23:01 +0200, Paul Bolle wrote: > On Mon, 2008-09-01 at 16:46 -0400, Jeffrey Stedfast wrote: > > On Mon, 2008-09-01 at 18:19 +0200, Paul Bolle wrote: > (I suppose by evolution) [...]. > > Evolution shouldn't do that. No. I should have looked longer. Seems to be a bug in the l