[Bug 481508] Review Request: pipviewer - Visualizer for multiple alignments of genomic sequences

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481508


Marcela Maslanova mmasl...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-review+




--- Comment #3 from Marcela Maslanova mmasl...@redhat.com  2009-01-28 
03:48:05 EDT ---
ACCEPTED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481528


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #4 from Parag AN(पराग) panem...@gmail.com  2009-01-28 04:00:49 
EDT ---
koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1088064

1)rpmlint outputs only
perl-DBIx-Safe.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line
1)
==Can be fixed using sed -i -e 's|\t|  |g' perl-DBIx-Safe.spec

2) Also, add following at the end of the %install section
%{_fixperms} %{buildroot}/* 


Make sure you will fix above 2 issues first before committing to cvs.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478372] Review request: Mathgl - Scientific plotting library.

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478372





--- Comment #5 from D Haley my...@yahoo.com  2009-01-28 03:58:00 EDT ---
SPEC URL: http://dhd.selfip.com/427e/mathgl-3.spec
SRPM URL: http://dhd.selfip.com/427e/mathgl-1.8-3.fc10.src.rpm


RPMLint:
$ rpmlint ../SRPMS/mathgl-1.8-3.fc10.src.rpm
../RPMS/i386/mathgl-1.8-3.fc10.i386.rpm mathgl.spec 
mathgl.i386: W: shared-lib-calls-exit /usr/lib/libmgl-glut.so.5.0.0
e...@glibc_2.0
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1088112

Summary without package name would be nice (as UDAV :-) )
Done.

Please preserve the time stamps, use ' make install DESTDIR=%{buildroot}
INSTALL=install -p ' if possible instead of ' make install
INSTALL_ROOT=%{buildroot} '
mathgl *does* use configure, so this is Done.

Use '%defattr(-,root,root,-)' instead of '%defattr(-, root, root)'
Done.


Will the upstream fix this issue?

Here is what upstream had to say:
---
I understand badness of usage of exit() function. Unfortunately I
don't know how user can terminate the program by other way using GLUT
window :(. So the only suggestion I have is exclude the module
libmgl-glut from the package. The matter is that this is not the part
of MathGL core and the same functionality can be reached by other
widget classes (FLTK or Qt).
---

So yes, if a suitable solution can be found. I haven't looked into it, it may
be trivial or it may not -- I have not used glut for generating windows.
Without suggestions as to the correct way to modify upstream code, no.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478603] Review Request: pysnmp - SNMP engine written in Python

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478603


Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #4 from Parag AN(पराग) panem...@gmail.com  2009-01-28 04:14:40 
EDT ---
koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1088069

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449135] Review Request: gforge - GForge Collaborative Development Environment

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=449135





--- Comment #19 from Nicolas Chauvet (kwizart) kwiz...@gmail.com  2009-01-28 
04:35:07 EDT ---
Was the project renamed ?
What is the status of the package ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 460600] Review Request: msp430-binutils - Cross compiling binutils targeted at the msp430

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460600





--- Comment #23 from Steve Whitehouse swhit...@redhat.com  2009-01-28 
04:45:24 EDT ---
Robert, you ought to be able to give your F-10 updates package a +1 from
yourself. I've given it a +1 and there is another too, so that should be enough
to get it released properly.

If you are looking for a second maintainer, then I'm happy to do that. For now
though I've only applied for the two watch permissions on the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478749] Review Request: dinotrace - X11 waveform viewer for electronics

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478749





--- Comment #4 from Parag AN(पराग) panem...@gmail.com  2009-01-28 05:10:22 
EDT ---
1) drop vendor tag in desktop-install-file. See
http://fedoraproject.org/wiki/PackagingGuidelines#desktop-file-install_usage
2) from https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Texinfo, use
%preun
if [ $1 = 0 ] ; then
  /sbin/install-info --delete %{_infodir}/%{name}.info %{_infodir}/dir || :
fi

3) from Emacs guildeines
Usually an add-on package will require a startup file, and this should be
called foo-init.el and be placed in /usr/share/emacs/site-lisp/site-start.d/. 

I think then you should have %{name}.el.site-start renamed to %{name}-init.el

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482807] New: Review Request: libfli - Library for FLI CCD Camera Filter Wheels

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: libfli - Library for FLI CCD Camera  Filter Wheels

https://bugzilla.redhat.com/show_bug.cgi?id=482807

   Summary: Review Request: libfli - Library for FLI CCD Camera 
Filter Wheels
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: sergio.pa...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://sergiopr.fedorapeople.org/libfli.spec
SRPM URL: http://sergiopr.fedorapeople.org/libfli-1.7-1.src.rpm
Description: Finger Lakes Instrument library is used by applications to control
FLI line of CCDs and Filter wheels

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467402] Review Request: mingw32-glib2 - MinGW Windows GLib2 library

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467402





--- Comment #18 from Richard W.M. Jones rjo...@redhat.com  2009-01-28 
05:34:54 EDT ---
(In reply to comment #17)
 for #9 is there any reason you not pushed 43.6 or 44.1 to f10 and epel?

Levente, let's discuss unrelated issues on the mailing list.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482807] Review Request: libfli - Library for FLI CCD Camera Filter Wheels

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482807


Kevin Kofler ke...@tigcc.ticalc.org changed:

   What|Removed |Added

 Blocks||478539




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467401] Review Request: mingw32-libjpeg - MinGW Windows Libjpeg library

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467401





--- Comment #7 from Richard W.M. Jones rjo...@redhat.com  2009-01-28 05:26:36 
EDT ---
Although application programs are excluded from the MinGW project,
we do ship the occasional Win32 binary if it would be useful for
testing, development or debugging.  Examples include:

- openssl.exe (so developers and end users can debug certificates)
- certtool.exe (for the same reason)
- worms.exe (useful demo program which can be used to find out if
   all the components leading up to the windows console are working)

In this case, I don't think any of those binaries are useful for
this purpose, so they should be excluded.  The following excludes
them, and also includes Levente's patch from comment 6.

Spec URL:
http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/raw-file/tip/libjpeg/mingw32-libjpeg.spec
SRPM URL:
http://www.annexia.org/tmp/mingw/fedora-rawhide/src/SRPMS/mingw32-libjpeg-6b-8.fc11.src.rpm

* Wed Jan 28 2009 Richard W.M. Jones rjo...@redhat.com - 6b-8
- Exclude the binaries.
- Rename the binaries to *.exe (Levente Farkas).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482807] Review Request: libfli - Library for FLI CCD Camera Filter Wheels

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482807


Sven Lankes s...@lank.es changed:

   What|Removed |Added

 CC||s...@lank.es




--- Comment #1 from Sven Lankes s...@lank.es  2009-01-28 06:11:20 EDT ---
From IRC:

11:51  killefiz Kevin_Kofler: from the libfli-spec - what does %cmake
-DLIB_POSTFIX=64
11:51  killefiz do? Will that hardcode lib64 as library path?
11:52 @Kevin_Kofler I guess so. Looks like this is broken indeed.
11:53 @Kevin_Kofler This needs to be conditional on %if %{?_lib} == lib64
11:54 @Kevin_Kofler But ideally the upstream CMake machinery should be fixed
to use the standard LIB_SUFFIX which is already set by our %cmake macro instead
of the nonstandard LIB_POSTFIX.
11:54 @Kevin_Kofler (upstream = libfli in this context)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226314] Merge Review: prctl

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226314





--- Comment #4 from Karsten Hopp kars...@redhat.com  2009-01-28 06:25:33 EDT 
---
The only parameters of prctl that do anything other than printing help are 
--unaligned= and --fpemu=. Both work only on ia64, on other archs you'll get
this
output: 'ERROR: Kernel on this platform may not implement this prctl feature.'

I've added this as a comment before the ExclusiveArch: in the spec file and
commited it to CVS.

As IA64 is a secondary arch in Fedora, a build will need to be done by the
secondary arch maintainers. See
https://fedoraproject.org/wiki/Architectures/IA64
for more info about Fedora-IA64

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467416] Review Request: mingw32-cairo - MinGW Windows Cairo library

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467416





--- Comment #17 from Richard W.M. Jones rjo...@redhat.com  2009-01-28 
07:05:00 EDT ---
Waiting for bug 467376 (mingw32-pixman).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467376] Review Request: mingw32-pixman - MinGW Windows Pixman library

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467376


Bug 467376 depends on bug 478640, which changed state.

Bug 478640 Summary: Review Request: mingw32-dlfcn - Implements a wrapper for 
dlfcn (dlopen dlclose dlsym dlerror)
https://bugzilla.redhat.com/show_bug.cgi?id=478640

   What|Old Value   |New Value

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE



--- Comment #8 from Richard W.M. Jones rjo...@redhat.com  2009-01-28 07:04:01 
EDT ---
Peter, ping?

If you have rawhide  mingw32-filesystem = 44 installed, then
rpmlint errors are reduced to this single warning[1]:

mingw32-pixman.src: W: strange-permission make-pixman-snapshot.sh 0775

I don't think this is a valid warning because it's perfectly
normal for shell scripts to have executable permission.

[1] However this is cheating slightly, because all we are doing is
dropping in an rpmlint configuration file which tells rpmlint to
suppress the warnings listed in https://fedoraproject.org/wiki/MinGW/Rpmlint
for MinGW packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467405] Review Request: mingw32-libxml2 - MinGW Windows libxml2 XML processing library

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467405





--- Comment #20 from Richard W.M. Jones rjo...@redhat.com  2009-01-28 
07:11:31 EDT ---
Built in Rawhide, F-10 and EL-5.
In response to comment 16 - Levente this built fine in EL-5.

I'll wait for the F-10 update before closing this bug.

Thanks to Tim and Kevin for working on this bug.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467402] Review Request: mingw32-glib2 - MinGW Windows GLib2 library

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467402





--- Comment #19 from Richard W.M. Jones rjo...@redhat.com  2009-01-28 
07:18:30 EDT ---
This has been built in Rawhide, F-10 and EL-5.

Thanks again Tim and Kevin for helping with this review.

I'll leave this bug open until the F-10 update goes through.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456527] Review Request: sil-gentium-fonts - Gentium Basic Font Family

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456527





--- Comment #17 from Rahul Bhalerao rbhal...@redhat.com  2009-01-28 07:22:09 
EDT ---
SPEC URL:
http://rbhalera.fedorapeople.org/sil-gentium-fonts/sil-gentium-fonts.spec

SRPM URL:
http://rbhalera.fedorapeople.org/sil-gentium-fonts/sil-gentium-fonts-1.1-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456527] Review Request: sil-gentium-fonts - Gentium Basic Font Family

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456527





--- Comment #18 from Rahul Bhalerao rbhal...@redhat.com  2009-01-28 07:23:59 
EDT ---
New Package CVS Request
===
Package Name: sil-gentium-fonts
Short Description:  Gentium Basic Font Family from SIL
Owners: rbhalera
Branches: devel
InitialCC: fonts-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 456527] Review Request: sil-gentium-fonts - Gentium Basic Font Family

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=456527


Rahul Bhalerao rbhal...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481528





--- Comment #5 from Itamar Reis Peixoto ita...@ispbrasil.com.br  2009-01-28 
07:27:05 EDT ---
fixed.

http://ispbrasil.com.br/perl-DBIx-Safe/perl-DBIx-Safe.spec
http://ispbrasil.com.br/perl-DBIx-Safe/perl-DBIx-Safe-1.2.5-3.fc10.src.rpm

koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=1088470

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481717] Review Request: ugene - genome analysis suite

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481717





--- Comment #3 from Ivan Efremov iefre...@unipro.ru  2009-01-28 07:27:01 EDT 
---
(In reply to comment #2)
 - Please place the changelog section at the end of the file.  It's not wrong
 just unusual.

done

 - Please add the dist tag to Release - 'Release: 1%{?dist}'

done

 - You don't need to define macros at the beginning of the file.  'Name:' and
 'Version:' are already macros.  But you must use macros in the %files section
   
 https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macros

fixed

 - Please preserve the time stamps, use ' make install DESTDIR=%{buildroot}
 INSTALL=install -p ' if possible instead of ' make install
 INSTALL_ROOT=%{buildroot} '

Since Makefile is generated by qmake it has some specific features:
1) it uses INSTALL_ROOT instead of DESTDIR
2) it uses INSTALL_FILE, INSTALL_PROGRAM etc. instead of INSTALL
3) these INSTALL_* variables already have '-p' option
so, there is no problem with time stapms

 - This application has a GUI.  You need to install the .desktop file.
   https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files

desktop file is part of the upstream tarball and is installed during 'make
install'

 - COPYRIGHT and LICENSE must be added as %doc in the %files section.  Maybe
 adding the sample files (out of data/samples in the source) is also a good
 idea. 

done. Samples are installed into /usr/share/ugene/data during 'make install'

 - There are 'unowned directories' in your %files section.
   https://fedoraproject.org/wiki/Packaging/UnownedDirectories

fixed

New links:
SPEC: http://ugene.unipro.ru/downloads/ugene.spec
SRPM: http://ugene.unipro.ru/downloads/ugene-1.3.2-1.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481528


Itamar Reis Peixoto ita...@ispbrasil.com.br changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #6 from Itamar Reis Peixoto ita...@ispbrasil.com.br  2009-01-28 
07:29:32 EDT ---
package approved in Comment #4

New Package CVS Request
===
Package Name: perl-DBIx-Safe
Short Description: Safer access to your database through a DBI database handle
Owners: itamarjp
Branches: F-10 F-9
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481564] Review Request: bind-to-tinydns - Convert DNS zone files in BIND format to tinydns format

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481564





--- Comment #10 from Itamar Reis Peixoto ita...@ispbrasil.com.br  2009-01-28 
07:45:43 EDT ---
 this must be fixed before approval.

Manuel

please look at Comment #9, and answer if sounds good now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 469894] Review Request: cglib - Code generation library for Java

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469894





--- Comment #10 from Mary Ellen Foster mefos...@gmail.com  2009-01-28 
07:56:15 EDT ---
I'd certainly prefer cglib 2.2 -- when the jpackage package appears, will/can a
jpackage person submit it to Fedora or should I do that?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481141] Review Request: pycryptsetup - Python bindings for cryptsetup tool

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481141


Matej Cepl mc...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-review+




--- Comment #6 from Matej Cepl mc...@redhat.com  2009-01-28 08:00:09 EDT ---
All fixed. 

APPROVED!!!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482807] Review Request: libfli - Library for FLI CCD Camera Filter Wheels

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482807





--- Comment #2 from Sergio Pascual sergio.pa...@gmail.com  2009-01-28 
07:57:27 EDT ---
My fault, I didn't check it in i386. I have patched the cmake file to use
LIB_SUFFIX instead of LIB_POSTFIX

Spec URL: http://sergiopr.fedorapeople.org/libfli.spec
SRPM URL: http://sergiopr.fedorapeople.org/libfli-1.7-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 464013] Review Request: findbugs-bcel - Byte Code Engineering Library with findbugs extensions

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464013


Mary Ellen Foster mefos...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #13 from Mary Ellen Foster mefos...@gmail.com  2009-01-28 
08:05:00 EDT ---
Builds cleanly for me in mock this time.

Better late than never: APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481141] Review Request: pycryptsetup - Python bindings for cryptsetup tool

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481141


Martin Sivák msi...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #7 from Martin Sivák msi...@redhat.com  2009-01-28 08:05:10 EDT 
---
New Package CVS Request
===
Package Name: python-cryptsetup
Short Description: Python libraries to ease LUKS manipulation from python code
Owners: msivak
Branches: Devel
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 473537] Review Request: jcodings - Java Libraries for Ruby String Encodings

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473537


Mary Ellen Foster mefos...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?, |fedora-review+
   |needinfo?(mefos...@gmail.co |
   |m)  |




--- Comment #5 from Mary Ellen Foster mefos...@gmail.com  2009-01-28 08:03:18 
EDT ---
Argh, sorry about that ... Christmas holidays followed by $DAYJOB busy-ness.
The changes look good, and the lack of documentation is annoying but I guess
not a total show-stopper. It builds cleanly in mock for me.

Better later than never: APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481508] Review Request: pipviewer - Visualizer for multiple alignments of genomic sequences

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481508


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #4 from Fabian Affolter fab...@bernewireless.net  2009-01-28 
08:13:13 EDT ---
New Package CVS Request
===
Package Name: pipviewer
Short Description: Visualizer for multiple alignments of genomic sequences
Owners: fab
Branches: F-9 F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478603] Review Request: pysnmp - SNMP engine written in Python

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478603


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #5 from Fabian Affolter fab...@bernewireless.net  2009-01-28 
08:13:45 EDT ---
New Package CVS Request
===
Package Name: pysnmp
Short Description: SNMP engine written in Python
Owners: fab
Branches: F-9 F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 464045] Review Request: sreadahead - Super Read Ahead

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464045





--- Comment #7 from Harald Hoyer har...@redhat.com  2009-01-28 08:24:48 EDT 
---
any progress on the kernel patch?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481732


Lubomir Rintel lkund...@v3.sk changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lkund...@v3.sk
 AssignedTo|nob...@fedoraproject.org|lkund...@v3.sk
   Flag||fedora-review?




--- Comment #3 from Lubomir Rintel lkund...@v3.sk  2009-01-28 08:29:02 EDT ---
Taking this.

(In reply to comment #1)
 Hello, this is my second package, I am seeking sponsor like at bug 481272

I could sponsor you, but I can't find any reviews you've participated in. Would
you mind pointing me to some, so I can be sure about your packaging abilities?
In case you haven't done so, I recommend picking up a couple of review requests
and doing preliminary reviews. Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481564] Review Request: bind-to-tinydns - Convert DNS zone files in BIND format to tinydns format

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481564





--- Comment #11 from manuel wolfshant wo...@nobugconsulting.ro  2009-01-28 
08:43:33 EDT ---
I've tested it yesterday :)
With your patch it looks OK.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481732





--- Comment #4 from Petr Sklenar pskle...@redhat.com  2009-01-28 08:44:51 EDT 
---
I started with fedora packaging these time so I haven't done any pre-review,
but I would like.

Please can you recommend me some review to do preliminary review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467401] Review Request: mingw32-libjpeg - MinGW Windows Libjpeg library

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467401


Adam Tkac at...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-review+




--- Comment #8 from Adam Tkac at...@redhat.com  2009-01-28 08:43:12 EDT ---
Ok, all problems have been fixed = reviewed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225694] Merge Review: dictd

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225694





--- Comment #5 from Karsten Hopp kars...@redhat.com  2009-01-28 08:43:13 EDT 
---
Thanks a lot for the review !
I've added the disttag as that one makes it much easier to reuse the spec file
for different releases and I just forgot to add it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481732





--- Comment #5 from manuel wolfshant wo...@nobugconsulting.ro  2009-01-28 
08:51:05 EDT ---
Petr, you could start for instance with
https://bugzilla.redhat.com/show_bug.cgi?id=480860 which is an easy one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467401] Review Request: mingw32-libjpeg - MinGW Windows Libjpeg library

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467401


Richard W.M. Jones rjo...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #9 from Richard W.M. Jones rjo...@redhat.com  2009-01-28 08:53:47 
EDT ---
New Package CVS Request
===
Package Name: mingw32-libjpeg
Short Description: MinGW Windows Libjpeg library
Owners: rjones berrange lfarkas
Branches: F-10 EL-5
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481564] Review Request: bind-to-tinydns - Convert DNS zone files in BIND format to tinydns format

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481564





--- Comment #12 from Itamar Reis Peixoto ita...@ispbrasil.com.br  2009-01-28 
08:59:51 EDT ---
(In reply to comment #11)
 I've tested it yesterday :)
 With your patch it looks OK.

then please add the review flag again +, so Tim Jackson will able to request
cvs access.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481732





--- Comment #6 from Petr Sklenar pskle...@redhat.com  2009-01-28 09:01:48 EDT 
---
re Comment #5:
OK, thanks much

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 460600] Review Request: msp430-binutils - Cross compiling binutils targeted at the msp430

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460600





--- Comment #24 from Robert Spanton rspan...@zepler.net  2009-01-28 09:02:13 
EDT ---
Steve, thanks -- I wasn't sure whether it was the done thing to add karma to
one's own package.

If you want to be a second maintainer on it, I've not problem with that :-)

I should get around to submitting the msp430-gcc, msp430-libc and msp430-gdb
packages for review in the next couple of days.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482827] New: Review Request: banshee-extension-mirage - An Automatic Playlist Generation Extension for Banshee

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: banshee-extension-mirage -  An Automatic Playlist 
Generation Extension for Banshee

https://bugzilla.redhat.com/show_bug.cgi?id=482827

   Summary: Review Request: banshee-extension-mirage -  An
Automatic Playlist Generation Extension for Banshee
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: gnomeu...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://dnielsen.fedorapeople.org/banshee-extension-mirage.spec
SRPM URL:
http://dnielsen.fedorapeople.org/banshee-extension-mirage-0.4.0-1.fc10.src.rpm
Description: Mirage is a Banshee plugin that provides innovative spectrum
analysis capabilities for the purpose of generating intelligent playlists.
See also http://hop.at/mirage/ for demonstration videos and further
information.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481732] Review Request: stardict-english-czech - czech dictionary for stardict

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481732





--- Comment #7 from Lubomir Rintel lkund...@v3.sk  2009-01-28 09:11:01 EDT ---
Here's the review queue:

http://fedoraproject.org/PackageReviewStatus/REVIEW.html

You are probably looking for bugs in NEW state, assigned to (Nobody).
By skimming through the list I've managed to find one package for which the
review did not start at all yet: python-argparse (bug #462505)

You may want to help your colleagues with Merge reviews as well ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 310631] Review Request: wmnd - A network monitoring dock app for WindowMaker

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=310631


Lubomir Rintel lkund...@v3.sk changed:

   What|Removed |Added

 CC||lkund...@v3.sk
   Flag|fedora-review?  |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481528


Ralf Corsepius rc040...@freenet.de changed:

   What|Removed |Added

 CC||rc040...@freenet.de




--- Comment #7 from Ralf Corsepius rc040...@freenet.de  2009-01-28 09:20:43 
EDT ---
Feel adviced to add perl-sig to InitialCC, like most perl package maintainer
do.

Activate the test suite. A test suite being noisy doesn't justify deactivating
it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 460600] Review Request: msp430-binutils - Cross compiling binutils targeted at the msp430

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460600





--- Comment #25 from Steve Whitehouse swhit...@redhat.com  2009-01-28 
09:16:53 EDT ---
Yes, I wondered about that too, but I've tended to find that with the packages
that I've been working on (with a fairly low user base compared with the core
packages) if I don't do that and then specifically ask other people to look at
the package, then it can just sit around in limbo forever. I think provided
you've checked to see that it works, there should be no problem really.

I'll send the requests through shortly for the other permissions in that case.

It will be really good to get the other packages in too. I guess the one bit we
can't do is the gdb proxy bit as it has a funny license, which is a pity I
think as it would have made a nice set. Even so, getting the core bits in is
really good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480373] Review Request: cilk - Language for multithreaded parallel programming.

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480373





--- Comment #6 from Adam Miller maxamill...@gmail.com  2009-01-28 09:26:18 
EDT ---
Spec URL: http://maxamillion.fedorapeople.org/cilk.spec
SRPM URL: http://maxamillion.fedorapeople.org/cilk-5.4.6-3.src.rpm

Added the %check, fixed the CFLAGS, also added the %{?_smp_mflags}

rpmlint still throws warning about devel-file-in-non-devel-package but i'm not
entirely sure that's a valid warning as the libs are specific to the app.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480373] Review Request: cilk - Language for multithreaded parallel programming.

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480373





--- Comment #7 from Ian Weller ianwel...@gmail.com  2009-01-28 09:52:29 EDT 
---
rpmlint still throws warning about devel-file-in-non-devel-package because you
need a -devel subpackage for those files. See the packaging guidelines.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481528] Review Request: perl-DBIx-Safe - Safer access to your database through a DBI database handle

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481528





--- Comment #8 from Itamar Reis Peixoto ita...@ispbrasil.com.br  2009-01-28 
10:12:57 EDT ---
(In reply to comment #7)

done.

http://ispbrasil.com.br/perl-DBIx-Safe/perl-DBIx-Safe.spec
http://ispbrasil.com.br/perl-DBIx-Safe/perl-DBIx-Safe-1.2.5-4.fc10.src.rpm




New Package CVS Request
===
Package Name: perl-DBIx-Safe
Short Description: Safer access to your database through a DBI database handle
Owners: itamarjp
Branches: F-10 F-9
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481322] Review Request: emacs-magit - Emacs interface to the most common Git operations

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481322


Jerry James loganje...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #4 from Jerry James loganje...@gmail.com  2009-01-28 10:16:16 EDT 
---
Looks good, Tom.  APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480146] Review Request: python-bicyclerepair - Python Refactoring Browser

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480146





--- Comment #7 from Jochen Schmitt joc...@herr-schmitt.de  2009-01-28 
10:17:55 EDT ---
Created an attachment (id=330235)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=330235)
Suggested SPEC file for python-bicyclerepair

I have found the x86_64 reletating issue. You have to use the %{python_sitelib}
macro instead of %{_libdir} on the find command in your SPEC files.

Additionaly, I think we can remove the python-devel BR, because it's only
require for compiled python extension.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481594] Review Request: python-pygooglechart - A complete Python wrapper for the Google Chart API

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481594


Jochen Schmitt joc...@herr-schmitt.de changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #7 from Jochen Schmitt joc...@herr-schmitt.de  2009-01-28 
10:25:04 EDT ---
Good:
+ Package has comment about why the test script could not used.
+ Local build works fine.
+ Build on koji works fine

*** APPROVED ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 464045] Review Request: sreadahead - Super Read Ahead

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464045





--- Comment #8 from Bill Nottingham nott...@redhat.com  2009-01-28 10:40:14 
EDT ---
It's an entirely different kernel patch now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226463] Merge Review: system-config-netboot

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226463


Jaroslav Reznik jrez...@redhat.com changed:

   What|Removed |Added

   Flag|needinfo?   |




--- Comment #11 from Jaroslav Reznik jrez...@redhat.com  2009-01-28 10:41:20 
EDT ---
Sorry, it takes so long but now it's already built for rawhide -
http://koji.fedoraproject.org/koji/taskinfo?taskID=103

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482856] New: Review Request: perl-MooseX-POE - Moose wrapper around a POE::Session

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-MooseX-POE - Moose wrapper around a POE::Session

https://bugzilla.redhat.com/show_bug.cgi?id=482856

   Summary: Review Request: perl-MooseX-POE - Moose wrapper around
a POE::Session
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: allis...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://allisson.fedorapeople.org/packages/perl-MooseX-POE/perl-MooseX-POE.spec

SRPM URL:
http://allisson.fedorapeople.org/packages/perl-MooseX-POE/perl-MooseX-POE-0.1-1.fc10.src.rpm

Description: MooseX::POE::Object is a Moose wrapper around a POE::Session.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 480860] Review Request: timespan - A tool that performs date-based time calculations

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480860


Petr Sklenar pskle...@redhat.com changed:

   What|Removed |Added

 CC||pskle...@redhat.com




--- Comment #4 from Petr Sklenar pskle...@redhat.com  2009-01-28 10:45:55 EDT 
---
Hello,
This is my informal review. I cannot sponsor you as I'm not an approved
packager. Your package and specfile seems OK for me:

My review:

+ rpmlint output is clean.
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec. There is timespan.spec.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license.
GPLv2+
+ There is license in separate file in %doc :
/usr/share/doc/timespan-2.1/COPYING
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package match the upstream source, as provided
in the spec URL (md5sum timespan-2.1.tar.gz  c9d545eb5f617b29b3a634d7a0aec39a
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture.
+ All build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of the Packaging Guidelines.
+ The package owns all directories that it creates.
+ There isn't duplicate files in the %files listing.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot}.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
+ Package doesn't own files or directories already owned by other packages.
+ At the beginning of %install, package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All file names in rpm packages are valid UTF-8.
architectures.

+ I did a limited test that the package functions as described, like
'/usr/bin/timespan -l now'
+ Summary and description corresponds package's home.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467376] Review Request: mingw32-pixman - MinGW Windows Pixman library

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467376


Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #9 from Peter Robinson pbrobin...@gmail.com  2009-01-28 11:06:41 
EDT ---
Sorry, been away. It all seems fine to me. Overall with the mingw* packages I
think there generally need to be updates to the packaging specs to cover the
mingw requirements (and rpmlint as appropriate) and also to include the license
file (to be fair we'd roast a commercial company for this!) and most of the
mingw reviews would be a breeze!

APPROVED!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453083] Review Request: Samba4 - Samba4 CIFS and AD server and client

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453083





--- Comment #41 from Matthias Clasen mcla...@redhat.com  2009-01-28 11:13:01 
EDT ---
Looks like the description of the -python subpackage should end in a period,
not a slash.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482863] New: Review Request: perl-MooseX-Daemonize - Role for daemonizing your Moose based application

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-MooseX-Daemonize  - Role for daemonizing your 
Moose based application

https://bugzilla.redhat.com/show_bug.cgi?id=482863

   Summary: Review Request: perl-MooseX-Daemonize  - Role for
daemonizing your Moose based application
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: allis...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://allisson.fedorapeople.org/packages/perl-MooseX-Daemonize/perl-MooseX-Daemonize.spec

SRPM URL:
http://allisson.fedorapeople.org/packages/perl-MooseX-Daemonize/perl-MooseX-Daemonize-0.08-1.fc10.src.rpm

Description: Often you want to write a persistent daemon that has a pid file,
and responds 
appropriately to Signals. This module provides a set of basic roles as an 
infrastructure to do that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453083] Review Request: Samba4 - Samba4 CIFS and AD server and client

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453083





--- Comment #42 from Matthias Clasen mcla...@redhat.com  2009-01-28 11:14:13 
EDT ---
And I think python wants to be capitalized when used as a name (compare
descriptions of other python packages).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467376] Review Request: mingw32-pixman - MinGW Windows Pixman library

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467376


Richard W.M. Jones rjo...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #11 from Richard W.M. Jones rjo...@redhat.com  2009-01-28 
11:25:05 EDT ---
New Package CVS Request
===
Package Name: mingw32-pixman
Short Description: MinGW Windows Pixman library
Owners: rjones berrange lfarkas
Branches: F-10 EL-5
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 467376] Review Request: mingw32-pixman - MinGW Windows Pixman library

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467376





--- Comment #10 from Richard W.M. Jones rjo...@redhat.com  2009-01-28 
11:23:27 EDT ---
Thanks Peter.

CVS request coming up ...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 464045] Review Request: sreadahead - Super Read Ahead

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464045





--- Comment #9 from Harald Hoyer har...@redhat.com  2009-01-28 11:25:40 EDT 
---
This one: http://lkml.org/lkml/2009/1/27/297 
together with sreadahead-1.0 http://lkml.org/lkml/2009/1/27/296

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 476758] Review Request: libspiro - Library to simplify the drawing of beautiful curves

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476758


Nils Philippsen nphil...@redhat.com changed:

   What|Removed |Added

 CC||nphil...@redhat.com
   Flag|fedora-cvs+ |fedora-cvs?




--- Comment #6 from Nils Philippsen nphil...@redhat.com  2009-01-28 11:30:23 
EDT ---
Package Change Request
==
Package Name: libspiro
New Branches: F-9 F-10
Owners: kevin nphilipp

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 474864] Review Request: perl-Test-Signature - Automated SIGNATURE testing

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=474864


Iain Arnell iarn...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?




--- Comment #11 from Iain Arnell iarn...@gmail.com  2009-01-28 11:37:37 EDT 
---
Package Change Request
==
Package Name: perl-Test-Signature
New Branches: EL-5
Owners: iarnell
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481322] Review Request: emacs-magit - Emacs interface to the most common Git operations

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481322


Tom Moertel t...@moertel.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #5 from Tom Moertel t...@moertel.com  2009-01-28 11:38:14 EDT ---
New Package CVS Request
===
Package Name: emacs-magit
Short Description: Emacs interface to the most common Git operations
Owners: tmoertel
Branches: F-9 F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481389] Review Request: beesu - Beesu is a wrapper around su

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481389





--- Comment #3 from bee honeybeehoneyhive-red...@yahoo.com  2009-01-28 
11:41:59 EDT ---
Thank you for your help Simon lukasìk
But, how much time do i have to wait for a sponsor to find me? i see nobody
around!
Thank you again!!

bye!!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481564] Review Request: bind-to-tinydns - Convert DNS zone files in BIND format to tinydns format

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481564


manuel wolfshant wo...@nobugconsulting.ro changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #13 from manuel wolfshant wo...@nobugconsulting.ro  2009-01-28 
11:44:51 EDT ---
Right, here we go.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481759] Review Request: python-Apptools - Enthough Tool Suite Application Tools

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481759


Jochen Schmitt joc...@herr-schmitt.de changed:

   What|Removed |Added

 CC||joc...@herr-schmitt.de
 AssignedTo|nob...@fedoraproject.org|joc...@herr-schmitt.de
   Flag||fedora-review?




--- Comment #1 from Jochen Schmitt joc...@herr-schmitt.de  2009-01-28 
11:46:46 EDT ---
Good:
+ Basename of SPEC file matches with package name
+ Name of the package fits naming guidelines for python addon packages
+ Consistently usage of rpm macros
+ Could download upstream tarball with spectool
+ Package contains most recent release of the software
+ Tar ball in the package matches with upstream
(md5sum: e67d9b40a9f88f62246a8248faede6c5)
+ Package contains proper License tag
+ License tag claims BSD and LGPLv2+ as valid OSS licenses
+ Package contains a verbatin copy of the license text
+ %doc stanza is small, so we not need a separate doc subpackage
+ Buildroot definition seems ok
+ Local install/uninstall works fine
+ Packaged files have proper files permissions
+ Packaged files are owned by the package
+ Packaged files doesn't own by other packages
+ Build on koji without python-setupdocs fails, because
package try to download it from the internet
+ Package contains no subpackages
+ Locel build works fine
+ Rpmlint is silient for source and binary rpms.
+ Buildroot will be cleaned on the beginning of %clean and %install
+ Package contains proper %changelog

Questions:
* Does it may sense to pacakge the %{python_sitelib}/integrationtest directory?
I assume it's only require for testing the built package, so we should remove
this directory from the package.

Bad:
- Cant find python-setupdocs in the Fedora repository
- Please remove the AppTools.egg-info directory from the sources
in the %setup stanza to make sure, that the err-info files are built
from sources

TODO:
- Not all source files have a proper copyright note
  (Please notify the upstream maintainer to fix this issue in the next release)
- A refview shows, that mostly all files which have a copyrith note
are licensed under the terms of the BSD license. So why there are references
agains the LGPLv2+?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226314] Merge Review: prctl

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226314





--- Comment #5 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-01-28 
11:48:53 EDT ---
Thanks for the explanation.
So I can't to do a test to evaluate the software but I could do a generic
package review since it is a simple one.
There is one minor issue and a few suggestions. Let me know whenever you update
the package so we can close the bug.

* rpmlint says
  prctl.src:22: W: setup-not-quiet
You need to use 
  %setup -q

! no disttag. I think it could be better to have a disttag to avoid
incompatibilities between the binaries produced by different versions of the
compiler. What do you think?

! The patch is trivial. I don't think it is necessary to submit upstream. It
would be nice though.

! You can make use of the %{name} macro a little more frequent

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481725] Review Request: python-setupdocs - Setuptools plugin

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481725


Jochen Schmitt joc...@herr-schmitt.de changed:

   What|Removed |Added

 CC||joc...@herr-schmitt.de




--- Comment #4 from Jochen Schmitt joc...@herr-schmitt.de  2009-01-28 
11:56:44 EDT ---
Unfortunately I have found a mistake in the package

The packaging guidlines says, theat the egg-info files should be build from
source. So it may be helpful to remove the setupdocs.egg-info directory from
source in the %setup stanza.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 227027] Review Request: ant-contrib-1.0-0.b2.1jpp - Collection of tasks for Ant

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=227027


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

 CC||fab...@bernewireless.net




--- Comment #14 from Fabian Affolter fab...@bernewireless.net  2009-01-28 
11:57:10 EDT ---
This package is in Fedora [1], but the review is '-'

[1] https://admin.fedoraproject.org/pkgdb/packages/name/ant-contrib

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226314] Merge Review: prctl

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226314





--- Comment #6 from Karsten Hopp kars...@redhat.com  2009-01-28 12:05:52 EDT 
---
I've added changes for those in CVS:
- added disttag
- setup -q
- frequent use of %{name} macro with the exception of the URL, because that's
  the string I use with cutpaste and firefox to check if there's a new
version.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=442233


Dave Jones da...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482880] Review Request: perl-Sane - Access SANE-compatible scanners with perl

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482880


Bernard Johnson bjohn...@symetrix.com changed:

   What|Removed |Added

 Blocks||482882




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482880] New: Review Request: perl-Sane - Access SANE-compatible scanners with perl

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Sane - Access SANE-compatible scanners with perl

https://bugzilla.redhat.com/show_bug.cgi?id=482880

   Summary: Review Request: perl-Sane - Access SANE-compatible
scanners with perl
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: bjohn...@symetrix.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://fedorapeople.org/~bjohnson/perl-Sane.spec
SRPM URL: http://fedorapeople.org/~bjohnson/perl-Sane-0.02-1.fc10.src.rpm
Description: 
This module allows you to access SANE-compatible scanners in a Perlish and
object-oriented way, freeing you from the casting and memory management in C,
yet remaining very close in spirit to original API.


Note: I've already queried the author regarding adding a license file and he
thought that the README was sufficient.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481725] Review Request: python-setupdocs - Setuptools plugin

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481725





--- Comment #5 from José Matos jama...@fc.up.pt  2009-01-28 12:14:01 EDT ---
Argh... good catch.

I have examined the source ball egg-info dir and I have forgot to do the same
in the generated rpm as I was expecting for setuptools to do the right thing.
My mistake. :-(

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 226314] Merge Review: prctl

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226314


Orcan 'oget' Ogetbil oget.fed...@gmail.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||RAWHIDE
 AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com
   Flag||fedora-review+




--- Comment #7 from Orcan 'oget' Ogetbil oget.fed...@gmail.com  2009-01-28 
12:16:45 EDT ---
Great! Thanks.

-
This Merge Review (prctl) is APPROVED by oget
-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478447] Review Request: qtgpsc - A client for the gpsd GPS server

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478447





--- Comment #1 from Lucian Langa co...@gnome.eu.org  2009-01-28 12:15:15 EDT 
---
OK  source files match upstream:
3e7bf8b2bd2e21c5082a52a37e381046  qtgpsc-0.2.3.tar.gz
OK  package meets naming and versioning guidelines.
OK  specfile is properly named, is cleanly written and uses macros
consistently.
OK  summary a short and concise description.
OK  description is OK.
OK  dist tag is present.
OK  build root is sane.
NOT OK  license field matches the actual license.
OK  license is open source-compatible.
OK  license text included in package.
OK  BuildRequires are proper.
OK  compiler flags are appropriate.
OK  %clean is present.
OK  package builds in mock (rawhide, x86_64).
OK  package installs properly.
OK  debuginfo package looks complete.
OK  rpmlint is silent.
  final provides and requires are sane:
qtgpsc = 0.2.3-1.fc11
qtgpsc(x86-64) = 0.2.3-1.fc11
  =
libX11.so.6()(64bit)
libXext.so.6()(64bit)
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgps.so.17()(64bit)
libm.so.6()(64bit)
libqt-mt.so.3()(64bit)
libstdc++.so.6()(64bit)
OK  %check is not present; no test suite upstream.
N/A no shared libraries are added to the regular linker search paths.
OK  owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  code, not content.
OK  documentation is small, so no -doc subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  no headers.
OK  no pkgconfig files.
OK  no static libraries.
OK  no libtool .la files.
OK  gui application; desktop file installed properly

Source0 is mistyped

desktop-file-validate qtgpsc.desktop
qtgpsc.desktop: warning: value Application;Utility; for key Categories in
group Desktop Entry contains a deprecated value Application

License should be BSD not MIT.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481759] Review Request: python-Apptools - Enthough Tool Suite Application Tools

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481759


Jochen Schmitt joc...@herr-schmitt.de changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




--- Comment #2 from Jochen Schmitt joc...@herr-schmitt.de  2009-01-28 
12:26:16 EDT ---
Unfortunately, I have not seen, that you have a review request for the
python-setupdocs package.

So I have built it self on the base of the source rpm provided by your review
request.

After then I have create an local yum repository in which I have put
python-setupdocs.

Now, when I try to doa mock build agains rawhide (x86_64) and including my
local yum repository, the build works fine.

I want to suggest, that you are notify me, if the python-setupdocs package is
available on koji, so we can do another tryp to build your package on koji

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482884] New: Review Request: CLC-INTERCAL - Compiler Language With No Pronounceable Acronym

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: CLC-INTERCAL - Compiler Language With No Pronounceable 
Acronym

https://bugzilla.redhat.com/show_bug.cgi?id=482884

   Summary: Review Request: CLC-INTERCAL - Compiler Language With
No Pronounceable Acronym
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: iarn...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://iarnell.fedorapeople.org/rpms/CLC-INTERCAL.spec
SRPM URL: http://iarnell.fedorapeople.org/rpms/CLC-INTERCAL-0-0.0.fc11.src.rpm
Description: Compiler Language With No Pronounceable Acronym.

Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1089200

Notes:
CLC-INTERCAL uses a novel perversion (rather than version, for correctness)
numbering system consisting of a floating point number with independent signs
for the integer and fractional parts. The current number is 1.-94.-2.
Unfortunately, RPM is unable to cope with such numbering, so I took some
liberties with sub-packages to make the resulting binary RPMs look almost
right. 

The license is almost-but-not-quite 3 clause BSD. The clauses are the same, but
the introduction slightly different: In addition to the above, permission is
hereby granted to use, misuse, modify, distribute, break, fix again, etcetera
CLC-INTERCAL-1.-94.-2 provided that the following conditions are met.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453083] Review Request: Samba4 - Samba4 CIFS and AD server and client

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453083





--- Comment #44 from Matthias Clasen mcla...@redhat.com  2009-01-28 12:41:36 
EDT ---
I think the disabling of the winbind package would better be done with

%if %enable_winbind

or somesuch

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453083] Review Request: Samba4 - Samba4 CIFS and AD server and client

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453083





--- Comment #43 from Matthias Clasen mcla...@redhat.com  2009-01-28 12:39:07 
EDT ---
There is some mixed use of $RPM_BUILD_ROOT and %{buildroot} that should
probably be cleaned up always use the one or the other.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482884] Review Request: CLC-INTERCAL - Compiler Language With No Pronounceable Acronym

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482884


Jochen Schmitt joc...@herr-schmitt.de changed:

   What|Removed |Added

 CC||joc...@herr-schmitt.de




--- Comment #1 from Jochen Schmitt joc...@herr-schmitt.de  2009-01-28 
12:47:46 EDT ---
Question: It this your first Fedora package?

I ask this, because the package look like it's need some love.

I try to summarize my first mind about this package:

1. At first, you should try to get a better description the package, so a user
which want to install the package may got a idea, why he should try out this
new programming language

2. Your have specified 0 as the global package version and add version
information on the definition of subpackage. This is not ok, you should put the
version information on the Version statement and the subpackage shouldn't have
any version information in thier name.

3.) It's look very ugly, that you are using rpm macros for the whole content of
the Summary and Group statement.

Unfortunately, I either a sponsor or a perl packaging specialist, so I can't
review your package, but I would show your some points which are needs some
homework.

If this you first package and you need a sponsor please set the FE-NEEDSPONSOR
bug as a blocker.

Best Regards:

Jochen Schmitt

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 481389] Review Request: beesu - Beesu is a wrapper around su

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481389


Itamar Reis Peixoto ita...@ispbrasil.com.br changed:

   What|Removed |Added

 CC||ita...@ispbrasil.com.br




--- Comment #4 from Itamar Reis Peixoto ita...@ispbrasil.com.br  2009-01-28 
12:23:03 EDT ---
sponsors generally are too busy, don't worry, someone will sponsor you as soon
as possible, but if you like to speed up this process then you can submit more
packages to review

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478393] Review Request: sugar-imageviewer - Simple image viewer for Sugar

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478393





--- Comment #4 from Fabian Affolter fab...@bernewireless.net  2009-01-28 
12:59:55 EDT ---
Thanks for reviewing and the cvs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 468491] Review Request: sugar-connect - Connect for Sugar

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468491


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

External Bug ID||OLPC 9221




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478447] Review Request: qtgpsc - A client for the gpsd GPS server

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478447


Lucian Langa co...@gnome.eu.org changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Comment #3 from Lucian Langa co...@gnome.eu.org  2009-01-28 13:27:53 EDT 
---
Looks good; thank you!

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 478447] Review Request: qtgpsc - A client for the gpsd GPS server

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478447


Fabian Affolter fab...@bernewireless.net changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #4 from Fabian Affolter fab...@bernewireless.net  2009-01-28 
13:38:53 EDT ---
New Package CVS Request
===
Package Name: qtgpsc
Short Description: A client for the gpsd GPS server
Owners: fab
Branches: F-9 F-10
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482902] New: Review Request: gsh - aggregate several remote shells into one

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: gsh - aggregate several remote shells into one

https://bugzilla.redhat.com/show_bug.cgi?id=482902

   Summary: Review Request: gsh - aggregate several remote shells
into one
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: maxamill...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-review@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://maxamillion.fedorapeople.org/gsh.spec
SRPM URL: http://maxamillion.fedorapeople.org/gsh-0.3-1.src.rpm

Description: gsh is used to launch several remote shells on many machines at
the same time and control them from a single command prompt.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225852] Merge Review: gok

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225852





--- Comment #5 from Debarshi Ray debarshi@gmail.com  2009-01-28 14:35:31 
EDT ---
 + According to
   https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make you should
   use 'make %{?_smp_mflags}' whenever possible. In this case since upstream
   supports parallel builds you should use it.

You have missed this one.

Sorry for not mentioning this earlier, but thanks to the new RPM in Rawhide the
following Requires in the -devel sub-package are redundant:
Requires: libgnomeui-devel
Requires: atk-devel
Requires: libbonobo-devel
Requires: gtk2-devel
Requires: gail-devel
Requires: libwnck-devel
Requires: esound-devel
Requires: at-spi-devel
Requires: pkgconfig

[ri...@freebook tmp]$ rpm --requires -qp gok-devel-2.25.3-3.fc11.x86_64.rpm
/usr/bin/pkg-config
[...]
pkgconfig(atk)
pkgconfig(cspi-1.0)
pkgconfig(esound)
pkgconfig(gail)
pkgconfig(gtk+-2.0)
pkgconfig(libbonobo-2.0)
pkgconfig(libgnomeui-2.0)
pkgconfig(libspi-1.0)
pkgconfig(libwnck-1.0)

Even though https://fedoraproject.org/wiki/Packaging:Guidelines#Pkgconfig_Files
still mandates the use of 'Requires: pkgconfig', Spot confirmed that they are
not needed from Fedora 11 onwards.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453083] Review Request: Samba4 - Samba4 CIFS and AD server and client

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453083





--- Comment #45 from Matthias Clasen mcla...@redhat.com  2009-01-28 14:37:50 
EDT ---
the main samba4 package include something called /usr/bin/tdbtorture, which
from the looks of it, is a test program for the tdb code. As such, it should
probably go in the -devel package, if at all.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 482827] Review Request: banshee-extension-mirage - An Automatic Playlist Generation Extension for Banshee

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482827


Jochen Schmitt joc...@herr-schmitt.de changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||joc...@herr-schmitt.de
 AssignedTo|nob...@fedoraproject.org|joc...@herr-schmitt.de
   Flag||fedora-review?




--- Comment #1 from Jochen Schmitt joc...@herr-schmitt.de  2009-01-28 
14:07:43 EDT ---
Good:
+ Base name of the SPEC file matches to package name
+ Buildroot will be cleaned at the beginn of %clean and %install
+ Local build works fine
+ Can download upstream tar ball with spectool
+ Tar ball in package matches with upstream
(md5sum: 7ebb939d44b64667eaa90ab1ef9a2220)
+ Package contains License tag
+ Package contains a verbatin copy of the license text
+ Buildroot declaration is ok
+ Package contains no patches
+ Package has not subpackages
+ $RPM_OPT_FLAGS are used during the build
+ Excluding of pp64 is ok
+ Local build works fine
+ Start of banshee with install package works
+ Local install works fine
+ Local uninstall works fine
+ Koji build works fine
+ %doc stanza is small, so we need no deparate doc subpackage
+ Packaged files of proper permissions
+ Packaged files are owned by the package
+ Package files have no comflict to other packages
+ Buildroot will be cleaned at the beginning of %clean and %install
+ *.a and *.la file are remove in the %install stanza
+ Package use %find_lang for i18n
+ Proper Changelog


Bad:
- IMHO the package name should be banshee-mirage instead of
banshee-extension-mirage
- Mixed use of $RRP_ROOT_BUILD and %{buildroot}
- Package has no %{?_smp_mflags} without a comment why
- Package banshee-musicbrainz-devel doesn't exit in Fedora repository, but
I could not found a blocker bug for a review of this package
- Rpmlint complaints for source package:
$ rpmlint banshee-extension-mirage-0.4.0-1.fc10.src.rpm
banshee-extension-mirage.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1,
tab: line 3)
banshee-extension-mirage.src: W: invalid-license X11/MIT
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
- rpmlint complaints binary rpm:
$ rpmlint banshee-extension-mirage-0.4.0-1.fc10.x86_64.rpm
banshee-extension-mirage.x86_64: W: invalid-license X11/MIT
banshee-extension-mirage.x86_64: W: unstripped-binary-or-object
/usr/lib64/libmirageaudio.so
banshee-extension-mirage.x86_64: E: invalid-soname /usr/lib64/libmirageaudio.so
libmirageaudio.so
1 packages and 0 specfiles checked; 1 errors, 2 warnings.
- License tag catins wrong license specification.
A short review of the copyright notes in the source files show that GPLv2+ may
be
the right specificiation for the license tag)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453083] Review Request: Samba4 - Samba4 CIFS and AD server and client

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453083





--- Comment #46 from Matthias Clasen mcla...@redhat.com  2009-01-28 14:42:58 
EDT ---
Similar for smbtorture and subunitrun in the -common subpackage

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225852] Merge Review: gok

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225852


Matthias Clasen mcla...@redhat.com changed:

   What|Removed |Added

   Flag|needinfo?(dav...@redhat.com |
   |)   |




--- Comment #6 from Matthias Clasen mcla...@redhat.com  2009-01-28 14:50:41 
EDT ---
 You have missed this one.

No, I haven't. I didn't feel it was worth it. There's only so much time I can
justify spending on irrelevant details of a spec file that make no difference
whatsoever to the resulting package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453083] Review Request: Samba4 - Samba4 CIFS and AD server and client

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453083





--- Comment #47 from Matthias Clasen mcla...@redhat.com  2009-01-28 14:55:52 
EDT ---
And I'm not sure we want a program called /usr/bin/nsstest shipped as part of
samba4-devel. 


The -python subpackage has a bunch of autogenerated provides that I don't think
it should have:
atsvc.so  
auth.so  
base.so  
com.so  
credentials.so  
dfs.so  
drsuapi.so  
echo.so  
epmapper.so  
glue.so  
initshutdown.so  
irpc.so  
ldb.so  
lsa.so  
messaging.so  
mgmt.so  
misc.so  
nbt.so  
net.so  
netbios.so  
param.so  
registry.so  
samr.so  
security.so  
svcctl.so  
tdb.so  
tevent.so  
unixinfo.so  
uuid.so  
winreg.so  
wkssvc.so

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453083] Review Request: Samba4 - Samba4 CIFS and AD server and client

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453083





--- Comment #48 from Matthias Clasen mcla...@redhat.com  2009-01-28 14:56:54 
EDT ---
The -devel package shouldn't own /usr/lib/pkgconfig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453083] Review Request: Samba4 - Samba4 CIFS and AD server and client

2009-01-28 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453083


Matthias Clasen mcla...@redhat.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|mcla...@redhat.com




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


  1   2   >