Re: [FFmpeg-devel] [PATCH 2/2] avcodec/takdec: remove unused variable

2014-08-03 Thread Paul B Mahol
On Sat, Aug 2, 2014 at 9:43 PM, Michael Niedermayer michae...@gmx.at wrote: Found-by: CSA Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/takdec.c |1 - 1 file changed, 1 deletion(-) ok ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] New p2p mode for showwaves filter

2014-08-03 Thread Paul B Mahol
On Thu, Jul 31, 2014 at 2:50 PM, mrskman mrsk...@gmail.com wrote: A few months ago I sent this patch and got some comments, which helped me to understand how this filter works. Thank you for that and I'm sorry it took me so long to reply. Here is a better version (atleast for me). Problem

Re: [FFmpeg-devel] [PATCH] doc/ffserver: merge paragraph starting with What happens next? with previous one

2014-08-03 Thread Stefano Sabatini
On date Saturday 2014-08-02 07:50:14 -0700, Timothy Gu encoded: On Aug 2, 2014 7:40 AM, Stefano Sabatini stefa...@gmail.com wrote: The name of the paragraph sounded a bit silly, and its text is small so it's better to merge it with the previous paragraph. --- doc/ffserver.texi | 8

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/takdec: move tmp declaration to where its used

2014-08-03 Thread Michael Niedermayer
On Sun, Aug 03, 2014 at 09:47:53AM +0200, Paul B Mahol wrote: On Sat, Aug 2, 2014 at 9:43 PM, Michael Niedermayer michae...@gmx.at wrote: Makes the code a bit easier to read Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/takdec.c |8 1 file

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/takdec: remove unused variable

2014-08-03 Thread Michael Niedermayer
On Sun, Aug 03, 2014 at 09:52:41AM +0200, Paul B Mahol wrote: On Sat, Aug 2, 2014 at 9:43 PM, Michael Niedermayer michae...@gmx.at wrote: Found-by: CSA Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/takdec.c |1 - 1 file changed, 1 deletion(-) ok applied

[FFmpeg-devel] [PATCH 2/5] lavfi/buffersrc: add add av_buffersrc_close().

2014-08-03 Thread Nicolas George
Also deprecate adding a NULL frame to mark EOF. TODO APIchanges entry, version bump. Signed-off-by: Nicolas George geo...@nsup.org --- libavfilter/buffersrc.c | 40 ++-- libavfilter/buffersrc.h | 15 +++ 2 files changed, 45 insertions(+), 10

[FFmpeg-devel] [PATCH 1/5] lavfi: add filter metaframes infrastructure.

2014-08-03 Thread Nicolas George
Metaframes are frames without data, identified by a negative format code, used to carry special conditions. They are sent only to filter that declare supporting them. The only metaframe for now is EOF; this mechanism augments the current mechanism based on request_frame() returning AVERROR_EOF,

[FFmpeg-devel] [PATCH 3/5] ffmpeg: use av_buffersrc_close().

2014-08-03 Thread Nicolas George
Signed-off-by: Nicolas George geo...@nsup.org --- ffmpeg.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index 1c1a559..3ac6620 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -1741,12 +1741,9 @@ static int decode_audio(InputStream *ist, AVPacket

[FFmpeg-devel] [PATCH 4/5] vf_fps: move flushing remaining frames in a separate function.

2014-08-03 Thread Nicolas George
Also remove unused loop counter, rename obsolete buf, and add a comment about a similar function. Signed-off-by: Nicolas George geo...@nsup.org --- libavfilter/vf_fps.c | 38 +- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git

[FFmpeg-devel] [PATCH 5/5] lavfi/vf_fps: accept EOF timestamp.

2014-08-03 Thread Nicolas George
This makes the FPS filter duplicate the last frame to take its duration into account, exactly like the other ones. Fix trac ticket #2674. Signed-off-by: Nicolas George geo...@nsup.org --- libavfilter/vf_fps.c | 33 + 1 file changed, 25 insertions(+), 8

Re: [FFmpeg-devel] [PATCH 1/4] lavfi: add filter metaframes infrastructure.

2014-08-03 Thread Nicolas George
Le quintidi 15 thermidor, an CCXXII, Stefano Sabatini a écrit : It shall probably execute the remaining part of the function even in case of failure. I am not completely sure about that. AFAIK, we consider most filtering failures fatal at some point or another anyway. I find this a bit

Re: [FFmpeg-devel] Inconsistent UDP output packet size - patch

2014-08-03 Thread Michael Niedermayer
On Tue, Jul 22, 2014 at 05:13:39PM +0600, Konstantin Shpinev wrote: Following https://trac.ffmpeg.org/ticket/2748 aviobuf.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) e26d95e9b0392d7b59a33700a9fe8ba7354cfd48

[FFmpeg-devel] [PATCH 1/2] lavfi/avf_showspectrum: set output frame rate.

2014-08-03 Thread Nicolas George
Signed-off-by: Nicolas George geo...@nsup.org --- libavfilter/avf_showspectrum.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/avf_showspectrum.c b/libavfilter/avf_showspectrum.c index 4a4b4f4..e3ae6ea 100644 --- a/libavfilter/avf_showspectrum.c +++

[FFmpeg-devel] [PATCH 2/2] lavfi/avf_showspectrum: fix output pts computation.

2014-08-03 Thread Nicolas George
Signed-off-by: Nicolas George geo...@nsup.org --- libavfilter/avf_showspectrum.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) These two patches fix a bunch of non-monotonically warnings/errors. diff --git a/libavfilter/avf_showspectrum.c b/libavfilter/avf_showspectrum.c index

[FFmpeg-devel] [PATCH] lavfi/avf_showspectrum: do not push the frame at EOF.

2014-08-03 Thread Nicolas George
It is always identical to the last pushed frame. The samples in the last incomplete window were ignored, this is unchanged. Possible enhancement: pad the last incomplete window with silence. Signed-off-by: Nicolas George geo...@nsup.org --- libavfilter/avf_showspectrum.c | 2 -- 1 file changed,

[FFmpeg-devel] [PATCH] lavfi/avf_showspectrum: use automatic framing.

2014-08-03 Thread Nicolas George
The framework can ensure that each input frame has exactly the correct number of samples, except the last one. Signed-off-by: Nicolas George geo...@nsup.org --- libavfilter/avf_showspectrum.c | 47 +++--- 1 file changed, 17 insertions(+), 30 deletions(-) diff

Re: [FFmpeg-devel] rectification filter

2014-08-03 Thread Daniel Oberhoff
Am 03.08.2014 um 03:15 schrieb Daniel Oberhoff danieloberh...@googlemail.com: Am 03.08.2014 um 00:12 schrieb Clément Bœsch u...@pkh.me: On Fri, Aug 01, 2014 at 12:56:42PM +0200, Daniel Oberhoff wrote: Am 01.08.2014 um 12:22 schrieb Clément Bœsch u...@pkh.me: On Fri, Aug 01, 2014 at

Re: [FFmpeg-devel] Reintroducing FFmpeg to Debian

2014-08-03 Thread Jose Luis Rivas
On 28/07/14, 01:20am, Andreas Cadhalpun wrote: Hi all, some of you may have noticed a weird ffmpeg package in the NEW queue[1]. Let me explain: In 2011 Libav[2] was forked from FFmpeg[3]. It was a time of great uncertainty, the fork happened with much drama that didn't help making a

Re: [FFmpeg-devel] [PATCH 1/4] libavcodec: new API for frame threading by step

2014-08-03 Thread Christophe Gisquet
Hi, note: I'm using step throughout the patch because of the step function and what the causal part most often looks like. I have no idea for another less confusing wording. 2014-07-28 23:15 GMT+02:00 Michael Niedermayer michae...@gmx.at: maybe i misunderstand but the progress[1] y check looks

Re: [FFmpeg-devel] rectification filter

2014-08-03 Thread Daniel Oberhoff
Am 03.08.2014 um 18:38 schrieb Paul B Mahol one...@gmail.com: On Sun, Aug 3, 2014 at 5:39 PM, Daniel Oberhoff danieloberh...@gmail.com wrote: Am 03.08.2014 um 03:15 schrieb Daniel Oberhoff danieloberh...@googlemail.com: Am 03.08.2014 um 00:12 schrieb Clément Bœsch u...@pkh.me: On

Re: [FFmpeg-devel] [PATCH 0/4] Exploit compile-time constant

2014-08-03 Thread Christophe Gisquet
Hi, 2014-08-02 14:48 GMT+02:00 Michael Niedermayer michae...@gmx.at: is this for apply/push or just RFC/WIP ? in-between. I had expected Mickael Raulet to comment if he was seeing something not compatible with this. I think the bipred code is a bit more mature since Ronald comments (iirc), so

[FFmpeg-devel] [PATCH] lavfi/avf_showspectrum: use automatic framing.

2014-08-03 Thread Nicolas George
The framework can ensure that each input frame has exactly the correct number of samples, except the last one. Signed-off-by: Nicolas George geo...@nsup.org --- libavfilter/avf_showspectrum.c | 48 +++--- 1 file changed, 17 insertions(+), 31 deletions(-)

[FFmpeg-devel] [PATCH] lavfi/avf_showspectrum: check RDFT contet init.

2014-08-03 Thread Nicolas George
Fix a segfault with large window size. Signed-off-by: Nicolas George geo...@nsup.org --- libavfilter/avf_showspectrum.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavfilter/avf_showspectrum.c b/libavfilter/avf_showspectrum.c index 7bf3aab..764a000 100644 ---

Re: [FFmpeg-devel] [PATCH] lavfi/avf_showspectrum: check RDFT contet init.

2014-08-03 Thread Timothy Gu
On Sun, Aug 3, 2014 at 11:40 AM, Nicolas George geo...@nsup.org wrote: Fix a segfault with large window size. Signed-off-by: Nicolas George geo...@nsup.org --- libavfilter/avf_showspectrum.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavfilter/avf_showspectrum.c

Re: [FFmpeg-devel] [PATCH 4/5] vf_fps: move flushing remaining frames in a separate function.

2014-08-03 Thread Michael Niedermayer
On Sun, Aug 03, 2014 at 03:15:39PM +0200, Nicolas George wrote: Also remove unused loop counter, rename obsolete buf, and add a comment about a similar function. Signed-off-by: Nicolas George geo...@nsup.org LGTM thanks [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 5/5] lavfi/vf_fps: accept EOF timestamp.

2014-08-03 Thread Michael Niedermayer
On Sun, Aug 03, 2014 at 03:15:40PM +0200, Nicolas George wrote: This makes the FPS filter duplicate the last frame to take its duration into account, exactly like the other ones. Fix trac ticket #2674. Signed-off-by: Nicolas George geo...@nsup.org --- libavfilter/vf_fps.c | 33

[FFmpeg-devel] [PATCH] avfilter/dctdnoiz: rewrite [f/i]dct

2014-08-03 Thread Clément Bœsch
This removes the avcodec dependency and make the code almost twice as fast. More to come. The DCT factorization is based on Fast and numerically stable algorithms for discrete cosine transforms from Gerlind Plonkaa Manfred Tasche (DOI: 10.1016/j.laa.2004.07.015). --- configure |

Re: [FFmpeg-devel] [PATCH] avfilter/dctdnoiz: rewrite [f/i]dct

2014-08-03 Thread Clément Bœsch
On Sun, Aug 03, 2014 at 10:27:21PM +0200, Clément Bœsch wrote: This removes the avcodec dependency and make the code almost twice as fast. More to come. The DCT factorization is based on Fast and numerically stable algorithms for discrete cosine transforms from Gerlind Plonkaa Manfred

Re: [FFmpeg-devel] [PATCHv3] Deprecate AFD field and add AFD as side-data

2014-08-03 Thread Michael Niedermayer
On Sun, Aug 03, 2014 at 07:24:56PM +0100, Kieran Kunhya wrote: --- doc/APIchanges|4 libavcodec/avcodec.h |5 - libavcodec/mpeg12dec.c| 20 +++- libavcodec/version.h |5 - libavfilter/vf_showinfo.c |3 +++

Re: [FFmpeg-devel] [PATCHv3] Deprecate AFD field and add AFD as side-data

2014-08-03 Thread Michael Niedermayer
On Sun, Aug 03, 2014 at 10:46:58PM +0200, Michael Niedermayer wrote: On Sun, Aug 03, 2014 at 07:24:56PM +0100, Kieran Kunhya wrote: --- doc/APIchanges|4 libavcodec/avcodec.h |5 - libavcodec/mpeg12dec.c| 20 +++-

Re: [FFmpeg-devel] [PATCH] lavfi/avf_showspectrum: check RDFT contet init.

2014-08-03 Thread Nicolas George
Le sextidi 16 thermidor, an CCXXII, Timothy Gu a écrit : s-rdft = av_rdft_init(rdft_bits, DFT_R2C); +if (!s-rdft) { +av_log(ctx, AV_LOG_ERROR, Unable to allocate RDFT context. + Maybe window too high.\n); +return

Re: [FFmpeg-devel] [PATCH] avfilter/dctdnoiz: rewrite [f/i]dct

2014-08-03 Thread Timothy Gu
On Aug 3, 2014 1:27 PM, Clément Bœsch u...@pkh.me wrote: This removes the avcodec dependency and make the code almost twice as fast. More to come. The DCT factorization is based on Fast and numerically stable algorithms for discrete cosine transforms from Gerlind Plonkaa Manfred Tasche

Re: [FFmpeg-devel] [PATCH] avcodec/avdct: Add get_pixels()

2014-08-03 Thread Michael Niedermayer
On Sat, Aug 02, 2014 at 09:05:56PM +0200, Michael Niedermayer wrote: TODO: version bump, update libavfilters to use it Suggested-by: ubitux Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/avdct.c |9 + libavcodec/avdct.h |4 2 files changed, 13

Re: [FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

2014-08-03 Thread Michael Niedermayer
On Sun, Aug 03, 2014 at 11:53:21PM +0200, Marvin Scholz wrote: +if (user) +av_freep(user); +if (headers) +av_freep(headers); pointless ifs I'm pretty sure I need it, since there are possible cases where these are not allocated and I can't free them. av_freep()

Re: [FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

2014-08-03 Thread Marvin Scholz
av_freep() should be safe to be used with NULL Since av_freep takes a pointer I am nearly sure that it doesn't, at least I remember that I had some issues without the if's… But please correct me if I'm wrong. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avfilter/dctdnoiz: rewrite [f/i]dct

2014-08-03 Thread Michael Niedermayer
On Sun, Aug 03, 2014 at 10:27:21PM +0200, Clément Bœsch wrote: This removes the avcodec dependency and make the code almost twice as fast. More to come. The DCT factorization is based on Fast and numerically stable algorithms for discrete cosine transforms from Gerlind Plonkaa Manfred

Re: [FFmpeg-devel] [PATCH] libavformat/icecast.c Add Icecast protocol

2014-08-03 Thread Michael Niedermayer
On Mon, Aug 04, 2014 at 12:24:27AM +0200, Marvin Scholz wrote: av_freep() should be safe to be used with NULL Since av_freep takes a pointer I am nearly sure that it doesn't, at least I remember that I had some issues without the if's… But please correct me if I'm wrong. in the quoted code

Re: [FFmpeg-devel] [PATCH 1/4] libavcodec: new API for frame threading by step

2014-08-03 Thread Michael Niedermayer
On Sun, Aug 03, 2014 at 06:39:38PM +0200, Christophe Gisquet wrote: Hi, note: I'm using step throughout the patch because of the step function and what the causal part most often looks like. I have no idea for another less confusing wording. 2014-07-28 23:15 GMT+02:00 Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] fix tls/tcp protocol after a 302 move in https

2014-08-03 Thread Michael Niedermayer
On Sat, Aug 02, 2014 at 02:57:10AM +0200, Michael Niedermayer wrote: On Fri, Aug 01, 2014 at 08:37:27PM -0400, compn wrote: patch from https://trac.ffmpeg.org/ticket/3824 -compn diff --git a/libavformat/http.c b/libavformat/http.c index 33585b0..3dffaee 100644 ---

[FFmpeg-devel] [PATCH 1/3] x86/hevc_mc: remove an unnecessary pxor

2014-08-03 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/x86/hevc_mc.asm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/x86/hevc_mc.asm b/libavcodec/x86/hevc_mc.asm index fc78062..a16b0ab 100644 --- a/libavcodec/x86/hevc_mc.asm +++ b/libavcodec/x86/hevc_mc.asm

[FFmpeg-devel] [PATCH 3/3] x86/vp9lpf: use fewer instructions in SPLATB_MIX

2014-08-03 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/x86/vp9lpf.asm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/x86/vp9lpf.asm b/libavcodec/x86/vp9lpf.asm index c5db0ca..def7d5a 100644 --- a/libavcodec/x86/vp9lpf.asm +++ b/libavcodec/x86/vp9lpf.asm

Re: [FFmpeg-devel] [PATCHv3] Deprecate AFD field and add AFD as side-data

2014-08-03 Thread Michael Niedermayer
On Sun, Aug 03, 2014 at 10:49:39PM +0200, Michael Niedermayer wrote: On Sun, Aug 03, 2014 at 10:46:58PM +0200, Michael Niedermayer wrote: On Sun, Aug 03, 2014 at 07:24:56PM +0100, Kieran Kunhya wrote: --- doc/APIchanges|4 libavcodec/avcodec.h |5 -

[FFmpeg-devel] [PATCH] x86/hevc_mc: use fewer instructions in hevc_put_hevc_{uni, bi}_w[24]_{8, 10, 12}

2014-08-03 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/x86/hevc_mc.asm | 35 ++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/hevc_mc.asm b/libavcodec/x86/hevc_mc.asm index fc78062..3ef0149 100644 ---