Re: [FFmpeg-devel] [PATCH] configure: update libvpx_vp9_encoder check

2014-08-25 Thread James Almer
On 26/08/14 12:32 AM, James Zern wrote: > On Mon, Aug 25, 2014 at 8:28 PM, James Almer wrote: >> Required to add support for the aq_mode setting. >> Any libvpx snapshot prior to 1.3.0 is not recommended for vp9 encoding for >> that matter. >> > lgtm. Pushed. Thanks.

[FFmpeg-devel] [PATCH] configure: update libvpx_vp9_encoder check

2014-08-25 Thread James Almer
Required to add support for the aq_mode setting. Any libvpx snapshot prior to 1.3.0 is not recommended for vp9 encoding for that matter. Signed-off-by: James Almer --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 0e13520..8e5f49b 1007

Re: [FFmpeg-devel] [PATCH] Adds support for setting aq_mode in libvpx encoder

2014-08-25 Thread James Almer
On 25/08/14 10:39 PM, Michael Niedermayer wrote: > On Mon, Aug 25, 2014 at 05:17:39PM -0700, Deb Mukherjee wrote: >> Sets aq_mode in the [0, 3] range for the libvpx encode wrapper. >> 0: none >> 1: variance aq >> 2: complexity aq >> 3: cyclic refresh aq >> --- >> doc/encoders.texi | 5 - >

Re: [FFmpeg-devel] [PATCH] Adds support for setting aq_mode in libvpx encoder

2014-08-25 Thread Michael Niedermayer
On Mon, Aug 25, 2014 at 05:17:39PM -0700, Deb Mukherjee wrote: > Sets aq_mode in the [0, 3] range for the libvpx encode wrapper. > 0: none > 1: variance aq > 2: complexity aq > 3: cyclic refresh aq > --- > doc/encoders.texi | 5 - > libavcodec/libvpxenc.c | 9 + > 2 files changed,

[FFmpeg-devel] [PATCH] Adds support for setting aq_mode in libvpx encoder

2014-08-25 Thread Deb Mukherjee
Sets aq_mode in the [0, 3] range for the libvpx encode wrapper. 0: none 1: variance aq 2: complexity aq 3: cyclic refresh aq --- doc/encoders.texi | 5 - libavcodec/libvpxenc.c | 9 + 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/doc/encoders.texi b/doc/encoders.t

Re: [FFmpeg-devel] [PATCH 2/2] fate: Add basic tests for WebM Dash Manifest

2014-08-25 Thread Lou Logan
On Mon, 25 Aug 2014 16:26:16 -0700, Vignesh Venkatasubramanian wrote: > i sent the files associated with this fate test as a tarball to this > mailing list and got a reply saying "message is awaiting moderator > approval because the attachment is > 500kb". could you please check? The samples were

Re: [FFmpeg-devel] [PATCH 2/2] fate: Add basic tests for WebM Dash Manifest

2014-08-25 Thread Michael Niedermayer
On Mon, Aug 25, 2014 at 03:03:45PM -0700, Vignesh Venkatasubramanian wrote: > Add fate tests that test out the functionality of WebM DASH > Manifest XML generation. This patch contains the vpx.mak file > changes and the reference gold XML files. > --- > tests/fate/vpx.mak

Re: [FFmpeg-devel] [PATCH v2] libavformat/ftp: Do not leak memory in routine ftp_features

2014-08-25 Thread Alexander Strasser
On 2014-08-21 23:02 +0200, Alexander Strasser wrote: > Setting the pointer to NULL inside both ftp_send_command > and ftp_features is redundant. Generally always setting to > NULL in ftp_send_command seems safer, but throughout the file > that parameter was always passed initialized. So I do it her

Re: [FFmpeg-devel] OpenEXR update and question

2014-08-25 Thread Gonzalo Garramuno
On 25/08/14 19:01, Nicolas George wrote: L'octidi 8 fructidor, an CCXXII, Gonzalo Garramuno a écrit : As you might not know, there's a new version of the OpenEXR library. This version introduces a new compressing scheme from Dreamworks Animation which is really great. It is patented but free to

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: use av_malloc_array()

2014-08-25 Thread Michael Niedermayer
On Mon, Aug 25, 2014 at 11:51:58PM +0200, Marton Balint wrote: > > On Mon, 25 Aug 2014, Michael Niedermayer wrote: > > >Signed-off-by: Michael Niedermayer > >--- > >ffplay.c |2 +- > >1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/ffplay.c b/ffplay.c > >index e66dea1..833b5

Re: [FFmpeg-devel] [PATCH 1/2] fate-run.sh: add function to execute raw ffmpeg command

2014-08-25 Thread Vignesh Venkatasubramanian
On Mon, Aug 25, 2014 at 1:17 PM, Timothy Gu wrote: > On Mon, Aug 25, 2014 at 12:27 PM, Vignesh Venkatasubramanian > wrote: >> add ffmpeg_raw() function to fate-run.sh which will run the exact >> ffmpeg command as specified in the *.mak file without any changes. >> --- >> tests/fate-run.sh | 4 ++

[FFmpeg-devel] [PATCH 2/2] fate: Add basic tests for WebM Dash Manifest

2014-08-25 Thread Vignesh Venkatasubramanian
Add fate tests that test out the functionality of WebM DASH Manifest XML generation. This patch contains the vpx.mak file changes and the reference gold XML files. --- tests/fate/vpx.mak | 9 tests/ref/fate/webm-dash-manifest | 48

Re: [FFmpeg-devel] [PATCH 3/3] huffyuv: fix 34x34 checksums

2014-08-25 Thread Michael Niedermayer
On Mon, Aug 25, 2014 at 10:28:50PM +0200, Christophe Gisquet wrote: > Hi, > > 2014-08-25 22:24 GMT+02:00 Christophe Gisquet : > > Now that the encoder and decoder have been fixed, the values changed, > > and make more sense (eg the PSNR/std dev). > > --- > > This patch lacks a fate:, and is actua

Re: [FFmpeg-devel] [PATCH 2/3] huffyuvdec: decode the last odd sample

2014-08-25 Thread Michael Niedermayer
On Mon, Aug 25, 2014 at 08:24:30PM +, Christophe Gisquet wrote: > --- > libavcodec/huffyuvdec.c | 26 ++ > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c > index bc5ad15..1df77e0 100644 > --- a/libavc

Re: [FFmpeg-devel] [PATCH 1/3] huffyuvenc: write last odd sample

2014-08-25 Thread Michael Niedermayer
On Mon, Aug 25, 2014 at 08:24:29PM +, Christophe Gisquet wrote: > If width is odd, last sample wouldn't be written. > --- > libavcodec/huffyuvenc.c | 61 > + > 1 file changed, 57 insertions(+), 4 deletions(-) applied thanks [...] -- Michael

Re: [FFmpeg-devel] OpenEXR update and question

2014-08-25 Thread Nicolas George
L'octidi 8 fructidor, an CCXXII, Gonzalo Garramuno a écrit : > As you might not know, there's a new version of the OpenEXR library. > This version introduces a new compressing scheme from Dreamworks > Animation which is really great. It is patented but free to use as > long as you use the openexr

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: use av_malloc_array()

2014-08-25 Thread Marton Balint
On Mon, 25 Aug 2014, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- ffplay.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffplay.c b/ffplay.c index e66dea1..833b5b1 100644 --- a/ffplay.c +++ b/ffplay.c @@ -991,7 +991,7 @@ static void video_audio_disp

Re: [FFmpeg-devel] OpenEXR update and question

2014-08-25 Thread Derek Buitenhuis
On 8/25/2014 6:46 PM, Gonzalo Garramuno wrote: > It is patented but free to use as long as you use the openexr library. wat ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vp9.: Use av_malloc_array()

2014-08-25 Thread Michael Niedermayer
On Mon, Aug 25, 2014 at 02:37:05PM -0400, Ronald S. Bultje wrote: > Hi, > > On Mon, Aug 25, 2014 at 12:47 PM, Michael Niedermayer > wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vp9.c |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib

Re: [FFmpeg-devel] [PATCH 3/5] x86: hevc_mc: make WP proxy functions static

2014-08-25 Thread Christophe Gisquet
Hi, 2014-08-24 12:21 GMT+02:00 Michael Niedermayer : > On Sun, Aug 24, 2014 at 08:46:32AM +, Christophe Gisquet wrote: >> --- >> libavcodec/x86/hevcdsp.h | 8 +++- >> libavcodec/x86/hevcdsp_init.c | 4 ++-- >> 2 files changed, 5 insertions(+), 7 deletions(-) > > this seems to break b

Re: [FFmpeg-devel] [PATCH 3/3] huffyuv: fix 34x34 checksums

2014-08-25 Thread Christophe Gisquet
Hi, 2014-08-25 22:24 GMT+02:00 Christophe Gisquet : > Now that the encoder and decoder have been fixed, the values changed, > and make more sense (eg the PSNR/std dev). > --- This patch lacks a fate:, and is actually for ffvhuff. -- Christophe From f5c6ee93b57055d18dee95374631d04970d9b1d0 Mon S

[FFmpeg-devel] [PATCH 3/3] huffyuv: fix 34x34 checksums

2014-08-25 Thread Christophe Gisquet
Now that the encoder and decoder have been fixed, the values changed, and make more sense (eg the PSNR/std dev). --- tests/ref/vsynth/vsynth3-ffvhuff420p12 | 8 tests/ref/vsynth/vsynth3-ffvhuff422p10left | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/test

[FFmpeg-devel] [PATCH 1/3] huffyuvenc: write last odd sample

2014-08-25 Thread Christophe Gisquet
If width is odd, last sample wouldn't be written. --- libavcodec/huffyuvenc.c | 61 + 1 file changed, 57 insertions(+), 4 deletions(-) diff --git a/libavcodec/huffyuvenc.c b/libavcodec/huffyuvenc.c index fd6f570..c7e69d5 100644 --- a/libavcodec/huff

[FFmpeg-devel] [PATCH 2/3] huffyuvdec: decode the last odd sample

2014-08-25 Thread Christophe Gisquet
--- libavcodec/huffyuvdec.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c index bc5ad15..1df77e0 100644 --- a/libavcodec/huffyuvdec.c +++ b/libavcodec/huffyuvdec.c @@ -660,11 +660,9 @@ static void d

[FFmpeg-devel] [PATCH 0/3] Fix ticket #3882

2014-08-25 Thread Christophe Gisquet
This bug is caused by both encoder and decoding not properly handling odd plane widths. This was actually caught by fate-vsynth3-ffvhuff42*, but we overlooked the unreasonabe std dev values. There's one bug remaining with #3882, the bottom green line. However, the video dimensions are 398x331, whi

Re: [FFmpeg-devel] [PATCH 1/2] fate-run.sh: add function to execute raw ffmpeg command

2014-08-25 Thread Timothy Gu
On Mon, Aug 25, 2014 at 12:27 PM, Vignesh Venkatasubramanian wrote: > add ffmpeg_raw() function to fate-run.sh which will run the exact > ffmpeg command as specified in the *.mak file without any changes. > --- > tests/fate-run.sh | 4 > 1 file changed, 4 insertions(+) > > diff --git a/tests

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vp9.: Use av_malloc_array()

2014-08-25 Thread Ronald S. Bultje
Hi, On Mon, Aug 25, 2014 at 12:47 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/vp9.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c > index 8f22685..241ea6c 100644 > --- a/libavcodec/vp9.

[FFmpeg-devel] OpenEXR update and question

2014-08-25 Thread Gonzalo Garramuno
As you might not know, there's a new version of the OpenEXR library. This version introduces a new compressing scheme from Dreamworks Animation which is really great. It is patented but free to use as long as you use the openexr library. I asked the owner of the patent whether it should be pos

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-25 Thread Christophe Gisquet
Hi, 2014-08-25 6:41 GMT+02:00 Reimar Döffinger : > The colorspace is supposed to be authoritative. > If it says 16 bit, then showing it as 16 bit must work properly. > The only intention of bits_per_raw_sample is to indicate that there is no > point in storing some of the lower bits if you have t

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Ensure cues_end is initialized

2014-08-25 Thread Michael Niedermayer
On Mon, Aug 25, 2014 at 09:15:13AM -0700, Vignesh Venkatasubramanian wrote: > Ensure that cues_start and cues_end are always initialized and > the webm_dash_manifest_cues function returns appropriate error if > they are not computed correctly. > > This fixes coverity defect CID1231991. > > Signed

[FFmpeg-devel] [PATCH 2/2] avcodec/vp9.: Use av_malloc_array()

2014-08-25 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/vp9.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 8f22685..241ea6c 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -368,7 +368,7 @@ static int update_block_buffers(AVCode

[FFmpeg-devel] [PATCH 1/2] ffplay: use av_malloc_array()

2014-08-25 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- ffplay.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffplay.c b/ffplay.c index e66dea1..833b5b1 100644 --- a/ffplay.c +++ b/ffplay.c @@ -991,7 +991,7 @@ static void video_audio_display(VideoState *s) av_free(s->rdft_da

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_parser: consider vbv_delay in bitrate heuristic also for mpeg2

2014-08-25 Thread Michael Niedermayer
On Wed, Aug 20, 2014 at 08:33:16PM +0200, Michael Niedermayer wrote: > Fixes bitrate detection in CBR mpeg2 > Fixes ticket3678 > --- > libavcodec/mpegvideo_parser.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730

Re: [FFmpeg-devel] [PATCH 2/5] x86: hevc_mc: correct unneeded use of SSE4 code

2014-08-25 Thread Michael Niedermayer
On Mon, Aug 25, 2014 at 10:06:00AM +0200, Mickaël Raulet wrote: > this commit might help to solve the issue with SSE4 > https://github.com/OpenHEVC/FFmpeg/commit/df8ebe304df453f26c28ff8f11d607f49b90a4c2 why does this add pmaxsw ? if they are needed only for SSSE3 / packsswd then they shouldnt be a

Re: [FFmpeg-devel] [PATCH 2/5] x86: hevc_mc: correct unneeded use of SSE4 code

2014-08-25 Thread Mickaël Raulet
this commit might help to solve the issue with SSE4 https://github.com/OpenHEVC/FFmpeg/commit/df8ebe304df453f26c28ff8f11d607f49b90a4c2 Mickaël Le 24 août 2014 à 11:52, Michael Niedermayer a écrit : > On Sun, Aug 24, 2014 at 08:46:31AM +, Christophe Gisquet wrote: >> --- >> libavcodec/x86/he

Re: [FFmpeg-devel] [PATCH]Fix pnm encoding with bpc set

2014-08-25 Thread Reimar Döffinger
On 25 August 2014 06:41:58 CEST, "Reimar Döffinger" wrote: >On 24.08.2014, at 14:02, Christophe Gisquet > wrote: >> Hi, >> >> I think a first point must be cleared, seeing your reaction to my >> pnmdec comment. Here' are the opinions: >> - Mine: bits_per_raw_sample should indicate the dynamics o