Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-19 Thread arwa arif
On Fri, Dec 19, 2014 at 12:15 PM, Timothy Gu timothyg...@gmail.com wrote: On Dec 18, 2014 10:31 PM, arwa arif arwaarif1...@gmail.com wrote: On Fri, Dec 19, 2014 at 10:40 AM, Michael Niedermayer michae...@gmx.at wrote: it segfaults without -cpuflags 0 here ./ffplay -i

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-19 Thread Michael Niedermayer
On Fri, Dec 19, 2014 at 06:45:13AM +, Timothy Gu wrote: On Dec 18, 2014 10:31 PM, arwa arif arwaarif1...@gmail.com wrote: On Fri, Dec 19, 2014 at 10:40 AM, Michael Niedermayer michae...@gmx.at wrote: it segfaults without -cpuflags 0 here ./ffplay -i matrixbench_mpeg2.mpg -vf

Re: [FFmpeg-devel] libavutil: Added cbc mode to cast5.c

2014-12-19 Thread Michael Niedermayer
On Fri, Dec 19, 2014 at 11:33:04AM +0530, supraja reddy wrote: Updated patch . Thanks, Supraja On Fri, Dec 19, 2014 at 3:01 AM, Giorgio Vazzana mywin...@gmail.com wrote: [...] the rest LGTM, thanks. patch applied maybe the Changelog should be updated to mention CBC thanks [...]

Re: [FFmpeg-devel] [PATCH] libavfilter: unsharpen opencl filter optimizations

2014-12-19 Thread Michael Niedermayer
On Thu, Dec 18, 2014 at 07:24:27PM +, Titov, Alexey wrote: Hi Michael, Here is the patch. I attached a zip of this patch in the last email, but it was probably stripped off. Let me know how I can help. === [...] diff --git a/libavutil/opencl.c

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-19 Thread Michael Niedermayer
On Fri, Dec 19, 2014 at 06:10:00AM +0100, Michael Niedermayer wrote: On Fri, Dec 19, 2014 at 02:13:01AM +0100, Stefano Sabatini wrote: On date Thursday 2014-12-18 13:57:27 +0530, arwa arif encoded: [...] Note: as usual you can prepare a patch to remove the corresponding mp filter once

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-19 Thread Clément Bœsch
On Fri, Dec 19, 2014 at 04:40:21PM +0100, Michael Niedermayer wrote: [...] then one filter that i remember was requested (longer ago) is nnedi3 but that would need to have its asm removed or ported which is not trivial i suspect The problem with nnedi3 is that it requires 13MB of learned

[FFmpeg-devel] [PATCH] Add FFMPEG_VERSION into the binary libs

2014-12-19 Thread Michael Niedermayer
This simplifies identifying from which revission a binary of a lib came from Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/utils.c |3 +++ libavformat/utils.c |3 +++ 2 files changed, 6 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index

Re: [FFmpeg-devel] [PATCH] Add FFMPEG_VERSION into the binary libs

2014-12-19 Thread Pavel Koshevoy
On 12/19/14 10:05, Michael Niedermayer wrote: This simplifies identifying from which revission a binary of a lib came from Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/utils.c |3 +++ libavformat/utils.c |3 +++ 2 files changed, 6 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH] Add FFMPEG_VERSION into the binary libs

2014-12-19 Thread Michael Niedermayer
On Fri, Dec 19, 2014 at 06:22:30PM +0100, Nicolas George wrote: Le nonidi 29 frimaire, an CCXXIII, Michael Niedermayer a écrit : +#include libavutil/ffversion.h +char *av_codec_ffversion = FFmpeg version FFMPEG_VERSION; This defines two variables: a pointer, and an anonymous const array

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-19 Thread Michael Niedermayer
On Fri, Dec 19, 2014 at 07:26:52PM +0100, Clément Bœsch wrote: On Fri, Dec 19, 2014 at 06:42:22PM +0100, Michael Niedermayer wrote: On Fri, Dec 19, 2014 at 04:55:32PM +0100, Clément Bœsch wrote: On Fri, Dec 19, 2014 at 04:40:21PM +0100, Michael Niedermayer wrote: [...] then one filter

[FFmpeg-devel] [PATCH] x86/constants: fix alignment of pw_255

2014-12-19 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/x86/constants.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/x86/constants.c b/libavcodec/x86/constants.c index d78b896..54acc89 100644 --- a/libavcodec/x86/constants.c +++ b/libavcodec/x86/constants.c

Re: [FFmpeg-devel] [PATCH] x86/constants: fix alignment of pw_255

2014-12-19 Thread Michael Niedermayer
On Fri, Dec 19, 2014 at 04:18:43PM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/x86/constants.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: remove rtp_mode=0 for H261

2014-12-19 Thread Michael Niedermayer
On Thu, Dec 18, 2014 at 11:32:42PM +0100, Michael Niedermayer wrote: Suggested-by: Thomas Volkert si...@gmx.net Signed-off-by: Michael Niedermayer michae...@gmx.at --- libavcodec/mpegvideo_enc.c |3 --- 1 file changed, 3 deletions(-) approved by Thomas applied thx [...] -- Michael

[FFmpeg-devel] [PATCH] wavdec: refactor wav_read_header()

2014-12-19 Thread Thomas Volkert
From: Thomas Volkert tho...@homer-conferencing.com Make it more readable and display an error message in case an invalid header is detected (the current version just returns AVERROR_INVALIDDATA) --- libavformat/wavdec.c | 31 ++- 1 file changed, 22 insertions(+), 9

Re: [FFmpeg-devel] [PATCH] wavdec: refactor wav_read_header()

2014-12-19 Thread Derek Buitenhuis
On 12/19/2014 9:09 PM, Thomas Volkert wrote: + av_log(s, AV_LOG_ERROR, invalid start code %c%c%c%c in RIFF header\n, tag 0xFF, (tag 8) 0xFF, (tag 16) 0xFF, (tag 24) 0xFF); I'm sure printing possibly non-printable chars is a great idea. Nothing could go wrong. Use 0x%X or something

Re: [FFmpeg-devel] [PATCH] wavdec: refactor wav_read_header()

2014-12-19 Thread Michael Niedermayer
On Fri, Dec 19, 2014 at 08:15:26PM +, Derek Buitenhuis wrote: On 12/19/2014 9:09 PM, Thomas Volkert wrote: + av_log(s, AV_LOG_ERROR, invalid start code %c%c%c%c in RIFF header\n, tag 0xFF, (tag 8) 0xFF, (tag 16) 0xFF, (tag 24) 0xFF); I'm sure printing possibly

[FFmpeg-devel] [PATCH] wavdec: refactor wav_read_header()

2014-12-19 Thread Thomas Volkert
From: Thomas Volkert tho...@homer-conferencing.com Make it more readable and display an error message in case an invalid header is detected (the current version just returns AVERROR_INVALIDDATA) --- libavformat/wavdec.c | 31 ++- 1 file changed, 22 insertions(+), 9

Re: [FFmpeg-devel] [PATCH] wavdec: refactor wav_read_header()

2014-12-19 Thread Thomas Volkert
On 12/19/2014 09:57 PM, Thomas Volkert wrote: + av_log(s, AV_LOG_ERROR, invalid start code %c%c%c%c in RIFF header\n, tag 0xFF, (tag 8) 0xFF, (tag 16) 0xFF, (tag 24) 0xFF); return AVERROR_INVALIDDATA; Some remainung tabs - please, remove when commit. Best regards,

Re: [FFmpeg-devel] [PATCH] wavdec: refactor wav_read_header()

2014-12-19 Thread Michael Niedermayer
On Fri, Dec 19, 2014 at 09:58:48PM +0100, Thomas Volkert wrote: On 12/19/2014 09:57 PM, Thomas Volkert wrote: +av_log(s, AV_LOG_ERROR, invalid start code %c%c%c%c in RIFF header\n, tag 0xFF, (tag 8) 0xFF, (tag 16) 0xFF, (tag 24) 0xFF); return

Re: [FFmpeg-devel] [PATCH] wavdec: refactor wav_read_header()

2014-12-19 Thread James Almer
On 19/12/14 7:00 PM, Michael Niedermayer wrote: On Fri, Dec 19, 2014 at 09:58:48PM +0100, Thomas Volkert wrote: On 12/19/2014 09:57 PM, Thomas Volkert wrote: + av_log(s, AV_LOG_ERROR, invalid start code %c%c%c%c in RIFF header\n, tag 0xFF, (tag 8) 0xFF, (tag 16) 0xFF, (tag 24)

Re: [FFmpeg-devel] [PATCH] wavdec: refactor wav_read_header()

2014-12-19 Thread Thomas Volkert
On 12/19/2014 11:03 PM, James Almer wrote: On 19/12/14 7:00 PM, Michael Niedermayer wrote: On Fri, Dec 19, 2014 at 09:58:48PM +0100, Thomas Volkert wrote: On 12/19/2014 09:57 PM, Thomas Volkert wrote: + av_log(s, AV_LOG_ERROR, invalid start code %c%c%c%c in RIFF header\n, tag 0xFF,

[FFmpeg-devel] [PATCH] wavdec: avoid output of arbitrary chars

2014-12-19 Thread Thomas Volkert
From: Thomas Volkert tho...@homer-conferencing.com use av_get_codec_tag_string() in wav_read_header() for printing the faulty start code from riff header --- libavformat/wavdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c

Re: [FFmpeg-devel] [PATCH] wavdec: avoid output of arbitrary chars

2014-12-19 Thread Michael Niedermayer
On Fri, Dec 19, 2014 at 11:39:01PM +0100, Thomas Volkert wrote: From: Thomas Volkert tho...@homer-conferencing.com use av_get_codec_tag_string() in wav_read_header() for printing the faulty start code from riff header applied thanks [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [PATCH] avcodec.h: document needed buffer size for av_get_codec_tag_string()

2014-12-19 Thread Thomas Volkert
From: Thomas Volkert tho...@homer-conferencing.com --- libavcodec/avcodec.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 4b6b00c..0f69a18 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -4900,6 +4900,8 @@ void

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-19 Thread Clément Bœsch
On Fri, Dec 19, 2014 at 08:04:33PM +0100, Michael Niedermayer wrote: On Fri, Dec 19, 2014 at 07:26:52PM +0100, Clément Bœsch wrote: On Fri, Dec 19, 2014 at 06:42:22PM +0100, Michael Niedermayer wrote: On Fri, Dec 19, 2014 at 04:55:32PM +0100, Clément Bœsch wrote: On Fri, Dec 19, 2014 at

Re: [FFmpeg-devel] [PATCH] avcodec.h: document needed buffer size for av_get_codec_tag_string()

2014-12-19 Thread Clément Bœsch
On Sat, Dec 20, 2014 at 12:29:56AM +0100, Thomas Volkert wrote: From: Thomas Volkert tho...@homer-conferencing.com --- libavcodec/avcodec.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 4b6b00c..0f69a18 100644 ---

Re: [FFmpeg-devel] [PATCH] qdm2: Allow hard-coding VLC tables.

2014-12-19 Thread Carl Eugen Hoyos
Reimar Döffinger Reimar.Doeffinger at gmx.de writes: This patch has broken make checkheaders. Should the header just not be checked or is there another fix? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] x86/vp3dsp: port put_vp_no_rnd_pixels8_l2_mmx to yasm

2014-12-19 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- libavcodec/x86/vp3dsp.asm| 44 libavcodec/x86/vp3dsp_init.c | 69 2 files changed, 50 insertions(+), 63 deletions(-) diff --git a/libavcodec/x86/vp3dsp.asm

[FFmpeg-devel] Git branch

2014-12-19 Thread Marcus Johnson
I'm working on the DTS codec, and my code isn't complete yet, but a lot of it is done, I've committed a few patches to my own branch, and I need to update ffmpeg (there's a blocking change in the main tree so I can't currently) I was wondering if I could push the uncomplete code in it's own