Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: improve junk skipping heuristic

On Tue, 20 Oct 2015 02:12:00 +0200 Michael Niedermayer wrote: > On Mon, Oct 19, 2015 at 11:12:03PM +0200, wm4 wrote: > > Commit 2b3e9bbfb529e6bde238aeb511b55ebe461664c8 caused problems for a > > certain API user: > > > >

[FFmpeg-devel] [PATCH] avfilter: add shuffleframes filter

Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_shuffleframes.c | 157 + 3 files changed, 159 insertions(+) create mode 100644 libavfilter/vf_shuffleframes.c

Re: [FFmpeg-devel] [PATCH] dca_parser: don't overwrite the sample rate, it may not be correct

On Mon, Oct 19, 2015 at 3:50 AM, Michael Niedermayer wrote: > On Sun, Oct 18, 2015 at 04:49:48PM +0200, Hendrik Leppkes wrote: >> On Wed, Sep 30, 2015 at 1:09 PM, Hendrik Leppkes wrote: >> > The parser only reads the dca core sample rate, which is

Re: [FFmpeg-devel] [PATCH] rtsp protocol : teardown packet not sent

On Sun, Oct 18, 2015 at 10:13:29PM +0200, Nicolas Adenis-Lamarre wrote: > The rtsp protocol requires the client to send a packet at the end of the > connexion. > FFmpeg basic network function check wether the user aborted the > communication and don't send the packet in this case. > So the

Re: [FFmpeg-devel] [PATCH] libvpxenc: remove some unused ctrl id mappings

On Mon, Oct 19, 2015 at 10:49:16PM -0700, James Zern wrote: > VP8E_UPD_ENTROPY, VP8E_UPD_REFERENCE, VP8E_USE_REFERENCE were removed > from libvpx and the remaining values were never used here > > Signed-off-by: James Zern LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCHv2] avutil/mathematics: speed up av_gcd by using Stein's binary GCD algorithm

On Tue, Oct 20, 2015 at 12:52 AM, James Almer wrote: > On 10/11/2015 12:45 AM, Michael Niedermayer wrote: >> On Sat, Oct 10, 2015 at 09:58:47PM -0400, Ganesh Ajjanagadde wrote: >>> This uses Stein's binary GCD algorithm: >>> https://en.wikipedia.org/wiki/Binary_GCD_algorithm

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/mxfenc.c: Fix segfault when writing an audio packet when there has not been a video one.

On Mon, 19 Oct 2015, Tomas Härdin wrote: On Mon, 2015-10-19 at 11:40 +0200, Alexis Ballier wrote: On Mon, 19 Oct 2015 10:30:00 +0200 Michael Niedermayer wrote: On Fri, Oct 16, 2015 at 10:42:32AM +0200, Alexis Ballier wrote: This happens when writing the trailer of

[FFmpeg-devel] [PATCH] avfilter: add shuffleframes filter

Signed-off-by: Paul B Mahol --- doc/filters.texi | 20 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_shuffleframes.c | 159 + 4 files changed, 181 insertions(+)

Re: [FFmpeg-devel] [PATCH] avfilter/vf_psnr: Add support for writing stats to stdout

On 10/20/15, Tobias Rapp wrote: > Attached patch implements writing PSNR frame stats to standard output if > the filename is "-". > > Regards, > Tobias > Looks fine to me. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] Channel layout flags - Patch

I am looking for a patch so that when using the below Channel layout flags, the FC comes out flagged as 'Center', not Mono, and also the DL and DR comes out as 'Left Total' 'Right Total'. Currently these 3 are coming out as 'Mono'. Is there a patch / command / flag to get these flagged

[FFmpeg-devel] [PATCH] Adds support parsing the QuickTime Metadata Keys.

The Apple dev specification: https://developer.apple.com/library/mac/documentation/QuickTime/QTFF/Metadata/Metadata.html --- libavformat/isom.h | 3 +++ libavformat/mov.c | 77 +- 2 files changed, 74 insertions(+), 6 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avfilter: add shuffleframes filter

On Tue, Oct 20, 2015 at 08:10:55PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 20 ++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_shuffleframes.c | 159 >

Re: [FFmpeg-devel] [PATCH 2/2] pixblockdsp: Use memcpy for get_pixels_16_c

On Sat, Oct 17, 2015 at 06:05:46PM -0700, Timothy Gu wrote: > Before: > 15543 decicycles in get_pixels, 4193214 runs, 1090 skips > After: >5713 decicycles in get_pixels, 8387564 runs, 1044 skips > --- > libavcodec/pixblockdsp.c | 38 - >

Re: [FFmpeg-devel] [PATCH] rtsp protocol : teardown packet not sent

Let's take the example of ffplay in which the code always fails. ie : ffplay 'rtsp:// mafreebox.freebox.fr/fbxtv_pub/stream?namespace=1=201=ld' fails to respect the protocol in 100% of the cases. When i close the window, ffplay.c : stream_close() is called => is->abort_request = 1; =>

Re: [FFmpeg-devel] [PATCH] rtsp protocol : teardown packet not sent

On Tue, Oct 20, 2015 at 06:16:12PM +0200, Nicolas Adenis-Lamarre wrote: > Let's take the example of ffplay in which the code always fails. > ie : ffplay 'rtsp:// > mafreebox.freebox.fr/fbxtv_pub/stream?namespace=1=201=ld' > fails to respect the protocol in 100% of the cases. > > When i close the

Re: [FFmpeg-devel] [PATCHv2] avutil/mathematics: speed up av_gcd by using Stein's binary GCD algorithm

On Tue, Oct 20, 2015 at 12:52 AM, James Almer wrote: > On 10/11/2015 12:45 AM, Michael Niedermayer wrote: >> On Sat, Oct 10, 2015 at 09:58:47PM -0400, Ganesh Ajjanagadde wrote: >>> This uses Stein's binary GCD algorithm: >>> https://en.wikipedia.org/wiki/Binary_GCD_algorithm

Re: [FFmpeg-devel] Channel layout flags - Patch

Le nonidi 29 vendémiaire, an CCXXIV, Kevin Wells a écrit : > I am looking for a patch so that when using the below Channel layout If you are not proposing a patch, then this is a usage question and should be on ffmpeg-user. Reply-to placed accordingly. > flags, the FC comes out flagged as

Re: [FFmpeg-devel] [PATCH] rtsp protocol : teardown packet not sent

Le nonidi 29 vendémiaire, an CCXXIV, Nicolas Adenis-Lamarre a écrit : > Probably i misunderstood again, but, > I don't understand however in which case an application would use a > callback to avoid any io at all. > For example, i don't understand why ffplay, when a user close the window, > choose

Re: [FFmpeg-devel] [PATCH] rtsp protocol : teardown packet not sent

Thanks for your answer. Thanks for your light. It's clear that my patch is wrong (even if it makes ffplay working). I've 2 solutions at the end, i hope that one of them could be valid for you. For the moment, i still don't know what is the best way to fix it. Probably i misunderstood again, but,

Re: [FFmpeg-devel] [PATCH 1/2] dnxhdenc: Optimize get_pixels_8x4_sym for 10-bit

On Tue, Oct 20, 2015 at 9:30 AM Michael Niedermayer wrote: > On Sat, Oct 17, 2015 at 06:05:45PM -0700, Timothy Gu wrote: > > This reverts commit 628e6d0164febc8e69b0f10dfa487e8a2dd1a28a and uses > > a better fix. > > > > Before: > > 4483 decicycles in get_pixels_8x4_sym,

Re: [FFmpeg-devel] [PATCH] pixblockdsp: Use memcpy for get_pixels_16_c

On Tue, Oct 20, 2015 at 4:20 PM, Timothy Gu wrote: > Before: > 15543 decicycles in get_pixels, 4193214 runs, 1090 skips > After: >5713 decicycles in get_pixels, 8387564 runs, 1044 skips > --- > libavcodec/pixblockdsp.c | 36

Re: [FFmpeg-devel] [PATCH] huffyuvencdsp: Convert ff_diff_bytes_mmx to yasm

On 10/19/2015 11:11 PM, Timothy Gu wrote: > Heavily based upon ff_add_bytes by Christophe Gisquet. > --- > > Taken into account James' comment, and fixed x86_32. Also saves one additional > GPR. > > --- > libavcodec/x86/Makefile| 1 + > libavcodec/x86/huffyuvencdsp.asm | 73 >

[FFmpeg-devel] [PATCH] pixblockdsp: Use memcpy for get_pixels_16_c

Before: 15543 decicycles in get_pixels, 4193214 runs, 1090 skips After: 5713 decicycles in get_pixels, 8387564 runs, 1044 skips --- libavcodec/pixblockdsp.c | 36 ++- libavcodec/pixblockdsp_template.c | 40 ---

Re: [FFmpeg-devel] [PATCH] avcodec: remove unused avpriv_ac3_parse_header

On 14.10.2015 01:53, James Almer wrote: > On 10/13/2015 8:50 PM, Andreas Cadhalpun wrote: >> It was replaced by avpriv_ac3_parse_header2. > > You could rename it to avpriv_ac3_parse_header() while at it. > The 2 suffix becomes silly with this. I'll send a separate patch for that. Best regards,

Re: [FFmpeg-devel] [PATCH] avutil: install des.h, rc4.h and tree.h as public headers

On 14.10.2015 14:07, Michael Niedermayer wrote: > On Wed, Oct 14, 2015 at 12:37:31AM +0200, Andreas Cadhalpun wrote: >> These headers contain functions supposed to be public. >> >> libavutil/des.h: >> av_des_alloc >> av_des_crypt >> av_des_init >> av_des_mac >> libavutil/rc4.h: >>

Re: [FFmpeg-devel] [PATCH] avcodec: remove unused avpriv_ac3_parse_header

On 14.10.2015 02:07, Michael Niedermayer wrote: > On Wed, Oct 14, 2015 at 01:50:13AM +0200, Andreas Cadhalpun wrote: >> It was replaced by avpriv_ac3_parse_header2. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/ac3_parser.c | 9 - >>

Re: [FFmpeg-devel] [PATCH] avutil: merge avpriv_float_dsp_init into avpriv_float_dsp_alloc

On 14.10.2015 02:04, James Almer wrote: > On 10/13/2015 8:48 PM, Andreas Cadhalpun wrote: >> Also replace the last two usages of avpriv_float_dsp_init with >> avpriv_float_dsp_alloc. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavutil/float_dsp.c | 47

Re: [FFmpeg-devel] [PATCH] avfilter/vf_psnr: Add support for writing stats to stdout

On Tue, Oct 20, 2015 at 09:10:53PM +0200, Paul B Mahol wrote: > On 10/20/15, Tobias Rapp wrote: > > Attached patch implements writing PSNR frame stats to standard output if > > the filename is "-". > > > > Regards, > > Tobias > > > > Looks fine to me. applied thanks

[FFmpeg-devel] [PATCH] avcodec: remove old avpriv_mpa_decode_header function

Replace its last use by avpriv_mpa_decode_header2 and drop the 2 suffix. Signed-off-by: Andreas Cadhalpun --- libavcodec/mpegaudio_parser.c | 2 +- libavcodec/mpegaudiodecheader.c | 7 +-- libavcodec/mpegaudiodecheader.h | 4 +--- libavformat/mp3dec.c

[FFmpeg-devel] [PATCH] avcodec: drop 2 suffix from avpriv_ac3_parse_header2

avpriv_ac3_parse_header was removed in commit 3dfb643. Signed-off-by: Andreas Cadhalpun --- libavcodec/ac3_parser.c | 4 ++-- libavcodec/ac3_parser.h | 2 +- libavcodec/ac3dec.c | 2 +- libavformat/ac3dec.c| 2 +- libavformat/movenc.c| 4 ++-- 5

Re: [FFmpeg-devel] [PATCH] avcodec: rename avpriv_color_frame to ff_color_frame

On 14.10.2015 01:50, Andreas Cadhalpun wrote: > It is only used inside libavcodec. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/h264_slice.c | 2 +- > libavcodec/internal.h | 2 +- > libavcodec/utils.c | 2 +- > 3 files changed, 3

[FFmpeg-devel] [PATCH] huffyuvencdsp: Add ff_diff_bytes_{sse2, avx2}

SSE2 version 4%-35% faster than MMX depending on the width. AVX2 version 1%-13% faster than SSE2 depending on the width. --- Addressed James's and Henrik's advices. Removed heuristics based on width. Made available both aligned and unaligned versions. For AVX2 version, gracefully fall back on

Re: [FFmpeg-devel] [PATCH] avcodec: drop 2 suffix from avpriv_ac3_parse_header2

On Wed, Oct 21, 2015 at 12:36:59AM +0200, Andreas Cadhalpun wrote: > avpriv_ac3_parse_header was removed in commit 3dfb643. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/ac3_parser.c | 4 ++-- > libavcodec/ac3_parser.h | 2 +- > libavcodec/ac3dec.c

[FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

Minor waste and more annoyingly triggers race detectors when the re-initialization happens across multiple threads. cos(0) == 1 and by default statics initialize to 0, so this check is safe. Signed-off-by: Dale Curtis --- libavcodec/fft_template.c | 2 ++ 1 file

Re: [FFmpeg-devel] [PATCH] huffyuvencdsp: Convert ff_diff_bytes_mmx to yasm

On Tue, Oct 20, 2015 at 2:18 PM James Almer wrote: > Removing this will make the INLINE_MMXEXT if statement below fail to > compile on > builds with inline asm disabled (msvc, etc). Even with dead code > elimination in > mind you'd need at least a prototype for the relevant

Re: [FFmpeg-devel] [PATCH] huffyuvencdsp: Add ff_diff_bytes_{sse2, avx2}

On 10/20/2015 10:32 PM, Timothy Gu wrote: > SSE2 version 4%-35% faster than MMX depending on the width. > AVX2 version 1%-13% faster than SSE2 depending on the width. > --- > > Addressed James's and Henrik's advices. Removed heuristics based on width. > Made available both aligned and unaligned

Re: [FFmpeg-devel] [PATCH] libvpxenc: remove some unused ctrl id mappings

On Tue, Oct 20, 2015 at 7:02 AM, Michael Niedermayer wrote: > On Mon, Oct 19, 2015 at 10:49:16PM -0700, James Zern wrote: >> VP8E_UPD_ENTROPY, VP8E_UPD_REFERENCE, VP8E_USE_REFERENCE were removed >> from libvpx and the remaining values were never used here >> >>

Re: [FFmpeg-devel] forcing ints to be 64 bits, possible new FATE client idea

On Tue, Oct 20, 2015 at 7:08 PM, Ganesh Ajjanagadde wrote: > Hi all, > > It is known that there exist at least certain parts of the codebase > that do not work correctly if ints are 64 bits. One of them I noticed > was in avutil/intmath.h: ff_ctz_c does not compute the right

Re: [FFmpeg-devel] forcing ints to be 64 bits, possible new FATE client idea

On Tue, Oct 20, 2015 at 7:09 PM Ganesh Ajjanagadde wrote: > Hi all, > > It is known that there exist at least certain parts of the codebase > that do not work correctly if ints are 64 bits. One of them I noticed > was in avutil/intmath.h: ff_ctz_c does not compute the right

Re: [FFmpeg-devel] [PATCH] avfilter: add shuffleframes filter

On Tue, Oct 20, 2015 at 12:28:32PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_shuffleframes.c | 157 > + doc please

[FFmpeg-devel] [PATCH] avfilter/vf_psnr: Add support for writing stats to stdout

Attached patch implements writing PSNR frame stats to standard output if the filename is "-". Regards, Tobias >From 163f8a547e7a4c4847c8b988017fd1ec73768d9e Mon Sep 17 00:00:00 2001 From: Tobias Rapp Date: Tue, 20 Oct 2015 15:02:21 +0200 Subject: [PATCH] avfilter/vf_psnr: