Re: [FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

On Sun, Jan 10, 2016 at 10:04:34PM +, Ricardo Constantino wrote: > On 10 January 2016 at 19:54, Michael Niedermayer > wrote: > > > > > please explain in the commit message why secmem is disabled > > > > > rtmpdh.c | 11 ++- > 1 file changed, 10

Re: [FFmpeg-devel] [PATCHv2] lavc/cbrt_tablegen: speed up tablegen

On Fri, Jan 8, 2016 at 6:52 AM, Michael Niedermayer wrote: > On Thu, Jan 07, 2016 at 05:20:55PM -0800, Ganesh Ajjanagadde wrote: >> On Thu, Jan 7, 2016 at 4:48 PM, Michael Niedermayer >> wrote: >> > On Mon, Jan 04, 2016 at 06:33:59PM -0800, Ganesh

Re: [FFmpeg-devel] [PATCH 3/3] ffmdec: change type of len to ptrdiff_t

On 07.01.2016 04:12, Michael Niedermayer wrote: > On Sat, Jan 02, 2016 at 04:52:25PM +0100, Andreas Cadhalpun wrote: >> It is used to store the difference between pointers, so ptrdiff_t is the >> correct type. >> >> This prevents potential overflows. >> >> Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH] diracdec: fix idwt_stride calculation in bytes

On 12.01.2016 00:01, Kieran Kunhya wrote: > Ok Pushed. Best regards, Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] diracdec: fix idwt_stride calculation in bytes

Ok On Mon, 11 Jan 2016 at 22:27 Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > The transformation to bytes must happen after alignment to get the same > resulting pointers as before. > > This fixes segmentation faults in the assembler code. > > The regression was introduced in

Re: [FFmpeg-devel] [PATCH] qtpalette: make the color_* variables unsigned again

On 10.01.2016 13:03, Mats Peterson wrote: > On 01/10/2016 11:56 AM, Andreas Cadhalpun wrote: >> This fixes segmentation faults due to out of bounds writes, when >> color_start is interpreted as negative number. >> > Yes Andreas, until my normalization patch for matroskadec.c is applied, of >

[FFmpeg-devel] [PATCH] avcodec/aacenc_is: replace pow(x, 0.75) by x/sqrtf(sqrtf(x))

This is quite an accurate approximation; testing shows ~ 2ulp error in the floating point result. Tested with FATE. Alternatively, if one wants "full accuracy", one can use powf, or sqrt instead of sqrtf. With powf, one gets 1 ulp error (theoretically should be 0, as 0.75 is exactly

[FFmpeg-devel] [PATCH] diracdec: Add slice threading to HQ profile

0001-diracdec-Add-slice-threading-to-HQ-profile.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] ffmpeg_opt: check fclose return value

This one may be slightly more theoretical, since the preset file is opened in a read-only mode. Nevertheless, it is a good idea to check its return value. Signed-off-by: Ganesh Ajjanagadde --- ffmpeg_opt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH] lavf/avi: pull stream durations from index, when available

This fixes files that have an incorrect nb_frames but a valid index --- libavformat/avidec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/avidec.c b/libavformat/avidec.c index 3859810..0b14860 100644 --- a/libavformat/avidec.c +++ b/libavformat/avidec.c @@ -1602,6 +1602,7 @@

[FFmpeg-devel] [PATCH] diracdec: fix idwt_stride calculation in bytes

The transformation to bytes must happen after alignment to get the same resulting pointers as before. This fixes segmentation faults in the assembler code. The regression was introduced in commit 9553689. Signed-off-by: Andreas Cadhalpun ---

Re: [FFmpeg-devel] [PATCH] libvpx: Support setting color range for vp9.

Thanks On Sat, Jan 9, 2016 at 7:53 AM, James Almer wrote: > On 1/9/2016 11:43 AM, Ronald S. Bultje wrote: > > Hi, > > > > On Fri, Jan 8, 2016 at 10:12 PM, Sasi Inguva wrote: > > > >> Pass through color range to vp9 encoder. Parse color range in >

[FFmpeg-devel] [PATCH]lavc/x264: Improve level setting

Hi! I guess that attached patch fixes the additional issue in ticket #3307. Please comment, Carl Eugen diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 88406a3..c1e52a1 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -559,6 +559,8 @@ static av_cold int

[FFmpeg-devel] [PATCH 2/2] lavc/srtdec: fix rounding errors in end times

--- libavcodec/srtdec.c | 4 +++ tests/ref/fate/sub-textenc | 66 ++-- tests/ref/fate/sub-webvttenc | 66 ++-- 3 files changed, 70 insertions(+), 66 deletions(-) diff --git a/libavcodec/srtdec.c

[FFmpeg-devel] [PATCH 1/2] lavc/ass: don't reset end_display_time if it's already set

--- libavcodec/ass.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/ass.c b/libavcodec/ass.c index 336c308..797b1c1 100644 --- a/libavcodec/ass.c +++ b/libavcodec/ass.c @@ -159,7 +159,8 @@ int ff_ass_add_rect(AVSubtitle *sub, const char *dialog, if (!rects)

Re: [FFmpeg-devel] [PATCH] qtpalette: make the color_* variables unsigned again

On 01/12/2016 03:32 AM, Mats Peterson wrote: Valid question. Of course there's no problem using uint32_t, but in the original code the variables are unsigned int... ask Andreas ;) Well, I'm to blame as well, since I have been using uint32_t for the a, r, g and b variables rather than unsigned

Re: [FFmpeg-devel] [PATCH] qtpalette: make the color_* variables unsigned again

On Mon, Jan 11, 2016 at 9:35 PM, Mats Peterson wrote: > On 01/12/2016 03:32 AM, Mats Peterson wrote: >> >> On 01/12/2016 03:26 AM, Ronald S. Bultje wrote: >>> >>> Why are we using stdint types for non-vector data here? Our custom has >>> always been to used sized

Re: [FFmpeg-devel] [PATCH] qtpalette: make the color_* variables unsigned again

On 01/12/2016 06:28 AM, Mats Peterson wrote: Exactly, I actually thought of that myself. And I like the stdint variables because they eliminate guesswork. That has always been a problem with the "standard" types in C. The stdint TYPES, of course. Mats

[FFmpeg-devel] [PATCH 03/13] lavfi/vf_lut3d: check fclose return value

Maybe theoretical; since the file is opened in read-only mode. Nevertheless, it is a good idea to check the return value. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_lut3d.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 00/13] check all fclose usage

Some preliminary work has already been done on fclose checking. This completes the work, modulo a few exceptions: 1. Things under an ifdef DEBUG or similar: these are not important. 2. Tests/tools code: also not important. 3. Likely not important, and beyond my knowledge: see lavu/arm/cpu.c.

Re: [FFmpeg-devel] [PATCH] qtpalette: make the color_* variables unsigned again

On 01/12/2016 05:48 AM, Ganesh Ajjanagadde wrote: You're free to make another patch, or if perhaps I should do it. If something is inherently 32 bits (e.g obtained by reading 4 bytes), then please don't make such a patch. Seems to be the case here, and so I would nack such a patch: color_start

[FFmpeg-devel] [PATCH] libvpxdec: fix 'ISO C90 forbids mixed declarations and code' warning

since: cbcc88c libvpx: Support setting color range for vp9. Signed-off-by: James Zern --- libavcodec/libvpxdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index de72be9..b51bfa2 100644 ---

Re: [FFmpeg-devel] [PATCH 00/13] check all fclose usage

On Mon, Jan 11, 2016 at 11:25 PM, Ganesh Ajjanagadde wrote: [...] > > In the case of ffserver, some nearby improvements were done. Most serious was > the > build failure on non Linux machines. This was a completely bogus one; an error made while rebasing/squashing stuff.

Re: [FFmpeg-devel] [PATCH] qtpalette: make the color_* variables unsigned again

On 01/12/2016 03:26 AM, Ronald S. Bultje wrote: Why are we using stdint types for non-vector data here? Our custom has always been to used sized (stdint-style) data only for vector data (arrays etc.), and use native-sized types (e.g. unsigned, int, whatever) for scalar values. Why are we making

[FFmpeg-devel] [PATCH 12/13] ffserver: correct indentation

Signed-off-by: Ganesh Ajjanagadde --- ffserver.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/ffserver.c b/ffserver.c index 4cd5834..c68894f 100644 --- a/ffserver.c +++ b/ffserver.c @@ -2072,31 +2072,31

Re: [FFmpeg-devel] [PATCH] qtpalette: make the color_* variables unsigned again

On Mon, Jan 11, 2016 at 9:48 PM, Mats Peterson wrote: > On 01/12/2016 03:32 AM, Mats Peterson wrote: >> >> Valid question. Of course there's no problem using uint32_t, but in the >> original code the variables are unsigned int... ask Andreas ;) > > > Well, I'm to

Re: [FFmpeg-devel] [PATCH] rtmpdh: Initialize gcrypt before using it

On Sun, Jan 10, 2016 at 10:04:34PM +, Ricardo Constantino wrote: > Either disabling or init'ing secure memory is required after the use > of gcry_check_version. From a look at the functions rtmpdh uses, I > noticed none require the use of secure memory, so we disable it [1][2]. > > This

Re: [FFmpeg-devel] [PATCH] qtpalette: make the color_* variables unsigned again

On 01/12/2016 05:51 AM, Ganesh Ajjanagadde wrote: On Mon, Jan 11, 2016 at 9:48 PM, Mats Peterson wrote: On 01/12/2016 03:32 AM, Mats Peterson wrote: Don't blame yourself; it is in fact a regression IMHO to change to unsigned int, albeit a theoretical one. C

Re: [FFmpeg-devel] [PATCH] qtpalette: make the color_* variables unsigned again

On 01/12/2016 03:32 AM, Mats Peterson wrote: On 01/12/2016 03:26 AM, Ronald S. Bultje wrote: Why are we using stdint types for non-vector data here? Our custom has always been to used sized (stdint-style) data only for vector data (arrays etc.), and use native-sized types (e.g. unsigned, int,

[FFmpeg-devel] [PATCH 11/13] ffserver: log diagnostics for popen return failure

Some errno hackery needed since errno is not set for when popen fails due to out of memory; man popen. Signed-off-by: Ganesh Ajjanagadde --- ffserver.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/ffserver.c b/ffserver.c index 51928f3..4cd5834 100644

[FFmpeg-devel] [PATCH 13/13] ffserver_config: check fclose return value

Maybe theoretical; since all files here are opened in read only mode. Nevertheless, it is a good idea to check the return value. Signed-off-by: Ganesh Ajjanagadde --- ffserver_config.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH 09/13] ffserver: check fclose return value

Maybe theoretical; since all files here are opened in read only mode. Nevertheless, it is a good idea to check the return value. Signed-off-by: Ganesh Ajjanagadde --- ffserver.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git

[FFmpeg-devel] [PATCH 01/13] lavc/dvdsubdec: check fclose return value

Maybe theoretical; since the file is opened in read-only mode. Nevertheless, it is a good idea to check the return value. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/dvdsubdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 05/13] lavfi/vf_psnr: check fclose return value

Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_psnr.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_psnr.c b/libavfilter/vf_psnr.c index bce5c51..b6e7f06 100644 --- a/libavfilter/vf_psnr.c +++ b/libavfilter/vf_psnr.c @@

[FFmpeg-devel] [PATCH 02/13] lavfi/vf_deshake: check fclose return value

Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_deshake.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_deshake.c b/libavfilter/vf_deshake.c index e7ece44..a89506b 100644 --- a/libavfilter/vf_deshake.c +++

[FFmpeg-devel] [PATCH 06/13] lavfi/vf_ssim: check fclose return value

Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_ssim.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_ssim.c b/libavfilter/vf_ssim.c index 7c43e98..1050b68 100644 --- a/libavfilter/vf_ssim.c +++ b/libavfilter/vf_ssim.c @@

[FFmpeg-devel] [PATCH 07/13] lavfi/vf_vidstabdetect: check fclose return value

Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_vidstabdetect.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_vidstabdetect.c b/libavfilter/vf_vidstabdetect.c index 4742949..a91968a 100644 --- a/libavfilter/vf_vidstabdetect.c

[FFmpeg-devel] [PATCH 04/13] lavfi/vf_paletteuse: check fclose return value

Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_paletteuse.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c index 1225a66..a5449df 100644 --- a/libavfilter/vf_paletteuse.c +++

[FFmpeg-devel] [PATCH 10/13] ffserver: fix build failure on non linux machines

Simple test: just change to !defined(linux). No idea why this was never fixed... Signed-off-by: Ganesh Ajjanagadde --- ffserver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ffserver.c b/ffserver.c index 720d164..51928f3 100644 --- a/ffserver.c +++ b/ffserver.c

Re: [FFmpeg-devel] [PATCH 2/2] lavc/ccaption_dec: implement real_time option

On Saturday, January 09, 2016 02:55:01 PM Aman Gupta wrote: > From: Aman Gupta > > This new mode is useful for realtime decoding of closed captions so they > can be display along with mpeg2 frames. > > Closed caption streams contain two major types of captions: > > - POPON

[FFmpeg-devel] [PATCH] ffmpeg: extend -benchmark_all option to show elapsed time

The value is useful to get a raw estimate of the expected encoding/decoding time. Also extend option documentation. --- doc/ffmpeg.texi | 6 ++ ffmpeg.c| 9 +++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index

Re: [FFmpeg-devel] [libav-devel] [PATCH 1/2] avcodec: Add Cineform HD Decoder

On Sun, Jan 10, 2016 at 1:28 AM, Kieran Kunhya wrote: > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/cfhd.c | 565 > > libavcodec/cfhd.h |