[FFmpeg-devel] [PATCH 3/3] avformat/matroska: use av_stream_add_side_data() for stereo3d side data

Signed-off-by: James Almer --- libavformat/matroska.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/libavformat/matroska.c b/libavformat/matroska.c index c592fb0..7a3d233 100644 --- a/libavformat/matroska.c +++

[FFmpeg-devel] [PATCH 1/3] avformat/utils: add av_stream_add_side_data()

Functionally similar to av_packet_add_side_data(). Allows the use of an already allocated buffer as stream side data. Signed-off-by: James Almer --- TODO: Version bump. doc/APIchanges | 3 +++ libavformat/avformat.h | 16 libavformat/utils.c| 32

[FFmpeg-devel] [PATCH 2/3] avformat/mov: use av_stream_add_side_data() for displaymatrix side data

Signed-off-by: James Almer --- libavformat/mov.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 8d6cc12..5ba9965 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -5647,20 +5647,13 @@

Re: [FFmpeg-devel] [PATCH 2/3 v2] lavc: Add spherical packet side data API

On 11/15/2016 1:56 PM, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > Updated to use int32 for rotation. > Please CC. > Vittorio [...] > diff --git a/libavformat/dump.c b/libavformat/dump.c > index cd14625..2dd7a0a 100644 > --- a/libavformat/dump.c

Re: [FFmpeg-devel] [PATCH] ffmdec: sanitize codec parameters

On Thu, Nov 17, 2016 at 01:08:31AM +0100, Andreas Cadhalpun wrote: > All the fields can be set via options read from the ffm file and thus > have to be sanitized. > > A negative extradata size for example gets passed to memcpy in > avcodec_parameters_from_context causing a segmentation fault. >

[FFmpeg-devel] [PATCH] ffmdec: sanitize codec parameters

All the fields can be set via options read from the ffm file and thus have to be sanitized. A negative extradata size for example gets passed to memcpy in avcodec_parameters_from_context causing a segmentation fault. Signed-off-by: Andreas Cadhalpun --- The

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

> > It was lossless before and is lossless after the patch but it > output the 16bit format that you don't like and of which you > claim it breaks with find_best_pix_fmt() - I still believe this > should be trivial to fix. > > Currently white is gray, the patch tries to fix this. > erm...in what

Re: [FFmpeg-devel] [PATCH 1/3 v2] lavu: Add AVSphericalMapping type and frame side data

On Wed, Nov 16, 2016 at 6:29 PM, Michael Niedermayer wrote: > On Wed, Nov 16, 2016 at 05:38:20PM -0500, Vittorio Giovara wrote: >> On Tue, Nov 15, 2016 at 8:52 PM, James Almer wrote: >> > On 11/15/2016 10:39 PM, Michael Niedermayer wrote: >> >> On Tue,

Re: [FFmpeg-devel] [PATCH 1/3 v2] lavu: Add AVSphericalMapping type and frame side data

On Wed, Nov 16, 2016 at 05:38:20PM -0500, Vittorio Giovara wrote: > On Tue, Nov 15, 2016 at 8:52 PM, James Almer wrote: > > On 11/15/2016 10:39 PM, Michael Niedermayer wrote: > >> On Tue, Nov 15, 2016 at 11:56:48AM -0500, Vittorio Giovara wrote: > >> [...] > >>> +/** > >>> + *

Re: [FFmpeg-devel] [PATCH] avcodec/aaccoder: Limit sf_idx difference for all cases

On Wed, Nov 16, 2016 at 8:09 PM, Michael Niedermayer wrote: >> Sorry for the delay, it turned out to be more complex than that. >> >> There were a few potential violations that I had already identified in >> a WIP patch but they did not apply to the fuzzed sample. That

Re: [FFmpeg-devel] [PATCH 3/3 v2] mov: Export spherical information

On Wed, Nov 16, 2016 at 5:57 PM, James Almer wrote: > On 11/16/2016 12:33 PM, Vittorio Giovara wrote: >> On Tue, Nov 15, 2016 at 10:09 PM, James Almer wrote: >>> On 11/15/2016 1:56 PM, Vittorio Giovara wrote: >>> >>> Does Google offer samples to confirm

Re: [FFmpeg-devel] [PATCH] avcodec/aaccoder: Limit sf_idx difference for all cases

On Thu, Sep 22, 2016 at 06:51:03AM -0300, Claudio Freire wrote: > On Sat, Sep 10, 2016 at 3:37 AM, Claudio Freire > wrote: > > On Thu, Aug 25, 2016 at 8:57 AM, Rostislav Pehlivanov > > wrote: > >>> 64ed96a710787ba5d0666746a8562e7d.dee > >>> > >>>

Re: [FFmpeg-devel] libavcodec/exr : Fix channel size calc

On 16.11.2016 23:24, Martin Vignali wrote: > Following discussion "exr : limit expected_len to tmp buffer size" > > Patch in attach fix channel calc when there is uint32 channel and other kind > of channel (float or half). Thanks, I've pushed this patch now. Best regards, Andreas

Re: [FFmpeg-devel] [PATCH 3/3 v2] mov: Export spherical information

On 11/16/2016 12:33 PM, Vittorio Giovara wrote: > On Tue, Nov 15, 2016 at 10:09 PM, James Almer wrote: >> On 11/15/2016 1:56 PM, Vittorio Giovara wrote: >>> +static int mov_read_st3d(MOVContext *c, AVIOContext *pb, MOVAtom atom) >>> +{ >>> +AVStream *st; >>> +

Re: [FFmpeg-devel] [PATCH 1/3 v2] lavu: Add AVSphericalMapping type and frame side data

On Tue, Nov 15, 2016 at 8:52 PM, James Almer wrote: > On 11/15/2016 10:39 PM, Michael Niedermayer wrote: >> On Tue, Nov 15, 2016 at 11:56:48AM -0500, Vittorio Giovara wrote: >> [...] >>> +/** >>> + * This structure describes how to handle spherical videos, outlining >>> + *

[FFmpeg-devel] libavcodec/exr : Fix channel size calc

Hello, Following discussion "exr : limit expected_len to tmp buffer size" Patch in attach fix channel calc when there is uint32 channel and other kind of channel (float or half). Found by Andreas Cadhalpun I will try to make a fate test for this. Martin From

Re: [FFmpeg-devel] [PATCH 1/3] exr: limit expected_len to tmp buffer size

> > Yes, that is a better fix. Can you send a proper patch for this? > > Best regards, > Andreas > > Yes i will send a patch for this. Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/3] exr: fix out-of-bounds read

On 16.11.2016 21:07, Paul B Mahol wrote: > On 11/16/16, Andreas Cadhalpun wrote: >> channel_index can be -1. >> >> This problem was introduced in commit >> 2dd7b46132e2801ef34fe1b5c27e0113cdcfa2f9. >> > > lgtm Pushed together with the reindentation. Best

Re: [FFmpeg-devel] [PATCH 1/3] exr: limit expected_len to tmp buffer size

> > td->xsize = 800 > td->ysize = 16 > s->current_channel_offset = 5 > td->channel_line_size = s->current_channel_offset * td->xsize = 4000 > uncompressed_size = td->channel_line_size * td->ysize = 64000 > > s->nb_channels = 3 > > p s->channels[0].pixel_type = EXR_HALF > expected_len = td->xsize *

Re: [FFmpeg-devel] [PATCH 1/3] exr: limit expected_len to tmp buffer size

On 16.11.2016 22:16, Martin Vignali wrote: > I think the trouble come from another place > The current channel offset is not correct for uint32 (because it use 1<<0 = 1 > instead of 4 for uint32) > > Some months ago i propose a patch who was not accepted for uint32 support in > exr. > But the

Re: [FFmpeg-devel] [PATCH 2/2] libschroedingerdec: fix leaking of framewithpts

On Wed, Nov 16, 2016 at 07:46:59PM +0100, Andreas Cadhalpun wrote: > On 16.11.2016 15:14, Michael Niedermayer wrote: > > On Wed, Nov 16, 2016 at 01:48:05PM +0100, wm4 wrote: > >> On Wed, 16 Nov 2016 13:21:34 +0100 > >> Michael Niedermayer wrote: > >>> On Tue, Nov 15, 2016

Re: [FFmpeg-devel] [PATCH 1/3] exr: limit expected_len to tmp buffer size

Hi, On 16.11.2016 21:29, Martin Vignali wrote: > in what case expected_len can be > to uncompress_size ? td->xsize = 800 td->ysize = 16 s->current_channel_offset = 5 td->channel_line_size = s->current_channel_offset * td->xsize = 4000 uncompressed_size = td->channel_line_size * td->ysize = 64000

Re: [FFmpeg-devel] [PATCH 1/3] exr: limit expected_len to tmp buffer size

> > +expected_len = FFMIN(expected_len, uncompressed_size); > + > dest_len = expected_len; > > > Hello, in what case expected_len can be > to uncompress_size ? Did you have a test sample ? Martin ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/3] exr: fix out-of-bounds read

On 11/16/16, Andreas Cadhalpun wrote: > channel_index can be -1. > > This problem was introduced in commit > 2dd7b46132e2801ef34fe1b5c27e0113cdcfa2f9. > lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 3/3] exr: reindent after previous commit

Signed-off-by: Andreas Cadhalpun --- libavcodec/exr.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index bff08f2..35e07d4 100644 --- a/libavcodec/exr.c +++ b/libavcodec/exr.c @@ -1431,14

[FFmpeg-devel] [PATCH 2/3] exr: fix out-of-bounds read

channel_index can be -1. This problem was introduced in commit 2dd7b46132e2801ef34fe1b5c27e0113cdcfa2f9. Signed-off-by: Andreas Cadhalpun --- libavcodec/exr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/exr.c

[FFmpeg-devel] [PATCH 1/3] exr: limit expected_len to tmp buffer size

This fixes crashes due to pointer corruption caused by invalid writes. The problem was introduced in commit 03152e74dfdc7f438cb4a10402c4de744e807e22. Signed-off-by: Andreas Cadhalpun --- libavcodec/exr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH 2/2] libschroedingerdec: fix leaking of framewithpts

On 16.11.2016 15:14, Michael Niedermayer wrote: > On Wed, Nov 16, 2016 at 01:48:05PM +0100, wm4 wrote: >> On Wed, 16 Nov 2016 13:21:34 +0100 >> Michael Niedermayer wrote: >>> On Tue, Nov 15, 2016 at 09:56:16PM +0100, Andreas Cadhalpun wrote: However, considering the

Re: [FFmpeg-devel] [PATCH 2/2] libschroedingerdec: fix leaking of framewithpts

On 16.11.2016 13:21, Michael Niedermayer wrote: > On Tue, Nov 15, 2016 at 09:56:16PM +0100, Andreas Cadhalpun wrote: >> libschroedingerdec.c | 16 +--- >> 1 file changed, 9 insertions(+), 7 deletions(-) >> 6cc9768bea564b1bf50a25198deaf95adfa3151a >>

Re: [FFmpeg-devel] [PATCH] dds: limit 4 bpp handling to AV_PIX_FMT_PAL8

On 16.11.2016 07:52, Paul B Mahol wrote: > On 11/15/16, Andreas Cadhalpun wrote: >> This fixes NULL pointer dereferencing for formats, where frame->data[1] >> is not allocated. >> >> The problem was introduced in commit >>

Re: [FFmpeg-devel] [PATCH 3/3 v2] mov: Export spherical information

On Tue, Nov 15, 2016 at 10:09 PM, James Almer wrote: > On 11/15/2016 1:56 PM, Vittorio Giovara wrote: >> +static int mov_read_st3d(MOVContext *c, AVIOContext *pb, MOVAtom atom) >> +{ >> +AVStream *st; >> +MOVStreamContext *sc; >> +enum AVStereo3DType type; >> +

Re: [FFmpeg-devel] [PATCH] fate: Add h264 extradata reload tests

On Tue, Nov 15, 2016 at 8:47 PM, Michael Niedermayer wrote: > On Tue, Nov 15, 2016 at 11:18:02AM -0500, Vittorio Giovara wrote: >> --- >> This is the version without hevc testing. >> Please CC. >> Vittorio >> >> tests/fate/h264.mak | 5 + >>

Re: [FFmpeg-devel] [PATCH] doc/filters: adds recently added -vf colorspace options

Hi Kieran, On Tue, Nov 15, 2016 at 7:18 PM, Kieran O Leary wrote: > From: kieranjol Is your name spelled like this intentionally? Maybe change your git config so this has your full name instead of what appears to be your login? Ronald

Re: [FFmpeg-devel] [PATCH 2/2] libschroedingerdec: fix leaking of framewithpts

On Wed, 16 Nov 2016 15:14:59 +0100 Michael Niedermayer wrote: > On Wed, Nov 16, 2016 at 01:48:05PM +0100, wm4 wrote: > > On Wed, 16 Nov 2016 13:21:34 +0100 > > Michael Niedermayer wrote: > > > > > On Tue, Nov 15, 2016 at 09:56:16PM +0100,

Re: [FFmpeg-devel] [PATCH 2/2] libschroedingerdec: fix leaking of framewithpts

On Wed, Nov 16, 2016 at 01:48:05PM +0100, wm4 wrote: > On Wed, 16 Nov 2016 13:21:34 +0100 > Michael Niedermayer wrote: > > > On Tue, Nov 15, 2016 at 09:56:16PM +0100, Andreas Cadhalpun wrote: > > > On 15.11.2016 03:18, Michael Niedermayer wrote: > > > > On Sun, Nov 13,

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

On Wed, Nov 16, 2016 at 12:15:28PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch improves output for some ffv1 files imo. > Current slowdown for the existing decode-line timer is > 2%, I wonder if this can be improved through refactoring. > > Please comment, Carl Eugen > ffv1dec.c |

Re: [FFmpeg-devel] [PATCH] doc/filters: adds recently added -vf colorspace options

On Wed, Nov 16, 2016 at 12:18:43AM +, Kieran O Leary wrote: > Hi, > > I've never submitted a patch for anything before, so hopefully this is OK. > I noticed that the recent commits by Vittorio Giovara were not reflected in > the filter documentation. > > I'm attaching the output of git

Re: [FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

On Wed, Nov 16, 2016 at 12:33:32PM +0100, wm4 wrote: > On Wed, 16 Nov 2016 11:21:59 + > Franklin Phillips wrote: > > > On Wed, Nov 16, 2016 at 11:41:41AM +0100, wm4 wrote: > > > On Wed, 16 Nov 2016 10:31:10 + > > > Franklin Phillips

Re: [FFmpeg-devel] [PATCH] configure: properly add dxva2 link dependencies

On Sun, Nov 13, 2016 at 10:18 AM, Hendrik Leppkes wrote: > On Sat, Nov 12, 2016 at 2:02 AM, Hendrik Leppkes wrote: >> Fixes building with --disable-everything --enable-shared --enable-dxva2 >> >> The hwcontext DXVA2 implementation in avutil needs this

Re: [FFmpeg-devel] [PATCH 2/2] libschroedingerdec: fix leaking of framewithpts

On Wed, 16 Nov 2016 13:21:34 +0100 Michael Niedermayer wrote: > On Tue, Nov 15, 2016 at 09:56:16PM +0100, Andreas Cadhalpun wrote: > > On 15.11.2016 03:18, Michael Niedermayer wrote: > > > On Sun, Nov 13, 2016 at 11:25:32PM +0100, Andreas Cadhalpun wrote: > > >>

Re: [FFmpeg-devel] [PATCH] cmdutils: remove duplicate windows.h include

On Tue, Nov 08, 2016 at 10:29:54PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > cmdutils.c | 1 - > 1 file changed, 1 deletion(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No great genius

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

2016-11-16 12:38 GMT+01:00 Hendrik Leppkes : > On Wed, Nov 16, 2016 at 12:15 PM, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch improves output for some ffv1 files imo. >> Current slowdown for the existing decode-line timer is >> 2%, I wonder if this

Re: [FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

On Tue, Nov 15, 2016 at 10:50:18AM +, Franklin Phillips wrote: > Hi, > > I am having trouble getting my patch to show up in > https://patchwork.ffmpeg.org/. This page > (https://www.ffmpeg.org/developer.html#Submitting-patches-1) suggests it > could be the mime type, however I used one of

Re: [FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

On Wed, Nov 16, 2016 at 12:15 PM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch improves output for some ffv1 files imo. > Current slowdown for the existing decode-line timer is > 2%, I wonder if this can be improved through refactoring. > > Please comment, Carl Eugen >

Re: [FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

On Wed, 16 Nov 2016 11:21:59 + Franklin Phillips wrote: > On Wed, Nov 16, 2016 at 11:41:41AM +0100, wm4 wrote: > > On Wed, 16 Nov 2016 10:31:10 + > > Franklin Phillips wrote: > > > > > This patch is a fix for ticket #2833. > > > >

Re: [FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

On Wed, Nov 16, 2016 at 11:41:41AM +0100, wm4 wrote: > On Wed, 16 Nov 2016 10:31:10 + > Franklin Phillips wrote: > > > This patch is a fix for ticket #2833. > > > > Each subtitle segment is its own WebVTT file and has to demuxed > > individually. > > > The timing

[FFmpeg-devel] [RFC]lavc/ffv1dec: Scale msb-packed output to full 16bit

Hi! Attached patch improves output for some ffv1 files imo. Current slowdown for the existing decode-line timer is 2%, I wonder if this can be improved through refactoring. Please comment, Carl Eugen From e4e8277d4f0daeb9f61c2da9ebb167a084b1b93c Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

On Tue, Nov 15, 2016 at 09:56:39PM +0100, Henrik Gramner wrote: > On Tue, Nov 15, 2016 at 1:39 PM, Franklin Phillips > wrote: > > Sorry, I forgot to mention that my first attempt was using git send-email, > > when that didn't work, I tried mutt, same result using

Re: [FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

On Tue, Nov 15, 2016 at 09:56:39PM +0100, Henrik Gramner wrote: > On Tue, Nov 15, 2016 at 1:39 PM, Franklin Phillips > wrote: > > Sorry, I forgot to mention that my first attempt was using git send-email, > > when that didn't work, I tried mutt, same result using

Re: [FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

On Wed, 16 Nov 2016 10:31:10 + Franklin Phillips wrote: > This patch is a fix for ticket #2833. > > Each subtitle segment is its own WebVTT file and has to demuxed individually. > The timing of the subtitles are not perfect but it is the best I could What does

[FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

This patch is a fix for ticket #2833. Each subtitle segment is its own WebVTT file and has to demuxed individually. The timing of the subtitles are not perfect but it is the best I could do and it also does not take into account the X-TIMESTAMP-MAP header in the WebVTT files which is needed to