Re: [FFmpeg-devel] [PATCH][WIP][RFC] Add support for MPEG-4 Simple Studio Profile

2017-01-07 Thread Michael Niedermayer
On Sun, Jan 08, 2017 at 01:00:31AM +, Kieran Kunhya wrote: > On Sat, 7 Jan 2017 at 23:43 Michael Niedermayer > wrote: > > > On Sat, Jan 07, 2017 at 10:35:43PM +, Kieran Kunhya wrote: > > > Hi, > > > > > > I have added support for MPEG-4 Sstp using the available

Re: [FFmpeg-devel] [PATCH] ffserver: local OOB write with custom program name

2017-01-07 Thread Michael Niedermayer
On Fri, Jan 06, 2017 at 11:33:16PM +0100, Tobias Stoeckmann wrote: > When the command line for children is created, it is assumed that > my_program_name always ends with "ffserver", which doesn't have to > be true if ffserver is called through a symbolic link. > > In such a case, it could be that

Re: [FFmpeg-devel] [PATCH][WIP][RFC] Add support for MPEG-4 Simple Studio Profile

2017-01-07 Thread Kieran Kunhya
On Sat, 7 Jan 2017 at 23:43 Michael Niedermayer wrote: > On Sat, Jan 07, 2017 at 10:35:43PM +, Kieran Kunhya wrote: > > Hi, > > > > I have added support for MPEG-4 Sstp using the available samples on trac. > > Yes it doesn't pass fate, yes it's not format-patch, yes

[FFmpeg-devel] [PATCH] Never unmap unallocated space

2017-01-07 Thread Tobias Stoeckmann
The function av_file_map can use mmap to memory-map the content of a file into address space. Just like every other alternative, mmap() could fail due to various reasons, e.g. if not enough address space is available. Unfortunately, av_file_map writes the requested size even on error into the

[FFmpeg-devel] [PATCH] ffserver: local OOB write with custom program name

2017-01-07 Thread Tobias Stoeckmann
When the command line for children is created, it is assumed that my_program_name always ends with "ffserver", which doesn't have to be true if ffserver is called through a symbolic link. In such a case, it could be that not enough space for "ffmpeg" is available at the end, leading to a buffer

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: start_number new options

2017-01-07 Thread Steven Liu
2017-01-08 1:37 GMT+08:00 Bodecs Bela : > > > 2017.01.07. 0:32 keltezéssel, Steven Liu írta: > >> 2017-01-07 0:47 GMT+08:00 Bodecs Bela : >> >> >>> 2017.01.06. 17:33 keltezéssel, Steven Liu írta: >>> >>> 2017-01-07 0:22 GMT+08:00 Bodecs Bela

Re: [FFmpeg-devel] [PATCH][WIP][RFC] Add support for MPEG-4 Simple Studio Profile

2017-01-07 Thread Michael Niedermayer
On Sat, Jan 07, 2017 at 10:35:43PM +, Kieran Kunhya wrote: > Hi, > > I have added support for MPEG-4 Sstp using the available samples on trac. > Yes it doesn't pass fate, yes it's not format-patch, yes it uses printfs. > https://trac.ffmpeg.org/ticket/4447 > > Being MPEG-4, it depends on

Re: [FFmpeg-devel] [PATCH] libavutil/hwcontext_qsv: Command line using hwaccel 'QSV' doesn't work

2017-01-07 Thread Mark Thompson
On 06/01/17 06:37, Huang, Zhengxu wrote: > Hi > > According to the suggestion update the patch. > > thanks. > > > From 4beadd3c84c797a56c4f375458d0a1e9d9b233c8 Mon Sep 17 00:00:00 2001 > From: Zhengxu > Date: Thu, 5 Jan 2017 14:48:06 +0800 > Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: disable B frame in baseline profile

2017-01-07 Thread Mark Thompson
On 06/01/17 15:19, Moritz Barsnick wrote: > Since Michael mentioned it: > > On Fri, Dec 16, 2016 at 10:21:25 +0800, Jun Zhao wrote: > >> +if (avctx->max_b_frames != 0) { >> +avctx->max_b_frames = 0; >> +av_log(avctx, AV_LOG_WARNING, "H.264 constrained baseline "

[FFmpeg-devel] [PATCH][WIP][RFC] Add support for MPEG-4 Simple Studio Profile

2017-01-07 Thread Kieran Kunhya
Hi, I have added support for MPEG-4 Sstp using the available samples on trac. Yes it doesn't pass fate, yes it's not format-patch, yes it uses printfs. https://trac.ffmpeg.org/ticket/4447 Being MPEG-4, it depends on mpegvideo.c so has tons of yuv420p assumptions baked in which are of course

Re: [FFmpeg-devel] Implementation of Huffman codes for DCA encoder

2017-01-07 Thread Даниил Чередник
With real music and 256k bitrate encoding (the source was 44100, 16bit stereo) I got: Without Huffman: Best PSNR is 31.77 for shift 0 With: Best PSNR is 37.45 for shift 0 Current implementation of DCA encoder has minimal set of DTS features (no ADPCM, no VQ, fixed amount of transmitted

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle given video parameters

2017-01-07 Thread Pavel Koshevoy
On Mon, Jan 2, 2017 at 2:26 PM, wrote: > From: Pavel Koshevoy > > Evidently CUVID doesn't support decoding 422 or 444 chroma formats, > and only a limited set of resolutions per codec are supported. > > Given that stream resolution and pixel format are

Re: [FFmpeg-devel] Implementation of Huffman codes for DCA encoder

2017-01-07 Thread Carl Eugen Hoyos
2017-01-07 20:39 GMT+01:00 Rostislav Pehlivanov : > On 7 January 2017 at 16:11, Carl Eugen Hoyos wrote: > >> 2017-01-07 16:00 GMT+01:00 Даниил Чередник : >> >> > Currently I am working on improvement quality of DTS encoder.

Re: [FFmpeg-devel] Implementation of Huffman codes for DCA encoder

2017-01-07 Thread Rostislav Pehlivanov
On 7 January 2017 at 16:11, Carl Eugen Hoyos wrote: > 2017-01-07 16:00 GMT+01:00 Даниил Чередник : > > > Currently I am working on improvement quality of DTS encoder. Following > > patches introduce Huffman coding. > > Is the quality improvement so

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: start_number new options

2017-01-07 Thread Bodecs Bela
2017.01.07. 0:32 keltezéssel, Steven Liu írta: 2017-01-07 0:47 GMT+08:00 Bodecs Bela : 2017.01.06. 17:33 keltezéssel, Steven Liu írta: 2017-01-07 0:22 GMT+08:00 Bodecs Bela : 2017.01.06. 16:50 keltezéssel, Steven Liu írta: 2017-01-06 22:07

Re: [FFmpeg-devel] [PATCH] avcodec/dca: add support for 20-bit XLL

2017-01-07 Thread Michael Niedermayer
On Sat, Jan 07, 2017 at 12:26:43PM +0300, foo86 wrote: > Fixes ticket #6063. > --- > libavcodec/dca_xll.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) I think i suggested it before but You are de facto maintaining dca, you should add yourself in a patch to the MAINTAINERs file

Re: [FFmpeg-devel] Implementation of Huffman codes for DCA encoder

2017-01-07 Thread Carl Eugen Hoyos
2017-01-07 16:00 GMT+01:00 Даниил Чередник : > Currently I am working on improvement quality of DTS encoder. Following > patches introduce Huffman coding. Is the quality improvement so obvious that no further tests are necessary? (Does psnr improve measurably?) Please

[FFmpeg-devel] Implementation of Huffman codes for DCA encoder

2017-01-07 Thread Даниил Чередник
Hi!. Currently I am working on improvement quality of DTS encoder. Following patches introduce Huffman coding. First one - reverse data layout [SUBBAND_SAMPLES][DCAENC_SUBBANDS][MAX_CHANNELS] to [MAX_CHANNELS][DCAENC_SUBBANDS][SUBBAND_SAMPLES]. I need it to write more readable code, and reduce (a

Re: [FFmpeg-devel] [PATCH] avcodec/dca: add support for 20-bit XLL

2017-01-07 Thread James Almer
On 1/7/2017 6:26 AM, foo86 wrote: > Fixes ticket #6063. > --- > libavcodec/dca_xll.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/dca_xll.c b/libavcodec/dca_xll.c > index 1d616c298c..1320aaf28f 100644 > --- a/libavcodec/dca_xll.c > +++

Re: [FFmpeg-devel] [PATCH] libavcodec/exr: Fix blank output when data window != display window

2017-01-07 Thread Moritz Barsnick
On Fri, Jan 06, 2017 at 18:08:44 +0100, Martin Vignali wrote: > Did you try,all the official display/data window sample ? I did have a look at a few selected samples, and ffmpeg doesn't seem to handle them: http://ffmpeg.org/pipermail/ffmpeg-user/2017-January/034831.html I'm not sure

Re: [FFmpeg-devel] [PATCH 2/2] avformat/matroskaenc: Regression fix for invalid MKV headers

2017-01-07 Thread James Almer
On 1/6/2017 8:33 PM, Soft Works wrote: > Revision #4: Don't create CRC32 for preliminary headers > > The following three commits created a regression by writing initially > invalid mkv headers: > > 650e17d88b63b5aca6e0a43483e89e64b0f7d2dd avformat/matroskaenc: write a > CRC32 element on Tags >

Re: [FFmpeg-devel] [PATCH 1/3] mpeg12dec: validate color space

2017-01-07 Thread Ronald S. Bultje
Hi, On Fri, Jan 6, 2017 at 9:35 PM, Michael Niedermayer wrote: > On Fri, Jan 06, 2017 at 09:43:24PM +0100, Andreas Cadhalpun wrote: > > On 23.12.2016 00:57, Andreas Cadhalpun wrote: > > > Signed-off-by: Andreas Cadhalpun > > > --- > > >

Re: [FFmpeg-devel] [PATCH 4/9] genh: prevent overflow during block alignment calculation

2017-01-07 Thread Ronald S. Bultje
Hi, On Fri, Jan 6, 2017 at 8:43 PM, Michael Niedermayer wrote: > On Fri, Jan 06, 2017 at 08:48:02PM +0100, Andreas Cadhalpun wrote: > > Signed-off-by: Andreas Cadhalpun > > --- > > libavformat/genh.c | 1 + > > 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/avio: Add avio_get_dyn_buf function

2017-01-07 Thread Michael Niedermayer
On Sat, Jan 07, 2017 at 03:38:48AM +, Soft Works wrote: > > Michael wrote > > Is the author name intended to be > > Author: softworkz > > Yes please, if you don't mind, same as my previous commit: >

Re: [FFmpeg-devel] [PATCH] avcodec/dca: add support for 20-bit XLL

2017-01-07 Thread Paul B Mahol
On 1/7/17, foo86 wrote: > Fixes ticket #6063. > --- > libavcodec/dca_xll.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/dca_xll.c b/libavcodec/dca_xll.c > index 1d616c298c..1320aaf28f 100644 > --- a/libavcodec/dca_xll.c > +++

[FFmpeg-devel] [PATCH] avcodec/dca: add support for 20-bit XLL

2017-01-07 Thread foo86
Fixes ticket #6063. --- libavcodec/dca_xll.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/dca_xll.c b/libavcodec/dca_xll.c index 1d616c298c..1320aaf28f 100644 --- a/libavcodec/dca_xll.c +++ b/libavcodec/dca_xll.c @@ -143,7 +143,7 @@ static int

Re: [FFmpeg-devel] [PATCH 1/9] avutil: add FF_RETURN_ON_OVERFLOW

2017-01-07 Thread Rodger Combs
> On Jan 7, 2017, at 02:36, Paul B Mahol wrote: > > On 1/7/17, Michael Niedermayer > wrote: >> On Fri, Jan 06, 2017 at 09:11:10PM -0300, James Almer wrote: >>> On 1/6/2017 4:46 PM, Andreas Cadhalpun wrote:

Re: [FFmpeg-devel] [PATCH 4/9] genh: prevent overflow during block alignment calculation

2017-01-07 Thread Paul B Mahol
On 1/7/17, Michael Niedermayer wrote: > On Fri, Jan 06, 2017 at 08:48:02PM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/genh.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git

Re: [FFmpeg-devel] [PATCH 1/9] avutil: add FF_RETURN_ON_OVERFLOW

2017-01-07 Thread Paul B Mahol
On 1/7/17, Michael Niedermayer wrote: > On Fri, Jan 06, 2017 at 09:11:10PM -0300, James Almer wrote: >> On 1/6/2017 4:46 PM, Andreas Cadhalpun wrote: >> > Suggested-by: Rodger Combs >> > Signed-off-by: Andreas Cadhalpun

Re: [FFmpeg-devel] [PATCH 3/9] electronicarts: prevent overflow during block alignment calculation

2017-01-07 Thread Paul B Mahol
On 1/7/17, Michael Niedermayer wrote: > On Fri, Jan 06, 2017 at 08:47:39PM +0100, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/electronicarts.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff