[FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

Signed-off-by: Daniel Kucera --- libavformat/avio.c| 2 +- libavformat/aviobuf.c | 20 libavformat/cache.c | 4 ++-- libavformat/file.c| 2 ++ libavformat/subfile.c | 2 +- libavformat/wtvdec.c | 4 ++-- 6 files changed, 20 insertions(+), 14 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

> -// Offset the DTS by ctts[0] to make the PTS of the first frame 0 > -if (ctts_data_old && ctts_count_old > 0) { > -edit_list_dts_entry_end -= ctts_data_old[0].duration; > -av_log(mov->fc, AV_LOG_DEBUG, "Offset DTS by ctts[%d].duration: %d\n", 0, ctts_data_old[0].duration)

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/utils: Fix several integer overflows.

On 6/3/2017 9:55 PM, Michael Niedermayer wrote: > On Sat, Jun 03, 2017 at 09:47:32PM -0300, James Almer wrote: >> On 6/3/2017 9:25 PM, Michael Niedermayer wrote: >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavcodec/utils.c | 7 +++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --g

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/utils: Fix several integer overflows.

On Sat, Jun 03, 2017 at 09:47:32PM -0300, James Almer wrote: > On 6/3/2017 9:25 PM, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/utils.c | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > > i

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/utils: Fix several integer overflows.

On 6/3/2017 9:25 PM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/utils.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index cde5849a41..feee7556ac 100644 > --- a/libavcodec/utils.c > +++ b/libavco

[FFmpeg-devel] [PATCH 3/3] avformat/utils: Slightly un-clutter code in determinable_frame_size() by using a switch

Signed-off-by: Michael Niedermayer --- libavformat/utils.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index c5f1eac185..bbc7a7b547 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -894,12 +894,13 @@ int ff

[FFmpeg-devel] [PATCH 1/3] avcodec/utils: Avoid hardcoding duplicated types in sizeof()

Signed-off-by: Michael Niedermayer --- libavcodec/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 1336e921c9..cde5849a41 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -655,7 +655,7 @@ int attribute_align_a

[FFmpeg-devel] [PATCH 2/3] avcodec/utils: Fix several integer overflows.

Signed-off-by: Michael Niedermayer --- libavcodec/utils.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index cde5849a41..feee7556ac 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -2278,6 +2278,9 @@ void avcodec_parameters_free(AVC

[FFmpeg-devel] [PATCH 2/2] avformat/options: Simplify loglevel initialization in io_open_default()

Signed-off-by: Michael Niedermayer --- libavformat/options.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavformat/options.c b/libavformat/options.c index d6d589a0b0..16e3886e4b 100644 --- a/libavformat/options.c +++ b/libavformat/options.c @@ -102,14 +102,11 @@ s

[FFmpeg-devel] [PATCH 1/2] avformat/options: Remove one special case in io_open_default()

This simplifies the code and reduces clutter. Signed-off-by: Michael Niedermayer --- libavformat/options.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/options.c b/libavformat/options.c index 9371c72667..d6d589a0b0 100644 --- a/libavformat/options.c +++ b/lib

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mlpdec: Check quant_step_size against huff_lsbs

On Mon, May 22, 2017 at 05:36:10PM +0200, Michael Niedermayer wrote: > On Sun, May 21, 2017 at 01:42:18PM +0200, wm4 wrote: > > On Sat, 20 May 2017 23:01:04 +0200 > > Michael Niedermayer wrote: > > > > > This reorders the operations so as to avoid computations with the above > > > arguments > >

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

On 6/3/2017 6:11 PM, Daniel Kučera wrote: > 2017-06-03 23:04 GMT+02:00 James Almer : >> On 6/3/2017 5:31 PM, Daniel Kučera wrote: >>> 2017-06-03 21:54 GMT+02:00 Michael Niedermayer : On Sat, Jun 03, 2017 at 10:16:59AM +0200, Daniel Kucera wrote: > Signed-off-by: Daniel Kucera > --- >>

Re: [FFmpeg-devel] [PATCH] avformat/options: log filename on open

On Fri, Jun 02, 2017 at 03:45:58PM +0200, wm4 wrote: > On Fri, 2 Jun 2017 15:05:27 +0200 > Michael Niedermayer wrote: > > > The loglevel is choosen so that the main filename and any images of > > multi image sequences are shown only at debug level to avoid > > clutter. > > > > This makes exploi

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: add a custom read_packet function

On 6/3/2017 5:16 PM, Michael Niedermayer wrote: > On Sat, Jun 03, 2017 at 12:33:33AM -0300, James Almer wrote: >> Atempt to read and propagate only full ADTS frames and not other data, >> like id3v1 or APETags at the end of the file. >> >> Fixes ticket #6439. >> >> Signed-off-by: James Almer >> --

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-03 23:04 GMT+02:00 James Almer : > On 6/3/2017 5:31 PM, Daniel Kučera wrote: >> 2017-06-03 21:54 GMT+02:00 Michael Niedermayer : >>> On Sat, Jun 03, 2017 at 10:16:59AM +0200, Daniel Kucera wrote: Signed-off-by: Daniel Kucera --- libavformat/avio.c| 2 +- libavform

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

On 6/3/2017 5:31 PM, Daniel Kučera wrote: > 2017-06-03 21:54 GMT+02:00 Michael Niedermayer : >> On Sat, Jun 03, 2017 at 10:16:59AM +0200, Daniel Kucera wrote: >>> Signed-off-by: Daniel Kucera >>> --- >>> libavformat/avio.c| 2 +- >>> libavformat/aviobuf.c | 18 ++ >>> libavfo

[FFmpeg-devel] [PATCH] avfilter/af_surround: add support for some upmixing of 3.0 channel layout

Signed-off-by: Paul B Mahol --- doc/filters.texi | 8 +- libavfilter/af_surround.c | 283 -- 2 files changed, 231 insertions(+), 60 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index d4fbb5a..65eef89 100644 --- a/doc/filters

[FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

Signed-off-by: Daniel Kucera --- libavformat/avio.c| 2 +- libavformat/aviobuf.c | 20 libavformat/cache.c | 2 +- libavformat/file.c| 2 ++ libavformat/subfile.c | 2 +- libavformat/wtvdec.c | 4 ++-- 6 files changed, 19 insertions(+), 13 deletions(-) diff -

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-03 21:54 GMT+02:00 Michael Niedermayer : > On Sat, Jun 03, 2017 at 10:16:59AM +0200, Daniel Kucera wrote: >> Signed-off-by: Daniel Kucera >> --- >> libavformat/avio.c| 2 +- >> libavformat/aviobuf.c | 18 ++ >> libavformat/cache.c | 2 +- >> libavformat/file.c|

Re: [FFmpeg-devel] [PATCH] libavfilter/scale2ref: Fix out-of-bounds array access

On Sat, Jun 03, 2017 at 05:04:19AM -0400, Kevin Mark wrote: > ff_scale_eval_dimensions blindly assumes that two inputs are always > available as of 3385989b98be7940044e4f0a6b431a0a00abf2fa. This is > notably not the case when the function is called for the scale > filter. With the scale filter inpu

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: add a custom read_packet function

On Sat, Jun 03, 2017 at 12:33:33AM -0300, James Almer wrote: > Atempt to read and propagate only full ADTS frames and not other data, > like id3v1 or APETags at the end of the file. > > Fixes ticket #6439. > > Signed-off-by: James Almer > --- > libavformat/aacdec.c | 42

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

On Sat, Jun 03, 2017 at 10:16:59AM +0200, Daniel Kucera wrote: > Signed-off-by: Daniel Kucera > --- > libavformat/avio.c| 2 +- > libavformat/aviobuf.c | 18 ++ > libavformat/cache.c | 2 +- > libavformat/file.c| 2 ++ > libavformat/subfile.c | 2 +- > libavformat/wt

Re: [FFmpeg-devel] libavformat: deprecated AVStream member suggests usage of private field

On Sat, 3 Jun 2017 21:15:01 +0200 "Tom M." wrote: > This is pretty confusing. Those "All fields below this line are not part of > the public API." comments are completely ignored by doxygen. And this is > where most people look at, I doubt they parse the raw header files > themselves. Wouldnt it

Re: [FFmpeg-devel] libavformat: deprecated AVStream member suggests usage of private field

On Sat, Jun 3, 2017 at 9:15 PM, Tom M. wrote: > This is pretty confusing. Those "All fields below this line are not part of > the public API." comments are completely ignored by doxygen. And this is > where most people look at, I doubt they parse the raw header files > themselves. Wouldnt it be po

[FFmpeg-devel] [PATCH] avformat/hls: Check local file extensions

This reduces the attack surface of local file-system information leaking. It prevents the existing exploit leading to an information leak. As well as similar hypothetical attacks. Leaks of information from files and symlinks ending in common multimedia extensions are still possible. But files wi

Re: [FFmpeg-devel] libavformat: deprecated AVStream member suggests usage of private field

This is pretty confusing. Those "All fields below this line are not part of the public API." comments are completely ignored by doxygen. And this is where most people look at, I doubt they parse the raw header files themselves. Wouldnt it be possible to move these private fields into the internal s

Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskaenc: also write chapters when output is WebM

On 6/2/2017 12:11 AM, James Zern wrote: > On Thu, Jun 1, 2017 at 7:51 PM, James Almer wrote: >> WebM supports a subset of elements from the Chapters master. >> See https://www.webmproject.org/docs/container/#chapters >> >> Addresses ticket #6425 >> >> Signed-off-by: James Almer >> --- >> libavfo

Re: [FFmpeg-devel] libavformat: deprecated AVStream member suggests usage of private field

On Sat, Jun 3, 2017 at 6:51 PM, Tom M. wrote: > I noticed that > > AVCodecContext *codec; > > within AVStream > has been > marked deprecated and suggests the usage of > > AVCodecParameters *codecpar; > > However, due to avformat.h:100

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

On Sat, Jun 03, 2017 at 10:16:59AM +0200, Daniel Kucera wrote: > Signed-off-by: Daniel Kucera > --- > libavformat/avio.c| 2 +- > libavformat/aviobuf.c | 18 ++ > libavformat/cache.c | 2 +- > libavformat/file.c| 2 ++ > libavformat/subfile.c | 2 +- > libavformat/wt

Re: [FFmpeg-devel] [PATCH] compat: LoadLibrary isn't available on UWP/WinRT

On 6/2/2017 7:11 AM, wm4 wrote: On Fri, 2 Jun 2017 15:29:07 +0200 Hugo Beauzée-Luyssen wrote: --- compat/w32dlfcn.h | 4 1 file changed, 4 insertions(+) diff --git a/compat/w32dlfcn.h b/compat/w32dlfcn.h index bc9bb8c9f5..308763be53 100644 --- a/compat/w32dlfcn.h +++ b/compat/w32dlfc

Re: [FFmpeg-devel] [PATCH] avformat/mov: add support for reading VP Codec Configuration Box

On 5/27/2017 7:00 PM, James Almer wrote: > As defined in "VP Codec ISO Media File Format Binding v1.0" > https://github.com/webmproject/vp9-dash/blob/master/VPCodecISOMediaFileFormatBinding.md > > Signed-off-by: James Almer > --- > libavformat/mov.c | 45 +

Re: [FFmpeg-devel] [PATCH] avformat/oggenc: add ogg_init() and ogg_free()

On 5/28/2017 5:09 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/oggenc.c | 32 > 1 file changed, 28 insertions(+), 4 deletions(-) > Ping for this and the aiff one. I have a set of about 50 patches to do the same with almost every other

Re: [FFmpeg-devel] [PATCH 1/6] initial alignment corrections for xmm registers

On Sat, Jun 03, 2017 at 02:18:04AM +0200, James Darnley wrote: > --- > libavcodec/x86/simple_idct.asm | 47 > ++ > 1 file changed, 34 insertions(+), 13 deletions(-) should be ok minor cosmetic misalignment below: [...] > @@ -582,7 +603,7 @@ SECTION .tex

Re: [FFmpeg-devel] [PATCH 2/2] avformat/utils: change bitrate to int64_t in av_find_best_stream

On Fri, Jun 02, 2017 at 11:10:14PM +0200, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavformat/utils.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index b544b6f9c5..aa2a00552e 100644 > --- a/libavfo

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: return impaired streams in av_find_best_stream if only those exist

On Fri, Jun 02, 2017 at 11:10:13PM +0200, Marton Balint wrote: > Fixes ticket #6397. > > Signed-off-by: Marton Balint > --- > libavformat/utils.c | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) LGTM can you add a fate test for this ? thx [...] -- Michael GnuPG

[FFmpeg-devel] [PATCH] avcodec/aacps: move checks for valid length outside the stereo_interpolate dsp function

Signed-off-by: James Almer --- libavcodec/aacps.c | 7 --- libavcodec/x86/aacpsdsp.asm | 6 -- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/libavcodec/aacps.c b/libavcodec/aacps.c index 29de8a5ea7..473da7bd43 100644 --- a/libavcodec/aacps.c +++ b/libavcodec/aacp

[FFmpeg-devel] libavformat: deprecated AVStream member suggests usage of private field

I noticed that AVCodecContext *codec; within AVStream has been marked deprecated and suggests the usage of AVCodecParameters *codecpar; However, due to avformat.h:1001

[FFmpeg-devel] [PATCH] libavformat/mov.c Fixed 'Error while filtering: Operation not permitted' when using -stream_loop, a short file with negativ timestamps and only one keyframe Fixes Ticket #6139

--- libavformat/mov.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 3845e63b53..afc2efe063 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -6547,9 +6547,9 @@ static int mov_seek_stream(AVFormatContext *s, AVStream

Re: [FFmpeg-devel] [PATCH] avfilter/af_sofalizer: switch to libmysofa

On 6/3/17, wm4 wrote: > On Sat, 3 Jun 2017 14:42:59 +0200 > Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol >> --- > > And libmysofa can't be NIH'ed? Why? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/f

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

On Saturday 2017-06-03 14:27, Timo Rothenpieler wrote: > > It is made sure that the public ABI does not break between major releases, > this > the major version is not bumped. > The problem in practice is that _a lot_ of downstream library users misuse the > API, using non-public fields and what

Re: [FFmpeg-devel] [PATCH] avformat/hls: Check file extensions

On Sat, Jun 3, 2017 at 2:58 PM, Michael Niedermayer wrote: > On Sat, Jun 03, 2017 at 11:18:46AM +0200, Hendrik Leppkes wrote: >> On Sat, Jun 3, 2017 at 2:31 AM, Michael Niedermayer >> wrote: >> > On Fri, Jun 02, 2017 at 09:27:16PM +0200, Hendrik Leppkes wrote: >> >> On Fri, Jun 2, 2017 at 9:19 PM

Re: [FFmpeg-devel] [PATCH] avformat/hls: Check file extensions

On Sat, 3 Jun 2017 14:58:19 +0200 Michael Niedermayer wrote: > Do you object to fixing this security issue that has a working exploit? > Can you provide a testcase the fix breaks ? So i can look into what > can be done about it ? (multiple testcases would be even better so > theres a lower chanc

[FFmpeg-devel] [PATCH] avformat/hls: Check file extensions

This reduces the attack surface of local file-system and local network information leaking. It prevents the existing exploit leading to an information leak. As well as similar hypothetical attacks. Leaks of information from files and symlinks ending in common multimedia extensions are still poss

Re: [FFmpeg-devel] [PATCH] avformat/hls: Check file extensions

On Sat, Jun 03, 2017 at 11:18:46AM +0200, Hendrik Leppkes wrote: > On Sat, Jun 3, 2017 at 2:31 AM, Michael Niedermayer > wrote: > > On Fri, Jun 02, 2017 at 09:27:16PM +0200, Hendrik Leppkes wrote: > >> On Fri, Jun 2, 2017 at 9:19 PM, Michael Niedermayer > >> wrote: > >> > This reduces the attack

Re: [FFmpeg-devel] [PATCH] avfilter/af_sofalizer: switch to libmysofa

On Sat, 3 Jun 2017 14:42:59 +0200 Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- And libmysofa can't be NIH'ed? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avfilter/af_sofalizer: switch to libmysofa

Signed-off-by: Paul B Mahol --- configure | 8 +- doc/filters.texi | 2 +- libavfilter/af_sofalizer.c | 700 - 3 files changed, 194 insertions(+), 516 deletions(-) diff --git a/configure b/configure index 72060ef..6ae838f

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

On Fri, 2 Jun 2017 18:17:22 -0700 Sasi Inguva wrote: > Fixes t/6421 > > Signed-off-by: Sasi Inguva > --- > libavformat/mov.c| 57 -- > tests/ref/fate/h264-twofields-packet | 60 > ++-- > 2 files changed, 70 i

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

On Sat, 3 Jun 2017 14:31:31 +0200 (CEST) Jan Engelhardt wrote: > On Saturday 2017-06-03 14:27, Timo Rothenpieler wrote: > > > >> could ffmpeg then ensure that the major is in fact bumped on major > >> releases? In distro context, a bump is easier to swallow than a > >> non-bump.. > > > > It i

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

On Saturday 2017-06-03 14:27, Timo Rothenpieler wrote: > >> could ffmpeg then ensure that the major is in fact bumped on major >> releases? In distro context, a bump is easier to swallow than a >> non-bump.. > > It is made sure that the public ABI does not break between major > releases, this the

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

On Sat, 3 Jun 2017 14:19:25 +0200 (CEST) Jan Engelhardt wrote: > >Anyway, in general, I recommend not pretending that FFmpeg has ABI > >compatibility. Especially not across major releases > > That would be fine with me - could ffmpeg then ensure that the > major is in fact bumped on major rele

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

Am 03.06.2017 um 14:19 schrieb Jan Engelhardt: On Saturday 2017-06-03 14:11, wm4 wrote: The layout of struct AVCodec changed. Four function pointers were inserted in the middle, shifting void (*flush) to a new address. The size of AVCodec also changed, which would have required a full MAJOR bu

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

On Saturday 2017-06-03 14:11, wm4 wrote: >> >> The layout of struct AVCodec changed. Four function pointers were >> inserted in the middle, shifting void (*flush) to a new address. The >> size of AVCodec also changed, which would have required a full MAJOR >> bump. > >Those aren't even public

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

On Sat, Jun 3, 2017 at 2:07 PM, Jan Engelhardt wrote: > > On Saturday 2017-06-03 14:02, Hendrik Leppkes wrote: > >>On Sat, Jun 3, 2017 at 1:58 PM, Jan Engelhardt wrote: >>> >>> On Saturday 2017-06-03 13:34, Hendrik Leppkes wrote: > > Fixing the .v file with a patch now won't help remedy t

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

Size changes are breakers in both directions. The size of the structs are not part of the public API/ABI. Only the location of public fields in them is. You claim your ABI is stable in one direction, which means that a program built with 3.0 headers should work with a 3.3 library on a separate

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

On Sat, Jun 3, 2017 at 2:07 PM, Jan Engelhardt wrote: > > On Saturday 2017-06-03 13:34, Hendrik Leppkes wrote: >>On Sat, Jun 3, 2017 at 1:18 PM, Jan Engelhardt wrote: >>> >>>The layout of struct AVCodec changed. Four function pointers were >>>inserted in the middle, shifting void (*flush) to a ne

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

On Sat, 3 Jun 2017 14:07:30 +0200 (CEST) Jan Engelhardt wrote: > On Saturday 2017-06-03 13:34, Hendrik Leppkes wrote: > >On Sat, Jun 3, 2017 at 1:18 PM, Jan Engelhardt wrote: > >> > >>The layout of struct AVCodec changed. Four function pointers were > >>inserted in the middle, shifting void (*

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

On Sat, 3 Jun 2017 13:18:30 +0200 (CEST) Jan Engelhardt wrote: > > The layout of struct AVCodec changed. Four function pointers were > inserted in the middle, shifting void (*flush) to a new address. The > size of AVCodec also changed, which would have required a full MAJOR > bump. Those are

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

On Saturday 2017-06-03 13:34, Hendrik Leppkes wrote: >On Sat, Jun 3, 2017 at 1:18 PM, Jan Engelhardt wrote: >> >>The layout of struct AVCodec changed. Four function pointers were >>inserted in the middle, shifting void (*flush) to a new address. >>The size of AVCodec also changed, which would hav

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

On Saturday 2017-06-03 14:02, Hendrik Leppkes wrote: >On Sat, Jun 3, 2017 at 1:58 PM, Jan Engelhardt wrote: >> >> On Saturday 2017-06-03 13:34, Hendrik Leppkes wrote: Fixing the .v file with a patch now won't help remedy the situation on existing systems; however, on future patch

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

On Sat, Jun 3, 2017 at 1:58 PM, Jan Engelhardt wrote: > > On Saturday 2017-06-03 13:34, Hendrik Leppkes wrote: >>> >>> Fixing the .v file with a patch now won't help remedy the situation on >>> existing systems; however, on future patch submissions, this action of >>> editing the .v file needs to

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

On Saturday 2017-06-03 13:34, Hendrik Leppkes wrote: >> >> Fixing the .v file with a patch now won't help remedy the situation on >> existing systems; however, on future patch submissions, this action of >> editing the .v file needs to be remembered when functions are >> added or removed. > >We ha

Re: [FFmpeg-devel] Backport HLS Cookie Authentication Fixes to 3.3

On 2017-06-01 09:04 PM, Michael Niedermayer wrote: On Tue, May 30, 2017 at 09:29:53PM -0400, Micah Galizia wrote: Hello, I'd like to backport the HLS cookie authentication fixes to 3.3 so that Kodi 18 picks them up. Originally, this was a three patch set but the first fix (to av_small_strpti

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

On Sat, Jun 3, 2017 at 1:18 PM, Jan Engelhardt wrote: > > I received a user report about ABI breakage between ffmpeg 3.0 and 3.3 > through the distribution commenting system > https://build.opensuse.org/package/show/multimedia:libs/ffmpeg : > > """I'm having a library compiled against ffmp

[FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

I received a user report about ABI breakage between ffmpeg 3.0 and 3.3 through the distribution commenting system https://build.opensuse.org/package/show/multimedia:libs/ffmpeg : """I'm having a library compiled against ffmpeg 3.3 on OBS. It uses the avcodec_{send|receive}packe

[FFmpeg-devel] [PATCH] web - src/contact - added link to SuperUser forum

The support forum at http://ffmpeg.gusari.org/index.php which is linked to at http://www.ffmpeg.org/contact.html#Forums now sports a banner announcing its likely closure. The banner redirects visitors to Stack Exchange which already receives most ffmpeg support queries. The patch below adds a

[FFmpeg-devel] [PATCH] libavfilter/scale2ref: Fix out-of-bounds array access

ff_scale_eval_dimensions blindly assumes that two inputs are always available as of 3385989b98be7940044e4f0a6b431a0a00abf2fa. This is notably not the case when the function is called for the scale filter. With the scale filter inputs[1] does not exist. ff_scale_eval_dimensions now has an updated s

Re: [FFmpeg-devel] [PATCH] libavfilter/scale2ref: Add constants for the primary input

On Fri, Jun 2, 2017 at 9:37 PM, Kevin Mark wrote: > On Fri, Jun 2, 2017 at 9:16 PM, James Almer wrote: >> This broke 820 tests with Valgrind. Patch has been submitted. Thanks again for the report! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org h

Re: [FFmpeg-devel] [PATCH] avformat/hls: Check file extensions

On Sat, Jun 3, 2017 at 2:31 AM, Michael Niedermayer wrote: > On Fri, Jun 02, 2017 at 09:27:16PM +0200, Hendrik Leppkes wrote: >> On Fri, Jun 2, 2017 at 9:19 PM, Michael Niedermayer >> wrote: >> > This reduces the attack surface of local file-system and local network >> > information leaking. >> >

[FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

Signed-off-by: Daniel Kucera --- libavformat/avio.c| 2 +- libavformat/aviobuf.c | 18 ++ libavformat/cache.c | 2 +- libavformat/file.c| 2 ++ libavformat/subfile.c | 2 +- libavformat/wtvdec.c | 4 ++-- 6 files changed, 17 insertions(+), 13 deletions(-) diff --g

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-03 8:58 GMT+02:00 Daniel Kučera : >> >> breaks: >> ffmpeg -i subfile,,start,1,end,40,,:matrixbench_mpeg2.mpg >> subfile.avi >> >> (infnite loop) >> >> > > Where can I get that matrixbench_mpeg2.mpg test file? If I run it > against fate-suite/mpeg2/matrixbench_mpeg2.lq1.mpg it work