Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Nicolas George
L'octidi 18 brumaire, an CCXXVI, James Almer a écrit : > Probably a good idea. > > Maybe just add the gamma value as a frame AVDictionary metadata entry? > If the idea is that the API user can get a single value from the PNG > image in some form, wouldn't side data and a dict metadata entry work

Re: [FFmpeg-devel] [PATCH 0/6] avcodec: Vorbis encoder improvements

2017-11-08 Thread Rostislav Pehlivanov
On 22 August 2017 at 02:23, Tyler Jones wrote: > Please see the following patches. > > The first two patches are identical to my latest pending changes sent to > the > mailing list on July 28. Changelogs are included regardless. The clipping > avoidance patch should remove

[FFmpeg-devel] [PATCH] avcodec/mips: cleanup unused macros

2017-11-08 Thread kaustubh.raste
From: Kaustubh Raste Signed-off-by: Kaustubh Raste --- libavcodec/mips/hevc_macros_msa.h | 37 - 1 file changed, 37 deletions(-) diff --git a/libavcodec/mips/hevc_macros_msa.h

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: make some function static

2017-11-08 Thread Aaron Levinson
On 11/8/2017 7:20 PM, James Almer wrote: Should fix ticket #6822 Signed-off-by: James Almer --- libavdevice/decklink_dec.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-11-08 Thread Rostislav Pehlivanov
On 18 October 2017 at 11:05, pkv.stream wrote: > Le 02/10/2017 à 8:39 PM, Rostislav Pehlivanov a écrit : > >> On 2 October 2017 at 18:43, pkv.stream wrote: >> >> Le 02/10/2017 à 7:23 PM, Michael Niedermayer a écrit : >>> >>> On Mon, Oct 02, 2017 at

[FFmpeg-devel] [PATCH] avdevice/decklink_dec: make some function static

2017-11-08 Thread James Almer
Should fix ticket #6822 Signed-off-by: James Almer --- libavdevice/decklink_dec.cpp | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index 191547ff10..e90b42811a 100644 ---

Re: [FFmpeg-devel] [PATCH v5] pngdec: expose gAMA and cHRM chunks as side/meta data

2017-11-08 Thread Rostislav Pehlivanov
On 9 November 2017 at 02:44, James Almer wrote: > On 11/8/2017 11:32 PM, Rostislav Pehlivanov wrote: > > Signed-off-by: Rostislav Pehlivanov > > --- > > libavcodec/pngdec.c | 39 ++- > > 1 file changed, 38

Re: [FFmpeg-devel] [PATCH v5] pngdec: expose gAMA and cHRM chunks as side/meta data

2017-11-08 Thread James Almer
On 11/8/2017 11:32 PM, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > libavcodec/pngdec.c | 39 ++- > 1 file changed, 38 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c >

Re: [FFmpeg-devel] [PATCH] avutil/frame: Add private_ref to AVFrame

2017-11-08 Thread Michael Niedermayer
On Wed, Nov 08, 2017 at 11:05:48PM +, Rostislav Pehlivanov wrote: > On 8 November 2017 at 22:55, Michael Niedermayer > wrote: > > > This gives FFmpeg libs a field that they can freely and safely use. > > Avoiding the need of wraping of a users opaque_ref field and its

[FFmpeg-devel] [PATCH v5] pngdec: expose gAMA and cHRM chunks as side/meta data

2017-11-08 Thread Rostislav Pehlivanov
Signed-off-by: Rostislav Pehlivanov --- libavcodec/pngdec.c | 39 ++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 0d6612ccca..0a9a248ee7 100644 --- a/libavcodec/pngdec.c +++

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-08 Thread Michael Niedermayer
On Wed, Nov 08, 2017 at 11:41:16PM +0100, Aurelien Jacobs wrote: > On Wed, Nov 08, 2017 at 06:26:03PM +0100, Michael Niedermayer wrote: > > On Wed, Nov 08, 2017 at 02:06:09PM +0100, Aurelien Jacobs wrote: > > [...] > > > +typedef const struct { > > > +const int32_t *quantize_intervals; > > > +

Re: [FFmpeg-devel] [PATCH v4] pngdec: expose gAMA and cHRM chunks as side/meta data

2017-11-08 Thread James Almer
On 11/8/2017 9:25 PM, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > libavcodec/pngdec.c | 30 +- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c > index

Re: [FFmpeg-devel] [PATCH] example/vaapi_transcode: Add a VA-VAPI transcode example.

2017-11-08 Thread Jun Zhao
On 2017/11/2 9:49, Jun Zhao wrote: Ping, any comments? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-08 Thread Rostislav Pehlivanov
On 8 November 2017 at 22:41, Aurelien Jacobs wrote: > On Wed, Nov 08, 2017 at 06:26:03PM +0100, Michael Niedermayer wrote: > > On Wed, Nov 08, 2017 at 02:06:09PM +0100, Aurelien Jacobs wrote: > > [...] > > > +typedef const struct { > > > +const int32_t *quantize_intervals;

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread James Almer
On 11/8/2017 9:39 PM, Rostislav Pehlivanov wrote: > On 8 November 2017 at 23:05, Mark Thompson wrote: > >> On 08/11/17 22:41, Rostislav Pehlivanov wrote: >>> On 8 November 2017 at 22:20, Mark Thompson wrote: >>> On 08/11/17 22:03, Rostislav Pehlivanov wrote:

[FFmpeg-devel] [PATCH 2/2] lavc/libx265: switch to ff_alloc_packet2

2017-11-08 Thread Jun Zhao
From 5afdf252b3bb6f8c7a276c2a8bde8f4a95d170e4 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Wed, 8 Nov 2017 21:04:51 +0800 Subject: [PATCH 2/2] lavc/libx265: switch to ff_alloc_packet2 ff_alloc_packet have been deprecated, switch to use ff_alloc_packet2. Signed-off-by: Jun

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Rostislav Pehlivanov
On 8 November 2017 at 23:05, Mark Thompson wrote: > On 08/11/17 22:41, Rostislav Pehlivanov wrote: > > On 8 November 2017 at 22:20, Mark Thompson wrote: > > > >> On 08/11/17 22:03, Rostislav Pehlivanov wrote: > >>> On 8 November 2017 at 21:49, Mark Thompson

[FFmpeg-devel] [PATCH 1/2] lavc/libkvazaar: switch to ff_alloc_packet2

2017-11-08 Thread Jun Zhao
From 190d3cf31345e9a94169278ffe0c195868a6d400 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Wed, 8 Nov 2017 21:02:23 +0800 Subject: [PATCH 1/2] lavc/libkvazaar: switch to ff_alloc_packet2. ff_alloc_packet have been deprecated, switch to use the ff_alloc_packet2.

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Rostislav Pehlivanov
On 8 November 2017 at 23:09, James Almer wrote: > On 11/8/2017 7:41 PM, Rostislav Pehlivanov wrote: > > On 8 November 2017 at 22:20, Mark Thompson wrote: > > > >> On 08/11/17 22:03, Rostislav Pehlivanov wrote: > >>> On 8 November 2017 at 21:49, Mark Thompson

[FFmpeg-devel] [PATCH v4] pngdec: expose gAMA and cHRM chunks as side/meta data

2017-11-08 Thread Rostislav Pehlivanov
Signed-off-by: Rostislav Pehlivanov --- libavcodec/pngdec.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 0d6612ccca..aef0d95819 100644 --- a/libavcodec/pngdec.c +++

[FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

2017-11-08 Thread Sasi Inguva
Partially fixes t/6699. --- libavformat/mov.c | 32 --- tests/fate/mov.mak| 4 tests/ref/fate/mov-elst-ends-betn-b-and-i | 31 ++ 3 files changed, 56 insertions(+), 11 deletions(-)

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

2017-11-08 Thread Sasi Inguva
Updated the fate test after http://git.videolan.org/?p=ffmpeg.git;a=commit;h=c2a8f0fcbe57ea9ccaa864130f078af10516c3c1 . Sending the updated patch. On Thu, Nov 2, 2017 at 4:23 PM, Michael Niedermayer wrote: > On Wed, Nov 01, 2017 at 02:27:50PM -0700, Sasi Inguva wrote: >

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Rostislav Pehlivanov
On 6 November 2017 at 17:38, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > doc/APIchanges | 3 +++ > libavutil/frame.h | 6 ++ > libavutil/version.h | 2 +- > 3 files changed, 10 insertions(+), 1 deletion(-) > >

[FFmpeg-devel] [PATCH] avformat/dashdec: fix memleak of rep_dest->parent null

2017-11-08 Thread Steven Liu
fix ticket id: #6820 use the current DASHContext for the rep_dest Signed-off-by: Steven Liu --- libavformat/dashdec.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index

Re: [FFmpeg-devel] [PATCH 3/9] lavc/vaapi_decode: fix uninitialized use of variables

2017-11-08 Thread Mark Thompson
On 08/11/17 18:17, Timo Rothenpieler wrote: > Fixes CID #1419524 and #1412855 > --- > libavcodec/vaapi_decode.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c > index 27ef33837c..a782cfd8da 100644 > ---

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread James Almer
On 11/8/2017 8:05 PM, Mark Thompson wrote: > On 08/11/17 22:41, Rostislav Pehlivanov wrote: >> On 8 November 2017 at 22:20, Mark Thompson wrote: >> >>> On 08/11/17 22:03, Rostislav Pehlivanov wrote: On 8 November 2017 at 21:49, Mark Thompson wrote: >

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Mark Thompson
On 08/11/17 22:41, Rostislav Pehlivanov wrote: > On 8 November 2017 at 22:20, Mark Thompson wrote: > >> On 08/11/17 22:03, Rostislav Pehlivanov wrote: >>> On 8 November 2017 at 21:49, Mark Thompson wrote: >>> On 08/11/17 21:26, Rostislav Pehlivanov wrote:

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread James Almer
On 11/8/2017 7:41 PM, Rostislav Pehlivanov wrote: > On 8 November 2017 at 22:20, Mark Thompson wrote: > >> On 08/11/17 22:03, Rostislav Pehlivanov wrote: >>> On 8 November 2017 at 21:49, Mark Thompson wrote: >>> On 08/11/17 21:26, Rostislav Pehlivanov wrote:

Re: [FFmpeg-devel] [PATCH] avutil/frame: Add private_ref to AVFrame

2017-11-08 Thread Rostislav Pehlivanov
On 8 November 2017 at 22:55, Michael Niedermayer wrote: > This gives FFmpeg libs a field that they can freely and safely use. > Avoiding the need of wraping of a users opaque_ref field and its issues. > > Signed-off-by: Michael Niedermayer > --- >

[FFmpeg-devel] [PATCH] avutil/frame: Add private_ref to AVFrame

2017-11-08 Thread Michael Niedermayer
This gives FFmpeg libs a field that they can freely and safely use. Avoiding the need of wraping of a users opaque_ref field and its issues. Signed-off-by: Michael Niedermayer --- libavutil/frame.c | 8 +++- libavutil/frame.h | 12 2 files changed, 19

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread James Almer
On 11/8/2017 7:15 PM, Nicolas George wrote: > L'octidi 18 brumaire, an CCXXVI, Hendrik Leppkes a écrit : >> Gamma might sound useful of a property to have, but there is no actual >> technical evidence to really support that. As said in an earlier mail, >> we've gone for years without it and no-one

Re: [FFmpeg-devel] [PATCH 2/2] aptx: add raw muxer and demuxer for aptX

2017-11-08 Thread Aurelien Jacobs
On Wed, Nov 08, 2017 at 05:24:34PM +, Rostislav Pehlivanov wrote: > > [...] > > Patch doesn't apply Here is a rebased patch.>From f6d9a7a804bc1c833e7c2e61411ac1b9155cb6ba Mon Sep 17 00:00:00 2001 From: Aurelien Jacobs Date: Thu, 31 Aug 2017 20:42:15 +0200 Subject: [PATCH

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-08 Thread Aurelien Jacobs
On Wed, Nov 08, 2017 at 06:26:03PM +0100, Michael Niedermayer wrote: > On Wed, Nov 08, 2017 at 02:06:09PM +0100, Aurelien Jacobs wrote: > [...] > > +typedef const struct { > > +const int32_t *quantize_intervals; > > +const int32_t *invert_quantize_dither_factors; > > +const int32_t

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Rostislav Pehlivanov
On 8 November 2017 at 22:20, Mark Thompson wrote: > On 08/11/17 22:03, Rostislav Pehlivanov wrote: > > On 8 November 2017 at 21:49, Mark Thompson wrote: > > > >> On 08/11/17 21:26, Rostislav Pehlivanov wrote: > >>> Signed-off-by: Rostislav Pehlivanov

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Mark Thompson
On 08/11/17 22:03, Rostislav Pehlivanov wrote: > On 8 November 2017 at 21:49, Mark Thompson wrote: > >> On 08/11/17 21:26, Rostislav Pehlivanov wrote: >>> Signed-off-by: Rostislav Pehlivanov >>> --- >>> doc/developer.texi | 3 +++ >>> 1 file changed, 3

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Nicolas George
L'octidi 18 brumaire, an CCXXVI, Hendrik Leppkes a écrit : > Gamma might sound useful of a property to have, but there is no actual > technical evidence to really support that. As said in an earlier mail, > we've gone for years without it and no-one missed it, and even now its > only being added

Re: [FFmpeg-devel] Added HW accelerated H.264 and HEVC encoding for AMD

2017-11-08 Thread Mironov, Mikhail
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: November 8, 2017 5:01 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Added HW accelerated H.264 and HEVC >

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Hendrik Leppkes
On Wed, Nov 8, 2017 at 10:30 PM, Nicolas George wrote: > > The question we should be asking is: does it make sense, in general, for > any frame (or any video frame, or...)? For this field, I would argue > that the answer is yes: the gamma value is needed to make a few >

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Rostislav Pehlivanov
On 8 November 2017 at 21:49, Mark Thompson wrote: > On 08/11/17 21:26, Rostislav Pehlivanov wrote: > > Signed-off-by: Rostislav Pehlivanov > > --- > > doc/developer.texi | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/doc/developer.texi

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Carl Eugen Hoyos
2017-11-08 22:49 GMT+01:00 Mark Thompson : > On 08/11/17 21:26, Rostislav Pehlivanov wrote: >> +@item >> +for loops with variable definition (@samp{for (int i = 0; i < 8; i++)}); > Can you comment on what the consequences would be for platform support? A similar-looking issue

Re: [FFmpeg-devel] Added HW accelerated H.264 and HEVC encoding for AMD

2017-11-08 Thread Carl Eugen Hoyos
2017-11-08 19:25 GMT+01:00 mmironov : > Changelog|3 +- > diff --git a/Changelog b/Changelog > index 6592d86..f0d22fa 100644 > --- a/Changelog > +++ b/Changelog > @@ -6,7 +6,8 @@ version : > - Dropped support for OpenJPEG versions 2.0 and below. Using

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Rostislav Pehlivanov
On 8 November 2017 at 21:45, Carl Eugen Hoyos wrote: > 2017-11-08 22:26 GMT+01:00 Rostislav Pehlivanov : > > > +@item > > +for loops with variable definition (@samp{for (int i = 0; i < 8; i++)}); > > Don't you think that this makes the code slightly

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Mark Thompson
On 08/11/17 21:26, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > doc/developer.texi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index a7b4f1d737..de7d887451 100644 > ---

Re: [FFmpeg-devel] [PATCH]lavfi/scale2ref: Set output frame rate to main input frame rate

2017-11-08 Thread Carl Eugen Hoyos
2017-11-08 18:43 GMT+01:00 Michael Niedermayer : > On Wed, Nov 08, 2017 at 09:23:58AM +0100, Carl Eugen Hoyos wrote: >> Hi! >> >> I believe attached patch fixes ticket #6817. >> >> Please comment, Carl Eugen > >> vf_scale.c |1 + >> 1 file changed, 1 insertion(+) >>

[FFmpeg-devel] [PATCH]lavf/dashdec: Fix several memleaks

2017-11-08 Thread Carl Eugen Hoyos
Hi! Attached patch fixes several memleaks found testing ticket #6820 (I cannot reproduce the crash). Please comment, Carl Eugen From 915eae44e2f9bd7fb5ae78aa697338f348db3e08 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 8 Nov 2017 22:44:06 +0100 Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Carl Eugen Hoyos
2017-11-08 22:26 GMT+01:00 Rostislav Pehlivanov : > +@item > +for loops with variable definition (@samp{for (int i = 0; i < 8; i++)}); Don't you think that this makes the code slightly uglier? Carl Eugen ___ ffmpeg-devel mailing

[FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Rostislav Pehlivanov
Signed-off-by: Rostislav Pehlivanov --- doc/developer.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/developer.texi b/doc/developer.texi index a7b4f1d737..de7d887451 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -132,6 +132,9 @@ designated

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Nicolas George
L'octidi 18 brumaire, an CCXXVI, Hendrik Leppkes a écrit : > I don't. We've done a lot of work to remove fields from generic data > structures which are used by single codecs on semi-obscure cases. The > fact alone that after years of avcodec and a PNG decoder this field > wasn't asked for

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Rostislav Pehlivanov
On 8 November 2017 at 20:52, Paul B Mahol wrote: > On 11/8/17, Nicolas George wrote: > > L'octidi 18 brumaire, an CCXXVI, Hendrik Leppkes a ecrit : > >> In the meantime, it does no real harm to add one more sidedata type to > >> the numerous list of types we

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread James Almer
On 11/8/2017 5:52 PM, Paul B Mahol wrote: > On 11/8/17, Nicolas George wrote: >> L'octidi 18 brumaire, an CCXXVI, Hendrik Leppkes a ecrit : >>> In the meantime, it does no real harm to add one more sidedata type to >>> the numerous list of types we already have, and lets people

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Paul B Mahol
On 11/8/17, Nicolas George wrote: > L'octidi 18 brumaire, an CCXXVI, Hendrik Leppkes a ecrit : >> In the meantime, it does no real harm to add one more sidedata type to >> the numerous list of types we already have, and lets people carry on >> with their work. > > It does harm,

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Hendrik Leppkes
On Wed, Nov 8, 2017 at 9:36 PM, Nicolas George wrote: > This is a terrible API, there is no doubt that > people would prefer a single field. > I don't. We've done a lot of work to remove fields from generic data structures which are used by single codecs on semi-obscure cases.

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Nicolas George
L'octidi 18 brumaire, an CCXXVI, Hendrik Leppkes a écrit : > In the meantime, it does no real harm to add one more sidedata type to > the numerous list of types we already have, and lets people carry on > with their work. It does harm, look at the other patch: 5 lines of useless clutter out of 10

Re: [FFmpeg-devel] [PATCH] avcodec/cngdec: Fix integer clipping

2017-11-08 Thread Michael Niedermayer
On Thu, Nov 02, 2017 at 06:34:09PM +0100, Michael Niedermayer wrote: > Fixes: runtime error: value -36211.7 is outside the range of representable > values of type 'short' > Fixes: 2992/clusterfuzz-testcase-6649611793989632 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Hendrik Leppkes
On Wed, Nov 8, 2017 at 8:31 PM, Nicolas George wrote: > L'octidi 18 brumaire, an CCXXVI, Paul B Mahol a écrit : >> Why are you doing this? Your bikesheds do not apply anymore. > > I am "doing this" because I care about the quality and design of the > API, no more. In this

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Paul B Mahol
On 11/8/17, Nicolas George wrote: > L'octidi 18 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> Why are you doing this? Your bikesheds do not apply anymore. > > I am "doing this" because I care about the quality and design of the > API, no more. In this particular instance, the

Re: [FFmpeg-devel] [PATCH 4/9] avfilter/af_haas: validate par_m_source parameter

2017-11-08 Thread Michael Niedermayer
On Wed, Nov 08, 2017 at 07:17:48PM +0100, Timo Rothenpieler wrote: > Fixes CID #1417663 > --- > libavfilter/af_haas.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/af_haas.c b/libavfilter/af_haas.c > index 691c251f54..fac4b6cf2f 100644 > --- a/libavfilter/af_haas.c > +++

Re: [FFmpeg-devel] [PATCH 5/9] avformat/fitsenc: validate input pixel format

2017-11-08 Thread Michael Niedermayer
On Wed, Nov 08, 2017 at 07:17:49PM +0100, Timo Rothenpieler wrote: > Fixes CID #1416961 and #1416962 > --- > libavformat/fitsenc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/fitsenc.c b/libavformat/fitsenc.c > index 7cb171596c..91411f2606 100644 > ---

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Nicolas George
L'octidi 18 brumaire, an CCXXVI, Paul B Mahol a écrit : > Why are you doing this? Your bikesheds do not apply anymore. I am "doing this" because I care about the quality and design of the API, no more. In this particular instance, the side data API is now completely braindead, a huge waste in

Re: [FFmpeg-devel] [PATCH] avfilter: initial macroblock types export and visualization

2017-11-08 Thread Paul B Mahol
On 11/8/17, Michael Niedermayer wrote: > On Wed, Nov 08, 2017 at 12:18:24PM +0100, Paul B Mahol wrote: >> On 11/8/17, Michael Niedermayer wrote: >> > On Thu, Nov 02, 2017 at 12:04:17PM -0400, Ronald S. Bultje wrote: >> >> Hi, >> >> >> >> On Thu,

Re: [FFmpeg-devel] [PATCH 4/9] avfilter/af_haas: validate par_m_source parameter

2017-11-08 Thread Paul B Mahol
On 11/8/17, Timo Rothenpieler wrote: > Fixes CID #1417663 > --- > libavfilter/af_haas.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/af_haas.c b/libavfilter/af_haas.c > index 691c251f54..fac4b6cf2f 100644 > --- a/libavfilter/af_haas.c > +++

Re: [FFmpeg-devel] [PATCH 7/9] avfilter/vf_premultiply: fix memory-leak on failure

2017-11-08 Thread Paul B Mahol
On 11/8/17, Timo Rothenpieler wrote: > Fixes CID #1416352 > --- > libavfilter/vf_premultiply.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_premultiply.c b/libavfilter/vf_premultiply.c > index 1af6433bc9..4b6abc6e73 100644 >

Re: [FFmpeg-devel] [PATCH 5/9] avformat/fitsenc: validate input pixel format

2017-11-08 Thread Paul B Mahol
On 11/8/17, Timo Rothenpieler wrote: > Fixes CID #1416961 and #1416962 > --- > libavformat/fitsenc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/fitsenc.c b/libavformat/fitsenc.c > index 7cb171596c..91411f2606 100644 > --- a/libavformat/fitsenc.c

Re: [FFmpeg-devel] [PATCH 6/9] avfilter/vf_premultiply: make sure plane count is less than 4

2017-11-08 Thread Paul B Mahol
On 11/8/17, Timo Rothenpieler wrote: > Fixes CID #1416350, #1416351, #1416353 and #1416354 > --- > libavfilter/vf_premultiply.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_premultiply.c b/libavfilter/vf_premultiply.c > index

Re: [FFmpeg-devel] [PATCH 8/9] movenc-test: fix potential uninitialized read

2017-11-08 Thread James Almer
On 11/8/2017 3:17 PM, Timo Rothenpieler wrote: > Fixes CID #1413023 > --- > libavformat/tests/movenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/tests/movenc.c b/libavformat/tests/movenc.c > index 8e59b74259..a210aec7ba 100644 > ---

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-11-08 Thread Mironov, Mikhail
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: November 8, 2017 10:15 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD > GPUs based on AMF SDK > > On 06/11/17

[FFmpeg-devel] [PATCH 8/9] movenc-test: fix potential uninitialized read

2017-11-08 Thread Timo Rothenpieler
Fixes CID #1413023 --- libavformat/tests/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/tests/movenc.c b/libavformat/tests/movenc.c index 8e59b74259..a210aec7ba 100644 --- a/libavformat/tests/movenc.c +++ b/libavformat/tests/movenc.c @@ -108,7 +108,7 @@

[FFmpeg-devel] [PATCH 9/9] avfilter/signature_lookup: fix potential uninitialized reads

2017-11-08 Thread Timo Rothenpieler
Fixes CID #1403238 and #1403239 --- libavfilter/signature_lookup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_lookup.c index 272c717c77..7de4a88ca2 100644 --- a/libavfilter/signature_lookup.c +++

[FFmpeg-devel] [PATCH 6/9] avfilter/vf_premultiply: make sure plane count is less than 4

2017-11-08 Thread Timo Rothenpieler
Fixes CID #1416350, #1416351, #1416353 and #1416354 --- libavfilter/vf_premultiply.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_premultiply.c b/libavfilter/vf_premultiply.c index 5120adc476..1af6433bc9 100644 --- a/libavfilter/vf_premultiply.c +++

[FFmpeg-devel] [PATCH 5/9] avformat/fitsenc: validate input pixel format

2017-11-08 Thread Timo Rothenpieler
Fixes CID #1416961 and #1416962 --- libavformat/fitsenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/fitsenc.c b/libavformat/fitsenc.c index 7cb171596c..91411f2606 100644 --- a/libavformat/fitsenc.c +++ b/libavformat/fitsenc.c @@ -106,6 +106,8 @@ static int

[FFmpeg-devel] [PATCH 2/9] avformat/hlsenc: allocate space for terminating null

2017-11-08 Thread Timo Rothenpieler
Fixes CID #1420394 --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 5ea9d216a4..b571772f60 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1455,7 +1455,7 @@ static int

[FFmpeg-devel] [PATCH 7/9] avfilter/vf_premultiply: fix memory-leak on failure

2017-11-08 Thread Timo Rothenpieler
Fixes CID #1416352 --- libavfilter/vf_premultiply.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_premultiply.c b/libavfilter/vf_premultiply.c index 1af6433bc9..4b6abc6e73 100644 --- a/libavfilter/vf_premultiply.c +++ b/libavfilter/vf_premultiply.c @@

[FFmpeg-devel] [PATCH 3/9] lavc/vaapi_decode: fix uninitialized use of variables

2017-11-08 Thread Timo Rothenpieler
Fixes CID #1419524 and #1412855 --- libavcodec/vaapi_decode.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c index 27ef33837c..a782cfd8da 100644 --- a/libavcodec/vaapi_decode.c +++ b/libavcodec/vaapi_decode.c @@

[FFmpeg-devel] [PATCH 4/9] avfilter/af_haas: validate par_m_source parameter

2017-11-08 Thread Timo Rothenpieler
Fixes CID #1417663 --- libavfilter/af_haas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/af_haas.c b/libavfilter/af_haas.c index 691c251f54..fac4b6cf2f 100644 --- a/libavfilter/af_haas.c +++ b/libavfilter/af_haas.c @@ -162,6 +162,7 @@ static int filter_frame(AVFilterLink

[FFmpeg-devel] [PATCH 1/9] lavfi/paletteuse: check get_color return value

2017-11-08 Thread Timo Rothenpieler
Fixes CID #1420396 --- libavfilter/vf_paletteuse.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c index ed80ab04d5..1980907e70 100644 --- a/libavfilter/vf_paletteuse.c +++ b/libavfilter/vf_paletteuse.c @@ -380,8

[FFmpeg-devel] [PATCH 0/9] Fix various issues found by coverity

2017-11-08 Thread Timo Rothenpieler
Timo Rothenpieler (9): lavfi/paletteuse: check get_color return value avformat/hlsenc: allocate space for terminating null lavc/vaapi_decode: fix uninitialized use of variables avfilter/af_haas: validate par_m_source parameter avformat/fitsenc: validate input pixel format

Re: [FFmpeg-devel] [PATCH] avfilter: initial macroblock types export and visualization

2017-11-08 Thread Michael Niedermayer
On Wed, Nov 08, 2017 at 12:18:24PM +0100, Paul B Mahol wrote: > On 11/8/17, Michael Niedermayer wrote: > > On Thu, Nov 02, 2017 at 12:04:17PM -0400, Ronald S. Bultje wrote: > >> Hi, > >> > >> On Thu, Nov 2, 2017 at 7:52 AM, Paul B Mahol wrote: > >> > >>

Re: [FFmpeg-devel] [PATCH]lavfi/scale2ref: Set output frame rate to main input frame rate

2017-11-08 Thread Michael Niedermayer
On Wed, Nov 08, 2017 at 09:23:58AM +0100, Carl Eugen Hoyos wrote: > Hi! > > I believe attached patch fixes ticket #6817. > > Please comment, Carl Eugen > vf_scale.c |1 + > 1 file changed, 1 insertion(+) > cbc17115125ac2e6ada248ec53f973a81bfc762f >

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-08 Thread Rostislav Pehlivanov
On 8 November 2017 at 17:26, Michael Niedermayer wrote: > On Wed, Nov 08, 2017 at 02:06:09PM +0100, Aurelien Jacobs wrote: > [...] > > +typedef const struct { > > +const int32_t *quantize_intervals; > > +const int32_t *invert_quantize_dither_factors; > > +

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-08 Thread Michael Niedermayer
On Wed, Nov 08, 2017 at 02:06:09PM +0100, Aurelien Jacobs wrote: [...] > +typedef const struct { > +const int32_t *quantize_intervals; > +const int32_t *invert_quantize_dither_factors; > +const int32_t *quantize_dither_factors; > +const int32_t *quantize_factor_select_offset;

Re: [FFmpeg-devel] [PATCH 2/2] aptx: add raw muxer and demuxer for aptX

2017-11-08 Thread Rostislav Pehlivanov
On 7 November 2017 at 22:26, Aurelien Jacobs wrote: > --- > doc/general.texi | 1 + > libavformat/Makefile | 2 ++ > libavformat/allformats.c | 1 + > libavformat/aptxdec.c| 58 ++ > ++ > libavformat/rawenc.c |

Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-08 Thread Paul B Mahol
On 11/8/17, Marc-Antoine ARNAUD wrote: > This patch will fix the stride issue. > Is it valid for you ? > > Does it required to merge these 2 patches ? (and remove base64 encoding on > the first one) Please merge those two patches, base64 encoding should not be

Re: [FFmpeg-devel] Added HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-11-08 Thread Mark Thompson
On 06/11/17 22:46, Michael Niedermayer wrote: > ... > In file included from src/libavcodec/amfenc.h:24:0, > from src/libavcodec/amfenc.c:27: > src/compat/amd/amfsdkenc.h:191:23: error: no previous prototype for > ‘AMFConstructRect’ [-Werror=missing-prototypes] > AMF_INLINE

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Paul B Mahol
On 11/8/17, Nicolas George wrote: > L'octidi 18 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> No, no and no. Gamma is not always available and polluting AVFrame is big >> no. > > The same arguments would apply for pict_type, channel_layout, color_*, > crop_*. This is no

Re: [FFmpeg-devel] [PATCH] avfilter: slice processing for geq

2017-11-08 Thread Marc-Antoine ARNAUD
This patch will fix the stride issue. Is it valid for you ? Does it required to merge these 2 patches ? (and remove base64 encoding on the first one) Thx Marc-Antoine Le ven. 3 nov. 2017 à 03:13, Michael Niedermayer a écrit : > On Thu, Nov 02, 2017 at 02:04:33PM +,

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Nicolas George
L'octidi 18 brumaire, an CCXXVI, Paul B Mahol a écrit : > No, no and no. Gamma is not always available and polluting AVFrame is big no. The same arguments would apply for pict_type, channel_layout, color_*, crop_*. This is no pollution, it is a minor but relevant information about the frame. > I

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-08 Thread Aurelien Jacobs
On Wed, Nov 08, 2017 at 10:54:18AM +0100, Paul B Mahol wrote: > On 11/7/17, Aurelien Jacobs wrote: > > The encoder was reverse engineered from binary library and from > > EP0398973B1 patent (long expired). > > The decoder was simply deduced from the encoder. > > --- > >

Re: [FFmpeg-devel] [PATCH] avfilter: initial macroblock types export and visualization

2017-11-08 Thread Paul B Mahol
On 11/8/17, Michael Niedermayer wrote: > On Thu, Nov 02, 2017 at 12:04:17PM -0400, Ronald S. Bultje wrote: >> Hi, >> >> On Thu, Nov 2, 2017 at 7:52 AM, Paul B Mahol wrote: >> >> > On 11/2/17, Michael Niedermayer wrote: >> > > Hi

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Paul B Mahol
On 11/8/17, Michael Niedermayer wrote: > On Wed, Nov 08, 2017 at 11:50:34AM +0100, Michael Niedermayer wrote: >> On Tue, Nov 07, 2017 at 08:13:57PM +, Rostislav Pehlivanov wrote: >> > On 6 November 2017 at 18:03, Nicolas George wrote: >> > >> > > Le

Re: [FFmpeg-devel] [PATCH] avfilter: initial macroblock types export and visualization

2017-11-08 Thread Michael Niedermayer
On Thu, Nov 02, 2017 at 12:04:17PM -0400, Ronald S. Bultje wrote: > Hi, > > On Thu, Nov 2, 2017 at 7:52 AM, Paul B Mahol wrote: > > > On 11/2/17, Michael Niedermayer wrote: > > > Hi > > > > > > On Sat, Oct 28, 2017 at 07:43:05AM -0400, Ronald S. Bultje

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Michael Niedermayer
On Wed, Nov 08, 2017 at 11:50:34AM +0100, Michael Niedermayer wrote: > On Tue, Nov 07, 2017 at 08:13:57PM +, Rostislav Pehlivanov wrote: > > On 6 November 2017 at 18:03, Nicolas George wrote: > > > > > Le sextidi 16 brumaire, an CCXXVI, Rostislav Pehlivanov a écrit : > > > >

Re: [FFmpeg-devel] [PATCH v3] lavu: add an AV_FRAME_DATA_GAMMA side data type

2017-11-08 Thread Michael Niedermayer
On Tue, Nov 07, 2017 at 08:13:57PM +, Rostislav Pehlivanov wrote: > On 6 November 2017 at 18:03, Nicolas George wrote: > > > Le sextidi 16 brumaire, an CCXXVI, Rostislav Pehlivanov a écrit : > > > Signed-off-by: Rostislav Pehlivanov > > > --- > > >

Re: [FFmpeg-devel] [PATCH]lavf/tls_openssl: Fix compilation with current libressl

2017-11-08 Thread Michael Niedermayer
On Tue, Nov 07, 2017 at 12:19:02PM -0300, James Almer wrote: > On 11/7/2017 12:15 PM, Hendrik Leppkes wrote: > > On Tue, Nov 7, 2017 at 2:57 PM, James Almer wrote: > >> On 11/7/2017 10:48 AM, Hendrik Leppkes wrote: > >>> On Tue, Nov 7, 2017 at 1:28 PM, Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc uni weighted 4 tap vt mc msa functions

2017-11-08 Thread Michael Niedermayer
On Tue, Nov 07, 2017 at 07:33:15AM +, Manojkumar Bhosale wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When you are offended at any man's fault, turn to yourself and study your own failings. Then you will forget your anger.

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc non-uni hv mc msa functions

2017-11-08 Thread Michael Niedermayer
On Tue, Nov 07, 2017 at 07:33:21AM +, Manojkumar Bhosale wrote: > LGTM will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capitalist society always remains about the same as it was in ancient Greek republics: Freedom for slave owners. --

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc uni 4 tap hv mc msa functions

2017-11-08 Thread Michael Niedermayer
On Tue, Nov 07, 2017 at 05:30:02AM +, Manojkumar Bhosale wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always

Re: [FFmpeg-devel] [PATCH] avcodec/mips: Improve hevc bi wgt 4 tap hv mc msa functions

2017-11-08 Thread Michael Niedermayer
On Tue, Nov 07, 2017 at 05:29:57AM +, Manojkumar Bhosale wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The misfortune of the wise is better than the prosperity of the fool. -- Epicurus signature.asc Description: Digital

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: creation of hls variant streams with master playlist in a single hlsenc instance

2017-11-08 Thread 刘歧
> 在 2017年11月8日,18:02,Dixit, Vishwanath 写道: > > I have added the copyright statement as per our legal team requirements. I > have updated the patches again. Please consider the patches in this mail > attachment as latest. Sorry for any inconvenience. Add Aman Gupta,

Re: [FFmpeg-devel] [PATCH 1/2] aptx: implement the aptX bluetooth codec

2017-11-08 Thread Paul B Mahol
On 11/7/17, Aurelien Jacobs wrote: > The encoder was reverse engineered from binary library and from > EP0398973B1 patent (long expired). > The decoder was simply deduced from the encoder. > --- > doc/general.texi| 2 + > libavcodec/Makefile | 2 + >

Re: [FFmpeg-devel] [PATCH]lavfi/scale2ref: Set output frame rate to main input frame rate

2017-11-08 Thread Paul B Mahol
On 11/8/17, Carl Eugen Hoyos wrote: > Hi! > > I believe attached patch fixes ticket #6817. > > Please comment, Carl Eugen > probably ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

  1   2   >