[FFmpeg-devel] [PATCH] hwcontext_vdpau: implement av_hwdevice_get_hwframe_constraints()

2018-01-12 Thread wm4
In addition, this does not allow creating frames contexts with sw_format for which no known transfer formats exist. In theory, we should check whether the chroma format (i.e. the sw_format) is supported at all by the vdpau driver, but checking for transfer formats has the same effect. Note that

Re: [FFmpeg-devel] [RFC]Use ptrdiff_t for linesize and stride

2018-01-12 Thread James Almer
On 1/12/2018 10:46 PM, Carl Eugen Hoyos wrote: > Hi! > > Seeing 6e80079a it appears that the unstable period is not over yet. > Vittorio posted a patch that introduces a temporary type to avoid > breaking API, but that may not be relevant if the api currently > unstable. The ABI is what is in

Re: [FFmpeg-devel] [RFC]Use ptrdiff_t for linesize and stride

2018-01-12 Thread wm4
On Sat, 13 Jan 2018 03:47:31 +0100 Carl Eugen Hoyos wrote: > 2018-01-13 3:19 GMT+01:00 wm4 : > > On Sat, 13 Jan 2018 02:46:51 +0100 > > Carl Eugen Hoyos wrote: > > > >> Hi! > >> > >> Seeing 6e80079a it appears that the unstable

Re: [FFmpeg-devel] [RFC]Use ptrdiff_t for linesize and stride

2018-01-12 Thread Carl Eugen Hoyos
2018-01-13 3:19 GMT+01:00 wm4 : > On Sat, 13 Jan 2018 02:46:51 +0100 > Carl Eugen Hoyos wrote: > >> Hi! >> >> Seeing 6e80079a it appears that the unstable period is not over yet. >> Vittorio posted a patch that introduces a temporary type to avoid >>

Re: [FFmpeg-devel] [RFC]Use ptrdiff_t for linesize and stride

2018-01-12 Thread wm4
On Sat, 13 Jan 2018 02:46:51 +0100 Carl Eugen Hoyos wrote: > Hi! > > Seeing 6e80079a it appears that the unstable period is not over yet. > Vittorio posted a patch that introduces a temporary type to avoid > breaking API, but that may not be relevant if the api currently >

[FFmpeg-devel] [RFC]Use ptrdiff_t for linesize and stride

2018-01-12 Thread Carl Eugen Hoyos
Hi! Seeing 6e80079a it appears that the unstable period is not over yet. Vittorio posted a patch that introduces a temporary type to avoid breaking API, but that may not be relevant if the api currently unstable. Attached patch (inspired by Vittorio's RFC) passes fate with --disable-asm and does

[FFmpeg-devel] [PATCH] lavfi/vf_scale_vaapi: set output SAR

2018-01-12 Thread Rodger Combs
--- libavfilter/vf_scale_vaapi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavfilter/vf_scale_vaapi.c b/libavfilter/vf_scale_vaapi.c index 22e928c..4bead5a 100644 --- a/libavfilter/vf_scale_vaapi.c +++ b/libavfilter/vf_scale_vaapi.c @@ -240,6 +240,11 @@ static int

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-12 Thread Дмитрий Гуменюк
Hi > On 12 Jan 2018, at 13:32, Дмитрий Гуменюк wrote: > >> On 12 Jan 2018, at 13:17, Tobias Rapp > > wrote: >> >> On 12.01.2018 12:16, Дмитрий Гуменюк wrote: >>> Hi On 11 Jan 2018, at 09:20, Tobias Rapp

Re: [FFmpeg-devel] [PATCH] avcodec/dcaenc: Use ffmpeg mdct instead of own implementation

2018-01-12 Thread Даниил Чередник
New path attached. Thanks. On Sat, Jan 13, 2018 at 2:37 AM, James Almer wrote: > On 1/12/2018 8:12 PM, Даниил Чередник wrote: > > Hysterically dcaenc uses own implementation of time->frequency > > transformation used by psychoacoustic. But actually function named fft in > >

Re: [FFmpeg-devel] [PATCH] avcodec/dcaenc: Use ffmpeg mdct instead of own implementation

2018-01-12 Thread James Almer
On 1/12/2018 8:12 PM, Даниил Чередник wrote: > Hysterically dcaenc uses own implementation of time->frequency > transformation used by psychoacoustic. But actually function named fft in > original dcaenc code is not fft. Power spectrum looks similar to mdct, and > Alexander E. Patrakov told me it

[FFmpeg-devel] [PATCH] avcodec/dcaenc: Use ffmpeg mdct instead of own implementation

2018-01-12 Thread Даниил Чередник
Hysterically dcaenc uses own implementation of time->frequency transformation used by psychoacoustic. But actually function named fft in original dcaenc code is not fft. Power spectrum looks similar to mdct, and Alexander E. Patrakov told me it is MDCT. But for me it is still a bit strange,

Re: [FFmpeg-devel] [PATCH v2] avfilter: add dumpwave filter.

2018-01-12 Thread Дмитрий Гуменюк
Hi One more thing regarding asetnsamples->metadata I think it would be hard to set up 2 chains of them for getting 2 different “resolutions" at the same time > On 12 Jan 2018, at 08:36, Kyle Swanson wrote: > > Hi, > > Make sure you go back and read our comments. There were several

Re: [FFmpeg-devel] [PATCHv2 2/2] avfilter/vf_framerate: simplify filter

2018-01-12 Thread Marton Balint
On Tue, 9 Jan 2018, Marton Balint wrote: On Thu, 4 Jan 2018, Marton Balint wrote: The framerate filter was quite convoluted with some filter_frame / request_frame logic bugs. It seemed easier to rewrite the whole filter_frame / request_frame part and also the frame interpolation ratio

[FFmpeg-devel] [PATCH] libavformat/dashdec: Fix for ticket 6856 (filename limited to 1024)

2018-01-12 Thread Colin NG
--- libavformat/dashdec.c | 87 +-- 1 file changed, 56 insertions(+), 31 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 5345f91..7316213 100644 --- a/libavformat/dashdec.c +++ b/libavformat/dashdec.c @@ -141,6 +141,7

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/utils: Avoid hardcoding duplicated types in sizeof()

2018-01-12 Thread Michael Niedermayer
On Sun, Jun 04, 2017 at 02:25:44AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/utils.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) applied [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] avcodec/opus: Add {} over multiline if() body

2018-01-12 Thread Michael Niedermayer
On Wed, Jan 03, 2018 at 01:34:59AM +, Rostislav Pehlivanov wrote: > On 2 January 2018 at 22:34, Michael Niedermayer > wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/opus.c | 4 ++-- > > 1 file changed, 2 insertions(+),

Re: [FFmpeg-devel] [PATCH] avcodec/arm/sbrdsp_neon: Use a free register instead of putting 2 things in one

2018-01-12 Thread Michael Niedermayer
On Fri, Jan 12, 2018 at 11:47:32AM -0800, Dale Curtis wrote: > lgtm, resolves the issue on our end. will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-01-12 Thread Michael Niedermayer
On Wed, Dec 13, 2017 at 03:31:04PM +0700, Nablet Developer wrote: [...] > @@ -3145,6 +3147,8 @@ libsmbclient_protocol_deps="libsmbclient gplv3" > libssh_protocol_deps="libssh" > mmsh_protocol_select="http_protocol" > mmst_protocol_select="network" > +opensrt_protocol_select="network" >

[FFmpeg-devel] [PATCH] avformat: add option to parse/store ID3 PRIV tags in metadata.

2018-01-12 Thread rshaffer
From: Richard Shaffer Enables getting access to ID3 PRIV tags from the command-line or metadata API when demuxing. The PRIV owner is stored as the metadata key, and the data is stored as the metadata value. As PRIV tags may contain arbitrary data, non- printable characters,

Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

2018-01-12 Thread Michael Niedermayer
On Sat, Dec 23, 2017 at 11:15:35PM +0100, Tomas Härdin wrote: > [...] > +static int codec2_read_header_common(AVFormatContext *s, AVStream *st) > +{ > +int mode = avpriv_codec2_mode_from_extradata(st->codecpar->extradata); > + > +st->codecpar->codec_type= AVMEDIA_TYPE_AUDIO; > +

Re: [FFmpeg-devel] [PATCH] avcodec/arm/sbrdsp_neon: Use a free register instead of putting 2 things in one

2018-01-12 Thread Dale Curtis
lgtm, resolves the issue on our end. - dale On Thu, Jan 11, 2018 at 1:47 PM, Michael Niedermayer wrote: > Fixes high pitched shriek > Fixes: 25420848_1478428308873746_4255813235963330560_n.mp4 > > Reported-by: Dale Curtis > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 2/2] lavf/tcp.c: Free allocated client URLContext in case of error.

2018-01-12 Thread Michael Niedermayer
On Fri, Jan 12, 2018 at 07:16:30PM +0100, Stephan Holljes wrote: > Signed-off-by: Stephan Holljes > --- > libavformat/tcp.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) patchset is probably ok [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 06/11] decklink: Add support for using libklvanc from within capture module

2018-01-12 Thread Devin Heitmueller
Hello Marton, Thank you for the feedback. Comments inline. >> +vanc_ctx->callback_context = _ctx; >> +int ret = klvanc_packet_parse(vanc_ctx, lineNr, decoded_words, >> sizeof(decoded_words) / (sizeof(uint16_t))); > > A parity error also causes a negative return value? Or

Re: [FFmpeg-devel] [PATCH 07/11] decklink: Add support for SCTE-104 to decklink capture

2018-01-12 Thread Marton Balint
On Mon, 8 Jan 2018, Devin Heitmueller wrote: Make use of libklvanc to parse SCTE-104 packets and announce them as a new stream. Right now we just pass the payload straight through, but once this is hooked into libklscte35 we'll be able to generate SCTE-35 messages in the MPEG TS stream.

Re: [FFmpeg-devel] [PATCH 06/11] decklink: Add support for using libklvanc from within capture module

2018-01-12 Thread Marton Balint
On Mon, 8 Jan 2018, Devin Heitmueller wrote: Make use of libklvanc from within the DeckLink capture module, initially for EIA-708 and AFD. Support for other VANC types will come in subsequent patches. Incorporates feedback from Derek Buitenhuis , James Almer

Re: [FFmpeg-devel] avcodec/utvideoenc : add SIMD (SSSE3) for sub_left_pred

2018-01-12 Thread Michael Niedermayer
On Fri, Jan 12, 2018 at 09:57:03AM +0100, Martin Vignali wrote: > > > > this changes the output: > > make -j12 && ./ffmpeg -i ~/videos/matrixbench_mpeg2.mpg -an -vcodec > > utvideo -t 1 -pix_fmt yuv420p -pred left -t 1 test2.avi > > > > -rw-r- 1 michael michael 3744402 Jan 12 04:20 test2.avi

Re: [FFmpeg-devel] [PATCH 03/11] decklink: Introduce support for capture of multiple audio streams

2018-01-12 Thread Marton Balint
On Mon, 8 Jan 2018, Devin Heitmueller wrote: Add support for the ability to capture all audio pairs available to the capture hardware. Each pair is exposed as a different audio stream, which matches up with the most common use cases for the broadcast space (i.e. where there is one stereo

Re: [FFmpeg-devel] [PATCH 02/11] decklink: Add support for output of Active Format Description (AFD)

2018-01-12 Thread Marton Balint
On Mon, 8 Jan 2018, Devin Heitmueller wrote: Implement support for including AFD in decklink output. This includes making sure the AFD data is preserved when going from an AVFrame to a V210 packet (needed for 10-bit support). Updated to reflect feedback from Marton Balint ,

[FFmpeg-devel] [PATCH 2/2] lavf/tcp.c: Free allocated client URLContext in case of error.

2018-01-12 Thread Stephan Holljes
Signed-off-by: Stephan Holljes --- libavformat/tcp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/tcp.c b/libavformat/tcp.c index 8773493df1..b0289f854f 100644 --- a/libavformat/tcp.c +++ b/libavformat/tcp.c @@ -208,8 +208,10 @@

[FFmpeg-devel] [PATCH 1/2] lavf/http.c: Free allocated client URLContext in case of error.

2018-01-12 Thread Stephan Holljes
Signed-off-by: Stephan Holljes --- libavformat/http.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/http.c b/libavformat/http.c index 4806b1e59b..537d0a4773 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -574,7 +574,11 @@ static int

Re: [FFmpeg-devel] [PATCH 01/11] libavdevice/decklink: Add support for EIA-708 output over SDI

2018-01-12 Thread Marton Balint
On Mon, 8 Jan 2018, Devin Heitmueller wrote: Hook in libklvanc and use it for output of EIA-708 captions over SDI. The bulk of this patch is just general support for ancillary data for the Decklink SDI module - the real work for construction of the EIA-708 CDP and VANC line construction is

Re: [FFmpeg-devel] avcodec/utvideoenc : add SIMD (SSSE3) for sub_left_pred

2018-01-12 Thread Henrik Gramner
On Thu, Jan 11, 2018 at 9:45 PM, Martin Vignali wrote: > +if (check_func(c.sub_left_predict, "sub_left_predict")) { > +call_ref(dst0, src0, stride, width, height); > +call_new(dst1, src0, stride, width, height); > +if (memcmp(dst0, dst1,

Re: [FFmpeg-devel] [PATCH v2 3/3] avdevice/decklink: addition of absolute wallclock option for pts source

2018-01-12 Thread Marton Balint
On Wed, 10 Jan 2018, vdi...@akamai.com wrote: From: Vishwanath Dixit --- doc/indevs.texi | 6 -- libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_dec.cpp| 4 libavdevice/decklink_dec_c.c| 1 + 4 files changed, 10 insertions(+), 2

Re: [FFmpeg-devel] [PATCH v2 1/3] avdevice/decklink: addition of copyts option

2018-01-12 Thread Marton Balint
On Wed, 10 Jan 2018, vdi...@akamai.com wrote: From: Vishwanath Dixit --- doc/indevs.texi | 5 + libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_dec.cpp| 18 +++--- libavdevice/decklink_dec_c.c| 1 + 4 files changed, 18

Re: [FFmpeg-devel] GSoC 2018

2018-01-12 Thread Pedro Arthur
2018-01-12 0:06 GMT-02:00 Michael Niedermayer : > if pedro is up to date on this stuff, then maybe he wants to mentor this > > either way, links to relevant research, tests, literature are welcome > > I can mentor this. One of the first NN based method was [1] which has a

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

2018-01-12 Thread Gyan Doshi
On 1/12/2018 2:01 PM, Kyle Swanson wrote: Just read through the patch, but actually didn't try it yet. I wonder if we should also scale the size of the text in cases where it's wider than the frame? Worth considering. Note that fontsize may be dynamic e.g. `50+t*20` which can lead to jerky

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-12 Thread Дмитрий Гуменюк
> On 12 Jan 2018, at 13:17, Tobias Rapp wrote: > > On 12.01.2018 12:16, Дмитрий Гуменюк wrote: >> Hi >>> On 11 Jan 2018, at 09:20, Tobias Rapp wrote: >>> >>> On 10.01.2018 18:18, Kyle Swanson wrote: Hi, For this to be a part of

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-12 Thread Tobias Rapp
On 12.01.2018 12:16, Дмитрий Гуменюк wrote: Hi On 11 Jan 2018, at 09:20, Tobias Rapp wrote: On 10.01.2018 18:18, Kyle Swanson wrote: Hi, For this to be a part of libavfilter the output needs to be more generic than the just the Soundcloud format. If we want this to be

Re: [FFmpeg-devel] GSoC 2018

2018-01-12 Thread Thilo Borgmann
Am 12.01.18 um 03:41 schrieb wm4: > On Fri, 12 Jan 2018 03:06:29 +0100 > Michael Niedermayer wrote: > >> On Thu, Jan 11, 2018 at 09:17:06PM +0100, Thilo Borgmann wrote: >>> Am 11.01.18 um 19:45 schrieb Michael Niedermayer: On Thu, Jan 11, 2018 at 02:43:01PM -0200,

Re: [FFmpeg-devel] [PATCH v2] avfilter: add dumpwave filter.

2018-01-12 Thread Dmitry Gumenyuk
> On 12 Jan 2018, at 08:36, Kyle Swanson wrote: > > Hi, > > Make sure you go back and read our comments. There were several things you > didn't address in your most recent patch. Sorry, seems I missed few emails. Sure > Thanks, > Kyle >

Re: [FFmpeg-devel] [PATCH v3 2/4] avformat/libopenmpt: Update to libopenmpt 0.3 API

2018-01-12 Thread Michael Niedermayer
On Thu, Jan 11, 2018 at 09:11:30AM +0100, Jörn Heusipp wrote: > libopenmpt 0.3 deprecates openmpt_module_create_from_memory() and > provides a replacement function openmpt_module_create_from_memory2(). > > Detecting libopenmpt 0.3 can be done at build time via the API > version macros provided by

Re: [FFmpeg-devel] [PATCH v3 1/4] avformat/libopenmpt: Fix mixed code and declarations

2018-01-12 Thread Michael Niedermayer
On Thu, Jan 11, 2018 at 09:11:29AM +0100, Jörn Heusipp wrote: > Signed-off-by: Jörn Heusipp > --- > libavformat/libopenmpt.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) applied thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] avdevice/gdigrab: Fix screen size and mouse position calculations on hi-DPI screens

2018-01-12 Thread Michael Niedermayer
On Tue, Nov 28, 2017 at 09:59:02AM +0100, Harald Gaechter wrote: > Signed-off-by: Harald Gaechter > --- > libavdevice/gdigrab.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 3/3] http: fix memory leak in parse_cookie.

2018-01-12 Thread Michael Niedermayer
On Thu, Jan 11, 2018 at 03:15:41PM -0800, Richard Shaffer wrote: > On Thu, Jan 11, 2018 at 2:49 PM, Moritz Barsnick wrote: > > > On Thu, Jan 11, 2018 at 14:28:52 -0800, rshaf...@tunein.com wrote: > > > > > [PATCH 3/3] http: fix memory leak in parse_cookie.g > > > > > This is my

Re: [FFmpeg-devel] [PATCH 1/2] examples/vaapi_encode: Remove redundancy check when free context.

2018-01-12 Thread Michael Niedermayer
On Thu, Jan 11, 2018 at 03:07:18PM +0800, Jun Zhao wrote: > > vaapi_encode.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > 6002024418a485e89bb71fac812f5c540a434cf5 > 0001-examples-vaapi_encode-Remove-redundancy-check-when-f.patch > From

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

2018-01-12 Thread Дмитрий Гуменюк
Hi > On 11 Jan 2018, at 09:20, Tobias Rapp wrote: > > On 10.01.2018 18:18, Kyle Swanson wrote: >> Hi, >> For this to be a part of libavfilter the output needs to be more generic >> than the just the Soundcloud format. If we want this to be generally useful >> it should

Re: [FFmpeg-devel] [PATCH 1/3] Add libcodec2 en/decoder

2018-01-12 Thread Tomas Härdin
ping? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] avcodec/utvideoenc : add SIMD (SSSE3) for sub_left_pred

2018-01-12 Thread Martin Vignali
> > this changes the output: > make -j12 && ./ffmpeg -i ~/videos/matrixbench_mpeg2.mpg -an -vcodec > utvideo -t 1 -pix_fmt yuv420p -pred left -t 1 test2.avi > > -rw-r- 1 michael michael 3744402 Jan 12 04:20 test2.avi > -rw-r- 1 michael michael 3753358 Jan 12 04:19 test.avi > > > Hello,

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

2018-01-12 Thread Kyle Swanson
Hi, On Thu, Jan 11, 2018 at 5:42 AM, Gyan Doshi wrote: > The no-op commit e496c45 from Libav introduced an option which allowed the > user to relocate text to fit within the frame if it was going out of bounds. > > For some reason, when the merge commit b479e01 was applied,