Re: [FFmpeg-devel] [PATCH 1/2] aadec: improve eof detection

On Sun, Jan 28, 2018 at 12:01:13AM +0100, Karsten Otto wrote: > Remember the end position of audio content in the file and check it during > read_packet. There always seems to be other data beyond it, which could be > misinterpreted as more audio. Also add some extra avio_read error checks, > to

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Check ret on avformat_write_header

> 在 2018年1月28日，上午7:17，Brendan McGrath 写道： > > On 26/01/18 14:30, 刘歧 wrote: >> >>> On 24 Jan 2018, at 09:24, Brendan McGrath >>> wrote: >>> >>> Encoding currently fails when using hls_ts_options with the fmp4 >>> segment type. >>> >>>

Re: [FFmpeg-devel] [PATCHv3] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

Patch updated to possibly fix thread related bug reports. Tsan is better but not perfect. 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mpeg4videodec: Avoid possibly aliasing violating casts

All 3 ok. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose: Fix regression with packed pixel formats

On 1/27/2018 10:50 PM, Michael Niedermayer wrote: > Regression since: c6939f65a116b1ffed345d29d8621ee4ffb32235 > Found-by: Paul B Mahol > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_transpose.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH] fate: add id3v2 test

Maybe a result of my mail client. Let me send from git send-email. -Richard On Thu, Jan 25, 2018 at 11:03 PM, Richard Shaffer wrote: > From f7398407c1f5822e1536ce03d46c885b2ad00c38 Mon Sep 17 00:00:00 2001 > From: Richard Shaffer > Date: Thu, 25 Jan

[FFmpeg-devel] [PATCH] fate: add id3v2 test

From: Richard Shaffer Adds basic unit test for parsing ID3v2 tags. --- This is the second time I'm attempting to send it. Sent it through an email client before, and it seems to have removed the leading white space. tests/Makefile| 1 + tests/fate-run.sh

Re: [FFmpeg-devel] [PATCH] fate: add id3v2 test

On Thu, Jan 25, 2018 at 11:03:13PM -0800, Richard Shaffer wrote: > From f7398407c1f5822e1536ce03d46c885b2ad00c38 Mon Sep 17 00:00:00 2001 > From: Richard Shaffer > Date: Thu, 25 Jan 2018 19:54:59 -0800 > Subject: [PATCH] fate: add id3v2 test > > Adds basic unit test for

Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose: Fix used plane count.

On Sat, Jan 27, 2018 at 09:54:51AM +0100, Paul B Mahol wrote: > On 1/24/18, Michael Niedermayer wrote: > > Fixes out of array access > > Fixes: poc.mp4 > > > > Found-by: GwanYeong Kim > > Signed-off-by: Michael Niedermayer > >

[FFmpeg-devel] [PATCH] avfilter/vf_transpose: Fix regression with packed pixel formats

Regression since: c6939f65a116b1ffed345d29d8621ee4ffb32235 Found-by: Paul B Mahol Signed-off-by: Michael Niedermayer --- libavfilter/vf_transpose.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_transpose.c

[FFmpeg-devel] [PATCH 1/3] avcodec/mpeg4videodec: Check mb_num also against 0

The spec implies that 0 is invalid in addition to the existing checks Found-by: Signed-off-by: Michael Niedermayer --- libavcodec/mpeg4videodec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c

[FFmpeg-devel] [PATCH 3/3] avcodec/mpeg4videodec: Avoid possibly aliasing violating casts

Found-by: kierank Signed-off-by: Michael Niedermayer --- libavcodec/mpeg4videodec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index ba332de531..756753e2fc 100644 ---

[FFmpeg-devel] [PATCH 2/3] avcodec/get_bits: Document the return code of get_vlc2()

Found-by: kierank Signed-off-by: Michael Niedermayer --- libavcodec/get_bits.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/get_bits.h b/libavcodec/get_bits.h index c530015169..0c7f5ff0c6 100644 --- a/libavcodec/get_bits.h +++ b/libavcodec/get_bits.h @@

Re: [FFmpeg-devel] [PATCH] dashdec: Fix segfault on decoding segment timeline

Just making sure this patch hasn't been overlooked. To better explain the existing issue - the value of 'pls->first_seq_no' comes from the 'startNumber' attribute of the 'SegmentTemplate' element. The 'pls->timelines' array represents the elements within the 'SegmentTimeline' element. So

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Check ret on avformat_write_header

On 26/01/18 14:30, 刘歧 wrote: On 24 Jan 2018, at 09:24, Brendan McGrath wrote: Encoding currently fails when using hls_ts_options with the fmp4 segment type. This is due to the fact that avformat_write_header does not process the passed options when the avformat

Re: [FFmpeg-devel] [PATCH 2/2] aadec: add chapters and seeking

On Sun, 28 Jan 2018 00:01:14 +0100 Karsten Otto wrote: > read_packet reads content in chunks. Thus seek must be clamped to valid > chunk positions in the file, which in turn are relative to chapter start > positions. > > So in read_header, scan for chapter headers once by

[FFmpeg-devel] [PATCH 0/2] hello + aadec improvements

Hello ffmpeg-devel! These two patches aim to improve playback support for Audible Format 2/3/4 as implemented in libavformat/aadec.c. Patch 1 is a very simple improvement of EOF detection in the presence of trailing data and broken/truncated files. It consists mainly of some extra error/bounds

[FFmpeg-devel] [PATCH 2/2] aadec: add chapters and seeking

read_packet reads content in chunks. Thus seek must be clamped to valid chunk positions in the file, which in turn are relative to chapter start positions. So in read_header, scan for chapter headers once by skipping through the content. Set stream time_base to bitrate in bytes/s, for easy

[FFmpeg-devel] [PATCH 1/2] aadec: improve eof detection

Remember the end position of audio content in the file and check it during read_packet. There always seems to be other data beyond it, which could be misinterpreted as more audio. Also add some extra avio_read error checks, to bail early in case of a broken/truncated file. --- libavformat/aadec.c

Re: [FFmpeg-devel] [PATCHv3] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

On Sat, Jan 27, 2018 at 06:40:13PM +, Kieran Kunhya wrote: > Patch updated. Still depends on [PATCH] simple_idct: Template functions to > support an input bitdepth parameter. > > Kieran > h263dec.c | 11 + > idctdsp.c | 12 - > ituh263dec.c |9 > mpeg4data.h

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

On Sat, Jan 27, 2018 at 02:24:29AM +, Kieran Kunhya wrote: > On Sat, Jan 27, 2018 at 12:33 AM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > > > On Fri, Jan 26, 2018 at 08:04:39PM +, Kieran Kunhya wrote: > > > On Mon, Jan 22, 2018 at 2:07 AM, Michael Niedermayer > >

Re: [FFmpeg-devel] [PATCH] mov: do not mark timed thumbnail tracks as attached picture

On Sat, 27 Jan 2018 18:07:53 +0100 (CET) Marton Balint wrote: > On Sat, 27 Jan 2018, wm4 wrote: > > >> Docs in avformat.h only says that AV_DISPOSITION_ATTACHED_PIC "usually" > >> contains one packet. > > > > It also implies AVStream.attached_pic is set, which can be only one

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: refcount input frame mappings

On Fri, 26 Jan 2018 20:18:30 +0100 Timo Rothenpieler wrote: > If some logic like vsync in ffmpeg.c duplicates frames, it might pass > the same frame twice, which will result in a crash due it being > effectively mapped and unmapped twice. > > Signed-off-by: Timo

[FFmpeg-devel] [PATCHv3] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

Patch updated. Still depends on [PATCH] simple_idct: Template functions to support an input bitdepth parameter. Kieran 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] mov: do not mark timed thumbnail tracks as attached picture

On Sat, 27 Jan 2018, wm4 wrote: Docs in avformat.h only says that AV_DISPOSITION_ATTACHED_PIC "usually" contains one packet. It also implies AVStream.attached_pic is set, which can be only one picture. From the docs I'd assume that attached_pic contains the _first_ packet of the stream if

Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose: Fix used plane count.

On 1/24/18, Michael Niedermayer wrote: > Fixes out of array access > Fixes: poc.mp4 > > Found-by: GwanYeong Kim > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_transpose.c | 8 +++- > 1 file changed, 7